)]}'
{"openstack/orchestration/v1/stack.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"51404d384b08c89ac9763e3c617b41047d556973","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    #: Timestamp of last update on the stack."},{"line_number":65,"context_line":"    updated_time \u003d resource.prop(\u0027updated_time\u0027)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def action(self, session, body):"},{"line_number":68,"context_line":"        \"\"\"Perform stack actions\"\"\""},{"line_number":69,"context_line":"        url \u003d utils.urljoin(self.base_path, self.id, \u0027actions\u0027)"},{"line_number":70,"context_line":"        resp \u003d session.post(url, service\u003dself.service, json\u003dbody).body"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_cfed8eb8","line":67,"updated":"2015-06-09 12:01:20.000000000","message":"Shouldn\u0027t this be private?","commit_id":"ee6ac84bf463f4dfec93f9b66aa5ffc2148888c7"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"90301dce9319010780cff47b24f66111e16a337b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    #: Timestamp of last update on the stack."},{"line_number":65,"context_line":"    updated_time \u003d resource.prop(\u0027updated_time\u0027)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def action(self, session, body):"},{"line_number":68,"context_line":"        \"\"\"Perform stack actions\"\"\""},{"line_number":69,"context_line":"        url \u003d utils.urljoin(self.base_path, self.id, \u0027actions\u0027)"},{"line_number":70,"context_line":"        resp \u003d session.post(url, service\u003dself.service, json\u003dbody).body"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_6deb1f14","line":67,"in_reply_to":"3afb71cf_cfed8eb8","updated":"2015-06-10 01:02:52.000000000","message":"Yes, it\u0027s better to make it private, but I referred to the nova side.\nhttp://git.openstack.org/cgit/stackforge/python-openstacksdk/tree/openstack/compute/v2/server.py#n87\n\nI will change it to a private method.","commit_id":"ee6ac84bf463f4dfec93f9b66aa5ffc2148888c7"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"51404d384b08c89ac9763e3c617b41047d556973","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def check(self, session):"},{"line_number":74,"context_line":"        body \u003d {\u0027check\u0027: \u0027\u0027}"},{"line_number":75,"context_line":"        return self.action(session, body)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @classmethod"},{"line_number":78,"context_line":"    def create_by_id(cls, session, attrs, resource_id\u003dNone, path_args\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_4f0f5e88","line":75,"updated":"2015-06-09 12:01:20.000000000","message":"Could probably one line this and add the three or so other actions.  Are there many actions not documented?","commit_id":"ee6ac84bf463f4dfec93f9b66aa5ffc2148888c7"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"90301dce9319010780cff47b24f66111e16a337b","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def check(self, session):"},{"line_number":74,"context_line":"        body \u003d {\u0027check\u0027: \u0027\u0027}"},{"line_number":75,"context_line":"        return self.action(session, body)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @classmethod"},{"line_number":78,"context_line":"    def create_by_id(cls, session, attrs, resource_id\u003dNone, path_args\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_8db9bb17","line":75,"in_reply_to":"3afb71cf_4f0f5e88","updated":"2015-06-10 01:02:52.000000000","message":"Yes, there are other actions, I will add them here.","commit_id":"ee6ac84bf463f4dfec93f9b66aa5ffc2148888c7"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"d49971afa7d106d73ab1faac00e292bc125aef43","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def check(self, session):"},{"line_number":74,"context_line":"        body \u003d {\u0027check\u0027: \u0027\u0027}"},{"line_number":75,"context_line":"        return self.action(session, body)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @classmethod"},{"line_number":78,"context_line":"    def create_by_id(cls, session, attrs, resource_id\u003dNone, path_args\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_edd02f21","line":75,"in_reply_to":"3afb71cf_8db9bb17","updated":"2015-06-10 01:09:53.000000000","message":"There are several other actions, I think it\u0027s better to add them in other patches.","commit_id":"ee6ac84bf463f4dfec93f9b66aa5ffc2148888c7"}],"openstack/tests/unit/orchestration/v1/test_stack.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"51404d384b08c89ac9763e3c617b41047d556973","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        session_mock.post.assert_called_with(url, service\u003dsot.service,"},{"line_number":110,"context_line":"                                             json\u003dbody)"},{"line_number":111,"context_line":"        self.assertEqual(FAKE_ID, sot.id)"},{"line_number":112,"context_line":"        self.assertEqual(FAKE_NAME, sot.name)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def test_check(self):"},{"line_number":115,"context_line":"        session_mock \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_6f81fac2","line":112,"updated":"2015-06-09 12:01:20.000000000","message":"if you make action private, you can get rid of this test.","commit_id":"ee6ac84bf463f4dfec93f9b66aa5ffc2148888c7"}]}