)]}'
{"openstack/tests/functional/network/v2/test_router_add_remove_interface.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"d8a80210c602e4d199e5d5fdf5d7a7bb801f0da2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def setUpClass(cls):"},{"line_number":34,"context_line":"        super(TestRouterInterface, cls).setUpClass()"},{"line_number":35,"context_line":"        sot \u003d cls.conn.network.create_router(name\u003dcls.ROUTER_NAME)"},{"line_number":36,"context_line":"        assert isinstance(sot, router.Router)"},{"line_number":37,"context_line":"        cls.assertIs(cls.ROUTER_NAME, sot.name)"},{"line_number":38,"context_line":"        net \u003d cls.conn.network.create_network(name\u003dcls.NET_NAME)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_78a7de4f","line":35,"updated":"2015-06-13 17:10:07.000000000","message":"You could save the router here cls.rot \u003d","commit_id":"18ba8c3f18ad25a9ab50c088e985637fd66d85a2"},{"author":{"_account_id":15739,"name":"Hardik Italia","email":"hardik.italia@suse.com","username":"hitalia"},"change_message_id":"16696286c13c6e04762591df44a2c08cd2f521f0","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def setUpClass(cls):"},{"line_number":34,"context_line":"        super(TestRouterInterface, cls).setUpClass()"},{"line_number":35,"context_line":"        sot \u003d cls.conn.network.create_router(name\u003dcls.ROUTER_NAME)"},{"line_number":36,"context_line":"        assert isinstance(sot, router.Router)"},{"line_number":37,"context_line":"        cls.assertIs(cls.ROUTER_NAME, sot.name)"},{"line_number":38,"context_line":"        net \u003d cls.conn.network.create_network(name\u003dcls.NET_NAME)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_ceb5007f","line":35,"in_reply_to":"fa32b979_78a7de4f","updated":"2015-06-13 20:48:44.000000000","message":"Done.","commit_id":"18ba8c3f18ad25a9ab50c088e985637fd66d85a2"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"d8a80210c602e4d199e5d5fdf5d7a7bb801f0da2","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        cls.assertIs(None, sot)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_router_add_interface(self):"},{"line_number":62,"context_line":"        rot \u003d self.conn.network.find_router(self.ROUTER_ID)"},{"line_number":63,"context_line":"        iface \u003d rot.add_interface(self.conn.session, self.SUB_ID)"},{"line_number":64,"context_line":"        self._verification(iface)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_d86cea0a","line":62,"updated":"2015-06-13 17:10:07.000000000","message":"You could use the save cls.rot instead of doing the find.","commit_id":"18ba8c3f18ad25a9ab50c088e985637fd66d85a2"},{"author":{"_account_id":15739,"name":"Hardik Italia","email":"hardik.italia@suse.com","username":"hitalia"},"change_message_id":"16696286c13c6e04762591df44a2c08cd2f521f0","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        cls.assertIs(None, sot)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_router_add_interface(self):"},{"line_number":62,"context_line":"        rot \u003d self.conn.network.find_router(self.ROUTER_ID)"},{"line_number":63,"context_line":"        iface \u003d rot.add_interface(self.conn.session, self.SUB_ID)"},{"line_number":64,"context_line":"        self._verification(iface)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_eeba446e","line":62,"in_reply_to":"fa32b979_d86cea0a","updated":"2015-06-13 20:48:44.000000000","message":"Done.","commit_id":"18ba8c3f18ad25a9ab50c088e985637fd66d85a2"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"d8a80210c602e4d199e5d5fdf5d7a7bb801f0da2","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    def test_router_remove_interface(self):"},{"line_number":67,"context_line":"        rot \u003d self.conn.network.find_router(self.ROUTER_ID)"},{"line_number":68,"context_line":"        iface \u003d rot.remove_interface(self.conn.session, self.SUB_ID)"},{"line_number":69,"context_line":"        self._verification(iface)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def _verification(self, interface):"},{"line_number":72,"context_line":"        self.assertEqual(interface[\u0027subnet_id\u0027], self.SUB_ID)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_987742d4","line":69,"updated":"2015-06-13 17:10:07.000000000","message":"Why is this verifying the same thing with the add and remove?  Isn\u0027t there some change we could detect?","commit_id":"18ba8c3f18ad25a9ab50c088e985637fd66d85a2"},{"author":{"_account_id":15739,"name":"Hardik Italia","email":"hardik.italia@suse.com","username":"hitalia"},"change_message_id":"16696286c13c6e04762591df44a2c08cd2f521f0","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    def test_router_remove_interface(self):"},{"line_number":67,"context_line":"        rot \u003d self.conn.network.find_router(self.ROUTER_ID)"},{"line_number":68,"context_line":"        iface \u003d rot.remove_interface(self.conn.session, self.SUB_ID)"},{"line_number":69,"context_line":"        self._verification(iface)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def _verification(self, interface):"},{"line_number":72,"context_line":"        self.assertEqual(interface[\u0027subnet_id\u0027], self.SUB_ID)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_8eb0588d","line":69,"in_reply_to":"fa32b979_987742d4","updated":"2015-06-13 20:48:44.000000000","message":"Response while adding \u0026 removing interface is same as of now. Other way may be to look for port id after removing interface and catch exception.","commit_id":"18ba8c3f18ad25a9ab50c088e985637fd66d85a2"}]}