)]}'
{"openstack/network/v2/network.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"162763f16685dcb309e6f1b588978c2aa1cb1a3a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    provider_segmentation_id \u003d resource.prop(\u0027provider:segmentation_id\u0027)"},{"line_number":46,"context_line":"    #: Whether or not the router is external. *Type: bool*"},{"line_number":47,"context_line":"    router_external \u003d resource.prop(\u0027router:external\u0027)"},{"line_number":48,"context_line":"    router_type \u003d resource.prop(\u0027router_type\u0027)"},{"line_number":49,"context_line":"    segments \u003d resource.prop(\u0027segments\u0027)"},{"line_number":50,"context_line":"    #: Indicates whether this network is shared across all tenants."},{"line_number":51,"context_line":"    #: By default, only administrative users can change this value."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_5fa292af","line":48,"updated":"2015-06-16 19:22:58.000000000","message":"https://bugs.launchpad.net/python-openstacksdk/+bug/1465813 to track this issue","commit_id":"7a2917a32fb19b06b5e30cfa4256bb83b5b52739"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"7b150ec354b1fa3d57b41727b5a2c21e4d5a14b8","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    def is_external(self):"},{"line_number":61,"context_line":"        if self.router_external is not None:"},{"line_number":62,"context_line":"            return self.router_external"},{"line_number":63,"context_line":"        if self.router_type \u003d\u003d \u0027External\u0027:"},{"line_number":64,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_98534de2","line":63,"updated":"2015-06-16 21:32:49.000000000","message":"This should have an \"else: return False\" so it\u0027s clear that it\u0027s returning a bool instead of potentially falling through and returning None","commit_id":"be7d5d929b26454009617d761fafee4d6fa2048d"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"cd8daa0eff2560423b751e388efaceaca18cb86b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    def is_external(self):"},{"line_number":61,"context_line":"        if self.router_external is not None:"},{"line_number":62,"context_line":"            return self.router_external"},{"line_number":63,"context_line":"        if self.router_type \u003d\u003d \u0027External\u0027:"},{"line_number":64,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_18ef16ea","line":63,"in_reply_to":"fa32b979_98534de2","updated":"2015-06-17 15:40:05.000000000","message":"Bad case of rushing a change so I could go out for a bike ride.","commit_id":"be7d5d929b26454009617d761fafee4d6fa2048d"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"5a09cc0acb97f2a3a0fdd8e6c8f849088d4fba01","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        if self.router_external is not None:"},{"line_number":62,"context_line":"            return self.router_external"},{"line_number":63,"context_line":"        if self.router_type \u003d\u003d \u0027External\u0027:"},{"line_number":64,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_a7faa841","line":64,"updated":"2015-06-17 01:08:29.000000000","message":"yip, just a \u0027return False\u0027 on line 65 will do.","commit_id":"be7d5d929b26454009617d761fafee4d6fa2048d"}]}