)]}'
{"openstack/auth/access.py":[{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"3cbadcf7d4a398e55ca3b2d02f1f3d15a47798a1","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        expiring \u003d norm_expires \u003c soon"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        if expiring:"},{"line_number":79,"context_line":"            logger.debug(\"Token expiring: expires\u003d{} \u003c soon\u003d{}. Re-authenticating.\".format(norm_expires, soon))"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        return expiring"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_a4573801","line":79,"updated":"2015-06-30 16:17:19.000000000","message":"While I\u0027m a big fan of the new-style formatting, but I think we should stick with the %-style formatting used elsewhere.\n\nI would leave out the expires \u003c soon part of the message and just say when it expires.","commit_id":"b9a0903c7551d8b3921cb6a69b8bd1a33c0a5bd8"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"1387b02118a9862f1bd848a1ccc2126fb035ab36","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        expiring \u003d norm_expires \u003c soon"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        if expiring:"},{"line_number":79,"context_line":"            logger.debug(\"Token expiring: expires\u003d{} \u003c soon\u003d{}. Re-authenticating.\".format(norm_expires, soon))"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        return expiring"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_0aef0a88","line":79,"in_reply_to":"ba3cc151_0a2dca45","updated":"2015-06-30 18:12:58.000000000","message":"Consistency with what we\u0027ve already done. Additionally, logger.debug (or any level) directly supports %-style formatting -- the first argument is a string, additional positional arguments are applied to the string in the %-style format.\n\nThis should really be logger.debug(\"Token expiring at %s\", norm_expires) and then you don\u0027t have to worry about formatting anything on your own.","commit_id":"b9a0903c7551d8b3921cb6a69b8bd1a33c0a5bd8"},{"author":{"_account_id":1112,"name":"Everett Toews","email":"everett.toews@rackspace.com","username":"everett-toews"},"change_message_id":"691324c157d4c49a3d3f281974bcfaedd02a0d83","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        expiring \u003d norm_expires \u003c soon"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        if expiring:"},{"line_number":79,"context_line":"            logger.debug(\"Token expiring: expires\u003d{} \u003c soon\u003d{}. Re-authenticating.\".format(norm_expires, soon))"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        return expiring"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_5879e191","line":79,"in_reply_to":"ba3cc151_0aef0a88","updated":"2015-07-09 14:09:13.000000000","message":"Done","commit_id":"b9a0903c7551d8b3921cb6a69b8bd1a33c0a5bd8"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"584c3a72bf993e0e99a4bf62220f64c23cc9f059","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        expiring \u003d norm_expires \u003c soon"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        if expiring:"},{"line_number":79,"context_line":"            logger.debug(\"Token expiring: expires\u003d{} \u003c soon\u003d{}. Re-authenticating.\".format(norm_expires, soon))"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        return expiring"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_0a2dca45","line":79,"in_reply_to":"ba3cc151_a4573801","updated":"2015-06-30 18:08:00.000000000","message":"Why should we stick with % style formatting?","commit_id":"b9a0903c7551d8b3921cb6a69b8bd1a33c0a5bd8"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"c9b43421bf2d731b441a7487c35eacccfafdebdc","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        expiring \u003d norm_expires \u003c soon"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        if expiring:"},{"line_number":79,"context_line":"            logger.debug(\"Token expiring at %s. Re-authenticating.\","},{"line_number":80,"context_line":"                         norm_expires)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        return expiring"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_986f695f","line":79,"updated":"2015-07-09 14:16:16.000000000","message":"I would probably leave the re-authenticating part out of this, since at this point we really only know when the token is expiring. If we break the code that handles this method\u0027s response and we don\u0027t actually do the reauth, we\u0027re logging something that\u0027s not happening.\n\nCan we log a message about actually doing the reauth where the reauth is completed?","commit_id":"97d4262e2968f20518e5618b9b565bc07644e67b"}]}