)]}'
{"openstack/tests/functional/network/v2/test_floating_ip.py":[{"author":{"_account_id":1112,"name":"Everett Toews","email":"everett.toews@rackspace.com","username":"everett-toews"},"change_message_id":"1156c793f900ba7e49bcaeac00e4f87ca48bf5b7","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def test_find_available_ip(self):"},{"line_number":125,"context_line":"        sot \u003d self.conn.network.find_available_ip()"},{"line_number":126,"context_line":"        self.assertEqual(None, sot.port_id)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def test_get(self):"},{"line_number":129,"context_line":"        sot \u003d self.conn.network.get_ip(self.FIP_ID)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_924b1e87","line":126,"updated":"2015-08-25 20:54:28.000000000","message":"Is there a reason not to use assertIsNotNone() here?","commit_id":"3ae7abeed5274fa7f326513efe62188d9f7c1c78"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"52db2e4e0b622b6d4b7d742ef0425266c7723fc2","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def test_find_available_ip(self):"},{"line_number":125,"context_line":"        sot \u003d self.conn.network.find_available_ip()"},{"line_number":126,"context_line":"        self.assertEqual(None, sot.port_id)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def test_get(self):"},{"line_number":129,"context_line":"        sot \u003d self.conn.network.get_ip(self.FIP_ID)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_077eee18","line":126,"updated":"2015-08-25 20:24:31.000000000","message":"We should probably test that sot.id is not None, over not looking at it at all. I don\u0027t think the port_id check is actually looking at anything valuable, as far as I understand it.","commit_id":"3ae7abeed5274fa7f326513efe62188d9f7c1c78"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"eb3211a023a297effee2a19cf7b96f8bb5cc1f05","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    def test_find_available_ip(self):"},{"line_number":125,"context_line":"        sot \u003d self.conn.network.find_available_ip()"},{"line_number":126,"context_line":"        self.assertIsNotNone(sot.id)"},{"line_number":127,"context_line":"        self.assertEqual(None, sot.port_id)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def test_get(self):"},{"line_number":130,"context_line":"        sot \u003d self.conn.network.get_ip(self.FIP_ID)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_803553db","line":127,"updated":"2015-08-27 19:03:45.000000000","message":"self.assertIsNone(sot.port_id) for consistency","commit_id":"93e793ace292854559d60e796769e61077a3ac60"}]}