)]}'
{"openstack/object_store/v1/_proxy.py":[{"author":{"_account_id":1112,"name":"Everett Toews","email":"everett.toews@rackspace.com","username":"everett-toews"},"change_message_id":"946d6874830a9a2e3026a60428d2eaab9ec25d89","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        \"\"\"Save the data contained inside an object to disk."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        :param obj: The object to save to disk."},{"line_number":169,"context_line":"        :type obj: :class:`~openstack.object_store.v1.obj.Object`"},{"line_number":170,"context_line":"        :param path str: Location to write the object contents."},{"line_number":171,"context_line":"        :param container: The container the object lives in."},{"line_number":172,"context_line":"        :type container:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_62e72c13","line":169,"updated":"2015-08-26 16:40:19.000000000","message":"There is no obj param anymore.","commit_id":"817bbd3939a915a4204c9e581dc9af8002584509"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"efcd7b38c4937639bb5fda2a1e6323d8d5051d53","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        \"\"\"Save the data contained inside an object to disk."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        :param obj: The object to save to disk."},{"line_number":169,"context_line":"        :type obj: :class:`~openstack.object_store.v1.obj.Object`"},{"line_number":170,"context_line":"        :param path str: Location to write the object contents."},{"line_number":171,"context_line":"        :param container: The container the object lives in."},{"line_number":172,"context_line":"        :type container:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_cdce69b4","line":169,"in_reply_to":"da20952f_62e72c13","updated":"2015-08-26 17:18:39.000000000","message":"Will change it to value","commit_id":"817bbd3939a915a4204c9e581dc9af8002584509"},{"author":{"_account_id":1112,"name":"Everett Toews","email":"everett.toews@rackspace.com","username":"everett-toews"},"change_message_id":"946d6874830a9a2e3026a60428d2eaab9ec25d89","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        :param obj: The object to save to disk."},{"line_number":169,"context_line":"        :type obj: :class:`~openstack.object_store.v1.obj.Object`"},{"line_number":170,"context_line":"        :param path str: Location to write the object contents."},{"line_number":171,"context_line":"        :param container: The container the object lives in."},{"line_number":172,"context_line":"        :type container:"},{"line_number":173,"context_line":"              :class:`~openstack.object_store.v1.container.Container`"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_e28edc26","line":170,"updated":"2015-08-26 16:40:19.000000000","message":"It would be helpful to say what happens when you pass only a dir vs a dir+filename.\n\ne.g.\n\n    path\u003d\u0027mydir\u0027\n\nvs\n\n    path\u003d\u0027mydir/myfilename.txt\u0027","commit_id":"817bbd3939a915a4204c9e581dc9af8002584509"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"efcd7b38c4937639bb5fda2a1e6323d8d5051d53","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        :param obj: The object to save to disk."},{"line_number":169,"context_line":"        :type obj: :class:`~openstack.object_store.v1.obj.Object`"},{"line_number":170,"context_line":"        :param path str: Location to write the object contents."},{"line_number":171,"context_line":"        :param container: The container the object lives in."},{"line_number":172,"context_line":"        :type container:"},{"line_number":173,"context_line":"              :class:`~openstack.object_store.v1.container.Container`"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_6d895dca","line":170,"in_reply_to":"da20952f_e28edc26","updated":"2015-08-26 17:18:39.000000000","message":"You can\u0027t write to a dir so it\u0027ll raise OSError, but I\u0027d prefer not to have to explain how builtin file objects work. I\u0027m going to document the path argument as the \"full\" path to be written to.\n\nOne thing I just briefly thought of, but don\u0027t like, is that path could be a dir and we derive the name from the object name. However, that\u0027s making a decision for the user they should probably make on their own, and they can just figure that out to their liking using get_object.","commit_id":"817bbd3939a915a4204c9e581dc9af8002584509"},{"author":{"_account_id":1112,"name":"Everett Toews","email":"everett.toews@rackspace.com","username":"everett-toews"},"change_message_id":"946d6874830a9a2e3026a60428d2eaab9ec25d89","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        :type container:"},{"line_number":173,"context_line":"              :class:`~openstack.object_store.v1.container.Container`"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        :returns: The count of bytes written to `path`"},{"line_number":176,"context_line":"        \"\"\""},{"line_number":177,"context_line":"        container_name \u003d self._get_container_name(value, container)"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_62d16cfb","line":175,"updated":"2015-08-26 16:40:19.000000000","message":"Isn\u0027t a file returned?","commit_id":"817bbd3939a915a4204c9e581dc9af8002584509"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"efcd7b38c4937639bb5fda2a1e6323d8d5051d53","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        :type container:"},{"line_number":173,"context_line":"              :class:`~openstack.object_store.v1.container.Container`"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        :returns: The count of bytes written to `path`"},{"line_number":176,"context_line":"        \"\"\""},{"line_number":177,"context_line":"        container_name \u003d self._get_container_name(value, container)"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_8d3e31b7","line":175,"in_reply_to":"da20952f_62d16cfb","updated":"2015-08-26 17:18:39.000000000","message":"You\u0027re right, but I wanted what was documented. Next change set stores the count returned by output.write, and this shows up in the functional test.","commit_id":"817bbd3939a915a4204c9e581dc9af8002584509"}],"openstack/tests/functional/object_store/v1/test_obj.py":[{"author":{"_account_id":1112,"name":"Everett Toews","email":"everett.toews@rackspace.com","username":"everett-toews"},"change_message_id":"946d6874830a9a2e3026a60428d2eaab9ec25d89","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            self.FILE, container\u003dself.FOLDER)"},{"line_number":45,"context_line":"        self.assertEqual(self.DATA, result)"},{"line_number":46,"context_line":"        result \u003d self.conn.object_store.get_object(self.sot)"},{"line_number":47,"context_line":"        self.assertEqual(self.DATA, result)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def test_get_metadata(self):"},{"line_number":50,"context_line":"        self.sot.data \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_e2781cfb","line":47,"updated":"2015-08-26 16:40:19.000000000","message":"We need a test_download_object() here.","commit_id":"817bbd3939a915a4204c9e581dc9af8002584509"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"efcd7b38c4937639bb5fda2a1e6323d8d5051d53","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            self.FILE, container\u003dself.FOLDER)"},{"line_number":45,"context_line":"        self.assertEqual(self.DATA, result)"},{"line_number":46,"context_line":"        result \u003d self.conn.object_store.get_object(self.sot)"},{"line_number":47,"context_line":"        self.assertEqual(self.DATA, result)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def test_get_metadata(self):"},{"line_number":50,"context_line":"        self.sot.data \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_c848978a","line":47,"in_reply_to":"da20952f_e2781cfb","updated":"2015-08-26 17:18:39.000000000","message":"Done","commit_id":"817bbd3939a915a4204c9e581dc9af8002584509"}]}