)]}'
{"openstack/compute/v2/server.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"2f83949b0c5a0fd669ca018e51ac937193f42db9","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        return body"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def action(self, session, body, has_response\u003dNone):"},{"line_number":90,"context_line":"        \"\"\"Preform server actions given the message body.\"\"\""},{"line_number":91,"context_line":"        url \u003d utils.urljoin(self.base_path, self.id, \u0027action\u0027)"},{"line_number":92,"context_line":"        if has_response is not None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a26ad4f_e32422c6","line":89,"updated":"2015-10-30 22:55:20.000000000","message":"Just checked several other projects and learned that \u0027POST\u0027 is a common practice. I\u0027m fine with it now.\n\nMy only question is about the \u0027accept\u0027 parameter below. Do we really need the \u0027has_response\u0027 parameter?","commit_id":"2ef40c46b2962a4e8002c8ced3d092ee62794dde"},{"author":{"_account_id":1112,"name":"Everett Toews","email":"everett.toews@rackspace.com","username":"everett-toews"},"change_message_id":"c64285f7164828e456039a485792428f5154c619","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        return body"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def action(self, session, body, has_response\u003dNone):"},{"line_number":90,"context_line":"        \"\"\"Preform server actions given the message body.\"\"\""},{"line_number":91,"context_line":"        url \u003d utils.urljoin(self.base_path, self.id, \u0027action\u0027)"},{"line_number":92,"context_line":"        if has_response is not None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_11964693","line":89,"in_reply_to":"1a26ad4f_0c7706d4","updated":"2015-11-06 01:36:46.000000000","message":"has_response needs to be a boolean.","commit_id":"2ef40c46b2962a4e8002c8ced3d092ee62794dde"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"7e9e337903f48273753dc684fcdd6a7ea5ee3af9","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        return body"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def action(self, session, body, has_response\u003dNone):"},{"line_number":90,"context_line":"        \"\"\"Preform server actions given the message body.\"\"\""},{"line_number":91,"context_line":"        url \u003d utils.urljoin(self.base_path, self.id, \u0027action\u0027)"},{"line_number":92,"context_line":"        if has_response is not None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a26ad4f_0c7706d4","line":89,"in_reply_to":"1a26ad4f_3d5b0ff8","updated":"2015-11-01 00:32:40.000000000","message":"thanks for the explanation.","commit_id":"2ef40c46b2962a4e8002c8ced3d092ee62794dde"},{"author":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"change_message_id":"7cede6eb8005443b6210dab309f1bd4ad508f615","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        return body"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def action(self, session, body, has_response\u003dNone):"},{"line_number":90,"context_line":"        \"\"\"Preform server actions given the message body.\"\"\""},{"line_number":91,"context_line":"        url \u003d utils.urljoin(self.base_path, self.id, \u0027action\u0027)"},{"line_number":92,"context_line":"        if has_response is not None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a26ad4f_3d5b0ff8","line":89,"in_reply_to":"1a26ad4f_e32422c6","updated":"2015-10-31 12:00:37.000000000","message":"the final method we use to send a post request is transport.request, \nwhich uses \"application/json\" as default value for \"accept\", \nand will parse response body as json format if value of \"accept\" is \"application/json\" , \nsee https://github.com/openstack/python-openstacksdk/blob/master/openstack/transport.py#L271 .\nas we will get no response body in many of server actions(few has response body), \nso introducing this parameter can help us handle both types of action.\nwe can let the  specific action decide whether get a response body.","commit_id":"2ef40c46b2962a4e8002c8ced3d092ee62794dde"}]}