)]}'
{"openstack/compute/v2/_proxy.py":[{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"42329c1a27113c67c31029233c606fe51a071621","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        return resource.wait_for_status(self.session, value, status,"},{"line_number":392,"context_line":"                                        failures, interval, wait)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def create_server_interface(self, server_id, **attrs):"},{"line_number":395,"context_line":"        \"\"\"Create a new server interface from attributes"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        :param server_id: The server_id can be either the ID of a server or a"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_6f45adb1","line":394,"updated":"2015-11-09 17:33:17.000000000","message":"Rather than be server_id, these args should be `server` because we can pass in an actual Server instance and the from_id will take care of it.","commit_id":"30ca421ffc79d7d1c60e9a198ca8f667f6be06be"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"6971f10756d7e6a6f94894b0d7d5ace4cbd22d1d","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        return resource.wait_for_status(self.session, value, status,"},{"line_number":392,"context_line":"                                        failures, interval, wait)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def create_server_interface(self, server_id, **attrs):"},{"line_number":395,"context_line":"        \"\"\"Create a new server interface from attributes"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        :param server_id: The server_id can be either the ID of a server or a"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_8b9f9302","line":394,"in_reply_to":"da85f559_6f45adb1","updated":"2015-11-10 01:01:13.000000000","message":"Yes, will change.","commit_id":"30ca421ffc79d7d1c60e9a198ca8f667f6be06be"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"ab22b7fafd15bbf03e91e414eb9a105e97505377","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        return self._create(server_interface.ServerInterface,"},{"line_number":409,"context_line":"                            path_args\u003d{\u0027server_id\u0027: server_obj.id}, **attrs)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    def delete_server_interface(self, value, server, ignore_missing\u003dTrue):"},{"line_number":412,"context_line":"        \"\"\"Delete a server interface"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"        :param value: The value can be either the ID of a server interface or a"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_0efdf539","line":411,"updated":"2015-11-17 15:58:03.000000000","message":"change the order of \u0027value\u0027 and \u0027server\u0027 parameters?","commit_id":"8a5ae645da37461b0dc85c61681c5c17345e8ffa"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"0eca98dfd616a7420b9c6840165df772dbaf68cc","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        return self._create(server_interface.ServerInterface,"},{"line_number":409,"context_line":"                            path_args\u003d{\u0027server_id\u0027: server_obj.id}, **attrs)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    def delete_server_interface(self, value, server, ignore_missing\u003dTrue):"},{"line_number":412,"context_line":"        \"\"\"Delete a server interface"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"        :param value: The value can be either the ID of a server interface or a"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_9fe1f1d2","line":411,"in_reply_to":"ba8a016a_0efdf539","updated":"2015-11-18 03:20:05.000000000","message":"Hi, Qiming, I just tried to keep consistent with some existing function calls which have extra input parameter defined for path_arg building, like this one:\n\nhttp://git.openstack.org/cgit/openstack/python-openstacksdk/tree/openstack/network/v2/_proxy.py#n735\n\nSo maybe we should change them as well?","commit_id":"8a5ae645da37461b0dc85c61681c5c17345e8ffa"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"1cae063760a6d5cd67573000312af56ba438790c","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        return self._create(server_interface.ServerInterface,"},{"line_number":409,"context_line":"                            path_args\u003d{\u0027server_id\u0027: server_obj.id}, **attrs)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    def delete_server_interface(self, value, server, ignore_missing\u003dTrue):"},{"line_number":412,"context_line":"        \"\"\"Delete a server interface"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"        :param value: The value can be either the ID of a server interface or a"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_8a645149","line":411,"in_reply_to":"ba8a016a_8a869163","updated":"2015-11-18 04:12:16.000000000","message":"understand.","commit_id":"8a5ae645da37461b0dc85c61681c5c17345e8ffa"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"fa561afeaff05b954a7c1c6b6de1ebbb9ac6fd2c","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        return self._create(server_interface.ServerInterface,"},{"line_number":409,"context_line":"                            path_args\u003d{\u0027server_id\u0027: server_obj.id}, **attrs)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    def delete_server_interface(self, value, server, ignore_missing\u003dTrue):"},{"line_number":412,"context_line":"        \"\"\"Delete a server interface"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"        :param value: The value can be either the ID of a server interface or a"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_8a869163","line":411,"in_reply_to":"ba8a016a_9fe1f1d2","updated":"2015-11-18 03:42:30.000000000","message":"I\u0027m thinking from a user\u0027s perspective instead of the URI formed. When operating an interface on a server, the first thing comes to mind is the server, the second thing is the interface (value). This is not a blocker though, just an opinion.","commit_id":"8a5ae645da37461b0dc85c61681c5c17345e8ffa"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"ab22b7fafd15bbf03e91e414eb9a105e97505377","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                     path_args\u003d{\u0027server_id\u0027: server_obj.id},"},{"line_number":431,"context_line":"                     ignore_missing\u003dignore_missing)"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    def find_server_interface(self, name_or_id, server,"},{"line_number":434,"context_line":"                              ignore_missing\u003dTrue):"},{"line_number":435,"context_line":"        \"\"\"Find a single server interface"},{"line_number":436,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_6e85a1ab","line":433,"updated":"2015-11-17 15:58:03.000000000","message":"maybe we should use \u0027value\u0027 here instead of \u0027name_or_id\u0027 for consistency.\n\nalso there is the suggestion of switching the order of \u0027value\u0027 and \u0027server\u0027 parameters.","commit_id":"8a5ae645da37461b0dc85c61681c5c17345e8ffa"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"0eca98dfd616a7420b9c6840165df772dbaf68cc","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                     path_args\u003d{\u0027server_id\u0027: server_obj.id},"},{"line_number":431,"context_line":"                     ignore_missing\u003dignore_missing)"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    def find_server_interface(self, name_or_id, server,"},{"line_number":434,"context_line":"                              ignore_missing\u003dTrue):"},{"line_number":435,"context_line":"        \"\"\"Find a single server interface"},{"line_number":436,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_bf5635d0","line":433,"in_reply_to":"ba8a016a_6e85a1ab","updated":"2015-11-18 03:20:05.000000000","message":"ok, will change the param name.","commit_id":"8a5ae645da37461b0dc85c61681c5c17345e8ffa"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"fa561afeaff05b954a7c1c6b6de1ebbb9ac6fd2c","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                     path_args\u003d{\u0027server_id\u0027: server_obj.id},"},{"line_number":431,"context_line":"                     ignore_missing\u003dignore_missing)"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    def find_server_interface(self, name_or_id, server,"},{"line_number":434,"context_line":"                              ignore_missing\u003dTrue):"},{"line_number":435,"context_line":"        \"\"\"Find a single server interface"},{"line_number":436,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_ea971d8e","line":433,"in_reply_to":"ba8a016a_bf5635d0","updated":"2015-11-18 03:42:30.000000000","message":"this is the reason I voted -1.","commit_id":"8a5ae645da37461b0dc85c61681c5c17345e8ffa"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"ab22b7fafd15bbf03e91e414eb9a105e97505377","unresolved":false,"context_lines":[{"line_number":451,"context_line":"            self.session, name_or_id, ignore_missing\u003dignore_missing,"},{"line_number":452,"context_line":"            path_args\u003d{\u0027server_id\u0027: server_obj.id})"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"    def get_server_interface(self, value, server):"},{"line_number":455,"context_line":"        \"\"\"Get a single server interface"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        :param value: The value can be the ID of a server interface or a"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_8e6d6506","line":454,"updated":"2015-11-17 15:58:03.000000000","message":"order of parameter","commit_id":"8a5ae645da37461b0dc85c61681c5c17345e8ffa"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"ab22b7fafd15bbf03e91e414eb9a105e97505377","unresolved":false,"context_lines":[{"line_number":475,"context_line":""},{"line_number":476,"context_line":"        :param server: The server can be either the ID of a server or a"},{"line_number":477,"context_line":"                       :class:`~openstack.compute.v2.server.Server` instance"},{"line_number":478,"context_line":"                       that the interface belongs to."},{"line_number":479,"context_line":"        :param kwargs \\*\\*query: Optional query parameters to be sent to limit"},{"line_number":480,"context_line":"                                 the resources being returned."},{"line_number":481,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_ee4d119a","line":478,"updated":"2015-11-17 15:58:03.000000000","message":"\u0027the interface\u0027 is referring to nothing here.","commit_id":"8a5ae645da37461b0dc85c61681c5c17345e8ffa"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"0eca98dfd616a7420b9c6840165df772dbaf68cc","unresolved":false,"context_lines":[{"line_number":475,"context_line":""},{"line_number":476,"context_line":"        :param server: The server can be either the ID of a server or a"},{"line_number":477,"context_line":"                       :class:`~openstack.compute.v2.server.Server` instance"},{"line_number":478,"context_line":"                       that the interface belongs to."},{"line_number":479,"context_line":"        :param kwargs \\*\\*query: Optional query parameters to be sent to limit"},{"line_number":480,"context_line":"                                 the resources being returned."},{"line_number":481,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_7f068dcf","line":478,"in_reply_to":"ba8a016a_ee4d119a","updated":"2015-11-18 03:20:05.000000000","message":"Yes, will remove it.","commit_id":"8a5ae645da37461b0dc85c61681c5c17345e8ffa"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"59235aa68ac266706f25306811f38b9199017cdf","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        :returns: The results of server interface creation"},{"line_number":405,"context_line":"        :rtype: :class:`~openstack.compute.v2.server_interface.ServerInterface`"},{"line_number":406,"context_line":"        \"\"\""},{"line_number":407,"context_line":"        server_obj \u003d _server.Server.from_id(server)"},{"line_number":408,"context_line":"        return self._create(server_interface.ServerInterface,"},{"line_number":409,"context_line":"                            path_args\u003d{\u0027server_id\u0027: server_obj.id}, **attrs)"},{"line_number":410,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_74c56e3b","line":407,"updated":"2015-11-23 14:24:11.000000000","message":"Suggestion: Create a private method for getting the server interface \"path_args\" from a server since the same code is repeated on many of these methods.","commit_id":"467f57995e3d030d926ec52ff3394b9884082176"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"73a7af465c2d4d7d45c687a88e70332612f67af4","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        :returns: The results of server interface creation"},{"line_number":405,"context_line":"        :rtype: :class:`~openstack.compute.v2.server_interface.ServerInterface`"},{"line_number":406,"context_line":"        \"\"\""},{"line_number":407,"context_line":"        server_obj \u003d _server.Server.from_id(server)"},{"line_number":408,"context_line":"        return self._create(server_interface.ServerInterface,"},{"line_number":409,"context_line":"                            path_args\u003d{\u0027server_id\u0027: server_obj.id}, **attrs)"},{"line_number":410,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_b006621e","line":407,"in_reply_to":"ba8a016a_74c56e3b","updated":"2015-11-24 01:56:12.000000000","message":"Hi, Richard, I think it\u0027s not that worthy to define an extra method for getting \u0027path_arg\u0027 value since it\u0027s just a really simple logic. Thanks.","commit_id":"467f57995e3d030d926ec52ff3394b9884082176"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"7ee0752eb5d9f7761c5558c6537f9b064843bbe1","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        \"\"\"Delete a server interface"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"        :param value: The value can be either the ID of a server interface or a"},{"line_number":415,"context_line":"               :class:`~openstack.compute.v2.server_interface.ServerInterface`"},{"line_number":416,"context_line":"               instance."},{"line_number":417,"context_line":"        :param server: The server can be either the ID of a server or a"},{"line_number":418,"context_line":"                       :class:`~openstack.compute.v2.server.Server` instance"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a8ffd7b_bf9c155e","line":415,"updated":"2015-11-25 15:05:45.000000000","message":"Might want to say server interface or mac address of a server interface.","commit_id":"128d0bc0af3adb31bb1344da89d721269163fe5b"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"dccdfef5f052f31bfb5f9a46c1f4939833972caa","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        \"\"\"Delete a server interface"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"        :param value: The value can be either the ID of a server interface or a"},{"line_number":415,"context_line":"               :class:`~openstack.compute.v2.server_interface.ServerInterface`"},{"line_number":416,"context_line":"               instance."},{"line_number":417,"context_line":"        :param server: The server can be either the ID of a server or a"},{"line_number":418,"context_line":"                       :class:`~openstack.compute.v2.server.Server` instance"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a8ffd7b_b54c1a71","line":415,"in_reply_to":"9a8ffd7b_bf9c155e","updated":"2015-11-26 02:31:41.000000000","message":"I checked the Nova API and found we should use port_id rather than mac_addr as the id_attribute of ServerInterface. Will make a change on ServerInterface definition.","commit_id":"128d0bc0af3adb31bb1344da89d721269163fe5b"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"7ee0752eb5d9f7761c5558c6537f9b064843bbe1","unresolved":false,"context_lines":[{"line_number":415,"context_line":"               :class:`~openstack.compute.v2.server_interface.ServerInterface`"},{"line_number":416,"context_line":"               instance."},{"line_number":417,"context_line":"        :param server: The server can be either the ID of a server or a"},{"line_number":418,"context_line":"                       :class:`~openstack.compute.v2.server.Server` instance"},{"line_number":419,"context_line":"                       that the interface belongs to."},{"line_number":420,"context_line":"        :param bool ignore_missing: When set to ``False``"},{"line_number":421,"context_line":"                    :class:`~openstack.exceptions.ResourceNotFound` will be"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a8ffd7b_bfae5596","line":418,"updated":"2015-11-25 15:05:45.000000000","message":"I think this is a little confusing to the user because if the passes a server_interface object, it will have a server already.  Might be nothing good to do about this","commit_id":"128d0bc0af3adb31bb1344da89d721269163fe5b"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"dccdfef5f052f31bfb5f9a46c1f4939833972caa","unresolved":false,"context_lines":[{"line_number":415,"context_line":"               :class:`~openstack.compute.v2.server_interface.ServerInterface`"},{"line_number":416,"context_line":"               instance."},{"line_number":417,"context_line":"        :param server: The server can be either the ID of a server or a"},{"line_number":418,"context_line":"                       :class:`~openstack.compute.v2.server.Server` instance"},{"line_number":419,"context_line":"                       that the interface belongs to."},{"line_number":420,"context_line":"        :param bool ignore_missing: When set to ``False``"},{"line_number":421,"context_line":"                    :class:`~openstack.exceptions.ResourceNotFound` will be"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a8ffd7b_9530f69f","line":418,"in_reply_to":"9a8ffd7b_bfae5596","updated":"2015-11-26 02:31:41.000000000","message":"Maybe we can give server parameter a default value None and add a hint in param description to say this is an optional parameter that is needed only when ServerInterface ID rather than instance is provided as value.","commit_id":"128d0bc0af3adb31bb1344da89d721269163fe5b"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"7ee0752eb5d9f7761c5558c6537f9b064843bbe1","unresolved":false,"context_lines":[{"line_number":427,"context_line":"        \"\"\""},{"line_number":428,"context_line":"        server_obj \u003d _server.Server.from_id(server)"},{"line_number":429,"context_line":"        self._delete(server_interface.ServerInterface, value,"},{"line_number":430,"context_line":"                     path_args\u003d{\u0027server_id\u0027: server_obj.id},"},{"line_number":431,"context_line":"                     ignore_missing\u003dignore_missing)"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    def find_server_interface(self, name_or_id, server, ignore_missing\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a8ffd7b_5ff9697f","line":430,"updated":"2015-11-25 15:05:45.000000000","message":"If value is a server interface, we should ignore the server attribute I think.","commit_id":"128d0bc0af3adb31bb1344da89d721269163fe5b"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"dccdfef5f052f31bfb5f9a46c1f4939833972caa","unresolved":false,"context_lines":[{"line_number":427,"context_line":"        \"\"\""},{"line_number":428,"context_line":"        server_obj \u003d _server.Server.from_id(server)"},{"line_number":429,"context_line":"        self._delete(server_interface.ServerInterface, value,"},{"line_number":430,"context_line":"                     path_args\u003d{\u0027server_id\u0027: server_obj.id},"},{"line_number":431,"context_line":"                     ignore_missing\u003dignore_missing)"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    def find_server_interface(self, name_or_id, server, ignore_missing\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a8ffd7b_1592c657","line":430,"in_reply_to":"9a8ffd7b_5ff9697f","updated":"2015-11-26 02:31:41.000000000","message":"Done","commit_id":"128d0bc0af3adb31bb1344da89d721269163fe5b"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"7ee0752eb5d9f7761c5558c6537f9b064843bbe1","unresolved":false,"context_lines":[{"line_number":433,"context_line":"    def find_server_interface(self, name_or_id, server, ignore_missing\u003dTrue):"},{"line_number":434,"context_line":"        \"\"\"Find a single server interface"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        :param name_or_id: The name or ID of a server interface."},{"line_number":437,"context_line":"        :param server: The server can be either the ID of a server or a"},{"line_number":438,"context_line":"                       :class:`~openstack.compute.v2.server.Server` instance"},{"line_number":439,"context_line":"                       that the interface belongs to."}],"source_content_type":"text/x-python","patch_set":8,"id":"9a8ffd7b_1f78c1f1","line":436,"updated":"2015-11-25 15:05:45.000000000","message":"There is no name attribute to the server interface near as I can tell.","commit_id":"128d0bc0af3adb31bb1344da89d721269163fe5b"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"dccdfef5f052f31bfb5f9a46c1f4939833972caa","unresolved":false,"context_lines":[{"line_number":433,"context_line":"    def find_server_interface(self, name_or_id, server, ignore_missing\u003dTrue):"},{"line_number":434,"context_line":"        \"\"\"Find a single server interface"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        :param name_or_id: The name or ID of a server interface."},{"line_number":437,"context_line":"        :param server: The server can be either the ID of a server or a"},{"line_number":438,"context_line":"                       :class:`~openstack.compute.v2.server.Server` instance"},{"line_number":439,"context_line":"                       that the interface belongs to."}],"source_content_type":"text/x-python","patch_set":8,"id":"9a8ffd7b_35834a06","line":436,"in_reply_to":"9a8ffd7b_1f78c1f1","updated":"2015-11-26 02:31:41.000000000","message":"Done","commit_id":"128d0bc0af3adb31bb1344da89d721269163fe5b"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"35bee0c4f0e9c4cf6f9ab931059bd2399c7d4729","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        :returns: The results of server interface creation"},{"line_number":405,"context_line":"        :rtype: :class:`~openstack.compute.v2.server_interface.ServerInterface`"},{"line_number":406,"context_line":"        \"\"\""},{"line_number":407,"context_line":"        server_obj \u003d _server.Server.from_id(server)"},{"line_number":408,"context_line":"        return self._create(server_interface.ServerInterface,"},{"line_number":409,"context_line":"                            path_args\u003d{\u0027server_id\u0027: server_obj.id}, **attrs)"},{"line_number":410,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a8ffd7b_0ad85dee","line":407,"updated":"2015-11-26 06:58:00.000000000","message":"the above line should be:\n\n   server_id \u003d resource.Resource.get_id(server)\n\nThen you can  use the server_id in the \u0027_create\u0027 call without having to instantiate a Server instance.","commit_id":"fd25b17b0e5cf91c3c6713659e89cfb1299a4ba6"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"7491309da8be8dc8bb44cad62cc4d3163606ddc4","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        :returns: The results of server interface creation"},{"line_number":405,"context_line":"        :rtype: :class:`~openstack.compute.v2.server_interface.ServerInterface`"},{"line_number":406,"context_line":"        \"\"\""},{"line_number":407,"context_line":"        server_obj \u003d _server.Server.from_id(server)"},{"line_number":408,"context_line":"        return self._create(server_interface.ServerInterface,"},{"line_number":409,"context_line":"                            path_args\u003d{\u0027server_id\u0027: server_obj.id}, **attrs)"},{"line_number":410,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a8ffd7b_3e87a2d8","line":407,"in_reply_to":"9a8ffd7b_0ad85dee","updated":"2015-11-26 07:35:24.000000000","message":"Thanks for pointing this out. Will change it.","commit_id":"fd25b17b0e5cf91c3c6713659e89cfb1299a4ba6"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"35bee0c4f0e9c4cf6f9ab931059bd2399c7d4729","unresolved":false,"context_lines":[{"line_number":428,"context_line":"        \"\"\""},{"line_number":429,"context_line":"        if isinstance(value, server_interface.ServerInterface):"},{"line_number":430,"context_line":"            server_id \u003d value.server_id"},{"line_number":431,"context_line":"        else:"},{"line_number":432,"context_line":"            server_obj \u003d _server.Server.from_id(server)"},{"line_number":433,"context_line":"            server_id \u003d server_obj.id"},{"line_number":434,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a8ffd7b_7e09aadc","line":431,"updated":"2015-11-26 06:58:00.000000000","message":"The following two lines should be changed to:\n\n   server_id \u003d resource.Resource.get_id(server)","commit_id":"fd25b17b0e5cf91c3c6713659e89cfb1299a4ba6"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"7491309da8be8dc8bb44cad62cc4d3163606ddc4","unresolved":false,"context_lines":[{"line_number":428,"context_line":"        \"\"\""},{"line_number":429,"context_line":"        if isinstance(value, server_interface.ServerInterface):"},{"line_number":430,"context_line":"            server_id \u003d value.server_id"},{"line_number":431,"context_line":"        else:"},{"line_number":432,"context_line":"            server_obj \u003d _server.Server.from_id(server)"},{"line_number":433,"context_line":"            server_id \u003d server_obj.id"},{"line_number":434,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a8ffd7b_fe691a26","line":431,"in_reply_to":"9a8ffd7b_7e09aadc","updated":"2015-11-26 07:35:24.000000000","message":"Done","commit_id":"fd25b17b0e5cf91c3c6713659e89cfb1299a4ba6"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"35bee0c4f0e9c4cf6f9ab931059bd2399c7d4729","unresolved":false,"context_lines":[{"line_number":451,"context_line":"        :returns: One :class:`~openstack.compute.v2.server_interface."},{"line_number":452,"context_line":"                  ServerInterface` or None"},{"line_number":453,"context_line":"        \"\"\""},{"line_number":454,"context_line":"        server_obj \u003d _server.Server.from_id(server)"},{"line_number":455,"context_line":"        return self._find(server_interface.ServerInterface,"},{"line_number":456,"context_line":"                          interface_id, path_args\u003d{\u0027server_id\u0027: server_obj.id},"},{"line_number":457,"context_line":"                          ignore_missing\u003dignore_missing)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a8ffd7b_fef59aca","line":454,"updated":"2015-11-26 06:58:00.000000000","message":"check comment on get_server_interface() call","commit_id":"fd25b17b0e5cf91c3c6713659e89cfb1299a4ba6"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"7491309da8be8dc8bb44cad62cc4d3163606ddc4","unresolved":false,"context_lines":[{"line_number":451,"context_line":"        :returns: One :class:`~openstack.compute.v2.server_interface."},{"line_number":452,"context_line":"                  ServerInterface` or None"},{"line_number":453,"context_line":"        \"\"\""},{"line_number":454,"context_line":"        server_obj \u003d _server.Server.from_id(server)"},{"line_number":455,"context_line":"        return self._find(server_interface.ServerInterface,"},{"line_number":456,"context_line":"                          interface_id, path_args\u003d{\u0027server_id\u0027: server_obj.id},"},{"line_number":457,"context_line":"                          ignore_missing\u003dignore_missing)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a8ffd7b_be739214","line":454,"in_reply_to":"9a8ffd7b_fef59aca","updated":"2015-11-26 07:35:24.000000000","message":"Hmm, I think we should remove this function since server interface actually doesn\u0027t have name attribute.","commit_id":"fd25b17b0e5cf91c3c6713659e89cfb1299a4ba6"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"35bee0c4f0e9c4cf6f9ab931059bd2399c7d4729","unresolved":false,"context_lines":[{"line_number":471,"context_line":"        :raises: :class:`~openstack.exceptions.ResourceNotFound`"},{"line_number":472,"context_line":"                 when no resource can be found."},{"line_number":473,"context_line":"        \"\"\""},{"line_number":474,"context_line":"        server_obj \u003d _server.Server.from_id(server)"},{"line_number":475,"context_line":"        return self._get(server_interface.ServerInterface, value,"},{"line_number":476,"context_line":"                         path_args\u003d{\u0027server_id\u0027: server_obj.id})"},{"line_number":477,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a8ffd7b_7e30ca9e","line":474,"updated":"2015-11-26 06:58:00.000000000","message":"how about:\n\n   if isinstance(value, server_interface.ServerInterface):\n      server_id \u003d value.server_id\n      intf_id \u003d value.id\n   else:\n      server_id \u003d resource.Resource.get_id(server)\n      intf_id \u003d value","commit_id":"fd25b17b0e5cf91c3c6713659e89cfb1299a4ba6"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"7491309da8be8dc8bb44cad62cc4d3163606ddc4","unresolved":false,"context_lines":[{"line_number":471,"context_line":"        :raises: :class:`~openstack.exceptions.ResourceNotFound`"},{"line_number":472,"context_line":"                 when no resource can be found."},{"line_number":473,"context_line":"        \"\"\""},{"line_number":474,"context_line":"        server_obj \u003d _server.Server.from_id(server)"},{"line_number":475,"context_line":"        return self._get(server_interface.ServerInterface, value,"},{"line_number":476,"context_line":"                         path_args\u003d{\u0027server_id\u0027: server_obj.id})"},{"line_number":477,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a8ffd7b_deb1b690","line":474,"in_reply_to":"9a8ffd7b_7e30ca9e","updated":"2015-11-26 07:35:24.000000000","message":"It makes sense. Just feel we don\u0027t need to extract interface ID from value since Proxy._get can accept both ID and resource object as input value. Will make a change.","commit_id":"fd25b17b0e5cf91c3c6713659e89cfb1299a4ba6"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"35bee0c4f0e9c4cf6f9ab931059bd2399c7d4729","unresolved":false,"context_lines":[{"line_number":486,"context_line":"        :returns: A generator of ServerInterface objects"},{"line_number":487,"context_line":"        :rtype: :class:`~openstack.compute.v2.server_interface.ServerInterface`"},{"line_number":488,"context_line":"        \"\"\""},{"line_number":489,"context_line":"        server_obj \u003d _server.Server.from_id(server)"},{"line_number":490,"context_line":"        return self._list(server_interface.ServerInterface, paginated\u003dFalse,"},{"line_number":491,"context_line":"                          path_args\u003d{\u0027server_id\u0027: server_obj.id},"},{"line_number":492,"context_line":"                          **query)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a8ffd7b_9ec9ee7a","line":489,"updated":"2015-11-26 06:58:00.000000000","message":"server_id \u003d resource.Resource.get_id(server)","commit_id":"fd25b17b0e5cf91c3c6713659e89cfb1299a4ba6"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"7491309da8be8dc8bb44cad62cc4d3163606ddc4","unresolved":false,"context_lines":[{"line_number":486,"context_line":"        :returns: A generator of ServerInterface objects"},{"line_number":487,"context_line":"        :rtype: :class:`~openstack.compute.v2.server_interface.ServerInterface`"},{"line_number":488,"context_line":"        \"\"\""},{"line_number":489,"context_line":"        server_obj \u003d _server.Server.from_id(server)"},{"line_number":490,"context_line":"        return self._list(server_interface.ServerInterface, paginated\u003dFalse,"},{"line_number":491,"context_line":"                          path_args\u003d{\u0027server_id\u0027: server_obj.id},"},{"line_number":492,"context_line":"                          **query)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a8ffd7b_7ef20a71","line":489,"in_reply_to":"9a8ffd7b_9ec9ee7a","updated":"2015-11-26 07:35:24.000000000","message":"Done","commit_id":"fd25b17b0e5cf91c3c6713659e89cfb1299a4ba6"}]}