)]}'
{"openstack/compute/v2/server.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"c0c7a1b24a89d3a8a4a3f0090eca42983987ddd7","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        return body"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def action(self, session, body, has_response\u003dFalse):"},{"line_number":90,"context_line":"        \"\"\"Preform server actions given the message body.\"\"\""},{"line_number":91,"context_line":"        url \u003d utils.urljoin(self.base_path, self.id, \u0027action\u0027)"},{"line_number":92,"context_line":"        if has_response:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_4fafd12b","line":89,"updated":"2015-12-22 13:38:01.000000000","message":"I don\u0027t see has_response\u003dTrue being used.  Is that path of the code used or tested?","commit_id":"ad650f4bad519d5fe5de7365f6a4b44edc0240a4"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"46311b3223f73dbb2d8fe111b0302bdf4a208117","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        return body"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def action(self, session, body, has_response\u003dFalse):"},{"line_number":90,"context_line":"        \"\"\"Preform server actions given the message body.\"\"\""},{"line_number":91,"context_line":"        url \u003d utils.urljoin(self.base_path, self.id, \u0027action\u0027)"},{"line_number":92,"context_line":"        if has_response:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_01a0909e","line":89,"in_reply_to":"1a7b0d38_667e61e6","updated":"2015-12-23 14:04:52.000000000","message":"I don\u0027t understand the need for having code that doesn\u0027t get run or tested.","commit_id":"ad650f4bad519d5fe5de7365f6a4b44edc0240a4"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"4ce13297a9a73ce557e2392b5453365bc91d7ffe","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        return body"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def action(self, session, body, has_response\u003dFalse):"},{"line_number":90,"context_line":"        \"\"\"Preform server actions given the message body.\"\"\""},{"line_number":91,"context_line":"        url \u003d utils.urljoin(self.base_path, self.id, \u0027action\u0027)"},{"line_number":92,"context_line":"        if has_response:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_667e61e6","line":89,"in_reply_to":"3a7e1126_4fafd12b","updated":"2015-12-23 02:01:26.000000000","message":"Hi, Richard, this logic was added in the following patch and there was a discussion there about whether we should keep this has_response branch. The decision makes sense to me although I haven\u0027t seen any Nova server action API returns resp body as of now.\n\nhttps://review.openstack.org/#/c/239253/","commit_id":"ad650f4bad519d5fe5de7365f6a4b44edc0240a4"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"3850f3cbd8a1dc5ecc63cd78f19a00bec7bdee6c","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        return body"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def action(self, session, body, has_response\u003dFalse):"},{"line_number":90,"context_line":"        \"\"\"Preform server actions given the message body.\"\"\""},{"line_number":91,"context_line":"        url \u003d utils.urljoin(self.base_path, self.id, \u0027action\u0027)"},{"line_number":92,"context_line":"        headers \u003d {\u0027Accept\u0027: \u0027\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_4bd2af5d","line":89,"updated":"2015-12-29 14:25:52.000000000","message":"has_response is not used and should be removed.","commit_id":"a71327d408155b1625d074715d72a95f1b58afc7"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"bb0b8e52be58d450c3f8e8fb2c236af3a3b30b92","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        return body"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def action(self, session, body, has_response\u003dFalse):"},{"line_number":90,"context_line":"        \"\"\"Preform server actions given the message body.\"\"\""},{"line_number":91,"context_line":"        url \u003d utils.urljoin(self.base_path, self.id, \u0027action\u0027)"},{"line_number":92,"context_line":"        headers \u003d {\u0027Accept\u0027: \u0027\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_4ae248a1","line":89,"in_reply_to":"1a7b0d38_4bd2af5d","updated":"2015-12-30 01:22:50.000000000","message":"my mistake, will change.","commit_id":"a71327d408155b1625d074715d72a95f1b58afc7"}]}