)]}'
{"openstack/network/v2/_proxy.py":[{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"769db7fc1c1ea7c821c665b2e200c03accd4d90b","unresolved":false,"context_lines":[{"line_number":1478,"context_line":"        \"\"\""},{"line_number":1479,"context_line":"        return self._get(_segment.Segment, segment)"},{"line_number":1480,"context_line":""},{"line_number":1481,"context_line":"    def segments(self, **query):"},{"line_number":1482,"context_line":"        \"\"\"Return a generator of segments"},{"line_number":1483,"context_line":""},{"line_number":1484,"context_line":"        .. caution::"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_51725e12","line":1481,"range":{"start_line":1481,"start_character":25,"end_line":1481,"end_character":30},"updated":"2016-05-13 14:48:27.000000000","message":"Does this call actually accept query parameters? I can\u0027t find it in the documentation, and one of the refactoring steps I\u0027ve done in compute (and will do elsewhere) is to clean up all of the places we claim to support query params when the underlying API doesn\u0027t support them. Their proliferation is a result of copy/paste, but we really only need to expose them in probably a dozen places.","commit_id":"ad25c36beba77869658273234d1ecc17c91aee61"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f7f31b8cbcdf7d1bf56fa8405ea5b3c8cda21c82","unresolved":false,"context_lines":[{"line_number":1478,"context_line":"        \"\"\""},{"line_number":1479,"context_line":"        return self._get(_segment.Segment, segment)"},{"line_number":1480,"context_line":""},{"line_number":1481,"context_line":"    def segments(self, **query):"},{"line_number":1482,"context_line":"        \"\"\"Return a generator of segments"},{"line_number":1483,"context_line":""},{"line_number":1484,"context_line":"        .. caution::"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_c5583efd","line":1481,"range":{"start_line":1481,"start_character":25,"end_line":1481,"end_character":30},"in_reply_to":"dab17558_51725e12","updated":"2016-05-13 17:49:06.000000000","message":"I had to double check but this call does support query parameters.","commit_id":"ad25c36beba77869658273234d1ecc17c91aee61"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"b03b8d347f4cb6a671e989aca098ddb6c35578c5","unresolved":false,"context_lines":[{"line_number":1478,"context_line":"        \"\"\""},{"line_number":1479,"context_line":"        return self._get(_segment.Segment, segment)"},{"line_number":1480,"context_line":""},{"line_number":1481,"context_line":"    def segments(self, **query):"},{"line_number":1482,"context_line":"        \"\"\"Return a generator of segments"},{"line_number":1483,"context_line":""},{"line_number":1484,"context_line":"        .. caution::"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_e5c9027b","line":1481,"range":{"start_line":1481,"start_character":25,"end_line":1481,"end_character":30},"in_reply_to":"dab17558_c5583efd","updated":"2016-05-13 17:54:05.000000000","message":"In that case, can you do me a favor and add a TODO comment in the Segment resource that links to the supported query parameters, or just leave a comment with the accepted params? When this gets refactored for resource2, we need to explicitly lay out the supported query parameters for a given resource and this would make it easier.","commit_id":"ad25c36beba77869658273234d1ecc17c91aee61"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"883603e5b78df67750cc3df84828078faf50edef","unresolved":false,"context_lines":[{"line_number":1478,"context_line":"        \"\"\""},{"line_number":1479,"context_line":"        return self._get(_segment.Segment, segment)"},{"line_number":1480,"context_line":""},{"line_number":1481,"context_line":"    def segments(self, **query):"},{"line_number":1482,"context_line":"        \"\"\"Return a generator of segments"},{"line_number":1483,"context_line":""},{"line_number":1484,"context_line":"        .. caution::"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_b9ae0396","line":1481,"range":{"start_line":1481,"start_character":25,"end_line":1481,"end_character":30},"in_reply_to":"dab17558_e5c9027b","updated":"2016-05-13 19:31:40.000000000","message":"I\u0027ve updated the documentation with the accepted params.","commit_id":"ad25c36beba77869658273234d1ecc17c91aee61"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e299ffc8a85598ab1ee2aaf4590bace5c75aee96","unresolved":false,"context_lines":[{"line_number":1445,"context_line":"        return self._list(_security_group_rule.SecurityGroupRule,"},{"line_number":1446,"context_line":"                          paginated\u003dFalse, **query)"},{"line_number":1447,"context_line":""},{"line_number":1448,"context_line":"    def find_segment(self, name_or_id, ignore_missing\u003dTrue):"},{"line_number":1449,"context_line":"        \"\"\"Find a single segment"},{"line_number":1450,"context_line":""},{"line_number":1451,"context_line":"        .. caution::"}],"source_content_type":"text/x-python","patch_set":10,"id":"bab6814e_c3b5ed31","line":1448,"range":{"start_line":1448,"start_character":27,"end_line":1448,"end_character":37},"updated":"2016-05-19 07:55:28.000000000","message":"segment don\u0027t have a name currently, is that under the consideration?","commit_id":"ac8a9bc92e7d1908e3c6f9cd9963eb00f2bce9a8"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"785b146a6a2f739669a6704aa4801545b6807325","unresolved":false,"context_lines":[{"line_number":1445,"context_line":"        return self._list(_security_group_rule.SecurityGroupRule,"},{"line_number":1446,"context_line":"                          paginated\u003dFalse, **query)"},{"line_number":1447,"context_line":""},{"line_number":1448,"context_line":"    def find_segment(self, name_or_id, ignore_missing\u003dTrue):"},{"line_number":1449,"context_line":"        \"\"\"Find a single segment"},{"line_number":1450,"context_line":""},{"line_number":1451,"context_line":"        .. caution::"}],"source_content_type":"text/x-python","patch_set":10,"id":"bab6814e_b418d685","line":1448,"range":{"start_line":1448,"start_character":27,"end_line":1448,"end_character":37},"in_reply_to":"bab6814e_c3b5ed31","updated":"2016-05-19 10:46:15.000000000","message":"Hi Hong Hui, yes that is under consideration here: https://review.openstack.org/#/c/293305/","commit_id":"ac8a9bc92e7d1908e3c6f9cd9963eb00f2bce9a8"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"0b54ad53bdf76a60e5087fc37e4499853d27eaca","unresolved":false,"context_lines":[{"line_number":1487,"context_line":"        :param kwargs \\*\\*query: Optional query parameters to be sent to limit"},{"line_number":1488,"context_line":"            the resources being returned. Available parameters include:"},{"line_number":1489,"context_line":""},{"line_number":1490,"context_line":"            * network_id: ID of the network that owns the segments"},{"line_number":1491,"context_line":"            * network_type: Network type for the segments"},{"line_number":1492,"context_line":"            * physical_network: Physical network name for the segments"},{"line_number":1493,"context_line":"            * segmentation_id: Segmentation ID for the segments"}],"source_content_type":"text/x-python","patch_set":10,"id":"dab17558_b970c3dd","line":1490,"range":{"start_line":1490,"start_character":14,"end_line":1490,"end_character":24},"updated":"2016-05-13 19:42:41.000000000","message":"Cool, these will work directly since they\u0027re not in some other naming format where we need to map them. We\u0027ll eventually just add QueryParameters(\"network_id\", \u003cother names\u003e) and it\u0027ll work the same but be more strict.","commit_id":"ac8a9bc92e7d1908e3c6f9cd9963eb00f2bce9a8"}]}