)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"9e9433e3ec2cc43fc57aa1531ba37d1df283029d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Updated these methods to accept the required parameter image and"},{"line_number":16,"context_line":"pass it to the respective base class methods in the required format."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"DocImpact: All the above member APIs will accept the missing image"},{"line_number":19,"context_line":"attribute which needs to be updated in the documentation."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: 1555955"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afc51ec_ff671e23","line":18,"updated":"2016-03-11 20:48:32.000000000","message":"You don\u0027t need DocImpact here.  Backwards compatibility is not guaranteed before release 1.0.","commit_id":"84db3e70dad66d2d2245354290e2ecc9f363a6b5"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"c872711f42a6141d9f26cfc4168b15900c67fa2c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Updated these methods to accept the required parameter image and"},{"line_number":16,"context_line":"pass it to the respective base class methods in the required format."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"DocImpact: All the above member APIs will accept the missing image"},{"line_number":19,"context_line":"attribute which needs to be updated in the documentation."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: 1555955"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afc51ec_ae1c23c2","line":18,"in_reply_to":"3afc51ec_ff671e23","updated":"2016-03-14 07:25:00.000000000","message":"Removed. As suggested by Brian, I have already updated the doc strings according to the code modified.","commit_id":"84db3e70dad66d2d2245354290e2ecc9f363a6b5"}],"openstack/image/v2/_proxy.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"729be53174fbf11acd6ea40617300e2649051aeb","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        \"\"\""},{"line_number":104,"context_line":"        return self._update(_image.Image, image, **attrs)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def create_member(self, **attrs):"},{"line_number":107,"context_line":"        \"\"\"Create a new member from attributes"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        :param dict attrs: Keyword arguments which will be used to create"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_6a2c07ac","line":106,"updated":"2016-03-15 13:07:35.000000000","message":"Doesn\u0027t this need the image as well?","commit_id":"bc036f6f508ad738bf37916b3d724389fab46ff3"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"62d7c270293bbcca02ae7009ef24723f4b728d44","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        \"\"\""},{"line_number":104,"context_line":"        return self._update(_image.Image, image, **attrs)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def create_member(self, **attrs):"},{"line_number":107,"context_line":"        \"\"\"Create a new member from attributes"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        :param dict attrs: Keyword arguments which will be used to create"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_c624d8b0","line":106,"in_reply_to":"1af94dfe_40e57e35","updated":"2016-03-16 20:36:48.000000000","message":"Please look at network proxy create_pool_member().  That method takes the pool as input.  For consistency, it seems like this should as well.","commit_id":"bc036f6f508ad738bf37916b3d724389fab46ff3"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"547bc202e0825b5ec203083947bbc6b32ff1a9af","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        \"\"\""},{"line_number":104,"context_line":"        return self._update(_image.Image, image, **attrs)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def create_member(self, **attrs):"},{"line_number":107,"context_line":"        \"\"\"Create a new member from attributes"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        :param dict attrs: Keyword arguments which will be used to create"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_40e57e35","line":106,"in_reply_to":"1af94dfe_6a2c07ac","updated":"2016-03-16 08:26:57.000000000","message":"Yes this needs \"image_id\" as an argument but this argument is accepted in \"attrs\" as Keyword arguments and working properly as it is.\n\n\nThough it working properly as it is but it looks confusing to the user that what arguments He need to pass in \"attrs\" to create a member. We should fix that separately after identifying all such occurrences.","commit_id":"bc036f6f508ad738bf37916b3d724389fab46ff3"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"966ab72283ee06b4a790c1863a9866771ac02adc","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        \"\"\""},{"line_number":104,"context_line":"        return self._update(_image.Image, image, **attrs)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def create_member(self, **attrs):"},{"line_number":107,"context_line":"        \"\"\"Create a new member from attributes"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        :param dict attrs: Keyword arguments which will be used to create"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_4b38b53d","line":106,"in_reply_to":"1af94dfe_bd7389e6","updated":"2016-03-17 11:35:09.000000000","message":"I\u0027ll defer to Brian on how these interfaces should be structured.","commit_id":"bc036f6f508ad738bf37916b3d724389fab46ff3"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"31841a2a2494e04cd7d714b53b108d8a9a828b38","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        \"\"\""},{"line_number":104,"context_line":"        return self._update(_image.Image, image, **attrs)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def create_member(self, **attrs):"},{"line_number":107,"context_line":"        \"\"\"Create a new member from attributes"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        :param dict attrs: Keyword arguments which will be used to create"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_bd7389e6","line":106,"in_reply_to":"1af94dfe_c624d8b0","updated":"2016-03-17 07:07:19.000000000","message":"I have checked network proxy create_pool_member() that takes pool as input and we can also pass pool_id as key word argument.\n\n\nNow if we pass pool as positional argument and also pool_id with key word arguments then base proxy _create method it first creates resource using pool_id passed in the key word arguments and then overwrites it by pool_id passes as pool, which is a kind of additional operation on resource object.\n\n\nI can understand that there is some inconsistency between these two methods but not relevant to the issue we are trying to fix here.","commit_id":"bc036f6f508ad738bf37916b3d724389fab46ff3"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"729be53174fbf11acd6ea40617300e2649051aeb","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        :param member: The value can be either the ID of a member or a"},{"line_number":122,"context_line":"                       :class:`~openstack.image.v2.member.Member` instance."},{"line_number":123,"context_line":"        :param image: This parameter need to be specified when member ID is"},{"line_number":124,"context_line":"                      given as value. The value can be the ID of a image or a"},{"line_number":125,"context_line":"                      :class:`~openstack.image.v2.image.Image` instance."},{"line_number":126,"context_line":"        :param bool ignore_missing: When set to ``False``"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_755fc80e","line":123,"updated":"2016-03-15 13:07:35.000000000","message":"Note that this is the image that the member belongs to.  This is a general comment.","commit_id":"bc036f6f508ad738bf37916b3d724389fab46ff3"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"547bc202e0825b5ec203083947bbc6b32ff1a9af","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        :param member: The value can be either the ID of a member or a"},{"line_number":122,"context_line":"                       :class:`~openstack.image.v2.member.Member` instance."},{"line_number":123,"context_line":"        :param image: This parameter need to be specified when member ID is"},{"line_number":124,"context_line":"                      given as value. The value can be the ID of a image or a"},{"line_number":125,"context_line":"                      :class:`~openstack.image.v2.image.Image` instance."},{"line_number":126,"context_line":"        :param bool ignore_missing: When set to ``False``"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_e6cae2a0","line":123,"in_reply_to":"1af94dfe_755fc80e","updated":"2016-03-16 08:26:57.000000000","message":"Done","commit_id":"bc036f6f508ad738bf37916b3d724389fab46ff3"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"729be53174fbf11acd6ea40617300e2649051aeb","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                     path_args\u003d{\u0027image_id\u0027: image_id},"},{"line_number":140,"context_line":"                     ignore_missing\u003dignore_missing)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def find_member(self, name_or_id, image\u003dNone, ignore_missing\u003dTrue):"},{"line_number":143,"context_line":"        \"\"\"Find a single member"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        :param name_or_id: The name or ID of a member."}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_d5817c4f","line":142,"updated":"2016-03-15 13:07:35.000000000","message":"image is required here.","commit_id":"bc036f6f508ad738bf37916b3d724389fab46ff3"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"547bc202e0825b5ec203083947bbc6b32ff1a9af","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                     path_args\u003d{\u0027image_id\u0027: image_id},"},{"line_number":140,"context_line":"                     ignore_missing\u003dignore_missing)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def find_member(self, name_or_id, image\u003dNone, ignore_missing\u003dTrue):"},{"line_number":143,"context_line":"        \"\"\"Find a single member"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        :param name_or_id: The name or ID of a member."}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_c6cfe6ae","line":142,"in_reply_to":"1af94dfe_d5817c4f","updated":"2016-03-16 08:26:57.000000000","message":"Done","commit_id":"bc036f6f508ad738bf37916b3d724389fab46ff3"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"729be53174fbf11acd6ea40617300e2649051aeb","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                          path_args\u003d{\u0027image_id\u0027: image_id},"},{"line_number":193,"context_line":"                          **query)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def update_member(self, member, **attrs):"},{"line_number":196,"context_line":"        \"\"\"Update a member"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        :param member: Either the ID of a member or a"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_f5f758f3","line":195,"updated":"2016-03-15 13:07:35.000000000","message":"Isn\u0027t image required here?","commit_id":"bc036f6f508ad738bf37916b3d724389fab46ff3"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"31841a2a2494e04cd7d714b53b108d8a9a828b38","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                          path_args\u003d{\u0027image_id\u0027: image_id},"},{"line_number":193,"context_line":"                          **query)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def update_member(self, member, **attrs):"},{"line_number":196,"context_line":"        \"\"\"Update a member"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        :param member: Either the ID of a member or a"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_dd5f753f","line":195,"in_reply_to":"1af94dfe_0637e0e3","updated":"2016-03-17 07:07:19.000000000","message":"Same as create member case.","commit_id":"bc036f6f508ad738bf37916b3d724389fab46ff3"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"62d7c270293bbcca02ae7009ef24723f4b728d44","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                          path_args\u003d{\u0027image_id\u0027: image_id},"},{"line_number":193,"context_line":"                          **query)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def update_member(self, member, **attrs):"},{"line_number":196,"context_line":"        \"\"\"Update a member"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        :param member: Either the ID of a member or a"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_0637e0e3","line":195,"in_reply_to":"1af94dfe_e0412a0d","updated":"2016-03-16 20:36:48.000000000","message":"Please look at network proxy update_pool_member().  That method takes the pool as input.  For consistency, it seems like this should as well.","commit_id":"bc036f6f508ad738bf37916b3d724389fab46ff3"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"547bc202e0825b5ec203083947bbc6b32ff1a9af","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                          path_args\u003d{\u0027image_id\u0027: image_id},"},{"line_number":193,"context_line":"                          **query)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def update_member(self, member, **attrs):"},{"line_number":196,"context_line":"        \"\"\"Update a member"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        :param member: Either the ID of a member or a"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_e0412a0d","line":195,"in_reply_to":"1af94dfe_f5f758f3","updated":"2016-03-16 08:26:57.000000000","message":"Yes this needs \"image_id\" as an argument but this argument is accepted in \"attrs\" as Keyword arguments and working properly as it is.\n\n\nThough it working properly as it is but it looks confusing to the user that what arguments He need to pass in \"attrs\" to update a member, so it should be updated in order to remove confusion. We should fix that separately after identifying all such occurrences.","commit_id":"bc036f6f508ad738bf37916b3d724389fab46ff3"}]}