)]}'
{"doc/source/users/guides/network.rst":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"db016ecd55bd9e21cd25bc52a5ef637f7433de85","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":".. _network resource create: http://git.openstack.org/cgit/openstack/python-openstacksdk/tree/examples/network/create.py"},{"line_number":115,"context_line":".. _network resource delete: http://git.openstack.org/cgit/openstack/python-openstacksdk/tree/examples/network/delete.py"},{"line_number":116,"context_line":".. _network resource list: http://git.openstack.org/cgit/openstack/python-openstacksdk/tree/examples/network/list.py"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_ecb93630","line":116,"updated":"2016-05-18 11:41:42.000000000","message":"what changed here?","commit_id":"ff88f0f82774a9a6bf7c0080fea6c1eb17cff759"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"f50ae0d9598f1a71f6f2fe1d6026eb55058cb21a","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":".. _network resource create: http://git.openstack.org/cgit/openstack/python-openstacksdk/tree/examples/network/create.py"},{"line_number":115,"context_line":".. _network resource delete: http://git.openstack.org/cgit/openstack/python-openstacksdk/tree/examples/network/delete.py"},{"line_number":116,"context_line":".. _network resource list: http://git.openstack.org/cgit/openstack/python-openstacksdk/tree/examples/network/list.py"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bab6814e_ac928755","line":116,"in_reply_to":"bab6814e_ecb93630","updated":"2016-05-18 14:15:33.000000000","message":"Nothing, I\u0027m not sure why gerrit has highlighted this portion in green.","commit_id":"ff88f0f82774a9a6bf7c0080fea6c1eb17cff759"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"dc4c08f0557dbed1c3e0e5d0eecf8c653147817f","unresolved":false,"context_lines":[{"line_number":77,"context_line":"Full example: `network resource list`_"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"List Network Agents"},{"line_number":80,"context_line":"------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"A **network agent** is a plugin that handles various tasks used to"},{"line_number":83,"context_line":"implement virtual networks.  These agents include neutron-dhcp-agent,"}],"source_content_type":"text/x-rst","patch_set":14,"id":"bab6814e_6e5fd341","line":80,"updated":"2016-05-19 02:01:56.000000000","message":"nit: more \u0027-\u0027 are needed on line 80","commit_id":"83aef9c8a044da1faef4825f52aa5e0428ea5f7f"}],"openstack/network/v2/_proxy.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"45c723e0c084d047c7dcff3d5d386eb7d7b50d1d","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                 when no resource can be found."},{"line_number":162,"context_line":"        \"\"\""},{"line_number":163,"context_line":"        return self._get(_agent.Agent, agent)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def availability_zones(self):"},{"line_number":166,"context_line":"        \"\"\"Return a generator of availability zones"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_35efe6b1","line":164,"updated":"2016-05-13 02:03:01.000000000","message":"seems the \u0027update_agent\u0027 method is missing because the Agent resource type says \"allow_update\u003dTrue\u0027.","commit_id":"7bc7ad23fbf56f5429e24d7a769e7983f1fb6e50"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"8e1c0353e3c0db3e4f913c98c855e7e4ca87baf4","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                 when no resource can be found."},{"line_number":162,"context_line":"        \"\"\""},{"line_number":163,"context_line":"        return self._get(_agent.Agent, agent)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def availability_zones(self):"},{"line_number":166,"context_line":"        \"\"\"Return a generator of availability zones"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_d59543e4","line":164,"in_reply_to":"dab17558_35efe6b1","updated":"2016-05-16 16:59:46.000000000","message":"Done","commit_id":"7bc7ad23fbf56f5429e24d7a769e7983f1fb6e50"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"906fe904d85ed711f8646b1ef5f1cbc3d2313540","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                            address_scope,"},{"line_number":124,"context_line":"                            **attrs)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def agents(self, **query):"},{"line_number":127,"context_line":"        \"\"\"Return a generator of network agents"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param kwargs \\*\\*query: Optional query parameters to be sent to limit"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_f1b5527e","line":126,"range":{"start_line":126,"start_character":23,"end_line":126,"end_character":28},"updated":"2016-05-13 14:50:57.000000000","message":"FYI: If query parameters aren\u0027t accepted by the underlying REST API (I have no idea, but it\u0027s not common), you can leave these off. I\u0027m in the process of removing them elsewhere in a refactor so they\u0027ll just be removed anyway unless they\u0027re actually required and supported by the server.","commit_id":"149cb1343e2c9f882b0da73dcc48089877f0eca5"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"a5ebd552fbb9a6d18c46bc0de56aeb39d73c6119","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                            address_scope,"},{"line_number":124,"context_line":"                            **attrs)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def agents(self, **query):"},{"line_number":127,"context_line":"        \"\"\"Return a generator of network agents"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param kwargs \\*\\*query: Optional query parameters to be sent to limit"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_0c0aa8d2","line":126,"range":{"start_line":126,"start_character":23,"end_line":126,"end_character":28},"in_reply_to":"bab6814e_5340cf56","updated":"2016-05-18 15:42:04.000000000","message":"There are no docs for this part of the API.\n\nHere is what I found in the code base:\n\nhttps://github.com/openstack/neutron/blob/master/neutron/extensions/agent.py\n\nhttps://github.com/openstack/neutron/blob/master/neutron/db/agents_db.py","commit_id":"149cb1343e2c9f882b0da73dcc48089877f0eca5"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"d9389951f1d2ae4e140f4ab5c61289c164be638a","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                            address_scope,"},{"line_number":124,"context_line":"                            **attrs)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def agents(self, **query):"},{"line_number":127,"context_line":"        \"\"\"Return a generator of network agents"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param kwargs \\*\\*query: Optional query parameters to be sent to limit"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_5340cf56","line":126,"range":{"start_line":126,"start_character":23,"end_line":126,"end_character":28},"in_reply_to":"bab6814e_b3549b54","updated":"2016-05-18 15:07:23.000000000","message":"Can you link to docs that outline what query parameters are accepted? I\u0027ll need to add a mapping for them when the network library gets refactored for the resource2 switchover.","commit_id":"149cb1343e2c9f882b0da73dcc48089877f0eca5"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"4858a371e6990bf672374a119221067d0841c59c","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                            address_scope,"},{"line_number":124,"context_line":"                            **attrs)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def agents(self, **query):"},{"line_number":127,"context_line":"        \"\"\"Return a generator of network agents"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param kwargs \\*\\*query: Optional query parameters to be sent to limit"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_d968ccf7","line":126,"range":{"start_line":126,"start_character":23,"end_line":126,"end_character":28},"in_reply_to":"dab17558_35d92ff4","updated":"2016-05-17 01:52:37.000000000","message":"It looks like the test suite currently assumes a kwarg param is available:\n\nhttp://logs.openstack.org/32/315832/7/check/gate-python-openstacksdk-python27/0243b59/testr_results.html.gz","commit_id":"149cb1343e2c9f882b0da73dcc48089877f0eca5"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"2a9769dce125c5d829dcd2c2b2ad5cf1579139ad","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                            address_scope,"},{"line_number":124,"context_line":"                            **attrs)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def agents(self, **query):"},{"line_number":127,"context_line":"        \"\"\"Return a generator of network agents"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param kwargs \\*\\*query: Optional query parameters to be sent to limit"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_ce469620","line":126,"range":{"start_line":126,"start_character":23,"end_line":126,"end_character":28},"in_reply_to":"dab17558_ba70b1dd","updated":"2016-05-13 21:13:42.000000000","message":"Shocking that the docs are lacking...\nI would just leave the query arg out then for now. We\u0027d need to know the specific arguments it takes for the documentation anyway, and the refactor needs them to the query args are even sent at all because it\u0027s more strict about what it sends, so we can add them in if/when we determine them.","commit_id":"149cb1343e2c9f882b0da73dcc48089877f0eca5"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"32977bdaa25c2680d2a083223fbd4a1f74a562f9","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                            address_scope,"},{"line_number":124,"context_line":"                            **attrs)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def agents(self, **query):"},{"line_number":127,"context_line":"        \"\"\"Return a generator of network agents"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param kwargs \\*\\*query: Optional query parameters to be sent to limit"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_35d92ff4","line":126,"range":{"start_line":126,"start_character":23,"end_line":126,"end_character":28},"in_reply_to":"dab17558_ce469620","updated":"2016-05-16 16:59:03.000000000","message":"Done","commit_id":"149cb1343e2c9f882b0da73dcc48089877f0eca5"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"666dcabb22c14f72605268ef00774a7f234bcb6f","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                            address_scope,"},{"line_number":124,"context_line":"                            **attrs)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def agents(self, **query):"},{"line_number":127,"context_line":"        \"\"\"Return a generator of network agents"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param kwargs \\*\\*query: Optional query parameters to be sent to limit"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_ff4daf3e","line":126,"range":{"start_line":126,"start_character":23,"end_line":126,"end_character":28},"in_reply_to":"dab17558_d968ccf7","updated":"2016-05-17 03:25:42.000000000","message":"Looks like there is a method to handle this situation:\n\nverify_list_no_kwargs\n\nGoing to give that a try.","commit_id":"149cb1343e2c9f882b0da73dcc48089877f0eca5"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"a50218f640dfb1dc0b84336b3fe5e21f603948c2","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                            address_scope,"},{"line_number":124,"context_line":"                            **attrs)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def agents(self, **query):"},{"line_number":127,"context_line":"        \"\"\"Return a generator of network agents"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param kwargs \\*\\*query: Optional query parameters to be sent to limit"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_ba70b1dd","line":126,"range":{"start_line":126,"start_character":23,"end_line":126,"end_character":28},"in_reply_to":"dab17558_f1b5527e","updated":"2016-05-13 21:04:06.000000000","message":"I\u0027m not quite sure on this one.  python-neutronclient looks like it might take additional args, but the API is lacking documentation from neutron.","commit_id":"149cb1343e2c9f882b0da73dcc48089877f0eca5"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"2a305a8e098834161d78d8e97c768f5df5ae63ee","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                            address_scope,"},{"line_number":124,"context_line":"                            **attrs)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def agents(self, **query):"},{"line_number":127,"context_line":"        \"\"\"Return a generator of network agents"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param kwargs \\*\\*query: Optional query parameters to be sent to limit"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_b3549b54","line":126,"range":{"start_line":126,"start_character":23,"end_line":126,"end_character":28},"in_reply_to":"dab17558_ff4daf3e","updated":"2016-05-18 15:04:13.000000000","message":"I did some testing with the API.  It is indeed valid to limit the results with a query.  Example, binary\u003d\"neutron-dhcp-agent\"\n\nThis will produce this expected results, so I have added **query back into this method in the latest patch set.","commit_id":"149cb1343e2c9f882b0da73dcc48089877f0eca5"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"db016ecd55bd9e21cd25bc52a5ef637f7433de85","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                     :class:`~openstack.network.v2.agent.Agent` instance."},{"line_number":139,"context_line":"        :param bool ignore_missing: When set to ``False``"},{"line_number":140,"context_line":"                    :class:`~openstack.exceptions.ResourceNotFound` will be"},{"line_number":141,"context_line":"                    raised when the floating ip does not exist."},{"line_number":142,"context_line":"                    When set to ``True``, no exception will be set when"},{"line_number":143,"context_line":"                    attempting to delete a nonexistent ip."},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_8cc18a83","line":141,"range":{"start_line":141,"start_character":36,"end_line":141,"end_character":47},"updated":"2016-05-18 11:41:42.000000000","message":"agent","commit_id":"ff88f0f82774a9a6bf7c0080fea6c1eb17cff759"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"f50ae0d9598f1a71f6f2fe1d6026eb55058cb21a","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                     :class:`~openstack.network.v2.agent.Agent` instance."},{"line_number":139,"context_line":"        :param bool ignore_missing: When set to ``False``"},{"line_number":140,"context_line":"                    :class:`~openstack.exceptions.ResourceNotFound` will be"},{"line_number":141,"context_line":"                    raised when the floating ip does not exist."},{"line_number":142,"context_line":"                    When set to ``True``, no exception will be set when"},{"line_number":143,"context_line":"                    attempting to delete a nonexistent ip."},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_af3719e2","line":141,"range":{"start_line":141,"start_character":36,"end_line":141,"end_character":47},"in_reply_to":"bab6814e_8cc18a83","updated":"2016-05-18 14:15:33.000000000","message":"Done","commit_id":"ff88f0f82774a9a6bf7c0080fea6c1eb17cff759"}],"openstack/network/v2/agent.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"45c723e0c084d047c7dcff3d5d386eb7d7b50d1d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    availability_zone \u003d resource.prop(\u0027availability_zone\u0027)"},{"line_number":36,"context_line":"    alive \u003d resource.prop(\u0027alive\u0027)"},{"line_number":37,"context_line":"    admin_state_up \u003d resource.prop(\u0027admin_state_up\u0027)"},{"line_number":38,"context_line":"    binary \u003d resource.prop(\u0027binary\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_55db8a1b","line":38,"updated":"2016-05-13 02:03:01.000000000","message":"Please add some comments to the properties. For SDK, documentation is generated from source code, so comments are kinda mandatory.","commit_id":"7bc7ad23fbf56f5429e24d7a769e7983f1fb6e50"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"8e1c0353e3c0db3e4f913c98c855e7e4ca87baf4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    availability_zone \u003d resource.prop(\u0027availability_zone\u0027)"},{"line_number":36,"context_line":"    alive \u003d resource.prop(\u0027alive\u0027)"},{"line_number":37,"context_line":"    admin_state_up \u003d resource.prop(\u0027admin_state_up\u0027)"},{"line_number":38,"context_line":"    binary \u003d resource.prop(\u0027binary\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_95f9fb50","line":38,"in_reply_to":"dab17558_55db8a1b","updated":"2016-05-16 16:59:46.000000000","message":"Done","commit_id":"7bc7ad23fbf56f5429e24d7a769e7983f1fb6e50"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"7c99aab780d602bea1e6ad04cd3013ad9dbea1eb","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    agent_type \u003d resource.prop(\u0027agent_type\u0027)"},{"line_number":33,"context_line":"    host \u003d resource.prop(\u0027host\u0027)"},{"line_number":34,"context_line":"    availability_zone \u003d resource.prop(\u0027availability_zone\u0027)"},{"line_number":35,"context_line":"    alive \u003d resource.prop(\u0027alive\u0027)"},{"line_number":36,"context_line":"    admin_state_up \u003d resource.prop(\u0027admin_state_up\u0027)"},{"line_number":37,"context_line":"    binary \u003d resource.prop(\u0027binary\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_72f331a0","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":52},"updated":"2016-05-13 10:37:27.000000000","message":"Please use boolean types for these.  Also, the SDK uses is_* prefix for booleans.","commit_id":"149cb1343e2c9f882b0da73dcc48089877f0eca5"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"a50218f640dfb1dc0b84336b3fe5e21f603948c2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    agent_type \u003d resource.prop(\u0027agent_type\u0027)"},{"line_number":33,"context_line":"    host \u003d resource.prop(\u0027host\u0027)"},{"line_number":34,"context_line":"    availability_zone \u003d resource.prop(\u0027availability_zone\u0027)"},{"line_number":35,"context_line":"    alive \u003d resource.prop(\u0027alive\u0027)"},{"line_number":36,"context_line":"    admin_state_up \u003d resource.prop(\u0027admin_state_up\u0027)"},{"line_number":37,"context_line":"    binary \u003d resource.prop(\u0027binary\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_fa7239e2","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":52},"in_reply_to":"dab17558_72f331a0","updated":"2016-05-13 21:04:06.000000000","message":"Done","commit_id":"149cb1343e2c9f882b0da73dcc48089877f0eca5"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"db016ecd55bd9e21cd25bc52a5ef637f7433de85","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    allow_list \u003d True"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    # Properties"},{"line_number":31,"context_line":"    #: The ID of the project the network agent."},{"line_number":32,"context_line":"    id \u003d resource.prop(\u0027id\u0027)"},{"line_number":33,"context_line":"    #: The type of network agent."},{"line_number":34,"context_line":"    agent_type \u003d resource.prop(\u0027agent_type\u0027)"},{"line_number":35,"context_line":"    #: The host the agent is running on."}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_0c311aa3","line":32,"range":{"start_line":31,"start_character":2,"end_line":32,"end_character":28},"updated":"2016-05-18 11:41:42.000000000","message":"This isn\u0027t needed.","commit_id":"ff88f0f82774a9a6bf7c0080fea6c1eb17cff759"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"f50ae0d9598f1a71f6f2fe1d6026eb55058cb21a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    allow_list \u003d True"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    # Properties"},{"line_number":31,"context_line":"    #: The ID of the project the network agent."},{"line_number":32,"context_line":"    id \u003d resource.prop(\u0027id\u0027)"},{"line_number":33,"context_line":"    #: The type of network agent."},{"line_number":34,"context_line":"    agent_type \u003d resource.prop(\u0027agent_type\u0027)"},{"line_number":35,"context_line":"    #: The host the agent is running on."}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_6c9edf57","line":32,"range":{"start_line":31,"start_character":2,"end_line":32,"end_character":28},"in_reply_to":"bab6814e_0c311aa3","updated":"2016-05-18 14:15:33.000000000","message":"Done","commit_id":"ff88f0f82774a9a6bf7c0080fea6c1eb17cff759"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"db016ecd55bd9e21cd25bc52a5ef637f7433de85","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    #: The ID of the project the network agent."},{"line_number":32,"context_line":"    id \u003d resource.prop(\u0027id\u0027)"},{"line_number":33,"context_line":"    #: The type of network agent."},{"line_number":34,"context_line":"    agent_type \u003d resource.prop(\u0027agent_type\u0027)"},{"line_number":35,"context_line":"    #: The host the agent is running on."},{"line_number":36,"context_line":"    host \u003d resource.prop(\u0027host\u0027)"},{"line_number":37,"context_line":"    #: Availability zones for the network agent."}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_ecc81677","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":14},"updated":"2016-05-18 11:41:42.000000000","message":"Why usually place the properties in alphabetical order here for the docs.","commit_id":"ff88f0f82774a9a6bf7c0080fea6c1eb17cff759"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"f50ae0d9598f1a71f6f2fe1d6026eb55058cb21a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    #: The ID of the project the network agent."},{"line_number":32,"context_line":"    id \u003d resource.prop(\u0027id\u0027)"},{"line_number":33,"context_line":"    #: The type of network agent."},{"line_number":34,"context_line":"    agent_type \u003d resource.prop(\u0027agent_type\u0027)"},{"line_number":35,"context_line":"    #: The host the agent is running on."},{"line_number":36,"context_line":"    host \u003d resource.prop(\u0027host\u0027)"},{"line_number":37,"context_line":"    #: Availability zones for the network agent."}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_4c183b85","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":14},"in_reply_to":"bab6814e_ecc81677","updated":"2016-05-18 14:15:33.000000000","message":"Done","commit_id":"ff88f0f82774a9a6bf7c0080fea6c1eb17cff759"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"4488b142adb881601d4428e3e32965fc4f5c7a88","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    # Properties"},{"line_number":32,"context_line":"    #: The type of network agent."},{"line_number":33,"context_line":"    agent_type \u003d resource.prop(\u0027agent_type\u0027)"},{"line_number":34,"context_line":"    #: Availability zones for the network agent."},{"line_number":35,"context_line":"    availability_zone \u003d resource.prop(\u0027availability_zone\u0027)"},{"line_number":36,"context_line":"    #: The name of the network agent\u0027s application binary."},{"line_number":37,"context_line":"    binary \u003d resource.prop(\u0027binary\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_c76879bd","line":34,"range":{"start_line":34,"start_character":20,"end_line":34,"end_character":25},"updated":"2016-05-18 15:57:56.000000000","message":"\"zones\" - is this one singular zone, or is it potentially multiple zones? From the tests, it looks like it\u0027s expecting just one zone.\n\nAlso, whether it\u0027s single or multiple, it\u0027s going to be an ID or IDs, right? If so, it should be availability_zone_id or availability_zone_ids. If it\u0027s not ID/IDs, what is contained in the JSON response?","commit_id":"bff53d360a7187678d8de1b8989ef062193d38ac"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"581ab6ac6283bf0d2e1f3f29e29b468cb6cc4b4b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    # Properties"},{"line_number":32,"context_line":"    #: The type of network agent."},{"line_number":33,"context_line":"    agent_type \u003d resource.prop(\u0027agent_type\u0027)"},{"line_number":34,"context_line":"    #: Availability zones for the network agent."},{"line_number":35,"context_line":"    availability_zone \u003d resource.prop(\u0027availability_zone\u0027)"},{"line_number":36,"context_line":"    #: The name of the network agent\u0027s application binary."},{"line_number":37,"context_line":"    binary \u003d resource.prop(\u0027binary\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_82093f2f","line":34,"range":{"start_line":34,"start_character":20,"end_line":34,"end_character":25},"in_reply_to":"bab6814e_c76879bd","updated":"2016-05-18 16:14:30.000000000","message":"Done.\nShould be zone, not \"zones\"\nhttps://github.com/openstack/neutron/blob/master/neutron/db/agents_db.py#L101","commit_id":"bff53d360a7187678d8de1b8989ef062193d38ac"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"4488b142adb881601d4428e3e32965fc4f5c7a88","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    description \u003d resource.prop(\u0027description\u0027)"},{"line_number":45,"context_line":"    #: Timestamp when the network agent\u0027s heartbeat was last seen."},{"line_number":46,"context_line":"    #: *Type: datetime object parsed from ISO 8601 formatted string*"},{"line_number":47,"context_line":"    heartbeat_timestamp \u003d resource.prop(\u0027heartbeat_timestamp\u0027,"},{"line_number":48,"context_line":"                                        type\u003dformat.ISO8601)"},{"line_number":49,"context_line":"    #: The host the agent is running on."},{"line_number":50,"context_line":"    host \u003d resource.prop(\u0027host\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_47e9291a","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":23},"updated":"2016-05-18 15:57:56.000000000","message":"To fit in with our general \"foo_at\" format for timestamp property names, this is maybe better as last_heartbeat_at","commit_id":"bff53d360a7187678d8de1b8989ef062193d38ac"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"581ab6ac6283bf0d2e1f3f29e29b468cb6cc4b4b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    description \u003d resource.prop(\u0027description\u0027)"},{"line_number":45,"context_line":"    #: Timestamp when the network agent\u0027s heartbeat was last seen."},{"line_number":46,"context_line":"    #: *Type: datetime object parsed from ISO 8601 formatted string*"},{"line_number":47,"context_line":"    heartbeat_timestamp \u003d resource.prop(\u0027heartbeat_timestamp\u0027,"},{"line_number":48,"context_line":"                                        type\u003dformat.ISO8601)"},{"line_number":49,"context_line":"    #: The host the agent is running on."},{"line_number":50,"context_line":"    host \u003d resource.prop(\u0027host\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_222b3384","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":23},"in_reply_to":"bab6814e_47e9291a","updated":"2016-05-18 16:14:30.000000000","message":"Done","commit_id":"bff53d360a7187678d8de1b8989ef062193d38ac"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"845a29658d02d949f6c5853e2a1cdd01205b75ea","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    #: The name of the network agent\u0027s application binary."},{"line_number":37,"context_line":"    binary \u003d resource.prop(\u0027binary\u0027)"},{"line_number":38,"context_line":"    #: Network agent configuration data specific to the agent_type."},{"line_number":39,"context_line":"    configurations \u003d resource.prop(\u0027configurations\u0027)"},{"line_number":40,"context_line":"    #: Timestamp when the network agent was created."},{"line_number":41,"context_line":"    #: *Type: datetime object parsed from ISO 8601 formatted string*"},{"line_number":42,"context_line":"    created_at \u003d resource.prop(\u0027created_at\u0027, type\u003dformat.ISO8601)"}],"source_content_type":"text/x-python","patch_set":13,"id":"bab6814e_244cdc41","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":18},"updated":"2016-05-18 17:33:21.000000000","message":"This is the last thing I have: I think this should just be singular \"configuration\". It\u0027s a dictionary with keys of things that have been configured, and we generally save pluralized names for sequences such as properties that contains lists, or list APIs that return generators.","commit_id":"8fb890e96f6db6519ad8eac2107d86e12726e84d"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"d6eb63a416762152a3b29c951061e17b87f1e26e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    #: The name of the network agent\u0027s application binary."},{"line_number":37,"context_line":"    binary \u003d resource.prop(\u0027binary\u0027)"},{"line_number":38,"context_line":"    #: Network agent configuration data specific to the agent_type."},{"line_number":39,"context_line":"    configurations \u003d resource.prop(\u0027configurations\u0027)"},{"line_number":40,"context_line":"    #: Timestamp when the network agent was created."},{"line_number":41,"context_line":"    #: *Type: datetime object parsed from ISO 8601 formatted string*"},{"line_number":42,"context_line":"    created_at \u003d resource.prop(\u0027created_at\u0027, type\u003dformat.ISO8601)"}],"source_content_type":"text/x-python","patch_set":13,"id":"bab6814e_64c5443b","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":18},"in_reply_to":"bab6814e_244cdc41","updated":"2016-05-18 17:42:00.000000000","message":"Done","commit_id":"8fb890e96f6db6519ad8eac2107d86e12726e84d"}],"openstack/tests/functional/network/v2/test_agent.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"db016ecd55bd9e21cd25bc52a5ef637f7433de85","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_update(self):"},{"line_number":49,"context_line":"        sot \u003d self.conn.network.update_agent(self.AGENT.id,"},{"line_number":50,"context_line":"                                             description\u003dself.DESC)"},{"line_number":51,"context_line":"        self.assertEqual(self.DESC, sot.description)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_8cf50a85","line":50,"range":{"start_line":50,"start_character":45,"end_line":50,"end_character":56},"updated":"2016-05-18 11:41:42.000000000","message":"Please add description property to the Agent resource.","commit_id":"ff88f0f82774a9a6bf7c0080fea6c1eb17cff759"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"f50ae0d9598f1a71f6f2fe1d6026eb55058cb21a","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_update(self):"},{"line_number":49,"context_line":"        sot \u003d self.conn.network.update_agent(self.AGENT.id,"},{"line_number":50,"context_line":"                                             description\u003dself.DESC)"},{"line_number":51,"context_line":"        self.assertEqual(self.DESC, sot.description)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_6f409157","line":50,"range":{"start_line":50,"start_character":45,"end_line":50,"end_character":56},"in_reply_to":"bab6814e_8cf50a85","updated":"2016-05-18 14:15:33.000000000","message":"Will do.  There are quite a few other properties that are available as well that are not documented in the Agent resource, I\u0027ll go ahead and add those too.","commit_id":"ff88f0f82774a9a6bf7c0080fea6c1eb17cff759"}]}