)]}'
{"openstack/cluster/v1/_proxy.py":[{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"0ae051d628eb1b02951bc7f743c0b02ad8e509e3","unresolved":false,"context_lines":[{"line_number":624,"context_line":"        :returns: A generator of cluster-policy binding instances."},{"line_number":625,"context_line":"        \"\"\""},{"line_number":626,"context_line":"        cluster_id \u003d resource2.Resource._get_id(cluster)"},{"line_number":627,"context_line":"        query.update({\u0027cluster_id\u0027: cluster_id})"},{"line_number":628,"context_line":"        return self._list(_cluster_policy.ClusterPolicy, paginated\u003dFalse,"},{"line_number":629,"context_line":"                          **query)"},{"line_number":630,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_7dd036ca","line":627,"range":{"start_line":627,"start_character":8,"end_line":627,"end_character":13},"updated":"2016-07-22 21:22:59.000000000","message":"While this will work as ultimately it\u0027s just a bunch of kwargs anyway, I think for readability it helps to explicitly put `cluster_id\u003dcluster_id` into the _list call\u0027s arguments (like you do in the get call below) and leave **query to just be the query params coming in.","commit_id":"392838bb3c24d63da32f4b31d7410f5486baaf65"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"8628eb015337b8b751bd4ab433772f628418dafd","unresolved":false,"context_lines":[{"line_number":478,"context_line":"            node matching the name or ID could be found."},{"line_number":479,"context_line":"        \"\"\""},{"line_number":480,"context_line":"        if details:"},{"line_number":481,"context_line":"            return self._get(_node.NodeDetail, requires_id\u003dFalse, node_id\u003dnode)"},{"line_number":482,"context_line":"        return self._get(_node.Node, node)"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"    def nodes(self, **query):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_a224f40c","line":481,"range":{"start_line":481,"start_character":24,"end_line":481,"end_character":28},"updated":"2016-07-26 03:46:33.000000000","message":"I get what you\u0027re doing here with requires_id, but it took a few extra looks to understand it since it looks different than most other cases. Would you mind adding a comment to specify that this is the case because of how base_path is specified on the NodeDetail resource and that the \"id\" is really a URI param in this case?","commit_id":"4121433b4bb74f2c77835edb35fd105b68622eb9"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"c7cce747c808b96af7b57f7f82953c3678aae25e","unresolved":false,"context_lines":[{"line_number":478,"context_line":"            node matching the name or ID could be found."},{"line_number":479,"context_line":"        \"\"\""},{"line_number":480,"context_line":"        if details:"},{"line_number":481,"context_line":"            return self._get(_node.NodeDetail, requires_id\u003dFalse, node_id\u003dnode)"},{"line_number":482,"context_line":"        return self._get(_node.Node, node)"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"    def nodes(self, **query):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_6db66dfa","line":481,"range":{"start_line":481,"start_character":24,"end_line":481,"end_character":28},"in_reply_to":"dada55a8_a224f40c","updated":"2016-07-26 04:15:49.000000000","message":"Done","commit_id":"4121433b4bb74f2c77835edb35fd105b68622eb9"}]}