)]}'
{"openstack/cluster/v1/_proxy.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2477e3830b0c67b5c9e6fabca51e8d934e930c3d","unresolved":false,"context_lines":[{"line_number":382,"context_line":"            obj \u003d self._find(_cluster.Cluster, cluster, ignore_missing\u003dFalse)"},{"line_number":383,"context_line":"        return obj.policy_update(self.session, policy, **params)"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    def cluster_collect(self, cluster, path):"},{"line_number":386,"context_line":"        \"\"\"Collect attribute values across a cluster."},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        :param cluster: The value can be either the ID of a cluster or a"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_700a8f27","line":385,"range":{"start_line":385,"start_character":8,"end_line":385,"end_character":23},"updated":"2016-08-05 12:01:12.000000000","message":"Should this be \"get_cluster_attr\" or \"get_cluster_attribute\" instead?","commit_id":"49f9b04ce39fbfcb15e49fbd7951b2a877d05280"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"5e9f21ffa514e1e154478841641527a3904ce602","unresolved":false,"context_lines":[{"line_number":382,"context_line":"            obj \u003d self._find(_cluster.Cluster, cluster, ignore_missing\u003dFalse)"},{"line_number":383,"context_line":"        return obj.policy_update(self.session, policy, **params)"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    def cluster_collect(self, cluster, path):"},{"line_number":386,"context_line":"        \"\"\"Collect attribute values across a cluster."},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        :param cluster: The value can be either the ID of a cluster or a"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_bc5220dc","line":385,"range":{"start_line":385,"start_character":8,"end_line":385,"end_character":23},"in_reply_to":"bacf61ea_700a8f27","updated":"2016-08-05 12:56:03.000000000","message":"From API\u0027s perspective, this method is doing a GET on the {cluster}/attrs URL, however, the server side is doing an aggregation across all nodes in a cluster, for the node attribute expressed in \u0027path\u0027. So, I\u0027d prefer the method named \u0027cluster_collect\u0027 to match its semantics.","commit_id":"49f9b04ce39fbfcb15e49fbd7951b2a877d05280"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2dece312425666945bce1cd65f375daa17f1d15d","unresolved":false,"context_lines":[{"line_number":382,"context_line":"            obj \u003d self._find(_cluster.Cluster, cluster, ignore_missing\u003dFalse)"},{"line_number":383,"context_line":"        return obj.policy_update(self.session, policy, **params)"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    def cluster_collect(self, cluster, path):"},{"line_number":386,"context_line":"        \"\"\"Collect attribute values across a cluster."},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        :param cluster: The value can be either the ID of a cluster or a"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_c2fc2ab7","line":385,"range":{"start_line":385,"start_character":8,"end_line":385,"end_character":23},"in_reply_to":"bacf61ea_bc5220dc","updated":"2016-08-06 10:59:37.000000000","message":"That sounds fine.  How about updating the method name to reflect what is being collected?  Should it be \"collect_cluster_attribute\" or something similar?","commit_id":"49f9b04ce39fbfcb15e49fbd7951b2a877d05280"}]}