)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2a5f4ddf034a861cfb7c5723fee5f4cee9eab428","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add QoS policy object and CRUD commands."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 1609037"},{"line_number":10,"context_line":"Change-Id: I33bafeca979410d329ae10a82772ccdb48c10daa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"3ac371cc_c2d98a85","line":10,"updated":"2016-08-19 08:54:37.000000000","message":"Please add the dependency as well in order to verify the functional tests.","commit_id":"c8412525a44b4873035080b54495f632b5b7b933"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4e165014b3bd61bbc56011eab7edcfeaf5aee41e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add QoS policy object and CRUD commands."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 1609037"},{"line_number":10,"context_line":"Change-Id: I33bafeca979410d329ae10a82772ccdb48c10daa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"3ac371cc_8578392d","line":10,"in_reply_to":"3ac371cc_c2d98a85","updated":"2016-08-19 09:59:51.000000000","message":"Done","commit_id":"c8412525a44b4873035080b54495f632b5b7b933"}],"doc/source/users/resources/network/v2/qos_policy.rst":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2a5f4ddf034a861cfb7c5723fee5f4cee9eab428","unresolved":false,"context_lines":[{"line_number":1,"context_line":"openstack.network.v2.qos_policy"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":".. automodule:: openstack.network.v2.qos_policy"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3ac371cc_42863a66","line":1,"updated":"2016-08-19 08:54:37.000000000","message":"You need to update the doc/source/users/resources/network/index.rst file as well.","commit_id":"c8412525a44b4873035080b54495f632b5b7b933"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4e165014b3bd61bbc56011eab7edcfeaf5aee41e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"openstack.network.v2.qos_policy"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":".. automodule:: openstack.network.v2.qos_policy"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3ac371cc_c5a9917d","line":1,"in_reply_to":"3ac371cc_42863a66","updated":"2016-08-19 09:59:51.000000000","message":"Done\n\nI\u0027ll make this change too in the related commits.","commit_id":"c8412525a44b4873035080b54495f632b5b7b933"}],"openstack/network/v2/_proxy.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"81bacac34172783b951ab21915e68a96d5880bd2","unresolved":false,"context_lines":[{"line_number":1896,"context_line":"        \"\"\"Create a new QoS policy from attributes"},{"line_number":1897,"context_line":""},{"line_number":1898,"context_line":"        :param dict attrs: Keyword arguments which will be used to create"},{"line_number":1899,"context_line":"                           a :class:`~openstack.network.v2.router.Router`,"},{"line_number":1900,"context_line":"                           comprised of the properties on the Router class."},{"line_number":1901,"context_line":""},{"line_number":1902,"context_line":"        :returns: The results of router creation"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_d0e1f79b","line":1899,"range":{"start_line":1899,"start_character":58,"end_line":1899,"end_character":72},"updated":"2016-08-10 09:27:28.000000000","message":"fix this","commit_id":"687bd3851d666a69ecba0255ec108643156521a5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"74f0be9761012d24e316441059fbfe96171659c8","unresolved":false,"context_lines":[{"line_number":1896,"context_line":"        \"\"\"Create a new QoS policy from attributes"},{"line_number":1897,"context_line":""},{"line_number":1898,"context_line":"        :param dict attrs: Keyword arguments which will be used to create"},{"line_number":1899,"context_line":"                           a :class:`~openstack.network.v2.router.Router`,"},{"line_number":1900,"context_line":"                           comprised of the properties on the Router class."},{"line_number":1901,"context_line":""},{"line_number":1902,"context_line":"        :returns: The results of router creation"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_b976e2d4","line":1899,"range":{"start_line":1899,"start_character":58,"end_line":1899,"end_character":72},"in_reply_to":"9ad45d7e_d0e1f79b","updated":"2016-08-10 13:19:05.000000000","message":"Done","commit_id":"687bd3851d666a69ecba0255ec108643156521a5"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"81bacac34172783b951ab21915e68a96d5880bd2","unresolved":false,"context_lines":[{"line_number":1897,"context_line":""},{"line_number":1898,"context_line":"        :param dict attrs: Keyword arguments which will be used to create"},{"line_number":1899,"context_line":"                           a :class:`~openstack.network.v2.router.Router`,"},{"line_number":1900,"context_line":"                           comprised of the properties on the Router class."},{"line_number":1901,"context_line":""},{"line_number":1902,"context_line":"        :returns: The results of router creation"},{"line_number":1903,"context_line":"        :rtype: :class:`~openstack.network.v2.router.Router`"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_50ece78e","line":1900,"range":{"start_line":1900,"start_character":62,"end_line":1900,"end_character":68},"updated":"2016-08-10 09:27:28.000000000","message":"this","commit_id":"687bd3851d666a69ecba0255ec108643156521a5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"74f0be9761012d24e316441059fbfe96171659c8","unresolved":false,"context_lines":[{"line_number":1897,"context_line":""},{"line_number":1898,"context_line":"        :param dict attrs: Keyword arguments which will be used to create"},{"line_number":1899,"context_line":"                           a :class:`~openstack.network.v2.router.Router`,"},{"line_number":1900,"context_line":"                           comprised of the properties on the Router class."},{"line_number":1901,"context_line":""},{"line_number":1902,"context_line":"        :returns: The results of router creation"},{"line_number":1903,"context_line":"        :rtype: :class:`~openstack.network.v2.router.Router`"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_b95d4249","line":1900,"range":{"start_line":1900,"start_character":62,"end_line":1900,"end_character":68},"in_reply_to":"9ad45d7e_50ece78e","updated":"2016-08-10 13:19:05.000000000","message":"Done","commit_id":"687bd3851d666a69ecba0255ec108643156521a5"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"81bacac34172783b951ab21915e68a96d5880bd2","unresolved":false,"context_lines":[{"line_number":1899,"context_line":"                           a :class:`~openstack.network.v2.router.Router`,"},{"line_number":1900,"context_line":"                           comprised of the properties on the Router class."},{"line_number":1901,"context_line":""},{"line_number":1902,"context_line":"        :returns: The results of router creation"},{"line_number":1903,"context_line":"        :rtype: :class:`~openstack.network.v2.router.Router`"},{"line_number":1904,"context_line":"        \"\"\""},{"line_number":1905,"context_line":"        return self._create(_qos_policy.QosPolicy, **attrs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_90d77fbe","line":1902,"range":{"start_line":1902,"start_character":33,"end_line":1902,"end_character":39},"updated":"2016-08-10 09:27:28.000000000","message":"QoS policy","commit_id":"687bd3851d666a69ecba0255ec108643156521a5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"74f0be9761012d24e316441059fbfe96171659c8","unresolved":false,"context_lines":[{"line_number":1899,"context_line":"                           a :class:`~openstack.network.v2.router.Router`,"},{"line_number":1900,"context_line":"                           comprised of the properties on the Router class."},{"line_number":1901,"context_line":""},{"line_number":1902,"context_line":"        :returns: The results of router creation"},{"line_number":1903,"context_line":"        :rtype: :class:`~openstack.network.v2.router.Router`"},{"line_number":1904,"context_line":"        \"\"\""},{"line_number":1905,"context_line":"        return self._create(_qos_policy.QosPolicy, **attrs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_945ac528","line":1902,"range":{"start_line":1902,"start_character":33,"end_line":1902,"end_character":39},"in_reply_to":"9ad45d7e_90d77fbe","updated":"2016-08-10 13:19:05.000000000","message":"Done","commit_id":"687bd3851d666a69ecba0255ec108643156521a5"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"81bacac34172783b951ab21915e68a96d5880bd2","unresolved":false,"context_lines":[{"line_number":1900,"context_line":"                           comprised of the properties on the Router class."},{"line_number":1901,"context_line":""},{"line_number":1902,"context_line":"        :returns: The results of router creation"},{"line_number":1903,"context_line":"        :rtype: :class:`~openstack.network.v2.router.Router`"},{"line_number":1904,"context_line":"        \"\"\""},{"line_number":1905,"context_line":"        return self._create(_qos_policy.QosPolicy, **attrs)"},{"line_number":1906,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_90fe5f36","line":1903,"range":{"start_line":1903,"start_character":45,"end_line":1903,"end_character":59},"updated":"2016-08-10 09:27:28.000000000","message":"this","commit_id":"687bd3851d666a69ecba0255ec108643156521a5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"74f0be9761012d24e316441059fbfe96171659c8","unresolved":false,"context_lines":[{"line_number":1900,"context_line":"                           comprised of the properties on the Router class."},{"line_number":1901,"context_line":""},{"line_number":1902,"context_line":"        :returns: The results of router creation"},{"line_number":1903,"context_line":"        :rtype: :class:`~openstack.network.v2.router.Router`"},{"line_number":1904,"context_line":"        \"\"\""},{"line_number":1905,"context_line":"        return self._create(_qos_policy.QosPolicy, **attrs)"},{"line_number":1906,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_f44d013f","line":1903,"range":{"start_line":1903,"start_character":45,"end_line":1903,"end_character":59},"in_reply_to":"9ad45d7e_90fe5f36","updated":"2016-08-10 13:19:05.000000000","message":"Done","commit_id":"687bd3851d666a69ecba0255ec108643156521a5"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"81bacac34172783b951ab21915e68a96d5880bd2","unresolved":false,"context_lines":[{"line_number":1907,"context_line":"    def delete_qos_policy(self, qos_policy, ignore_missing\u003dTrue):"},{"line_number":1908,"context_line":"        \"\"\"Delete a QoS policy"},{"line_number":1909,"context_line":""},{"line_number":1910,"context_line":"        :param qos_policy: The value can be either the ID of a router or a"},{"line_number":1911,"context_line":"                           :class:`~openstack.network.v2.qos.QosPolicy`"},{"line_number":1912,"context_line":"                           instance."},{"line_number":1913,"context_line":"        :param bool ignore_missing: When set to ``False``"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_1099cf1f","line":1910,"range":{"start_line":1910,"start_character":63,"end_line":1910,"end_character":69},"updated":"2016-08-10 09:27:28.000000000","message":"this","commit_id":"687bd3851d666a69ecba0255ec108643156521a5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"74f0be9761012d24e316441059fbfe96171659c8","unresolved":false,"context_lines":[{"line_number":1907,"context_line":"    def delete_qos_policy(self, qos_policy, ignore_missing\u003dTrue):"},{"line_number":1908,"context_line":"        \"\"\"Delete a QoS policy"},{"line_number":1909,"context_line":""},{"line_number":1910,"context_line":"        :param qos_policy: The value can be either the ID of a router or a"},{"line_number":1911,"context_line":"                           :class:`~openstack.network.v2.qos.QosPolicy`"},{"line_number":1912,"context_line":"                           instance."},{"line_number":1913,"context_line":"        :param bool ignore_missing: When set to ``False``"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_145ed511","line":1910,"range":{"start_line":1910,"start_character":63,"end_line":1910,"end_character":69},"in_reply_to":"9ad45d7e_1099cf1f","updated":"2016-08-10 13:19:05.000000000","message":"Done","commit_id":"687bd3851d666a69ecba0255ec108643156521a5"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"81bacac34172783b951ab21915e68a96d5880bd2","unresolved":false,"context_lines":[{"line_number":1908,"context_line":"        \"\"\"Delete a QoS policy"},{"line_number":1909,"context_line":""},{"line_number":1910,"context_line":"        :param qos_policy: The value can be either the ID of a router or a"},{"line_number":1911,"context_line":"                           :class:`~openstack.network.v2.qos.QosPolicy`"},{"line_number":1912,"context_line":"                           instance."},{"line_number":1913,"context_line":"        :param bool ignore_missing: When set to ``False``"},{"line_number":1914,"context_line":"                    :class:`~openstack.exceptions.ResourceNotFound` will be"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_90213fb7","line":1911,"range":{"start_line":1911,"start_character":57,"end_line":1911,"end_character":60},"updated":"2016-08-10 09:27:28.000000000","message":"qos_policy","commit_id":"687bd3851d666a69ecba0255ec108643156521a5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"74f0be9761012d24e316441059fbfe96171659c8","unresolved":false,"context_lines":[{"line_number":1908,"context_line":"        \"\"\"Delete a QoS policy"},{"line_number":1909,"context_line":""},{"line_number":1910,"context_line":"        :param qos_policy: The value can be either the ID of a router or a"},{"line_number":1911,"context_line":"                           :class:`~openstack.network.v2.qos.QosPolicy`"},{"line_number":1912,"context_line":"                           instance."},{"line_number":1913,"context_line":"        :param bool ignore_missing: When set to ``False``"},{"line_number":1914,"context_line":"                    :class:`~openstack.exceptions.ResourceNotFound` will be"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_94a805dd","line":1911,"range":{"start_line":1911,"start_character":57,"end_line":1911,"end_character":60},"in_reply_to":"9ad45d7e_90213fb7","updated":"2016-08-10 13:19:05.000000000","message":"Done","commit_id":"687bd3851d666a69ecba0255ec108643156521a5"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"81bacac34172783b951ab21915e68a96d5880bd2","unresolved":false,"context_lines":[{"line_number":1912,"context_line":"                           instance."},{"line_number":1913,"context_line":"        :param bool ignore_missing: When set to ``False``"},{"line_number":1914,"context_line":"                    :class:`~openstack.exceptions.ResourceNotFound` will be"},{"line_number":1915,"context_line":"                    raised when the router does not exist."},{"line_number":1916,"context_line":"                    When set to ``True``, no exception will be set when"},{"line_number":1917,"context_line":"                    attempting to delete a nonexistent QoS policy."},{"line_number":1918,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_b08a83bd","line":1915,"range":{"start_line":1915,"start_character":36,"end_line":1915,"end_character":42},"updated":"2016-08-10 09:27:28.000000000","message":"this","commit_id":"687bd3851d666a69ecba0255ec108643156521a5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"74f0be9761012d24e316441059fbfe96171659c8","unresolved":false,"context_lines":[{"line_number":1912,"context_line":"                           instance."},{"line_number":1913,"context_line":"        :param bool ignore_missing: When set to ``False``"},{"line_number":1914,"context_line":"                    :class:`~openstack.exceptions.ResourceNotFound` will be"},{"line_number":1915,"context_line":"                    raised when the router does not exist."},{"line_number":1916,"context_line":"                    When set to ``True``, no exception will be set when"},{"line_number":1917,"context_line":"                    attempting to delete a nonexistent QoS policy."},{"line_number":1918,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_14b53530","line":1915,"range":{"start_line":1915,"start_character":36,"end_line":1915,"end_character":42},"in_reply_to":"9ad45d7e_b08a83bd","updated":"2016-08-10 13:19:05.000000000","message":"Done","commit_id":"687bd3851d666a69ecba0255ec108643156521a5"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"81bacac34172783b951ab21915e68a96d5880bd2","unresolved":false,"context_lines":[{"line_number":1930,"context_line":"                    raised when the resource does not exist."},{"line_number":1931,"context_line":"                    When set to ``True``, None will be returned when"},{"line_number":1932,"context_line":"                    attempting to find a nonexistent resource."},{"line_number":1933,"context_line":"        :returns: One :class:`~openstack.network.v2.qos.QosPolicy` or None"},{"line_number":1934,"context_line":"        \"\"\""},{"line_number":1935,"context_line":"        return self._find(_qos_policy.QosPolicy, name_or_id,"},{"line_number":1936,"context_line":"                          ignore_missing\u003dignore_missing)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_30197389","line":1933,"range":{"start_line":1933,"start_character":52,"end_line":1933,"end_character":55},"updated":"2016-08-10 09:27:28.000000000","message":"qos_policy","commit_id":"687bd3851d666a69ecba0255ec108643156521a5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"74f0be9761012d24e316441059fbfe96171659c8","unresolved":false,"context_lines":[{"line_number":1930,"context_line":"                    raised when the resource does not exist."},{"line_number":1931,"context_line":"                    When set to ``True``, None will be returned when"},{"line_number":1932,"context_line":"                    attempting to find a nonexistent resource."},{"line_number":1933,"context_line":"        :returns: One :class:`~openstack.network.v2.qos.QosPolicy` or None"},{"line_number":1934,"context_line":"        \"\"\""},{"line_number":1935,"context_line":"        return self._find(_qos_policy.QosPolicy, name_or_id,"},{"line_number":1936,"context_line":"                          ignore_missing\u003dignore_missing)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_7484715d","line":1933,"range":{"start_line":1933,"start_character":52,"end_line":1933,"end_character":55},"in_reply_to":"9ad45d7e_30197389","updated":"2016-08-10 13:19:05.000000000","message":"Done","commit_id":"687bd3851d666a69ecba0255ec108643156521a5"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"81bacac34172783b951ab21915e68a96d5880bd2","unresolved":false,"context_lines":[{"line_number":1938,"context_line":"    def get_qos_policy(self, qos_policy):"},{"line_number":1939,"context_line":"        \"\"\"Get a single QoS policy"},{"line_number":1940,"context_line":""},{"line_number":1941,"context_line":"        :param qos_policy: The value can be the ID of a router or a"},{"line_number":1942,"context_line":"                           :class:`~openstack.network.v2.qos.QosPolicy`"},{"line_number":1943,"context_line":"                           instance."},{"line_number":1944,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_d07d77b2","line":1941,"range":{"start_line":1941,"start_character":56,"end_line":1941,"end_character":62},"updated":"2016-08-10 09:27:28.000000000","message":"this","commit_id":"687bd3851d666a69ecba0255ec108643156521a5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"74f0be9761012d24e316441059fbfe96171659c8","unresolved":false,"context_lines":[{"line_number":1938,"context_line":"    def get_qos_policy(self, qos_policy):"},{"line_number":1939,"context_line":"        \"\"\"Get a single QoS policy"},{"line_number":1940,"context_line":""},{"line_number":1941,"context_line":"        :param qos_policy: The value can be the ID of a router or a"},{"line_number":1942,"context_line":"                           :class:`~openstack.network.v2.qos.QosPolicy`"},{"line_number":1943,"context_line":"                           instance."},{"line_number":1944,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_74ebd113","line":1941,"range":{"start_line":1941,"start_character":56,"end_line":1941,"end_character":62},"in_reply_to":"9ad45d7e_d07d77b2","updated":"2016-08-10 13:19:05.000000000","message":"Done","commit_id":"687bd3851d666a69ecba0255ec108643156521a5"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"81bacac34172783b951ab21915e68a96d5880bd2","unresolved":false,"context_lines":[{"line_number":1939,"context_line":"        \"\"\"Get a single QoS policy"},{"line_number":1940,"context_line":""},{"line_number":1941,"context_line":"        :param qos_policy: The value can be the ID of a router or a"},{"line_number":1942,"context_line":"                           :class:`~openstack.network.v2.qos.QosPolicy`"},{"line_number":1943,"context_line":"                           instance."},{"line_number":1944,"context_line":""},{"line_number":1945,"context_line":"        :returns: One :class:`~openstack.network.v2.qos.QosPolicy`"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_5016a755","line":1942,"range":{"start_line":1942,"start_character":57,"end_line":1942,"end_character":60},"updated":"2016-08-10 09:27:28.000000000","message":"qos_policy","commit_id":"687bd3851d666a69ecba0255ec108643156521a5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"74f0be9761012d24e316441059fbfe96171659c8","unresolved":false,"context_lines":[{"line_number":1939,"context_line":"        \"\"\"Get a single QoS policy"},{"line_number":1940,"context_line":""},{"line_number":1941,"context_line":"        :param qos_policy: The value can be the ID of a router or a"},{"line_number":1942,"context_line":"                           :class:`~openstack.network.v2.qos.QosPolicy`"},{"line_number":1943,"context_line":"                           instance."},{"line_number":1944,"context_line":""},{"line_number":1945,"context_line":"        :returns: One :class:`~openstack.network.v2.qos.QosPolicy`"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_b4f1c903","line":1942,"range":{"start_line":1942,"start_character":57,"end_line":1942,"end_character":60},"in_reply_to":"9ad45d7e_5016a755","updated":"2016-08-10 13:19:05.000000000","message":"Done","commit_id":"687bd3851d666a69ecba0255ec108643156521a5"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"81bacac34172783b951ab21915e68a96d5880bd2","unresolved":false,"context_lines":[{"line_number":1942,"context_line":"                           :class:`~openstack.network.v2.qos.QosPolicy`"},{"line_number":1943,"context_line":"                           instance."},{"line_number":1944,"context_line":""},{"line_number":1945,"context_line":"        :returns: One :class:`~openstack.network.v2.qos.QosPolicy`"},{"line_number":1946,"context_line":"        :raises: :class:`~openstack.exceptions.ResourceNotFound`"},{"line_number":1947,"context_line":"                 when no resource can be found."},{"line_number":1948,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_b00d6340","line":1945,"range":{"start_line":1945,"start_character":52,"end_line":1945,"end_character":55},"updated":"2016-08-10 09:27:28.000000000","message":"qos_policy","commit_id":"687bd3851d666a69ecba0255ec108643156521a5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"74f0be9761012d24e316441059fbfe96171659c8","unresolved":false,"context_lines":[{"line_number":1942,"context_line":"                           :class:`~openstack.network.v2.qos.QosPolicy`"},{"line_number":1943,"context_line":"                           instance."},{"line_number":1944,"context_line":""},{"line_number":1945,"context_line":"        :returns: One :class:`~openstack.network.v2.qos.QosPolicy`"},{"line_number":1946,"context_line":"        :raises: :class:`~openstack.exceptions.ResourceNotFound`"},{"line_number":1947,"context_line":"                 when no resource can be found."},{"line_number":1948,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_54d7ad4a","line":1945,"range":{"start_line":1945,"start_character":52,"end_line":1945,"end_character":55},"in_reply_to":"9ad45d7e_b00d6340","updated":"2016-08-10 13:19:05.000000000","message":"Done","commit_id":"687bd3851d666a69ecba0255ec108643156521a5"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"81bacac34172783b951ab21915e68a96d5880bd2","unresolved":false,"context_lines":[{"line_number":1963,"context_line":"        \"\"\"Update a QoS policy"},{"line_number":1964,"context_line":""},{"line_number":1965,"context_line":"        :param qos_policy: Either the id of a QoS policy or a"},{"line_number":1966,"context_line":"                           :class:`~openstack.network.v2.qos.QosPolicy`"},{"line_number":1967,"context_line":"                           instance."},{"line_number":1968,"context_line":"        :attrs kwargs: The attributes to update on the QoS policy represented"},{"line_number":1969,"context_line":"                       by ``value``."}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_f007db19","line":1966,"range":{"start_line":1966,"start_character":57,"end_line":1966,"end_character":60},"updated":"2016-08-10 09:27:28.000000000","message":"qos_policy","commit_id":"687bd3851d666a69ecba0255ec108643156521a5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"74f0be9761012d24e316441059fbfe96171659c8","unresolved":false,"context_lines":[{"line_number":1963,"context_line":"        \"\"\"Update a QoS policy"},{"line_number":1964,"context_line":""},{"line_number":1965,"context_line":"        :param qos_policy: Either the id of a QoS policy or a"},{"line_number":1966,"context_line":"                           :class:`~openstack.network.v2.qos.QosPolicy`"},{"line_number":1967,"context_line":"                           instance."},{"line_number":1968,"context_line":"        :attrs kwargs: The attributes to update on the QoS policy represented"},{"line_number":1969,"context_line":"                       by ``value``."}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_b4c8a9a9","line":1966,"range":{"start_line":1966,"start_character":57,"end_line":1966,"end_character":60},"in_reply_to":"9ad45d7e_f007db19","updated":"2016-08-10 13:19:05.000000000","message":"Done","commit_id":"687bd3851d666a69ecba0255ec108643156521a5"}],"openstack/network/v2/qos.py":[{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"c0cb4a2c781569489155c1c03c2742f94d0f80cd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016, Intel Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_5bb55eec","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2016-08-09 12:39:52.000000000","message":"This file should ideally be named qos_policy to match the class name.","commit_id":"b934427bbecd2b74a55eb9dbaf605f9e344b7830"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"51b1a3fba19afd548fa66482f73bae87056ca54b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016, Intel Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_5c3fe6d5","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"9ad45d7e_5bb55eec","updated":"2016-08-10 08:20:01.000000000","message":"Yes, I agree","commit_id":"b934427bbecd2b74a55eb9dbaf605f9e344b7830"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"c0cb4a2c781569489155c1c03c2742f94d0f80cd","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from openstack import resource"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class QosPolicy(resource.Resource):"},{"line_number":21,"context_line":"    resource_key \u003d \u0027policy\u0027"},{"line_number":22,"context_line":"    resources_key \u003d \u0027policies\u0027"},{"line_number":23,"context_line":"    base_path \u003d \u0027/qos/policies\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_9b96b64a","line":20,"range":{"start_line":20,"start_character":6,"end_line":20,"end_character":15},"updated":"2016-08-09 12:39:52.000000000","message":"QoSPolicy would be the name to use here. The same usage of QoS would apply to your other reviews as well.","commit_id":"b934427bbecd2b74a55eb9dbaf605f9e344b7830"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"39a2ac5eeb5b8efc45e617ff29c8d0662bd2d71f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from openstack import resource"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class QosPolicy(resource.Resource):"},{"line_number":21,"context_line":"    resource_key \u003d \u0027policy\u0027"},{"line_number":22,"context_line":"    resources_key \u003d \u0027policies\u0027"},{"line_number":23,"context_line":"    base_path \u003d \u0027/qos/policies\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_df49cd61","line":20,"range":{"start_line":20,"start_character":6,"end_line":20,"end_character":15},"in_reply_to":"9ad45d7e_052b4195","updated":"2016-08-11 07:18:06.000000000","message":"Done","commit_id":"b934427bbecd2b74a55eb9dbaf605f9e344b7830"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"fc8dec1fecaeebf2d8ab3dac2401e9a3fa930c47","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from openstack import resource"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class QosPolicy(resource.Resource):"},{"line_number":21,"context_line":"    resource_key \u003d \u0027policy\u0027"},{"line_number":22,"context_line":"    resources_key \u003d \u0027policies\u0027"},{"line_number":23,"context_line":"    base_path \u003d \u0027/qos/policies\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_052b4195","line":20,"range":{"start_line":20,"start_character":6,"end_line":20,"end_character":15},"in_reply_to":"9ad45d7e_7f7d7c6d","updated":"2016-08-10 14:12:36.000000000","message":"I\u0027m not worried about what other projects do. You can use Qos here though.","commit_id":"b934427bbecd2b74a55eb9dbaf605f9e344b7830"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"51b1a3fba19afd548fa66482f73bae87056ca54b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from openstack import resource"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class QosPolicy(resource.Resource):"},{"line_number":21,"context_line":"    resource_key \u003d \u0027policy\u0027"},{"line_number":22,"context_line":"    resources_key \u003d \u0027policies\u0027"},{"line_number":23,"context_line":"    base_path \u003d \u0027/qos/policies\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_7f7d7c6d","line":20,"range":{"start_line":20,"start_character":6,"end_line":20,"end_character":15},"in_reply_to":"9ad45d7e_9b96b64a","updated":"2016-08-10 08:20:01.000000000","message":"I don\u0027t agree with this. I undestand QoS is written with two capital letters, but also is considered a single word.\n\nThe naming convention used in OpenStack projects is to use only capital letters at the beginning of the word. Please, take a look at: https://github.com/openstack/neutron/blob/master/neutron/objects/qos/policy.py","commit_id":"b934427bbecd2b74a55eb9dbaf605f9e344b7830"}],"openstack/network/v2/qos_policy.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"b3991b967c35142a8fafe4f868dbca897010f644","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016, Intel Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_4b56cc5c","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":1},"updated":"2016-08-11 01:19:51.000000000","message":"please remove","commit_id":"5ebb2abe7ac5a5a060ed4ba032e0446f2b376187"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8dc2a7e5077a110c35850a33391a7ef22fce1710","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016, Intel Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_3fa8e9da","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":1},"in_reply_to":"9ad45d7e_4b56cc5c","updated":"2016-08-11 07:18:09.000000000","message":"Done","commit_id":"5ebb2abe7ac5a5a060ed4ba032e0446f2b376187"}],"openstack/tests/functional/network/v2/test_qos_policy.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"81bacac34172783b951ab21915e68a96d5880bd2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            shared\u003dcls.IS_SHARED,"},{"line_number":38,"context_line":"        )"},{"line_number":39,"context_line":"        assert isinstance(qos, _qos_policy.QosPolicy)"},{"line_number":40,"context_line":"        cls.assertIs(cls.QOS_POLICY_NAME, qos.name)"},{"line_number":41,"context_line":"        cls.QOS_POLICY_ID \u003d qos.id"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_ebba4e22","line":40,"range":{"start_line":40,"start_character":12,"end_line":40,"end_character":20},"updated":"2016-08-10 09:27:28.000000000","message":"assertEqual?","commit_id":"687bd3851d666a69ecba0255ec108643156521a5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"74f0be9761012d24e316441059fbfe96171659c8","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            shared\u003dcls.IS_SHARED,"},{"line_number":38,"context_line":"        )"},{"line_number":39,"context_line":"        assert isinstance(qos, _qos_policy.QosPolicy)"},{"line_number":40,"context_line":"        cls.assertIs(cls.QOS_POLICY_NAME, qos.name)"},{"line_number":41,"context_line":"        cls.QOS_POLICY_ID \u003d qos.id"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_34bdd902","line":40,"range":{"start_line":40,"start_character":12,"end_line":40,"end_character":20},"in_reply_to":"9ad45d7e_ebba4e22","updated":"2016-08-10 13:19:05.000000000","message":"The same answer as https://review.openstack.org/#/c/351565/4/openstack/tests/functional/network/v2/test_qos_minimum_bandwidth_rule.py@40","commit_id":"687bd3851d666a69ecba0255ec108643156521a5"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"b3991b967c35142a8fafe4f868dbca897010f644","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016, Intel Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_ebd340d3","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":1},"updated":"2016-08-11 01:19:51.000000000","message":"please remove","commit_id":"5ebb2abe7ac5a5a060ed4ba032e0446f2b376187"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8dc2a7e5077a110c35850a33391a7ef22fce1710","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016, Intel Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_9fb1154a","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":1},"in_reply_to":"9ad45d7e_ebd340d3","updated":"2016-08-11 07:18:09.000000000","message":"Done","commit_id":"5ebb2abe7ac5a5a060ed4ba032e0446f2b376187"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6f47c0edd33902400b76af03f0497d1199fed402","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    QOS_POLICY_DESCRIPTION \u003d \"QoS policy description\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @classmethod"},{"line_number":29,"context_line":"    def setUpClass(cls):"},{"line_number":30,"context_line":"        super(TestQoSPolicy, cls).setUpClass()"},{"line_number":31,"context_line":"        qos \u003d cls.conn.network.create_qos_policy("},{"line_number":32,"context_line":"            description\u003dcls.QOS_POLICY_DESCRIPTION,"}],"source_content_type":"text/x-python","patch_set":11,"id":"3ac371cc_bf7a24ef","line":29,"updated":"2016-08-17 14:55:55.000000000","message":"The class setup is failing in the functional test.  I think this should be fixed before merging.","commit_id":"bb892ee48189b477fe9a0f37708b50f75018fef6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"28091aaeddf4305e1e230ca4002fb758ed678f98","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    QOS_POLICY_DESCRIPTION \u003d \"QoS policy description\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @classmethod"},{"line_number":29,"context_line":"    def setUpClass(cls):"},{"line_number":30,"context_line":"        super(TestQoSPolicy, cls).setUpClass()"},{"line_number":31,"context_line":"        qos \u003d cls.conn.network.create_qos_policy("},{"line_number":32,"context_line":"            description\u003dcls.QOS_POLICY_DESCRIPTION,"}],"source_content_type":"text/x-python","patch_set":11,"id":"3ac371cc_caf1e096","line":29,"in_reply_to":"3ac371cc_bf7a24ef","updated":"2016-08-18 12:40:47.000000000","message":"QoS is an ML2 extension. Currently, the only one loaded is \"port_security\"\n\u003e 2016-08-11 08:05:56.540 27499 INFO neutron.plugins.ml2.managers [-] Loaded extension driver names: [\u0027port_security\u0027]\n(http://logs.openstack.org/87/351187/11/check/gate-sdk-dsvm-functional/66bb9d3/logs/screen-q-svc.txt.gz)\n\nBy default, if no other configuration is changed, \"port_security\" is loaded because is the default one in devstack: https://github.com/openstack-dev/devstack/commit/d03005321b2f0b38fe0507ca3023a838dee76f84\n\nPossible solutions for this problem:\n- Change the devstack default ML2 extensions: not recommended.\n- Change the gate config to load QoS extension during full stack tests.\n\nThe same solution applies to all QoS patches submitted.\n\nThese tests pass in a server with QoS extension enabled (manually tested).","commit_id":"bb892ee48189b477fe9a0f37708b50f75018fef6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"61d4d83af134af081be300b4091eae58f72bc9e2","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    QOS_POLICY_DESCRIPTION \u003d \"QoS policy description\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @classmethod"},{"line_number":29,"context_line":"    def setUpClass(cls):"},{"line_number":30,"context_line":"        super(TestQoSPolicy, cls).setUpClass()"},{"line_number":31,"context_line":"        qos \u003d cls.conn.network.create_qos_policy("},{"line_number":32,"context_line":"            description\u003dcls.QOS_POLICY_DESCRIPTION,"}],"source_content_type":"text/x-python","patch_set":11,"id":"3ac371cc_f1092b96","line":29,"in_reply_to":"3ac371cc_c06b7f83","updated":"2016-08-18 13:32:08.000000000","message":"| Shouldn\u0027t we also need a depends-on the neutron patch?.\n\nNeutron is up and running. I don\u0027t think we need to enable it.\n\nHow can I make this change (to enable to qos service)? It\u0027s the first time I try to make a modification in the config of a gate.","commit_id":"bb892ee48189b477fe9a0f37708b50f75018fef6"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"4613d9a030bdcd161ecb8e281c94d15acca30009","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    QOS_POLICY_DESCRIPTION \u003d \"QoS policy description\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @classmethod"},{"line_number":29,"context_line":"    def setUpClass(cls):"},{"line_number":30,"context_line":"        super(TestQoSPolicy, cls).setUpClass()"},{"line_number":31,"context_line":"        qos \u003d cls.conn.network.create_qos_policy("},{"line_number":32,"context_line":"            description\u003dcls.QOS_POLICY_DESCRIPTION,"}],"source_content_type":"text/x-python","patch_set":11,"id":"3ac371cc_c06b7f83","line":29,"in_reply_to":"3ac371cc_caf1e096","updated":"2016-08-18 12:57:51.000000000","message":"Shouldn\u0027t we also need a depends-on the neutron patch?.\n\nI suspect the 2nd option is better. To enable qos in the sdk gating we need to do import the neutron plugin \u0026 enable qos:\n\nin local.conf:\n    enable_plugin neutron https://github.com/openstack/neutron\n    enable_service q-qos","commit_id":"bb892ee48189b477fe9a0f37708b50f75018fef6"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"f055b567701758b1db40fbc6f7017c8c6b404605","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_find(self):"},{"line_number":46,"context_line":"        sot \u003d self.conn.network.find_address_scope(self.QOS_POLICY_NAME)"},{"line_number":47,"context_line":"        self.assertEqual(self.QOS_POLICY_ID, sot.id)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def test_get(self):"},{"line_number":50,"context_line":"        sot \u003d self.conn.network.get_qos_policy(self.QOS_POLICY_ID)"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ac06dbe_355a2151","line":47,"updated":"2016-08-22 09:34:29.000000000","message":"this line still fails with: \n\nAttributeError: \u0027NoneType\u0027 object has no attribute \u0027id\u0027","commit_id":"0341d6b7957b925076feb2ac06e92c43ec463ff5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"26e24322bf4440a56d168e0143bd0b71cde71628","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_find(self):"},{"line_number":46,"context_line":"        sot \u003d self.conn.network.find_address_scope(self.QOS_POLICY_NAME)"},{"line_number":47,"context_line":"        self.assertEqual(self.QOS_POLICY_ID, sot.id)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def test_get(self):"},{"line_number":50,"context_line":"        sot \u003d self.conn.network.get_qos_policy(self.QOS_POLICY_ID)"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ac06dbe_10f453f0","line":47,"in_reply_to":"1ac06dbe_355a2151","updated":"2016-08-22 09:40:07.000000000","message":"Sorry copy+paste from address_scope...","commit_id":"0341d6b7957b925076feb2ac06e92c43ec463ff5"}],"openstack/tests/unit/network/v2/test_qos_policy.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"b3991b967c35142a8fafe4f868dbca897010f644","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016, Intel Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_2bda78e8","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":1},"updated":"2016-08-11 01:19:51.000000000","message":"please remove","commit_id":"5ebb2abe7ac5a5a060ed4ba032e0446f2b376187"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8dc2a7e5077a110c35850a33391a7ef22fce1710","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016, Intel Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_7faee1e6","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":1},"in_reply_to":"9ad45d7e_2bda78e8","updated":"2016-08-11 07:18:09.000000000","message":"Done","commit_id":"5ebb2abe7ac5a5a060ed4ba032e0446f2b376187"}]}