)]}'
{"openstack/network/v2/_proxy.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"1f4cf0ff831d18b63aae65781373fff7e4f57ed1","unresolved":false,"context_lines":[{"line_number":1979,"context_line":""},{"line_number":1980,"context_line":"        :param dict attrs: Keyword arguments which will be used to create"},{"line_number":1981,"context_line":"                           a :class:`~openstack.network.v2."},{"line_number":1982,"context_line":"                           qos_minimum_bandwidth.QosMinimumBandwidthRule`,"},{"line_number":1983,"context_line":"                           comprised of the properties on the"},{"line_number":1984,"context_line":"                           QosMinimumBandwidthRuleRouter class."},{"line_number":1985,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_8be3d204","line":1982,"range":{"start_line":1982,"start_character":27,"end_line":1982,"end_character":48},"updated":"2016-08-10 09:35:06.000000000","message":"qos_minimum_bandwidth_rule","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"79533271aec8171d94389e7d1ea4cfdb5fbd463c","unresolved":false,"context_lines":[{"line_number":1979,"context_line":""},{"line_number":1980,"context_line":"        :param dict attrs: Keyword arguments which will be used to create"},{"line_number":1981,"context_line":"                           a :class:`~openstack.network.v2."},{"line_number":1982,"context_line":"                           qos_minimum_bandwidth.QosMinimumBandwidthRule`,"},{"line_number":1983,"context_line":"                           comprised of the properties on the"},{"line_number":1984,"context_line":"                           QosMinimumBandwidthRuleRouter class."},{"line_number":1985,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_9af7998a","line":1982,"range":{"start_line":1982,"start_character":27,"end_line":1982,"end_character":48},"in_reply_to":"9ad45d7e_8be3d204","updated":"2016-08-10 10:24:39.000000000","message":"Done","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"1f4cf0ff831d18b63aae65781373fff7e4f57ed1","unresolved":false,"context_lines":[{"line_number":1981,"context_line":"                           a :class:`~openstack.network.v2."},{"line_number":1982,"context_line":"                           qos_minimum_bandwidth.QosMinimumBandwidthRule`,"},{"line_number":1983,"context_line":"                           comprised of the properties on the"},{"line_number":1984,"context_line":"                           QosMinimumBandwidthRuleRouter class."},{"line_number":1985,"context_line":""},{"line_number":1986,"context_line":"        :returns: The results of router creation"},{"line_number":1987,"context_line":"        :rtype: :class:`~openstack.network.v2.qos_minimum_bandwidth."}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_cbedcaf0","line":1984,"range":{"start_line":1984,"start_character":50,"end_line":1984,"end_character":56},"updated":"2016-08-10 09:35:06.000000000","message":"delete","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"79533271aec8171d94389e7d1ea4cfdb5fbd463c","unresolved":false,"context_lines":[{"line_number":1981,"context_line":"                           a :class:`~openstack.network.v2."},{"line_number":1982,"context_line":"                           qos_minimum_bandwidth.QosMinimumBandwidthRule`,"},{"line_number":1983,"context_line":"                           comprised of the properties on the"},{"line_number":1984,"context_line":"                           QosMinimumBandwidthRuleRouter class."},{"line_number":1985,"context_line":""},{"line_number":1986,"context_line":"        :returns: The results of router creation"},{"line_number":1987,"context_line":"        :rtype: :class:`~openstack.network.v2.qos_minimum_bandwidth."}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_9d6793e8","line":1984,"range":{"start_line":1984,"start_character":50,"end_line":1984,"end_character":56},"in_reply_to":"9ad45d7e_cbedcaf0","updated":"2016-08-10 10:24:39.000000000","message":"Done","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"1f4cf0ff831d18b63aae65781373fff7e4f57ed1","unresolved":false,"context_lines":[{"line_number":1983,"context_line":"                           comprised of the properties on the"},{"line_number":1984,"context_line":"                           QosMinimumBandwidthRuleRouter class."},{"line_number":1985,"context_line":""},{"line_number":1986,"context_line":"        :returns: The results of router creation"},{"line_number":1987,"context_line":"        :rtype: :class:`~openstack.network.v2.qos_minimum_bandwidth."},{"line_number":1988,"context_line":"                    QosMinimumBandwidthRule`"},{"line_number":1989,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_4b2a7a2d","line":1986,"range":{"start_line":1986,"start_character":33,"end_line":1986,"end_character":39},"updated":"2016-08-10 09:35:06.000000000","message":"resource","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"79533271aec8171d94389e7d1ea4cfdb5fbd463c","unresolved":false,"context_lines":[{"line_number":1983,"context_line":"                           comprised of the properties on the"},{"line_number":1984,"context_line":"                           QosMinimumBandwidthRuleRouter class."},{"line_number":1985,"context_line":""},{"line_number":1986,"context_line":"        :returns: The results of router creation"},{"line_number":1987,"context_line":"        :rtype: :class:`~openstack.network.v2.qos_minimum_bandwidth."},{"line_number":1988,"context_line":"                    QosMinimumBandwidthRule`"},{"line_number":1989,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_dd5d8b16","line":1986,"range":{"start_line":1986,"start_character":33,"end_line":1986,"end_character":39},"in_reply_to":"9ad45d7e_4b2a7a2d","updated":"2016-08-10 10:24:39.000000000","message":"Done","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"1f4cf0ff831d18b63aae65781373fff7e4f57ed1","unresolved":false,"context_lines":[{"line_number":1984,"context_line":"                           QosMinimumBandwidthRuleRouter class."},{"line_number":1985,"context_line":""},{"line_number":1986,"context_line":"        :returns: The results of router creation"},{"line_number":1987,"context_line":"        :rtype: :class:`~openstack.network.v2.qos_minimum_bandwidth."},{"line_number":1988,"context_line":"                    QosMinimumBandwidthRule`"},{"line_number":1989,"context_line":"        \"\"\""},{"line_number":1990,"context_line":"        return self._create("}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_abe856e3","line":1987,"range":{"start_line":1987,"start_character":46,"end_line":1987,"end_character":67},"updated":"2016-08-10 09:35:06.000000000","message":"qos_minimum_bandwidth_rule","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"79533271aec8171d94389e7d1ea4cfdb5fbd463c","unresolved":false,"context_lines":[{"line_number":1984,"context_line":"                           QosMinimumBandwidthRuleRouter class."},{"line_number":1985,"context_line":""},{"line_number":1986,"context_line":"        :returns: The results of router creation"},{"line_number":1987,"context_line":"        :rtype: :class:`~openstack.network.v2.qos_minimum_bandwidth."},{"line_number":1988,"context_line":"                    QosMinimumBandwidthRule`"},{"line_number":1989,"context_line":"        \"\"\""},{"line_number":1990,"context_line":"        return self._create("}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_bdb1b749","line":1987,"range":{"start_line":1987,"start_character":46,"end_line":1987,"end_character":67},"in_reply_to":"9ad45d7e_abe856e3","updated":"2016-08-10 10:24:39.000000000","message":"Done","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"1f4cf0ff831d18b63aae65781373fff7e4f57ed1","unresolved":false,"context_lines":[{"line_number":2001,"context_line":"        :param qos_policy_id: ID of the QoS policy that the rule belongs."},{"line_number":2002,"context_line":"        :param bool ignore_missing: When set to ``False``"},{"line_number":2003,"context_line":"                    :class:`~openstack.exceptions.ResourceNotFound` will be"},{"line_number":2004,"context_line":"                    raised when the router does not exist."},{"line_number":2005,"context_line":"                    When set to ``True``, no exception will be set when"},{"line_number":2006,"context_line":"                    attempting to delete a nonexistent minimum bandwidth rule."},{"line_number":2007,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_abcfb67d","line":2004,"range":{"start_line":2004,"start_character":36,"end_line":2004,"end_character":42},"updated":"2016-08-10 09:35:06.000000000","message":"resource","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"79533271aec8171d94389e7d1ea4cfdb5fbd463c","unresolved":false,"context_lines":[{"line_number":2001,"context_line":"        :param qos_policy_id: ID of the QoS policy that the rule belongs."},{"line_number":2002,"context_line":"        :param bool ignore_missing: When set to ``False``"},{"line_number":2003,"context_line":"                    :class:`~openstack.exceptions.ResourceNotFound` will be"},{"line_number":2004,"context_line":"                    raised when the router does not exist."},{"line_number":2005,"context_line":"                    When set to ``True``, no exception will be set when"},{"line_number":2006,"context_line":"                    attempting to delete a nonexistent minimum bandwidth rule."},{"line_number":2007,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_1d89e375","line":2004,"range":{"start_line":2004,"start_character":36,"end_line":2004,"end_character":42},"in_reply_to":"9ad45d7e_abcfb67d","updated":"2016-08-10 10:24:39.000000000","message":"Done","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"1f4cf0ff831d18b63aae65781373fff7e4f57ed1","unresolved":false,"context_lines":[{"line_number":2036,"context_line":"                         a :class:`~openstack.network.v2.qos_minimum_bandwidth."},{"line_number":2037,"context_line":"                         QosMinimumBandwidthRule` instance."},{"line_number":2038,"context_line":"        :param qos_policy_id: ID of the QoS policy that the rule belongs."},{"line_number":2039,"context_line":"        :returns: One :class:`~openstack.network.v2.qos_minimum_bandwidth."},{"line_number":2040,"context_line":"                       QosMinimumBandwidthRule`"},{"line_number":2041,"context_line":"        :raises: :class:`~openstack.exceptions.ResourceNotFound`"},{"line_number":2042,"context_line":"                       when no resource can be found."}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_cb72ea48","line":2039,"range":{"start_line":2039,"start_character":52,"end_line":2039,"end_character":73},"updated":"2016-08-10 09:35:06.000000000","message":"qos_minimum_bandwidth_rule","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"79533271aec8171d94389e7d1ea4cfdb5fbd463c","unresolved":false,"context_lines":[{"line_number":2036,"context_line":"                         a :class:`~openstack.network.v2.qos_minimum_bandwidth."},{"line_number":2037,"context_line":"                         QosMinimumBandwidthRule` instance."},{"line_number":2038,"context_line":"        :param qos_policy_id: ID of the QoS policy that the rule belongs."},{"line_number":2039,"context_line":"        :returns: One :class:`~openstack.network.v2.qos_minimum_bandwidth."},{"line_number":2040,"context_line":"                       QosMinimumBandwidthRule`"},{"line_number":2041,"context_line":"        :raises: :class:`~openstack.exceptions.ResourceNotFound`"},{"line_number":2042,"context_line":"                       when no resource can be found."}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_3deb0715","line":2039,"range":{"start_line":2039,"start_character":52,"end_line":2039,"end_character":73},"in_reply_to":"9ad45d7e_cb72ea48","updated":"2016-08-10 10:24:39.000000000","message":"Done","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"1f4cf0ff831d18b63aae65781373fff7e4f57ed1","unresolved":false,"context_lines":[{"line_number":2051,"context_line":"        :param kwargs \\*\\*query: Optional query parameters to be sent to limit"},{"line_number":2052,"context_line":"                                 the resources being returned."},{"line_number":2053,"context_line":"        :returns: A generator of minimum bandwidth rule objects"},{"line_number":2054,"context_line":"        :rtype: :class:`~openstack.network.v2.qos_minimum_bandwidth."},{"line_number":2055,"context_line":"                       QosMinimumBandwidthRule`"},{"line_number":2056,"context_line":"        \"\"\""},{"line_number":2057,"context_line":"        return self._list(_qos_minimum_bandwidth_rule.QosMinimumBandwidthRule,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_8b9f524f","line":2054,"range":{"start_line":2054,"start_character":46,"end_line":2054,"end_character":67},"updated":"2016-08-10 09:35:06.000000000","message":"qos_minimum_bandwidth_rule","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"79533271aec8171d94389e7d1ea4cfdb5fbd463c","unresolved":false,"context_lines":[{"line_number":2051,"context_line":"        :param kwargs \\*\\*query: Optional query parameters to be sent to limit"},{"line_number":2052,"context_line":"                                 the resources being returned."},{"line_number":2053,"context_line":"        :returns: A generator of minimum bandwidth rule objects"},{"line_number":2054,"context_line":"        :rtype: :class:`~openstack.network.v2.qos_minimum_bandwidth."},{"line_number":2055,"context_line":"                       QosMinimumBandwidthRule`"},{"line_number":2056,"context_line":"        \"\"\""},{"line_number":2057,"context_line":"        return self._list(_qos_minimum_bandwidth_rule.QosMinimumBandwidthRule,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_7df1ff00","line":2054,"range":{"start_line":2054,"start_character":46,"end_line":2054,"end_character":67},"in_reply_to":"9ad45d7e_8b9f524f","updated":"2016-08-10 10:24:39.000000000","message":"Done","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"1f4cf0ff831d18b63aae65781373fff7e4f57ed1","unresolved":false,"context_lines":[{"line_number":2063,"context_line":"        \"\"\"Update a minimum bandwidth rule"},{"line_number":2064,"context_line":""},{"line_number":2065,"context_line":"        :param qos_rule: Either the id of a minimum bandwidth rule or a"},{"line_number":2066,"context_line":"                         :class:`~openstack.network.v2.qos_minimum_bandwidth."},{"line_number":2067,"context_line":"                         QosMinimumBandwidthRule` instance."},{"line_number":2068,"context_line":"        :param qos_policy_id: ID of the QoS policy that the rule belongs."},{"line_number":2069,"context_line":"        :attrs kwargs: The attributes to update on the minimum bandwidth rule"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_abcb3652","line":2066,"range":{"start_line":2066,"start_character":55,"end_line":2066,"end_character":76},"updated":"2016-08-10 09:35:06.000000000","message":"qos_minimum_bandwidth_rule","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"79533271aec8171d94389e7d1ea4cfdb5fbd463c","unresolved":false,"context_lines":[{"line_number":2063,"context_line":"        \"\"\"Update a minimum bandwidth rule"},{"line_number":2064,"context_line":""},{"line_number":2065,"context_line":"        :param qos_rule: Either the id of a minimum bandwidth rule or a"},{"line_number":2066,"context_line":"                         :class:`~openstack.network.v2.qos_minimum_bandwidth."},{"line_number":2067,"context_line":"                         QosMinimumBandwidthRule` instance."},{"line_number":2068,"context_line":"        :param qos_policy_id: ID of the QoS policy that the rule belongs."},{"line_number":2069,"context_line":"        :attrs kwargs: The attributes to update on the minimum bandwidth rule"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_3dd2e75c","line":2066,"range":{"start_line":2066,"start_character":55,"end_line":2066,"end_character":76},"in_reply_to":"9ad45d7e_abcb3652","updated":"2016-08-10 10:24:39.000000000","message":"Done","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"0dfe6c972942fb66d81871d1d470895dd093e665","unresolved":false,"context_lines":[{"line_number":1977,"context_line":"        \"\"\""},{"line_number":1978,"context_line":"        return self._update(_qos_policy.QoSPolicy, qos_policy, **attrs)"},{"line_number":1979,"context_line":""},{"line_number":1980,"context_line":"    def create_qos_minimum_bandwidth_rule(self, qos_policy_id, **attrs):"},{"line_number":1981,"context_line":"        \"\"\"Create a new minimum bandwidth rule"},{"line_number":1982,"context_line":""},{"line_number":1983,"context_line":"        :param dict attrs: Keyword arguments which will be used to create"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_62d653f2","line":1980,"updated":"2016-08-17 15:16:41.000000000","message":"The pool member methods support ID or object and use the get_id helper.  I think we should be consistent and allow ID or QoSPolicy instance here and in the other applicable methods below.","commit_id":"0e2cc58594b04b31a05966305936d38a9f61ce4a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"504617dcada6285308e3d58a9ec2b3a6a19bc93b","unresolved":false,"context_lines":[{"line_number":1977,"context_line":"        \"\"\""},{"line_number":1978,"context_line":"        return self._update(_qos_policy.QoSPolicy, qos_policy, **attrs)"},{"line_number":1979,"context_line":""},{"line_number":1980,"context_line":"    def create_qos_minimum_bandwidth_rule(self, qos_policy_id, **attrs):"},{"line_number":1981,"context_line":"        \"\"\"Create a new minimum bandwidth rule"},{"line_number":1982,"context_line":""},{"line_number":1983,"context_line":"        :param dict attrs: Keyword arguments which will be used to create"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_c0e41fad","line":1980,"in_reply_to":"3ac371cc_62d653f2","updated":"2016-08-18 13:02:20.000000000","message":"Done","commit_id":"0e2cc58594b04b31a05966305936d38a9f61ce4a"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"377c292118e8255531333ddbe2c2cf7259c6ef99","unresolved":false,"context_lines":[{"line_number":1149,"context_line":"    def create_qos_minimum_bandwidth_rule(self, qos_policy, **attrs):"},{"line_number":1150,"context_line":"        \"\"\"Create a new minimum bandwidth rule"},{"line_number":1151,"context_line":""},{"line_number":1152,"context_line":"        :param dict attrs: Keyword arguments which will be used to create"},{"line_number":1153,"context_line":"                           a :class:`~openstack.network.v2."},{"line_number":1154,"context_line":"                           qos_minimum_bandwidth_rule.QoSMinimumBandwidthRule`,"},{"line_number":1155,"context_line":"                           comprised of the properties on the"},{"line_number":1156,"context_line":"                           QoSMinimumBandwidthRule class."},{"line_number":1157,"context_line":"        :param qos_policy: The value can be the ID of the QoS policy that the"},{"line_number":1158,"context_line":"                           rule belongs or a :class:`~openstack.network.v2."},{"line_number":1159,"context_line":"                           qos_policy.QoSPolicy` instance."},{"line_number":1160,"context_line":""},{"line_number":1161,"context_line":"        :returns: The results of resource creation"},{"line_number":1162,"context_line":"        :rtype: :class:`~openstack.network.v2.qos_minimum_bandwidth_rule."}],"source_content_type":"text/x-python","patch_set":22,"id":"9a89bdaa_eb5505c2","line":1159,"range":{"start_line":1152,"start_character":0,"end_line":1159,"end_character":58},"updated":"2016-09-07 11:31:17.000000000","message":"Switch order of the parameters to match method definition.","commit_id":"51ab4e17f6d0e429899ea29cab63ed37c385f19a"}],"openstack/network/v2/qos_minimum_bandwidth_rule.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"1f4cf0ff831d18b63aae65781373fff7e4f57ed1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016, Intel Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_cbee6ab3","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":22},"updated":"2016-08-10 09:35:06.000000000","message":"as a general suggestion, we don\u0027t add company copyright to source code.","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"79533271aec8171d94389e7d1ea4cfdb5fbd463c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016, Intel Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_bd4d3740","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":22},"in_reply_to":"9ad45d7e_cbee6ab3","updated":"2016-08-10 10:24:39.000000000","message":"Done","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"1f4cf0ff831d18b63aae65781373fff7e4f57ed1","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    # Properties"},{"line_number":34,"context_line":"    #: QoS minimum bandwidth rule id."},{"line_number":35,"context_line":"    name \u003d resource.prop(\u0027id\u0027)"},{"line_number":36,"context_line":"    #: The ID of the QoS policy who owns rule."},{"line_number":37,"context_line":"    qos_policy_id \u003d resource.prop(\u0027qos_policy_id\u0027)"},{"line_number":38,"context_line":"    #: Minimum bandwidth in kbps."}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_2b13c6b9","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":8},"updated":"2016-08-10 09:35:06.000000000","message":"should be ID?","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"79533271aec8171d94389e7d1ea4cfdb5fbd463c","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    # Properties"},{"line_number":34,"context_line":"    #: QoS minimum bandwidth rule id."},{"line_number":35,"context_line":"    name \u003d resource.prop(\u0027id\u0027)"},{"line_number":36,"context_line":"    #: The ID of the QoS policy who owns rule."},{"line_number":37,"context_line":"    qos_policy_id \u003d resource.prop(\u0027qos_policy_id\u0027)"},{"line_number":38,"context_line":"    #: Minimum bandwidth in kbps."}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_fd184f20","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":8},"in_reply_to":"9ad45d7e_2b13c6b9","updated":"2016-08-10 10:24:39.000000000","message":"Yes, you are right!","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"0dfe6c972942fb66d81871d1d470895dd093e665","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    #: The ID of the QoS policy who owns rule."},{"line_number":34,"context_line":"    qos_policy_id \u003d resource.prop(\u0027qos_policy_id\u0027)"},{"line_number":35,"context_line":"    #: Minimum bandwidth in kbps."},{"line_number":36,"context_line":"    min_kbps \u003d resource.prop(\u0027min_kbps\u0027)"},{"line_number":37,"context_line":"    #: Traffic direction from the tenant point of view (\u0027egress\u0027, \u0027ingress\u0027)."},{"line_number":38,"context_line":"    direction \u003d resource.prop(\u0027direction\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_f5967b3c","line":36,"updated":"2016-08-17 15:16:41.000000000","message":"I\u0027m a little confused on this one.  The neutron CLI shows max kbps and max burst kbps options.","commit_id":"0e2cc58594b04b31a05966305936d38a9f61ce4a"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"a10b7859b1847772cc6f16dfb3f8b7d038fb70a6","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    #: The ID of the QoS policy who owns rule."},{"line_number":34,"context_line":"    qos_policy_id \u003d resource.prop(\u0027qos_policy_id\u0027)"},{"line_number":35,"context_line":"    #: Minimum bandwidth in kbps."},{"line_number":36,"context_line":"    min_kbps \u003d resource.prop(\u0027min_kbps\u0027)"},{"line_number":37,"context_line":"    #: Traffic direction from the tenant point of view (\u0027egress\u0027, \u0027ingress\u0027)."},{"line_number":38,"context_line":"    direction \u003d resource.prop(\u0027direction\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_f5095b85","line":36,"in_reply_to":"3ac371cc_f5967b3c","updated":"2016-08-17 15:17:54.000000000","message":"Ignore this comment, I was looking at the wrong command.","commit_id":"0e2cc58594b04b31a05966305936d38a9f61ce4a"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"377c292118e8255531333ddbe2c2cf7259c6ef99","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    allow_list \u003d True"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    # Properties"},{"line_number":31,"context_line":"    #: QoS minimum bandwidth rule id."},{"line_number":32,"context_line":"    id \u003d resource.prop(\u0027id\u0027)"},{"line_number":33,"context_line":"    #: The ID of the QoS policy who owns rule."},{"line_number":34,"context_line":"    qos_policy_id \u003d resource.prop(\u0027qos_policy_id\u0027)"},{"line_number":35,"context_line":"    #: Minimum bandwidth in kbps."}],"source_content_type":"text/x-python","patch_set":22,"id":"9a89bdaa_ab9cddc0","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":28},"updated":"2016-09-07 11:31:17.000000000","message":"You shouldn\u0027t need to parse the id property.","commit_id":"51ab4e17f6d0e429899ea29cab63ed37c385f19a"}],"openstack/proxy.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"1b7d6dfea76fe5978e9834c5699e9d7ba0097c76","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.session \u003d session"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _get_resource(self, resource_type, value, path_args\u003dNone,"},{"line_number":47,"context_line":"                      update_path\u003dTrue):"},{"line_number":48,"context_line":"        \"\"\"Get a resource object to work on"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        :param resource_type: The type of resource to operate on. This should"}],"source_content_type":"text/x-python","patch_set":19,"id":"1ac06dbe_3d13355e","line":47,"updated":"2016-08-25 11:22:05.000000000","message":"One problem is that Proxy and Resource have been refactored and will be replaced by Proxy2 and Resource2.  So this will need to fit there as well.\n\nHowever, I question what you are trying to solve.  For example, PoolMember has a method to extract pool_id from the create body.  I suggest that you run your use case by Brian Curtain for ideas on how to best solve this.","commit_id":"cce1c2e7c3bd397c9b3677fa7666c4db5f73eb65"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"db2474c111df849cb71e9b8235f5d764ea2a57cb","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.session \u003d session"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _get_resource(self, resource_type, value, path_args\u003dNone,"},{"line_number":47,"context_line":"                      update_path\u003dTrue):"},{"line_number":48,"context_line":"        \"\"\"Get a resource object to work on"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        :param resource_type: The type of resource to operate on. This should"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a89bdaa_e8a3834d","line":47,"in_reply_to":"1ac06dbe_3d13355e","updated":"2016-09-06 13:42:24.000000000","message":"I\u0027ll use the same solution used in PoolMember","commit_id":"cce1c2e7c3bd397c9b3677fa7666c4db5f73eb65"}],"openstack/tests/functional/network/v2/test_qos_minimum_bandwidth_rule.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"1f4cf0ff831d18b63aae65781373fff7e4f57ed1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016, Intel Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_eb21aefc","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":22},"updated":"2016-08-10 09:35:06.000000000","message":"same","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"79533271aec8171d94389e7d1ea4cfdb5fbd463c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016, Intel Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_7ddbbf4f","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":22},"in_reply_to":"9ad45d7e_eb21aefc","updated":"2016-08-10 10:24:39.000000000","message":"Done","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"1f4cf0ff831d18b63aae65781373fff7e4f57ed1","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        )"},{"line_number":38,"context_line":"        assert isinstance(qos_min_bw_rule,"},{"line_number":39,"context_line":"                          _qos_minimum_bandwidth_rule.QosMinimumBandwidthRule)"},{"line_number":40,"context_line":"        cls.assertIs(cls.RULE_MIN_KBPS, qos_min_bw_rule.min_kbps)"},{"line_number":41,"context_line":"        cls.assertIs(cls.RULE_DIRECTION, qos_min_bw_rule.direction)"},{"line_number":42,"context_line":"        cls.RULE_ID \u003d qos_min_bw_rule.id"},{"line_number":43,"context_line":"        cls.RULE_QOS_POLICY_ID \u003d qos_min_bw_rule.qos_policy_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_4b871ad7","line":40,"range":{"start_line":40,"start_character":12,"end_line":40,"end_character":20},"updated":"2016-08-10 09:35:06.000000000","message":"assertEqual","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"79533271aec8171d94389e7d1ea4cfdb5fbd463c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        )"},{"line_number":38,"context_line":"        assert isinstance(qos_min_bw_rule,"},{"line_number":39,"context_line":"                          _qos_minimum_bandwidth_rule.QosMinimumBandwidthRule)"},{"line_number":40,"context_line":"        cls.assertIs(cls.RULE_MIN_KBPS, qos_min_bw_rule.min_kbps)"},{"line_number":41,"context_line":"        cls.assertIs(cls.RULE_DIRECTION, qos_min_bw_rule.direction)"},{"line_number":42,"context_line":"        cls.RULE_ID \u003d qos_min_bw_rule.id"},{"line_number":43,"context_line":"        cls.RULE_QOS_POLICY_ID \u003d qos_min_bw_rule.qos_policy_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_fdf04f93","line":40,"range":{"start_line":40,"start_character":12,"end_line":40,"end_character":20},"in_reply_to":"9ad45d7e_4b871ad7","updated":"2016-08-10 10:24:39.000000000","message":"With assertEqual, both objects must be the same object. Also this is the check function used in many setUpClass in this project.\nI\u0027ll leave this check.","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"1f4cf0ff831d18b63aae65781373fff7e4f57ed1","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        assert isinstance(qos_min_bw_rule,"},{"line_number":39,"context_line":"                          _qos_minimum_bandwidth_rule.QosMinimumBandwidthRule)"},{"line_number":40,"context_line":"        cls.assertIs(cls.RULE_MIN_KBPS, qos_min_bw_rule.min_kbps)"},{"line_number":41,"context_line":"        cls.assertIs(cls.RULE_DIRECTION, qos_min_bw_rule.direction)"},{"line_number":42,"context_line":"        cls.RULE_ID \u003d qos_min_bw_rule.id"},{"line_number":43,"context_line":"        cls.RULE_QOS_POLICY_ID \u003d qos_min_bw_rule.qos_policy_id"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_ab6e962c","line":41,"range":{"start_line":41,"start_character":12,"end_line":41,"end_character":20},"updated":"2016-08-10 09:35:06.000000000","message":"assertEqual","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"79533271aec8171d94389e7d1ea4cfdb5fbd463c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        assert isinstance(qos_min_bw_rule,"},{"line_number":39,"context_line":"                          _qos_minimum_bandwidth_rule.QosMinimumBandwidthRule)"},{"line_number":40,"context_line":"        cls.assertIs(cls.RULE_MIN_KBPS, qos_min_bw_rule.min_kbps)"},{"line_number":41,"context_line":"        cls.assertIs(cls.RULE_DIRECTION, qos_min_bw_rule.direction)"},{"line_number":42,"context_line":"        cls.RULE_ID \u003d qos_min_bw_rule.id"},{"line_number":43,"context_line":"        cls.RULE_QOS_POLICY_ID \u003d qos_min_bw_rule.qos_policy_id"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_dded8bb8","line":41,"range":{"start_line":41,"start_character":12,"end_line":41,"end_character":20},"in_reply_to":"9ad45d7e_ab6e962c","updated":"2016-08-10 10:24:39.000000000","message":"Ditto","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"0dfe6c972942fb66d81871d1d470895dd093e665","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    RULE_DIRECTION_NEW \u003d \u0027ingress\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @classmethod"},{"line_number":30,"context_line":"    def setUpClass(cls):"},{"line_number":31,"context_line":"        super(TestQoSMinimumBandwidthRule, cls).setUpClass()"},{"line_number":32,"context_line":"        qos_min_bw_rule \u003d cls.conn.network.create_qos_minimum_bandwidth_rule("},{"line_number":33,"context_line":"            cls.RULE_QOS_POLICY_ID, direction\u003dcls.RULE_DIRECTION,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_82bc2f07","line":30,"updated":"2016-08-17 15:16:41.000000000","message":"Please fix the functional test case setup failure.","commit_id":"0e2cc58594b04b31a05966305936d38a9f61ce4a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"504617dcada6285308e3d58a9ec2b3a6a19bc93b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    RULE_DIRECTION_NEW \u003d \u0027ingress\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @classmethod"},{"line_number":30,"context_line":"    def setUpClass(cls):"},{"line_number":31,"context_line":"        super(TestQoSMinimumBandwidthRule, cls).setUpClass()"},{"line_number":32,"context_line":"        qos_min_bw_rule \u003d cls.conn.network.create_qos_minimum_bandwidth_rule("},{"line_number":33,"context_line":"            cls.RULE_QOS_POLICY_ID, direction\u003dcls.RULE_DIRECTION,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_1ddfc03a","line":30,"in_reply_to":"3ac371cc_82bc2f07","updated":"2016-08-18 13:02:20.000000000","message":"Same answer: https://review.openstack.org/#/c/351187/11/openstack/tests/functional/network/v2/test_qos_policy.py@29","commit_id":"0e2cc58594b04b31a05966305936d38a9f61ce4a"}],"openstack/tests/unit/network/v2/test_proxy.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"b859a24a5c8eacb80dddac0fb784ebc2d56aa521","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from openstack.network.v2 import pool_member"},{"line_number":31,"context_line":"from openstack.network.v2 import port"},{"line_number":32,"context_line":"from openstack.network.v2 import qos_policy"},{"line_number":33,"context_line":"from openstack.network.v2 import qos_minimum_bandwidth_rule"},{"line_number":34,"context_line":"from openstack.network.v2 import quota"},{"line_number":35,"context_line":"from openstack.network.v2 import rbac_policy"},{"line_number":36,"context_line":"from openstack.network.v2 import router"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_eb3d00de","line":33,"updated":"2016-08-11 01:24:23.000000000","message":"move this line before line 32, then all set.","commit_id":"207553b6b3e17f954b93c685a9edb937afc54e14"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"94e2aefa4c27c492ee5ef6cfebffef63603b47c6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from openstack.network.v2 import pool_member"},{"line_number":31,"context_line":"from openstack.network.v2 import port"},{"line_number":32,"context_line":"from openstack.network.v2 import qos_policy"},{"line_number":33,"context_line":"from openstack.network.v2 import qos_minimum_bandwidth_rule"},{"line_number":34,"context_line":"from openstack.network.v2 import quota"},{"line_number":35,"context_line":"from openstack.network.v2 import rbac_policy"},{"line_number":36,"context_line":"from openstack.network.v2 import router"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_7401e837","line":33,"in_reply_to":"9ad45d7e_eb3d00de","updated":"2016-08-11 06:57:23.000000000","message":"Done","commit_id":"207553b6b3e17f954b93c685a9edb937afc54e14"}],"openstack/tests/unit/network/v2/test_qos_minimum_bandwidth_rule.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"1f4cf0ff831d18b63aae65781373fff7e4f57ed1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016, Intel Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_4b5efa76","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":22},"updated":"2016-08-10 09:35:06.000000000","message":"same","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"79533271aec8171d94389e7d1ea4cfdb5fbd463c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016, Intel Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_fd1e8fb9","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":22},"in_reply_to":"9ad45d7e_4b5efa76","updated":"2016-08-10 10:24:39.000000000","message":"Done","commit_id":"39a453a2360d7dda8d25caf7ac2d652cecc0cdef"}]}