)]}'
{"openstack/orchestration/v1/_proxy.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6797d02c4a693ef045cc8709dd7c3b5d7a7561ac","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    def check_stack(self, stack):"},{"line_number":111,"context_line":"        \"\"\"Check a stack\u0027s status"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        :param stack: The value can be either the ID or a stack or an"},{"line_number":114,"context_line":"                      :class:`~openstack.orchestration.v1.stack.Stack`"},{"line_number":115,"context_line":"                      instance."},{"line_number":116,"context_line":"        :returns: ``None``"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_199a53b9","line":113,"updated":"2016-08-11 12:00:19.000000000","message":"Can this be a stack name as well since find is used?  Should get be used instead?","commit_id":"52688a7813db561bd9e9015400afc5506afda67d"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"9dcd189495245ce8a71bcc0a4bd68555a66e2bf6","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    def check_stack(self, stack):"},{"line_number":111,"context_line":"        \"\"\"Check a stack\u0027s status"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        :param stack: The value can be either the ID or a stack or an"},{"line_number":114,"context_line":"                      :class:`~openstack.orchestration.v1.stack.Stack`"},{"line_number":115,"context_line":"                      instance."},{"line_number":116,"context_line":"        :returns: ``None``"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_eb6de4cc","line":113,"in_reply_to":"9ad45d7e_199a53b9","updated":"2016-08-11 12:39:52.000000000","message":"good question. It could be a stack name. Will revise.","commit_id":"52688a7813db561bd9e9015400afc5506afda67d"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6797d02c4a693ef045cc8709dd7c3b5d7a7561ac","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        :param stack: The value can be either the ID or a stack or an"},{"line_number":114,"context_line":"                      :class:`~openstack.orchestration.v1.stack.Stack`"},{"line_number":115,"context_line":"                      instance."},{"line_number":116,"context_line":"        :returns: ``None``"},{"line_number":117,"context_line":"        \"\"\""},{"line_number":118,"context_line":"        if isinstance(stack, _stack.Stack):"},{"line_number":119,"context_line":"            stk \u003d stack"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_591a0b18","line":116,"updated":"2016-08-11 12:00:19.000000000","message":"If None is returned, how does a caller know the status.  Some more detail would be nice.","commit_id":"52688a7813db561bd9e9015400afc5506afda67d"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"9dcd189495245ce8a71bcc0a4bd68555a66e2bf6","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        :param stack: The value can be either the ID or a stack or an"},{"line_number":114,"context_line":"                      :class:`~openstack.orchestration.v1.stack.Stack`"},{"line_number":115,"context_line":"                      instance."},{"line_number":116,"context_line":"        :returns: ``None``"},{"line_number":117,"context_line":"        \"\"\""},{"line_number":118,"context_line":"        if isinstance(stack, _stack.Stack):"},{"line_number":119,"context_line":"            stk \u003d stack"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_4b8b5068","line":116,"in_reply_to":"9ad45d7e_591a0b18","updated":"2016-08-11 12:39:52.000000000","message":"In heat, this operation is an \u0027action\u0027 to be executed asynchronously. The only way for user to know the progress of the operation would be checking the stack status.","commit_id":"52688a7813db561bd9e9015400afc5506afda67d"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"762b97fd3e10012c5e1bfcd4af80389917ea89a2","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        if isinstance(stack, _stack.Stack):"},{"line_number":122,"context_line":"            stk \u003d stack"},{"line_number":123,"context_line":"        else:"},{"line_number":124,"context_line":"            stk \u003d self._find(_stack.Stack, stack, ignore_missing\u003dFalse)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        stk.check(self.session)"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_7cfc183e","line":124,"range":{"start_line":124,"start_character":22,"end_line":124,"end_character":23},"updated":"2016-08-11 14:22:00.000000000","message":"I\u0027m not sure we should do this find here. So far we don\u0027t do this anywhere else and we\u0027ve only had operations work with an ID or an instance. If you need to look up by name, everywhere else you\u0027d need to do the find first and then pass in the instance you get back, so I think that consistency is valuable.\n\nOr am I missing something as to why this one is different than other operations?","commit_id":"9844b6137dce3da413493bc71c624323e5ec5e23"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"82835fd648a6a85ca2b4916a1622743ab1c859fb","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        if isinstance(stack, _stack.Stack):"},{"line_number":122,"context_line":"            stk \u003d stack"},{"line_number":123,"context_line":"        else:"},{"line_number":124,"context_line":"            stk \u003d self._find(_stack.Stack, stack, ignore_missing\u003dFalse)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        stk.check(self.session)"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_91e732ab","line":124,"range":{"start_line":124,"start_character":22,"end_line":124,"end_character":23},"in_reply_to":"9ad45d7e_7cfc183e","updated":"2016-08-11 14:28:56.000000000","message":"I agree, we should be consistent.","commit_id":"9844b6137dce3da413493bc71c624323e5ec5e23"}]}