)]}'
{"openstack/network/v2/pool.py":[{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"7a3d40d990c7e323e846cb7321d4e0a4e80b87b8","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    #: *Type: dict with keys ``type`` and ``cookie_name``*"},{"line_number":76,"context_line":"    session_persistence \u003d resource.Body(\u0027session_persistence\u0027)"},{"line_number":77,"context_line":"    #: The ID of the virtual IP (VIP) address."},{"line_number":78,"context_line":"    vip_id \u003d resource.Body(\u0027vip\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_462af42d","line":78,"updated":"2016-12-07 16:51:03.000000000","message":"This looks like it\u0027s called vip_id at http://developer.openstack.org/api-ref/networking/v2/?expanded\u003did577-detail#id577 — are the docs wrong or should this change?\n\nAlso, what do you think about making this `virtual_ip_id`? When I see VIP I think more \"very important person\", although I know we\u0027re not talking about people here, but spelling it out could be more clear.","commit_id":"b91be123fe60041d6e6acfa3be2196e4d737bd61"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"68e13aba487644e25d0c50299a989916c126909f","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    #: *Type: dict with keys ``type`` and ``cookie_name``*"},{"line_number":76,"context_line":"    session_persistence \u003d resource.Body(\u0027session_persistence\u0027)"},{"line_number":77,"context_line":"    #: The ID of the virtual IP (VIP) address."},{"line_number":78,"context_line":"    vip_id \u003d resource.Body(\u0027vip\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_21e230a0","line":78,"in_reply_to":"3a71b18c_462af42d","updated":"2016-12-08 02:05:21.000000000","message":"yep, it was a typo.\n\nI\u0027m fine with changing it to \u0027virtual_ip_id\u0027 though I don\u0027t think people will confuse \u0027vip\u0027 with \u0027very important person\u0027 in this context. :)","commit_id":"b91be123fe60041d6e6acfa3be2196e4d737bd61"}],"openstack/network/v2/port.py":[{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"7a3d40d990c7e323e846cb7321d4e0a4e80b87b8","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    #: users can specify a project ID other than their own."},{"line_number":101,"context_line":"    project_id \u003d resource.Body(\u0027tenant_id\u0027)"},{"line_number":102,"context_line":"    #: The extra DHCP option name."},{"line_number":103,"context_line":"    opt_name \u003d resource.Body(\u0027opt_name\u0027)"},{"line_number":104,"context_line":"    #: The extra DHCP option value."},{"line_number":105,"context_line":"    opt_value \u003d resource.Body(\u0027opt_value\u0027)"},{"line_number":106,"context_line":"    #: The ID of the QoS policy attached to the port."}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_26dc1846","line":103,"updated":"2016-12-07 16:51:03.000000000","message":"How about option_name and option_value here?","commit_id":"b91be123fe60041d6e6acfa3be2196e4d737bd61"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"68e13aba487644e25d0c50299a989916c126909f","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    #: users can specify a project ID other than their own."},{"line_number":101,"context_line":"    project_id \u003d resource.Body(\u0027tenant_id\u0027)"},{"line_number":102,"context_line":"    #: The extra DHCP option name."},{"line_number":103,"context_line":"    opt_name \u003d resource.Body(\u0027opt_name\u0027)"},{"line_number":104,"context_line":"    #: The extra DHCP option value."},{"line_number":105,"context_line":"    opt_value \u003d resource.Body(\u0027opt_value\u0027)"},{"line_number":106,"context_line":"    #: The ID of the QoS policy attached to the port."}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_61c0a8e1","line":103,"in_reply_to":"3a71b18c_26dc1846","updated":"2016-12-08 02:05:21.000000000","message":"good suggestion, will do.","commit_id":"b91be123fe60041d6e6acfa3be2196e4d737bd61"}]}
