)]}'
{"openstack/network/v2/_proxy.py":[{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"63fd90f2e11d1f6431a35083d4256fc1ed16a4ec","unresolved":false,"context_lines":[{"line_number":910,"context_line":"        \"\"\""},{"line_number":911,"context_line":"        return self._update(_flavor.Flavor, flavor, **attrs)"},{"line_number":912,"context_line":""},{"line_number":913,"context_line":"    def associate_flavor(self, flavor):"},{"line_number":914,"context_line":"        \"\"\"Associate network flavor with service profile."},{"line_number":915,"context_line":""},{"line_number":916,"context_line":"        :param flavor:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_4a1f915a","line":913,"updated":"2016-11-28 21:12:37.000000000","message":"This should have the full name of the method, so associate_flavor_with_service_profile. The same goes with the disassociate method.","commit_id":"a256316ee7590b6b943afa56fa985a09d0aaca73"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"947e24f892ec992551706e2b88e82c37ac3b0117","unresolved":false,"context_lines":[{"line_number":910,"context_line":"        \"\"\""},{"line_number":911,"context_line":"        return self._update(_flavor.Flavor, flavor, **attrs)"},{"line_number":912,"context_line":""},{"line_number":913,"context_line":"    def associate_flavor(self, flavor):"},{"line_number":914,"context_line":"        \"\"\"Associate network flavor with service profile."},{"line_number":915,"context_line":""},{"line_number":916,"context_line":"        :param flavor:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_d3c14782","line":913,"in_reply_to":"5a74a57a_4a1f915a","updated":"2016-12-01 20:55:26.000000000","message":"Done","commit_id":"a256316ee7590b6b943afa56fa985a09d0aaca73"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"ff213743643cb9a6775a667cf5223f241f9fcbb6","unresolved":false,"context_lines":[{"line_number":451,"context_line":"        service_profile \u003d self._get_resource("},{"line_number":452,"context_line":"            _service_profile.ServiceProfile, service_profile)"},{"line_number":453,"context_line":"        return flavor.associate_flavor_with_service_profile("},{"line_number":454,"context_line":"            self.session, flavor.id, service_profile.id)"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    def disassociate_flavor_from_service_profile("},{"line_number":457,"context_line":"            self, flavor, service_profile):"}],"source_content_type":"text/x-python","patch_set":10,"id":"da36d5c6_abb0d18c","line":454,"range":{"start_line":454,"start_character":26,"end_line":454,"end_character":35},"updated":"2017-02-20 12:47:21.000000000","message":"Why is flavor.id passed in for these two methods?","commit_id":"4a47f8c75bbdf659546c3c4ef5189916a13cd01f"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"2efb4d2220a1ce28b3a35eb985a20ffde1623b79","unresolved":false,"context_lines":[{"line_number":451,"context_line":"        service_profile \u003d self._get_resource("},{"line_number":452,"context_line":"            _service_profile.ServiceProfile, service_profile)"},{"line_number":453,"context_line":"        return flavor.associate_flavor_with_service_profile("},{"line_number":454,"context_line":"            self.session, flavor.id, service_profile.id)"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    def disassociate_flavor_from_service_profile("},{"line_number":457,"context_line":"            self, flavor, service_profile):"}],"source_content_type":"text/x-python","patch_set":10,"id":"da36d5c6_5d36e452","line":454,"range":{"start_line":454,"start_character":26,"end_line":454,"end_character":35},"in_reply_to":"da36d5c6_abb0d18c","updated":"2017-02-22 16:32:30.000000000","message":"Done. Removed.","commit_id":"4a47f8c75bbdf659546c3c4ef5189916a13cd01f"}],"openstack/network/v2/flavor.py":[{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"63fd90f2e11d1f6431a35083d4256fc1ed16a4ec","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    #: Service type to which the flavor applies"},{"line_number":41,"context_line":"    service_type \u003d resource.prop(\u0027service_type\u0027)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def associate_flavor_to_service_profile(self, session, **body):"},{"line_number":44,"context_line":"        flavor_id \u003d body.get(\u0027flavor_id\u0027)"},{"line_number":45,"context_line":"        url \u003d utils.urljoin(self.base_path, flavor_id, \u0027service_profiles\u0027)"},{"line_number":46,"context_line":"        resp \u003d session.post(url, endpoint_filter\u003dself.service, json\u003dbody)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_0f1beb81","line":43,"updated":"2016-11-28 21:12:37.000000000","message":"This would read more clearly if you switched \"to\" to be \"with\" -- generally you associate things *with* other things, not *to* them.\n\nI\u0027m guessing you may have been following the convention we\u0027ve had elsewhere with add_x_to_y/remove_x_from_y, which is good to see, but I think in this case it\u0027s better for this method to diverge slightly from that so it reads more like a sentence than sticks too rigidly to a guideline.","commit_id":"a256316ee7590b6b943afa56fa985a09d0aaca73"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"947e24f892ec992551706e2b88e82c37ac3b0117","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    #: Service type to which the flavor applies"},{"line_number":41,"context_line":"    service_type \u003d resource.prop(\u0027service_type\u0027)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def associate_flavor_to_service_profile(self, session, **body):"},{"line_number":44,"context_line":"        flavor_id \u003d body.get(\u0027flavor_id\u0027)"},{"line_number":45,"context_line":"        url \u003d utils.urljoin(self.base_path, flavor_id, \u0027service_profiles\u0027)"},{"line_number":46,"context_line":"        resp \u003d session.post(url, endpoint_filter\u003dself.service, json\u003dbody)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_533c5793","line":43,"in_reply_to":"5a74a57a_0f1beb81","updated":"2016-12-01 20:55:26.000000000","message":"Done","commit_id":"a256316ee7590b6b943afa56fa985a09d0aaca73"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"9e94da3651c6e4acb816d1568fdb051e39e9d7cb","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    #: IDs of service profiles associated with this flavor"},{"line_number":44,"context_line":"    service_profile_ids \u003d resource.Body(\u0027service_profiles\u0027)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def associate_flavor_with_service_profile(self, session, **body):"},{"line_number":47,"context_line":"        flavor_id \u003d body.get(\u0027flavor_id\u0027)"},{"line_number":48,"context_line":"        url \u003d utils.urljoin(self.base_path, flavor_id, \u0027service_profiles\u0027)"},{"line_number":49,"context_line":"        body \u003d {\"service_profile\": {\"id\": body.get(\u0027service_profile_id\u0027)}}"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_92c1ad31","line":46,"updated":"2016-12-12 18:13:40.000000000","message":"Rather than take kwargs here you should just add flavor_id\u003dNone and service_profile_id\u003dNone.","commit_id":"5c930264afc6f56242706dadcc0aa199f3d55777"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"cadbdf296dcbd46caf71b7ce7615d5d6203ad28f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    #: IDs of service profiles associated with this flavor"},{"line_number":44,"context_line":"    service_profile_ids \u003d resource.Body(\u0027service_profiles\u0027)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def associate_flavor_with_service_profile(self, session, **body):"},{"line_number":47,"context_line":"        flavor_id \u003d body.get(\u0027flavor_id\u0027)"},{"line_number":48,"context_line":"        url \u003d utils.urljoin(self.base_path, flavor_id, \u0027service_profiles\u0027)"},{"line_number":49,"context_line":"        body \u003d {\"service_profile\": {\"id\": body.get(\u0027service_profile_id\u0027)}}"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_0a9febb4","line":46,"in_reply_to":"1a6eadb0_92c1ad31","updated":"2016-12-13 19:01:18.000000000","message":"Done","commit_id":"5c930264afc6f56242706dadcc0aa199f3d55777"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"ae993be4f446526017b583cfe3d6e0635f41a5b0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    def associate_flavor_with_service_profile("},{"line_number":47,"context_line":"            self, session, flavor_id\u003dNone, service_profile_id\u003dNone):"},{"line_number":48,"context_line":"        url \u003d utils.urljoin(self.base_path, flavor_id, \u0027service_profiles\u0027)"},{"line_number":49,"context_line":"        body \u003d {\"service_profile\": {\"id\": service_profile_id}}"},{"line_number":50,"context_line":"        resp \u003d session.post(url, endpoint_filter\u003dself.service, json\u003dbody)"},{"line_number":51,"context_line":"        return resp.json()"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da36d5c6_e203c3b6","line":49,"updated":"2017-02-20 16:56:50.000000000","message":"Shashank: As per Terry\u0027s comments. you can replace flavor_id\u003dNone and remove from the calling function since you can just get the flavor\u0027s id with \"self.id\"","commit_id":"4a47f8c75bbdf659546c3c4ef5189916a13cd01f"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"2efb4d2220a1ce28b3a35eb985a20ffde1623b79","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    def associate_flavor_with_service_profile("},{"line_number":47,"context_line":"            self, session, flavor_id\u003dNone, service_profile_id\u003dNone):"},{"line_number":48,"context_line":"        url \u003d utils.urljoin(self.base_path, flavor_id, \u0027service_profiles\u0027)"},{"line_number":49,"context_line":"        body \u003d {\"service_profile\": {\"id\": service_profile_id}}"},{"line_number":50,"context_line":"        resp \u003d session.post(url, endpoint_filter\u003dself.service, json\u003dbody)"},{"line_number":51,"context_line":"        return resp.json()"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da36d5c6_bd3b6037","line":49,"in_reply_to":"da36d5c6_e203c3b6","updated":"2017-02-22 16:32:30.000000000","message":"Done","commit_id":"4a47f8c75bbdf659546c3c4ef5189916a13cd01f"}],"openstack/tests/functional/network/v2/test_flavor.py":[{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"063bc7169c20d0ed06a1ab867349ba1ca5060e48","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        response \u003d \\"},{"line_number":73,"context_line":"            self.conn.network.associate_flavor_with_service_profile("},{"line_number":74,"context_line":"                self.ID, self.service_profiles.id)"},{"line_number":75,"context_line":"        self.assertIsNotNone(response)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_disassociate_flavor_from_service_profile(self):"},{"line_number":78,"context_line":"        response \u003d \\"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_bfb8572b","line":75,"updated":"2016-12-06 22:04:58.000000000","message":"Is there any way to do a check to see if it actually attached?","commit_id":"0573dd2046ad14064a9e3c7c5c3206be19bcae63"}],"openstack/tests/unit/network/v2/test_flavor.py":[{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"eb3b12e06e1db3f0074d0fece62cc2f3be888f91","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.assertEqual(EXAMPLE_WITH_OPTIONAL[\u0027enabled\u0027], flavors.is_enabled)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_associate_flavor_with_service_profile(self):"},{"line_number":62,"context_line":"        pass"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def test_disassociate_flavor_from_service_profile(self):"},{"line_number":65,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_335efbe9","line":62,"updated":"2016-12-01 20:55:31.000000000","message":"Work in progress.","commit_id":"46ea3425ead636167176f752467c3ad7e98dc919"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"063bc7169c20d0ed06a1ab867349ba1ca5060e48","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    \u0027service_type\u0027: \u0027VPN\u0027,"},{"line_number":22,"context_line":"    \u0027tenant_id\u0027: \u00275\u0027,"},{"line_number":23,"context_line":"    \u0027description\u0027: \u0027VPN flavor\u0027,"},{"line_number":24,"context_line":"    \u0027enabled\u0027: True,"},{"line_number":25,"context_line":"}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"EXAMPLE \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_8a443b4a","line":24,"updated":"2016-12-06 22:04:58.000000000","message":"\u0027id\u0027: IDENTIFIER and ditto for EXAMPLE","commit_id":"0573dd2046ad14064a9e3c7c5c3206be19bcae63"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"063bc7169c20d0ed06a1ab867349ba1ca5060e48","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        response \u003d mock.Mock()"},{"line_number":65,"context_line":"        response.body \u003d {\u0027service-profile\u0027: {\u0027id\u0027: \u00271\u0027}}"},{"line_number":66,"context_line":"        response.json \u003d mock.Mock(return_value\u003dresponse.body)"},{"line_number":67,"context_line":"        sess \u003d mock.Mock()"},{"line_number":68,"context_line":"        sess.post \u003d mock.Mock(return_value\u003dresponse)"},{"line_number":69,"context_line":"        body \u003d {\u0027service-profile\u0027: {\u0027id\u0027: \u00271\u0027}}"},{"line_number":70,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_aa94978a","line":67,"updated":"2016-12-06 22:04:58.000000000","message":"I think the structure of this is wrong based on --debug mode on API call. \n\nthe first body sent is {serv_prof {\u0027id\u0027: \u003cservice-profile-id\u003e}}  then the response body is {\u0027service_profile\u0027 {\u0027id\u0027: \u003cflavor-id\u003e}}","commit_id":"0573dd2046ad14064a9e3c7c5c3206be19bcae63"}]}