)]}'
{"tox.ini":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"6391a95db98c34a2056f690acb9d91e4ed00f573","unresolved":false,"context_lines":[{"line_number":8,"context_line":"install_command \u003d {toxinidir}/tools/tox_install.sh {env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages}"},{"line_number":9,"context_line":"setenv \u003d"},{"line_number":10,"context_line":"   VIRTUAL_ENV\u003d{envdir}"},{"line_number":11,"context_line":"   BRANCH_NAME\u003dmaster"},{"line_number":12,"context_line":"   CLIENT_NAME\u003dopenstacksdk"},{"line_number":13,"context_line":"deps \u003d -r{toxinidir}/test-requirements.txt"},{"line_number":14,"context_line":"commands \u003d ostestr {posargs}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3a461143_f10cf3ed","line":11,"range":{"start_line":11,"start_character":3,"end_line":11,"end_character":21},"updated":"2017-01-30 15:50:37.000000000","message":"This is the oddest part of this change to me, having the branch name here.  I\u0027ve been out of the loop lately though.","commit_id":"94326bfcca74592c25daf5503c66b733cd4f5331"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2702c4b7e6c0858b7ddc37c8edd46c9a25f8ea36","unresolved":false,"context_lines":[{"line_number":8,"context_line":"install_command \u003d {toxinidir}/tools/tox_install.sh {env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages}"},{"line_number":9,"context_line":"setenv \u003d"},{"line_number":10,"context_line":"   VIRTUAL_ENV\u003d{envdir}"},{"line_number":11,"context_line":"   BRANCH_NAME\u003dmaster"},{"line_number":12,"context_line":"   CLIENT_NAME\u003dopenstacksdk"},{"line_number":13,"context_line":"deps \u003d -r{toxinidir}/test-requirements.txt"},{"line_number":14,"context_line":"commands \u003d ostestr {posargs}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"5ff73747_cf07c018","line":11,"range":{"start_line":11,"start_character":3,"end_line":11,"end_character":21},"in_reply_to":"3a461143_b7adea9c","updated":"2017-05-03 15:27:53.000000000","message":"BRANCH_NAME here looks unnecessary.\n\nWe usually use BRNACH_NAME in tox_install.sh but the current version of tox_install.sh contains no BRANCH_NAME.","commit_id":"94326bfcca74592c25daf5503c66b733cd4f5331"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"511cb850419b5e9935dc57a2d1989a49d6661731","unresolved":false,"context_lines":[{"line_number":8,"context_line":"install_command \u003d {toxinidir}/tools/tox_install.sh {env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages}"},{"line_number":9,"context_line":"setenv \u003d"},{"line_number":10,"context_line":"   VIRTUAL_ENV\u003d{envdir}"},{"line_number":11,"context_line":"   BRANCH_NAME\u003dmaster"},{"line_number":12,"context_line":"   CLIENT_NAME\u003dopenstacksdk"},{"line_number":13,"context_line":"deps \u003d -r{toxinidir}/test-requirements.txt"},{"line_number":14,"context_line":"commands \u003d ostestr {posargs}"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3a461143_b7adea9c","line":11,"range":{"start_line":11,"start_character":3,"end_line":11,"end_character":21},"in_reply_to":"3a461143_f10cf3ed","updated":"2017-01-31 01:36:05.000000000","message":"The aim is to get tools/tox_install.sh to the point where it can be identical in *every* repo[1].  So yes you\u0027re right that BRANCH_NAME is a little strange here and could have been added later when needed I wasn\u0027t smart enough to do that so we end up with an unused environment variable in tox.\n\n\n[1] This may be a pipe dream","commit_id":"94326bfcca74592c25daf5503c66b733cd4f5331"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"75dfb448b8cc79e194a895d016b1ddacffb412c5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"passenv \u003d OS_*"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[functionalbase]"},{"line_number":22,"context_line":"# Note(tonyb): VIRTUAL_ENV/BRANCH_NAME/CLIENT_NAME need to be duplicated here"},{"line_number":23,"context_line":"# as nested expansions don\u0027t work :("},{"line_number":24,"context_line":"setenv \u003d"},{"line_number":25,"context_line":"    VIRTUAL_ENV\u003d{envdir}"}],"source_content_type":"text/x-properties","patch_set":3,"id":"3f044301_52601933","line":22,"range":{"start_line":22,"start_character":27,"end_line":22,"end_character":39},"updated":"2017-05-04 06:22:50.000000000","message":"unnecessary too","commit_id":"702e3c6b58b512bfb6618521762d785cf3eb52ea"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"75dfb448b8cc79e194a895d016b1ddacffb412c5","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# as nested expansions don\u0027t work :("},{"line_number":24,"context_line":"setenv \u003d"},{"line_number":25,"context_line":"    VIRTUAL_ENV\u003d{envdir}"},{"line_number":26,"context_line":"    BRANCH_NAME\u003dmaster"},{"line_number":27,"context_line":"    CLIENT_NAME\u003dopenstacksdk"},{"line_number":28,"context_line":"    OS_TEST_PATH\u003d./openstack/tests/functional"},{"line_number":29,"context_line":"passenv \u003d OS_*"}],"source_content_type":"text/x-properties","patch_set":3,"id":"3f044301_d272e911","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":22},"updated":"2017-05-04 06:22:50.000000000","message":"This is unnecessary too....","commit_id":"702e3c6b58b512bfb6618521762d785cf3eb52ea"}]}