)]}'
{"openstack/workflow/v2/_proxy.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"35f776851d199f52113be253dee4eea74bf358be","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        return self._find(_execution.Execution, name_or_id,"},{"line_number":169,"context_line":"                          ignore_missing\u003dignore_missing)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def wait_for_execution(self, execution, status\u003d\u0027SUCCESS\u0027,"},{"line_number":172,"context_line":"                           failures\u003d[\u0027ERROR\u0027], interval\u003d2, wait\u003d120):"},{"line_number":173,"context_line":"        return resource2.wait_for_status(self.session, execution, status,"},{"line_number":174,"context_line":"                                         failures, interval, wait)"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a3c09a3_28e3c906","line":174,"range":{"start_line":171,"start_character":0,"end_line":174,"end_character":66},"updated":"2017-01-16 01:50:13.000000000","message":"suppose you have created an Execution resource my_exc, you can directly invoke \u0027my_exc.wait_for_status()\u0027, right?","commit_id":"021d4252b9ded0f1e95634fd5386ba0218762c5d"},{"author":{"_account_id":15857,"name":"Xinhui Li","email":"lxinhui@vmware.com","username":"Cindia-blue"},"change_message_id":"01e438b6a424c5eff26530e102f79e52b0eaa516","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        return self._find(_execution.Execution, name_or_id,"},{"line_number":169,"context_line":"                          ignore_missing\u003dignore_missing)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def wait_for_execution(self, execution, status\u003d\u0027SUCCESS\u0027,"},{"line_number":172,"context_line":"                           failures\u003d[\u0027ERROR\u0027], interval\u003d2, wait\u003d120):"},{"line_number":173,"context_line":"        return resource2.wait_for_status(self.session, execution, status,"},{"line_number":174,"context_line":"                                         failures, interval, wait)"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a3c09a3_03cfce7f","line":174,"range":{"start_line":171,"start_character":0,"end_line":174,"end_character":66},"in_reply_to":"7a3c09a3_28e3c906","updated":"2017-01-16 02:42:02.000000000","message":"Yes, thx. Done","commit_id":"021d4252b9ded0f1e95634fd5386ba0218762c5d"}],"openstack/workflow/v2/execution.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"20cbf51249cbf8fc84e0b2e4f508bdbf8f428344","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    allow_get \u003d True"},{"line_number":27,"context_line":"    allow_delete \u003d True"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    marker \u003d resource.Body(\"marker\")"},{"line_number":30,"context_line":"    limit \u003d resource.Body(\"limit\")"},{"line_number":31,"context_line":"    sort_keys \u003d resource.Body(\"sort_keys\")"},{"line_number":32,"context_line":"    sort_dirs \u003d resource.Body(\"sort_dirs\")"},{"line_number":33,"context_line":"    fields \u003d resource.Body(\"fields\")"},{"line_number":34,"context_line":"    workflow_name \u003d resource.Body(\"workflow_name\")"},{"line_number":35,"context_line":"    workflow_id \u003d resource.Body(\"workflow_id\")"},{"line_number":36,"context_line":"    description \u003d resource.Body(\"description\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_302dc6fe","line":33,"range":{"start_line":29,"start_character":0,"end_line":33,"end_character":36},"updated":"2016-12-26 14:17:35.000000000","message":"I think these should be query parameters instead of properties in body","commit_id":"fb7633f53a3b64d0cc07927d89208db412202de7"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"6f8a887565abd0b1bafe4f75011ec7b1522c24b9","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    allow_get \u003d True"},{"line_number":27,"context_line":"    allow_delete \u003d True"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    marker \u003d resource.Body(\"marker\")"},{"line_number":30,"context_line":"    limit \u003d resource.Body(\"limit\")"},{"line_number":31,"context_line":"    sort_keys \u003d resource.Body(\"sort_keys\")"},{"line_number":32,"context_line":"    sort_dirs \u003d resource.Body(\"sort_dirs\")"},{"line_number":33,"context_line":"    fields \u003d resource.Body(\"fields\")"},{"line_number":34,"context_line":"    workflow_name \u003d resource.Body(\"workflow_name\")"},{"line_number":35,"context_line":"    workflow_id \u003d resource.Body(\"workflow_id\")"},{"line_number":36,"context_line":"    description \u003d resource.Body(\"description\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_75b812c9","line":33,"range":{"start_line":29,"start_character":0,"end_line":33,"end_character":36},"in_reply_to":"da4df55a_2f1638f1","updated":"2016-12-27 05:12:28.000000000","message":"Yes, I have checked the doc. For executions, the \u0027marker\u0027, \u0027limit\u0027, \u0027sort_keys\u0027, etc are all \"parameters\". They are not part of the response body, I believe. The usage of these parameters are completely different from the properties of objects. For example,\n\n  GET /v2/executions?limit\u003d10\u0026sort_keys\u003d...\n\nThe other fields, such as \u0027workflow_name\u0027, \u0027state\u0027 etc are part for the response body:\n\n  {\n     \"workflow_name\": \"blah\",\n     \"state\": \"...\"\n  }\n\nNow you see the difference?\n\nThe \u0027limit\u0027, \u0027marker\u0027 ... parameters are not part of the resource body, so they are not supposed to be defined as \u0027resource.Body()\u0027.","commit_id":"fb7633f53a3b64d0cc07927d89208db412202de7"},{"author":{"_account_id":15857,"name":"Xinhui Li","email":"lxinhui@vmware.com","username":"Cindia-blue"},"change_message_id":"52ed7ee411511938ed0bdd3d12aef8e79caa5b65","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    allow_get \u003d True"},{"line_number":27,"context_line":"    allow_delete \u003d True"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    marker \u003d resource.Body(\"marker\")"},{"line_number":30,"context_line":"    limit \u003d resource.Body(\"limit\")"},{"line_number":31,"context_line":"    sort_keys \u003d resource.Body(\"sort_keys\")"},{"line_number":32,"context_line":"    sort_dirs \u003d resource.Body(\"sort_dirs\")"},{"line_number":33,"context_line":"    fields \u003d resource.Body(\"fields\")"},{"line_number":34,"context_line":"    workflow_name \u003d resource.Body(\"workflow_name\")"},{"line_number":35,"context_line":"    workflow_id \u003d resource.Body(\"workflow_id\")"},{"line_number":36,"context_line":"    description \u003d resource.Body(\"description\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_2f1638f1","line":33,"range":{"start_line":29,"start_character":0,"end_line":33,"end_character":36},"in_reply_to":"da4df55a_302dc6fe","updated":"2016-12-27 01:17:15.000000000","message":"please refer to http://docs.openstack.org/developer/mistral/developer/webapi/v2.html#actions\n\nThanks.","commit_id":"fb7633f53a3b64d0cc07927d89208db412202de7"},{"author":{"_account_id":15857,"name":"Xinhui Li","email":"lxinhui@vmware.com","username":"Cindia-blue"},"change_message_id":"bf9da4c59b71b734b58e9c6f533e964ab52f07a2","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    allow_get \u003d True"},{"line_number":27,"context_line":"    allow_delete \u003d True"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    marker \u003d resource.Body(\"marker\")"},{"line_number":30,"context_line":"    limit \u003d resource.Body(\"limit\")"},{"line_number":31,"context_line":"    sort_keys \u003d resource.Body(\"sort_keys\")"},{"line_number":32,"context_line":"    sort_dirs \u003d resource.Body(\"sort_dirs\")"},{"line_number":33,"context_line":"    fields \u003d resource.Body(\"fields\")"},{"line_number":34,"context_line":"    workflow_name \u003d resource.Body(\"workflow_name\")"},{"line_number":35,"context_line":"    workflow_id \u003d resource.Body(\"workflow_id\")"},{"line_number":36,"context_line":"    description \u003d resource.Body(\"description\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_d85ad329","line":33,"range":{"start_line":29,"start_character":0,"end_line":33,"end_character":36},"in_reply_to":"da4df55a_75b812c9","updated":"2016-12-27 05:54:48.000000000","message":"Done","commit_id":"fb7633f53a3b64d0cc07927d89208db412202de7"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"20cbf51249cbf8fc84e0b2e4f508bdbf8f428344","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    workflow_name \u003d resource.Body(\"workflow_name\")"},{"line_number":35,"context_line":"    workflow_id \u003d resource.Body(\"workflow_id\")"},{"line_number":36,"context_line":"    description \u003d resource.Body(\"description\")"},{"line_number":37,"context_line":"    params \u003d resource.Body(\"params\")"},{"line_number":38,"context_line":"    task_execution_id \u003d resource.Body(\"task_execution_id\")"},{"line_number":39,"context_line":"    state \u003d resource.Body(\"state\")"},{"line_number":40,"context_line":"    state_info \u003d resource.Body(\"state_info\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_b6b1ae49","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":10},"updated":"2016-12-26 14:17:35.000000000","message":"this is only a query parameter?","commit_id":"fb7633f53a3b64d0cc07927d89208db412202de7"},{"author":{"_account_id":15857,"name":"Xinhui Li","email":"lxinhui@vmware.com","username":"Cindia-blue"},"change_message_id":"52ed7ee411511938ed0bdd3d12aef8e79caa5b65","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    workflow_name \u003d resource.Body(\"workflow_name\")"},{"line_number":35,"context_line":"    workflow_id \u003d resource.Body(\"workflow_id\")"},{"line_number":36,"context_line":"    description \u003d resource.Body(\"description\")"},{"line_number":37,"context_line":"    params \u003d resource.Body(\"params\")"},{"line_number":38,"context_line":"    task_execution_id \u003d resource.Body(\"task_execution_id\")"},{"line_number":39,"context_line":"    state \u003d resource.Body(\"state\")"},{"line_number":40,"context_line":"    state_info \u003d resource.Body(\"state_info\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_6fda004e","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":10},"in_reply_to":"da4df55a_b6b1ae49","updated":"2016-12-27 01:17:15.000000000","message":"Used to keep only resources with specific parameters.","commit_id":"fb7633f53a3b64d0cc07927d89208db412202de7"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"20cbf51249cbf8fc84e0b2e4f508bdbf8f428344","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    output \u003d resource.Body(\"output\")"},{"line_number":43,"context_line":"    created_at \u003d resource.Body(\"created_at\")"},{"line_number":44,"context_line":"    updated_at \u003d resource.Body(\"updated_at\")"},{"line_number":45,"context_line":"    include_output \u003d resource.Body(\"include_output\")"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def create(self, session, prepend_key\u003dTrue):"},{"line_number":48,"context_line":"        request \u003d self._prepare_request(requires_id\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_b66a8eb1","line":45,"range":{"start_line":45,"start_character":4,"end_line":45,"end_character":18},"updated":"2016-12-26 14:17:35.000000000","message":"This is also a query string?","commit_id":"fb7633f53a3b64d0cc07927d89208db412202de7"},{"author":{"_account_id":15857,"name":"Xinhui Li","email":"lxinhui@vmware.com","username":"Cindia-blue"},"change_message_id":"52ed7ee411511938ed0bdd3d12aef8e79caa5b65","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    output \u003d resource.Body(\"output\")"},{"line_number":43,"context_line":"    created_at \u003d resource.Body(\"created_at\")"},{"line_number":44,"context_line":"    updated_at \u003d resource.Body(\"updated_at\")"},{"line_number":45,"context_line":"    include_output \u003d resource.Body(\"include_output\")"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def create(self, session, prepend_key\u003dTrue):"},{"line_number":48,"context_line":"        request \u003d self._prepare_request(requires_id\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_8fdba44e","line":45,"range":{"start_line":45,"start_character":4,"end_line":45,"end_character":18},"in_reply_to":"da4df55a_b66a8eb1","updated":"2016-12-27 01:17:15.000000000","message":"Used to include the output for all executions in the list.","commit_id":"fb7633f53a3b64d0cc07927d89208db412202de7"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"9ba50af20d1dd299c6633029bb752185e8fcff2a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        \u0027marker\u0027, \u0027limit\u0027, \u0027sort_keys\u0027, \u0027sort_dirs\u0027, \u0027fields\u0027, \u0027params\u0027,"},{"line_number":31,"context_line":"        \u0027include_output\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    marker \u003d resource.Body(\"marker\")"},{"line_number":34,"context_line":"    limit \u003d resource.Body(\"limit\")"},{"line_number":35,"context_line":"    sort_keys \u003d resource.Body(\"sort_keys\")"},{"line_number":36,"context_line":"    sort_dirs \u003d resource.Body(\"sort_dirs\")"},{"line_number":37,"context_line":"    fields \u003d resource.Body(\"fields\")"},{"line_number":38,"context_line":"    include_output \u003d resource.Body(\"include_output\")"},{"line_number":39,"context_line":"    workflow_name \u003d resource.Body(\"workflow_name\")"},{"line_number":40,"context_line":"    workflow_id \u003d resource.Body(\"workflow_id\")"},{"line_number":41,"context_line":"    description \u003d resource.Body(\"description\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba5201f7_db7b58f3","line":38,"range":{"start_line":33,"start_character":0,"end_line":38,"end_character":52},"updated":"2017-01-07 11:52:29.000000000","message":"all these \u0027properties\u0027 are not real properties contained in the response body. They are all query strings as listed in line 29.","commit_id":"33fc8b297ee4dc782dee2e9471cee73f929945de"}],"openstack/workflow/v2/workflow.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"20cbf51249cbf8fc84e0b2e4f508bdbf8f428344","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class Workflow(resource.Resource):"},{"line_number":18,"context_line":"    resource_key \u003d \u0027workflow\u0027"},{"line_number":19,"context_line":"    resources_key \u003d \u0027workflows\u0027"},{"line_number":20,"context_line":"    base_path \u003d \u0027/workflows\u0027"},{"line_number":21,"context_line":"    service \u003d workflow_service.WorkflowService()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_d6955287","line":18,"range":{"start_line":18,"start_character":4,"end_line":18,"end_character":16},"updated":"2016-12-26 14:17:35.000000000","message":"does it really have a resource_key?","commit_id":"fb7633f53a3b64d0cc07927d89208db412202de7"},{"author":{"_account_id":15857,"name":"Xinhui Li","email":"lxinhui@vmware.com","username":"Cindia-blue"},"change_message_id":"52ed7ee411511938ed0bdd3d12aef8e79caa5b65","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class Workflow(resource.Resource):"},{"line_number":18,"context_line":"    resource_key \u003d \u0027workflow\u0027"},{"line_number":19,"context_line":"    resources_key \u003d \u0027workflows\u0027"},{"line_number":20,"context_line":"    base_path \u003d \u0027/workflows\u0027"},{"line_number":21,"context_line":"    service \u003d workflow_service.WorkflowService()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_0ff094c8","line":18,"range":{"start_line":18,"start_character":4,"end_line":18,"end_character":16},"in_reply_to":"da4df55a_d6955287","updated":"2016-12-27 01:17:15.000000000","message":"Yes.","commit_id":"fb7633f53a3b64d0cc07927d89208db412202de7"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"20cbf51249cbf8fc84e0b2e4f508bdbf8f428344","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    allow_get \u003d True"},{"line_number":27,"context_line":"    allow_delete \u003d True"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    marker \u003d resource.Body(\"marker\")"},{"line_number":30,"context_line":"    limit \u003d resource.Body(\"limit\")"},{"line_number":31,"context_line":"    sort_keys \u003d resource.Body(\"sort_keys\")"},{"line_number":32,"context_line":"    sort_dirs \u003d resource.Body(\"sort_dirs\")"},{"line_number":33,"context_line":"    fields \u003d resource.Body(\"fields\")"},{"line_number":34,"context_line":"    name \u003d resource.Body(\"name\")"},{"line_number":35,"context_line":"    input \u003d resource.Body(\"input\")"},{"line_number":36,"context_line":"    definition \u003d resource.Body(\"definition\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_b698cec1","line":33,"range":{"start_line":29,"start_character":0,"end_line":33,"end_character":36},"updated":"2016-12-26 14:17:35.000000000","message":"these are query parameters","commit_id":"fb7633f53a3b64d0cc07927d89208db412202de7"},{"author":{"_account_id":15857,"name":"Xinhui Li","email":"lxinhui@vmware.com","username":"Cindia-blue"},"change_message_id":"52ed7ee411511938ed0bdd3d12aef8e79caa5b65","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    allow_get \u003d True"},{"line_number":27,"context_line":"    allow_delete \u003d True"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    marker \u003d resource.Body(\"marker\")"},{"line_number":30,"context_line":"    limit \u003d resource.Body(\"limit\")"},{"line_number":31,"context_line":"    sort_keys \u003d resource.Body(\"sort_keys\")"},{"line_number":32,"context_line":"    sort_dirs \u003d resource.Body(\"sort_dirs\")"},{"line_number":33,"context_line":"    fields \u003d resource.Body(\"fields\")"},{"line_number":34,"context_line":"    name \u003d resource.Body(\"name\")"},{"line_number":35,"context_line":"    input \u003d resource.Body(\"input\")"},{"line_number":36,"context_line":"    definition \u003d resource.Body(\"definition\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_2fed58ef","line":33,"range":{"start_line":29,"start_character":0,"end_line":33,"end_character":36},"in_reply_to":"da4df55a_b698cec1","updated":"2016-12-27 01:17:15.000000000","message":"Ditto","commit_id":"fb7633f53a3b64d0cc07927d89208db412202de7"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"20cbf51249cbf8fc84e0b2e4f508bdbf8f428344","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            \"data\": request.body[\"workflow\"][\"definition\"]"},{"line_number":52,"context_line":"        }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        scope \u003d \"?scope\u003d%s\" % request.body[\"workflow\"][\"scope\"]"},{"line_number":55,"context_line":"        uri \u003d request.uri + scope"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        request.headers.update(headers)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_76c826a9","line":54,"range":{"start_line":54,"start_character":56,"end_line":54,"end_character":61},"updated":"2016-12-26 14:17:35.000000000","message":"the scope has to be specified?","commit_id":"fb7633f53a3b64d0cc07927d89208db412202de7"},{"author":{"_account_id":15857,"name":"Xinhui Li","email":"lxinhui@vmware.com","username":"Cindia-blue"},"change_message_id":"52ed7ee411511938ed0bdd3d12aef8e79caa5b65","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            \"data\": request.body[\"workflow\"][\"definition\"]"},{"line_number":52,"context_line":"        }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        scope \u003d \"?scope\u003d%s\" % request.body[\"workflow\"][\"scope\"]"},{"line_number":55,"context_line":"        uri \u003d request.uri + scope"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        request.headers.update(headers)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_cfd04c22","line":54,"range":{"start_line":54,"start_character":56,"end_line":54,"end_character":61},"in_reply_to":"da4df55a_76c826a9","updated":"2016-12-27 01:17:15.000000000","message":"Yes. It is enum - public or private.","commit_id":"fb7633f53a3b64d0cc07927d89208db412202de7"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"9ba50af20d1dd299c6633029bb752185e8fcff2a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    _query_mapping \u003d resource.QueryParameters("},{"line_number":30,"context_line":"        \u0027marker\u0027, \u0027limit\u0027, \u0027sort_keys\u0027, \u0027sort_dirs\u0027, \u0027fields\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    marker \u003d resource.Body(\"marker\")"},{"line_number":33,"context_line":"    limit \u003d resource.Body(\"limit\")"},{"line_number":34,"context_line":"    sort_keys \u003d resource.Body(\"sort_keys\")"},{"line_number":35,"context_line":"    sort_dirs \u003d resource.Body(\"sort_dirs\")"},{"line_number":36,"context_line":"    fields \u003d resource.Body(\"fields\")"},{"line_number":37,"context_line":"    name \u003d resource.Body(\"name\")"},{"line_number":38,"context_line":"    input \u003d resource.Body(\"input\")"},{"line_number":39,"context_line":"    definition \u003d resource.Body(\"definition\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba5201f7_fb7e5ce2","line":36,"range":{"start_line":32,"start_character":0,"end_line":36,"end_character":36},"updated":"2017-01-07 11:52:29.000000000","message":"None of these are properties contained in the response BODY, and none of them are attributes needed for workflow creation.","commit_id":"33fc8b297ee4dc782dee2e9471cee73f929945de"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"3d9c0c5ee06b87f026ccdb9e0a8f3573ba7169ab","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            \"Content-Type\": \u0027text/plain\u0027"},{"line_number":47,"context_line":"        }"},{"line_number":48,"context_line":"        kwargs \u003d {"},{"line_number":49,"context_line":"            \"data\": request.body[\"workflow\"][\"definition\"]"},{"line_number":50,"context_line":"        }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        scope \u003d \"?scope\u003d%s\" % request.body[\"workflow\"][\"scope\"]"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5201f7_0d5bc62f","line":49,"updated":"2017-01-09 13:12:33.000000000","message":"This should just use self.definition instead of working through the prepared body contents. The same would go for line 52 where you look through it to find the scope, which could be self.scope.\n\nOr am I missing something with why that was being done?","commit_id":"a4925dc50bbd3fa4fc30159de8957e9663e4f3cf"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"09bbc08b53080ba057fbdb13dc89eeae1d9f2a49","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            \"Content-Type\": \u0027text/plain\u0027"},{"line_number":47,"context_line":"        }"},{"line_number":48,"context_line":"        kwargs \u003d {"},{"line_number":49,"context_line":"            \"data\": request.body[\"workflow\"][\"definition\"]"},{"line_number":50,"context_line":"        }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        scope \u003d \"?scope\u003d%s\" % request.body[\"workflow\"][\"scope\"]"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a57fde8_915fcf0d","line":49,"in_reply_to":"9a57fde8_1b493e8c","updated":"2017-01-12 11:49:01.000000000","message":"replace line 49 with the following line will make any difference?\n\n  \"data\": self.definition,","commit_id":"a4925dc50bbd3fa4fc30159de8957e9663e4f3cf"},{"author":{"_account_id":15857,"name":"Xinhui Li","email":"lxinhui@vmware.com","username":"Cindia-blue"},"change_message_id":"8d6ac528ee5f61332dc688c4618a503766db186b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            \"Content-Type\": \u0027text/plain\u0027"},{"line_number":47,"context_line":"        }"},{"line_number":48,"context_line":"        kwargs \u003d {"},{"line_number":49,"context_line":"            \"data\": request.body[\"workflow\"][\"definition\"]"},{"line_number":50,"context_line":"        }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        scope \u003d \"?scope\u003d%s\" % request.body[\"workflow\"][\"scope\"]"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a57fde8_6c2292bb","line":49,"in_reply_to":"9a57fde8_915fcf0d","updated":"2017-01-12 12:25:24.000000000","message":"Thanks, Brian and Qiming, for having my head screwed on the right way.","commit_id":"a4925dc50bbd3fa4fc30159de8957e9663e4f3cf"},{"author":{"_account_id":15857,"name":"Xinhui Li","email":"lxinhui@vmware.com","username":"Cindia-blue"},"change_message_id":"10bf741ea37c45326299e8a91f6545f866bdc552","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            \"Content-Type\": \u0027text/plain\u0027"},{"line_number":47,"context_line":"        }"},{"line_number":48,"context_line":"        kwargs \u003d {"},{"line_number":49,"context_line":"            \"data\": request.body[\"workflow\"][\"definition\"]"},{"line_number":50,"context_line":"        }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        scope \u003d \"?scope\u003d%s\" % request.body[\"workflow\"][\"scope\"]"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a57fde8_1b493e8c","line":49,"in_reply_to":"ba5201f7_0d5bc62f","updated":"2017-01-12 11:27:25.000000000","message":"The reason why we need to construct this way is because mistral today does not accept definition in the default json style. So we use data in kwargs to transfer the definition. The scope usage of mistral is also different. It asked for the scope to be put into the part of uri. We have tested through this on our test bed.","commit_id":"a4925dc50bbd3fa4fc30159de8957e9663e4f3cf"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"09bbc08b53080ba057fbdb13dc89eeae1d9f2a49","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            \"data\": request.body[\"workflow\"][\"definition\"]"},{"line_number":50,"context_line":"        }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        scope \u003d \"?scope\u003d%s\" % request.body[\"workflow\"][\"scope\"]"},{"line_number":53,"context_line":"        uri \u003d request.uri + scope"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        request.headers.update(headers)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a57fde8_91b6ef3b","line":52,"range":{"start_line":52,"start_character":30,"end_line":52,"end_character":63},"updated":"2017-01-12 11:49:01.000000000","message":"similarly, replace this with \"request.scope\"?","commit_id":"a4925dc50bbd3fa4fc30159de8957e9663e4f3cf"}]}
