)]}'
{"openstack/network/v2/quota.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ade209c4e59c1335b221b28e13d0db9f91246185","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    #: The maximum amount of security groups you can create. *Type: int*"},{"line_number":60,"context_line":"    security_groups \u003d resource.Body(\u0027security_group\u0027, type\u003dint)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _prepare_request(self, requires_id\u003dTrue, prepend_key\u003dFalse):"},{"line_number":63,"context_line":"        \"\"\"Overrides the _prepare_request function of resource2.Resource"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        Quota objects have a different behavior than the normal Neutron"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_341a316f","line":62,"updated":"2017-01-16 12:18:49.000000000","message":"A unit and/or functional test would be nice to verify this fix.","commit_id":"64bcbbe2cf5debd722f69e3f7a8ad5d8a4b5ab6c"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"74e25f66e76cd7955b471fff31391c060996a791","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        uri \u003d self.base_path % self._uri.attributes"},{"line_number":83,"context_line":"        uri \u003d utils.urljoin(uri, self._get_id(self))"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        return resource._Request(uri, body, headers)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class QuotaDefault(Quota):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_62f7628b","line":85,"updated":"2017-01-17 11:43:46.000000000","message":"The most part of code is duplicate with the super class, so I think we can use it, like this:\n\n        _request \u003d super(Quota, self)._prepare_request(requires_id,\n                                                       prepend_key)\n        if \u0027id\u0027 in _request.body:\n            del _request.body[\u0027id\u0027]\n        return _request\n\nThen you don\u0027t have to modify it in your DefaultQuota patch\n\nhttps://review.openstack.org/#/c/420301/","commit_id":"64bcbbe2cf5debd722f69e3f7a8ad5d8a4b5ab6c"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"acd179ceb7c3d349f8c19f16785cf4dfac0767fe","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        uri \u003d self.base_path % self._uri.attributes"},{"line_number":83,"context_line":"        uri \u003d utils.urljoin(uri, self._get_id(self))"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        return resource._Request(uri, body, headers)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class QuotaDefault(Quota):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_cb9e0ab8","line":85,"in_reply_to":"7a3c09a3_3950fd31","updated":"2017-01-18 20:34:37.000000000","message":"Where does it add in the project ID? I\u0027m not seeing this and the docstring doesn\u0027t mention this either in the description of what\u0027s happening.","commit_id":"64bcbbe2cf5debd722f69e3f7a8ad5d8a4b5ab6c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"cceadbc91205fa7e68c81b2ad4d54de8cfc1d059","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        uri \u003d self.base_path % self._uri.attributes"},{"line_number":83,"context_line":"        uri \u003d utils.urljoin(uri, self._get_id(self))"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        return resource._Request(uri, body, headers)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class QuotaDefault(Quota):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_3950fd31","line":85,"in_reply_to":"7a3c09a3_62f7628b","updated":"2017-01-18 07:42:16.000000000","message":"This is similar but has slight difference from the base class\u0027s prepare_request.\nI would like to keep this function as it is, as its not just popping out the ID, but also adding the Project ID in the URI, when requires_id is true","commit_id":"64bcbbe2cf5debd722f69e3f7a8ad5d8a4b5ab6c"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"1285526936f37cdad3358d4852255f337e76b3fe","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        uri \u003d self.base_path % self._uri.attributes"},{"line_number":83,"context_line":"        uri \u003d utils.urljoin(uri, self._get_id(self))"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        return resource._Request(uri, body, headers)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class QuotaDefault(Quota):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_b6498cb9","line":85,"in_reply_to":"7a3c09a3_62f7628b","updated":"2017-01-17 12:45:33.000000000","message":"Yep, agreed with this. Since it just seems to be popping out the ID from body, this would be a good solution.","commit_id":"64bcbbe2cf5debd722f69e3f7a8ad5d8a4b5ab6c"}]}
