)]}'
{"openstack/network/v2/_proxy.py":[{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"6803006d23dde07bed0c8ec34f057dce384baf11","unresolved":false,"context_lines":[{"line_number":1995,"context_line":"                 when no resource can be found."},{"line_number":1996,"context_line":"        \"\"\""},{"line_number":1997,"context_line":"        quota_obj \u003d self._get_resource(_quota.Quota, quota)"},{"line_number":1998,"context_line":"        return self._get(_quota.QuotaDefault, project\u003dquota_obj.project_id)"},{"line_number":1999,"context_line":""},{"line_number":2000,"context_line":"    def quotas(self, **query):"},{"line_number":2001,"context_line":"        \"\"\"Return a generator of quotas"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_c94a5d83","side":"PARENT","line":1998,"updated":"2017-01-14 07:42:25.000000000","message":"please add the argument \"requires_id\u003dFalse\" in self._get(), we don\u0027t have to modify v2/quota.py. Base class Resource will handle the details about \"requires_id\u003dFalse\"\n\nAnd I don\u0027t know why current unit test don\u0027t catch the issue?","commit_id":"64bcbbe2cf5debd722f69e3f7a8ad5d8a4b5ab6c"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"d4f62a9cd2bb4dc5c358ed6d387fcb4e3212ec2f","unresolved":false,"context_lines":[{"line_number":1995,"context_line":"                 when no resource can be found."},{"line_number":1996,"context_line":"        \"\"\""},{"line_number":1997,"context_line":"        quota_obj \u003d self._get_resource(_quota.Quota, quota)"},{"line_number":1998,"context_line":"        return self._get(_quota.QuotaDefault, project\u003dquota_obj.id,"},{"line_number":1999,"context_line":"                         requires_id\u003dFalse)"},{"line_number":2000,"context_line":""},{"line_number":2001,"context_line":"    def quotas(self, **query):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_8bede2f1","line":1998,"updated":"2017-01-18 20:42:19.000000000","message":"Does this actually work? There\u0027s no attribute on QuotaDefault called project, so I\u0027m not sure where this value is going.","commit_id":"5341a02b824b45458d5856135cb84c3ccb9ac70a"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"13f7cf274da98e6ca38ee93b194c78a932ab24c0","unresolved":false,"context_lines":[{"line_number":1995,"context_line":"                 when no resource can be found."},{"line_number":1996,"context_line":"        \"\"\""},{"line_number":1997,"context_line":"        quota_obj \u003d self._get_resource(_quota.Quota, quota)"},{"line_number":1998,"context_line":"        return self._get(_quota.QuotaDefault, project\u003dquota_obj.id,"},{"line_number":1999,"context_line":"                         requires_id\u003dFalse)"},{"line_number":2000,"context_line":""},{"line_number":2001,"context_line":"    def quotas(self, **query):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_7065f8df","line":1998,"in_reply_to":"7a3c09a3_8bede2f1","updated":"2017-01-19 11:45:00.000000000","message":"QuotaDefault class have \"project\" attribute, see my other comments.","commit_id":"5341a02b824b45458d5856135cb84c3ccb9ac70a"}],"openstack/network/v2/quota.py":[{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"d4f62a9cd2bb4dc5c358ed6d387fcb4e3212ec2f","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        headers \u003d self._header.dirty"},{"line_number":81,"context_line":"        uri \u003d self.base_path % self._uri.attributes"},{"line_number":82,"context_line":"        if requires_id:"},{"line_number":83,"context_line":"            uri \u003d utils.urljoin(uri, self._get_id(self))"},{"line_number":84,"context_line":"        return resource._Request(uri, body, headers)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_ab9ffe63","line":82,"updated":"2017-01-18 20:42:19.000000000","message":"Isn\u0027t this just popping the ID out of the body and putting it onto URI? I don\u0027t see where the project ID is coming into it.","commit_id":"5341a02b824b45458d5856135cb84c3ccb9ac70a"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"13f7cf274da98e6ca38ee93b194c78a932ab24c0","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        headers \u003d self._header.dirty"},{"line_number":81,"context_line":"        uri \u003d self.base_path % self._uri.attributes"},{"line_number":82,"context_line":"        if requires_id:"},{"line_number":83,"context_line":"            uri \u003d utils.urljoin(uri, self._get_id(self))"},{"line_number":84,"context_line":"        return resource._Request(uri, body, headers)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_301450f4","line":82,"in_reply_to":"7a3c09a3_ab9ffe63","updated":"2017-01-19 11:45:00.000000000","message":"Seems the patch is out of date, it should be rebase on https://review.openstack.org/#/c/419911/3/openstack/network/v2/quota.py","commit_id":"5341a02b824b45458d5856135cb84c3ccb9ac70a"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"13f7cf274da98e6ca38ee93b194c78a932ab24c0","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    # Properties"},{"line_number":97,"context_line":"    #: The ID of the project."},{"line_number":98,"context_line":"    project \u003d resource.URI(\u0027project\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_d025ccae","line":98,"updated":"2017-01-19 11:45:00.000000000","message":"here","commit_id":"5341a02b824b45458d5856135cb84c3ccb9ac70a"}]}