)]}'
{"openstack/proxy2.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"030f87355a90e7dfb68dcf16689413784c6064f7","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        :raises: :class:`~AttributeError` if the resource does not have a"},{"line_number":297,"context_line":"                 status attribute"},{"line_number":298,"context_line":"        \"\"\""},{"line_number":299,"context_line":"        return resource2.wait_for_status(self.session, value, status,"},{"line_number":300,"context_line":"                                         failures, interval, wait)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    @utils.deprecated(deprecated_in\u003d\"0.9.14\", removed_in\u003d\"1.0\","}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_f3558df9","line":299,"range":{"start_line":299,"start_character":41,"end_line":299,"end_character":53},"updated":"2017-02-16 03:00:50.000000000","message":"I believe the value of the proxy2.wait_for_status lies in its hiding of the \u0027session\u0027 parameter. If we have to use resource level methods, we will need it. Isn\u0027t that a conflict to the patch that renames session to _session?\n\nBy the way, we have been heavily using this method in senlinclient and senlin thanks to its convenience brought to callers. Maintaining this and the the wait_for_delete should not be a huge burden.","commit_id":"9260f8404ca0cfa7260638bceede0839fff94bcf"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"e502d541e86b922db541af06bc234f811ae89b64","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        :raises: :class:`~AttributeError` if the resource does not have a"},{"line_number":297,"context_line":"                 status attribute"},{"line_number":298,"context_line":"        \"\"\""},{"line_number":299,"context_line":"        return resource2.wait_for_status(self.session, value, status,"},{"line_number":300,"context_line":"                                         failures, interval, wait)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    @utils.deprecated(deprecated_in\u003d\"0.9.14\", removed_in\u003d\"1.0\","}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_a547354a","line":299,"range":{"start_line":299,"start_character":41,"end_line":299,"end_character":53},"in_reply_to":"fa31d9ce_f3558df9","updated":"2017-02-16 12:44:02.000000000","message":"That is a big value of it, but what I think should then be done is that the cluster proxy takes on whatever wait_for methods it needs.\n\nFor example, object_store and and identity have these wait_for_* methods but have no immediately apparent—or at least proven—use for them. I don\u0027t doubt that they\u0027re good and useful methods for some services, but having them in the base class is perhaps a stretch. They\u0027re mostly in this class because compute was the first major service.\n\nThe alternative would be to make the non-user classes raise a NonImplementedError, which feels pretty weird to have as the common case.","commit_id":"9260f8404ca0cfa7260638bceede0839fff94bcf"}]}