)]}'
{"openstack/network/v2/subnet.py":[{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"34f74d15968b222879db7f2646fe4ab9935537ce","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    #: Timestamp when the subnet was last updated."},{"line_number":83,"context_line":"    updated_at \u003d resource.Body(\u0027updated_at\u0027)"},{"line_number":84,"context_line":"    #: Whether to use the default subnet pool to obtain a CIDR."},{"line_number":85,"context_line":"    use_default_subnetpool \u003d resource.Body(\u0027use_default_subnetpool\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_79997878","line":85,"updated":"2017-02-27 12:50:06.000000000","message":"If this in fact necessary, use_default_subnet_pool would be the name.","commit_id":"13a16032e8e5525af7430076382abf4eb1d7b1c5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5afbb73489aac33542faaf4778d421269c2a155b","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    #: Timestamp when the subnet was last updated."},{"line_number":83,"context_line":"    updated_at \u003d resource.Body(\u0027updated_at\u0027)"},{"line_number":84,"context_line":"    #: Whether to use the default subnet pool to obtain a CIDR."},{"line_number":85,"context_line":"    use_default_subnetpool \u003d resource.Body(\u0027use_default_subnetpool\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_e97115aa","line":85,"in_reply_to":"da36d5c6_79997878","updated":"2017-02-27 13:12:49.000000000","message":"The name is already being used this way in OSC[2], so do you think it should be changed there, too?\n\n[2] http://git.openstack.org/cgit/openstack/python-openstackclient/tree/openstackclient/network/v2/subnet.py#n182","commit_id":"13a16032e8e5525af7430076382abf4eb1d7b1c5"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"37693d77be1ee824b309cfd2a307fba047668ef6","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    #: Timestamp when the subnet was last updated."},{"line_number":83,"context_line":"    updated_at \u003d resource.Body(\u0027updated_at\u0027)"},{"line_number":84,"context_line":"    #: Whether to use the default subnet pool to obtain a CIDR."},{"line_number":85,"context_line":"    use_default_subnetpool \u003d resource.Body(\u0027use_default_subnetpool\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_29e32d07","line":85,"in_reply_to":"da36d5c6_e97115aa","updated":"2017-02-27 13:20:12.000000000","message":"OSC can do whatever it wants, and the string is fine as you wrote it since that\u0027s what the REST API expects, but the name here should change because we already have a consistency going with how the two words subnet and pool are combined.","commit_id":"13a16032e8e5525af7430076382abf4eb1d7b1c5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f332b6b89798e2316c2077ebc535ab3d06641ca0","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    #: Timestamp when the subnet was last updated."},{"line_number":83,"context_line":"    updated_at \u003d resource.Body(\u0027updated_at\u0027)"},{"line_number":84,"context_line":"    #: Whether to use the default subnet pool to obtain a CIDR."},{"line_number":85,"context_line":"    use_default_subnet_pool \u003d resource.Body(\u0027use_default_subnetpool\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_d26cfad2","line":85,"updated":"2017-02-27 14:35:58.000000000","message":"I still have two questions about this:\n\n- Should this have a \u0027type\u003dbool\u0027 added?\n- How can we avoid this attribute being listed in the output of a \"subnet show\" command? It only makes sense for creation really and not for existing subnets, where the subnet_pool_id is relevant instead.","commit_id":"58f0a922d213b9cdfccf63b7d07456347d1ef08d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cffd14140726211ee0a32c948ebad8ff35c88d88","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    #: Timestamp when the subnet was last updated."},{"line_number":83,"context_line":"    updated_at \u003d resource.Body(\u0027updated_at\u0027)"},{"line_number":84,"context_line":"    #: Whether to use the default subnet pool to obtain a CIDR."},{"line_number":85,"context_line":"    use_default_subnet_pool \u003d resource.Body(\u0027use_default_subnetpool\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_839b1272","line":85,"in_reply_to":"da36d5c6_bd075780","updated":"2017-02-27 15:54:24.000000000","message":"Done","commit_id":"58f0a922d213b9cdfccf63b7d07456347d1ef08d"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"ac6b60cab82701b0a0d5072d88dfad046091fed7","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    #: Timestamp when the subnet was last updated."},{"line_number":83,"context_line":"    updated_at \u003d resource.Body(\u0027updated_at\u0027)"},{"line_number":84,"context_line":"    #: Whether to use the default subnet pool to obtain a CIDR."},{"line_number":85,"context_line":"    use_default_subnet_pool \u003d resource.Body(\u0027use_default_subnetpool\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_bd075780","line":85,"in_reply_to":"da36d5c6_d26cfad2","updated":"2017-02-27 15:10:13.000000000","message":"Yes, type\u003dbool would be good. \n\nAs for the second one you\u0027d probably have to do something in OSC.","commit_id":"58f0a922d213b9cdfccf63b7d07456347d1ef08d"}],"openstack/tests/unit/network/v2/test_subnet.py":[{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"d6363e4d6bc9b323b9c8d9a6d43e2c0683b96d18","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    \u0027subnetpool_id\u0027: \u002716\u0027,"},{"line_number":37,"context_line":"    \u0027tenant_id\u0027: \u002717\u0027,"},{"line_number":38,"context_line":"    \u0027updated_at\u0027: \u002718\u0027,"},{"line_number":39,"context_line":"    \u0027use_default_subnet_pool\u0027: True,"},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_35ae1be8","line":39,"updated":"2017-02-27 16:41:21.000000000","message":"This one should be \"use_default_subnetpool\" (as should the dictionary access on line 80) as that\u0027s how the body is going to be sent/received. \n\nThe test still passes fine as-is because the string matches up directly with the name on the Subnet class. It ends up just testing that we can set a name directly, rather than test that we can match up what the server expects with the name we have mapped on our end.","commit_id":"d3d91e8bb46d4239932f35c894d4c01841c9fea7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e6919c5965537949d669c219083d0d04c195eca8","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    \u0027subnetpool_id\u0027: \u002716\u0027,"},{"line_number":37,"context_line":"    \u0027tenant_id\u0027: \u002717\u0027,"},{"line_number":38,"context_line":"    \u0027updated_at\u0027: \u002718\u0027,"},{"line_number":39,"context_line":"    \u0027use_default_subnet_pool\u0027: True,"},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_55cd4f5c","line":39,"in_reply_to":"da36d5c6_35ae1be8","updated":"2017-02-27 16:57:56.000000000","message":"Done","commit_id":"d3d91e8bb46d4239932f35c894d4c01841c9fea7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e6919c5965537949d669c219083d0d04c195eca8","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.assertEqual(EXAMPLE[\u0027subnetpool_id\u0027], sot.subnet_pool_id)"},{"line_number":77,"context_line":"        self.assertEqual(EXAMPLE[\u0027tenant_id\u0027], sot.project_id)"},{"line_number":78,"context_line":"        self.assertEqual(EXAMPLE[\u0027updated_at\u0027], sot.updated_at)"},{"line_number":79,"context_line":"        self.assertEqual("},{"line_number":80,"context_line":"            EXAMPLE[\u0027use_default_subnet_pool\u0027],"},{"line_number":81,"context_line":"            sot.use_default_subnet_pool"},{"line_number":82,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_f539e3f3","line":79,"updated":"2017-02-27 16:57:56.000000000","message":"Made this even simpler like with the other boolean option above.","commit_id":"d3d91e8bb46d4239932f35c894d4c01841c9fea7"}]}