)]}'
{"openstack/compute/v2/server.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"43e1ae9da84678fb61acf404e8d63469842001b9","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    personality \u003d resource2.Body(\u0027personality\u0027)"},{"line_number":120,"context_line":"    #: Configuration information or scripts to use upon launch."},{"line_number":121,"context_line":"    #: Must be Base64 encoded."},{"line_number":122,"context_line":"    user_data \u003d resource2.Body(\u0027user_data\u0027)"},{"line_number":123,"context_line":"    #: Enables fine grained control of the block device mapping for an"},{"line_number":124,"context_line":"    #: instance. This is typically used for booting servers from volumes."},{"line_number":125,"context_line":"    block_device_mapping \u003d resource2.Body(\u0027block_device_mapping_v2\u0027, type\u003ddict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_5b30d101","side":"PARENT","line":122,"range":{"start_line":122,"start_character":31,"end_line":122,"end_character":41},"updated":"2017-03-08 13:03:25.000000000","message":"I was pretty sure when you send user data it expects this format.  I thought I\u0027d tested that.  Sending is a lot more important than receiving in this case.","commit_id":"075b280dc2b9bc30761f2246af022c74a4461701"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"443abf7ef74aa20458aa868511e0e640668a28d0","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    personality \u003d resource2.Body(\u0027personality\u0027)"},{"line_number":120,"context_line":"    #: Configuration information or scripts to use upon launch."},{"line_number":121,"context_line":"    #: Must be Base64 encoded."},{"line_number":122,"context_line":"    user_data \u003d resource2.Body(\u0027user_data\u0027)"},{"line_number":123,"context_line":"    #: Enables fine grained control of the block device mapping for an"},{"line_number":124,"context_line":"    #: instance. This is typically used for booting servers from volumes."},{"line_number":125,"context_line":"    block_device_mapping \u003d resource2.Body(\u0027block_device_mapping_v2\u0027, type\u003ddict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_1e72c2ad","side":"PARENT","line":122,"range":{"start_line":122,"start_character":31,"end_line":122,"end_character":41},"in_reply_to":"9a30ddce_23b853e5","updated":"2017-03-08 15:22:56.000000000","message":"We just got a bug report about a possibly similar thing with availability_zone. https://bugs.launchpad.net/python-openstacksdk/+bug/1671073\n\nI think I know how to do the field mapping change to support your request/response names, will take a look.","commit_id":"075b280dc2b9bc30761f2246af022c74a4461701"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"ff3ad02f442342d9c9cf896c033c79edcf4eeeff","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    personality \u003d resource2.Body(\u0027personality\u0027)"},{"line_number":120,"context_line":"    #: Configuration information or scripts to use upon launch."},{"line_number":121,"context_line":"    #: Must be Base64 encoded."},{"line_number":122,"context_line":"    user_data \u003d resource2.Body(\u0027user_data\u0027)"},{"line_number":123,"context_line":"    #: Enables fine grained control of the block device mapping for an"},{"line_number":124,"context_line":"    #: instance. This is typically used for booting servers from volumes."},{"line_number":125,"context_line":"    block_device_mapping \u003d resource2.Body(\u0027block_device_mapping_v2\u0027, type\u003ddict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_23b853e5","side":"PARENT","line":122,"range":{"start_line":122,"start_character":31,"end_line":122,"end_character":41},"in_reply_to":"9a30ddce_5b30d101","updated":"2017-03-08 15:07:20.000000000","message":"Valid point. Before submitting this patch, I have experimented adding an \u0027alias\u0027 field to the Body component but I found it hard to refactor the current assumption about field mappings.\n\nSo I tried this fix although I was worrying that it may break the create_server API. Strange enough, it works, :)\n\nIn the long run, I think we may want to introduce some changes to the Body() component. For example:\n\n   attr1 \u003d resource2.Body(request\u003d\u0027foo1\u0027, response\u003d\u0027foo1\u0027)\n   attr2 \u003d resource2.Body(request\u003d\u0027foo2\u0027, response\u003d\u0027bar1\u0027)\n   attr3 \u003d resource2.Body(request\u003d\u0027foo3\u0027, response\u003dNone)\n   attr4 \u003d resource2.Body(request\u003dNone\u0027, response\u003d\u0027bar2\u0027)\n\nattr1 is the common case, a field which can show up both in request and in response with the same name; attr2 is a variant, it shows up in both direction, but it appears as a different name. attr3 is only supposed to appear in a request, i.e. it won\u0027t show up in a response; attr4 is on the contrary, only valid for response parsing.\n\nTake the \u0027Server\u0027 resource here as example, we will have:\n\n  access_ipv4 \u003d resource2.Body(request\u003dNone, response\u003d\u0027accessIPV4\u0027)\n  admin_password \u003d resource2.Body(request\u003d\u0027adminPass\u0027, response\u003dNone)\n  personality \u003d resource2.Body(request\u003d\u0027personality\u0027, response\u003dNone)\n  user_data \u003d resource2.Body(request\u003d\u0027user_data\u0027, response\u003d\u0027OS-EXT-SRV-ATTR:user_data\u0027)","commit_id":"075b280dc2b9bc30761f2246af022c74a4461701"}]}
