)]}'
{"openstack/load_balancer/pool_service.py":[{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"cd0ce3fbf995b1745dd3fedfcb16f3c4004fa71c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_dc79fec4","line":1,"updated":"2017-03-29 19:54:27.000000000","message":"I don\u0027t think this is needed, service would be load_balancer_service for all Octavia controllers","commit_id":"cac6cfb9abfbb5d483682561aceb8a1f23f8dcee"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"aee09eab0617e5539d00fb24d8dbb007d7e4b7b6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_f75b8484","line":1,"in_reply_to":"ffe62b97_dc79fec4","updated":"2017-03-31 15:20:29.000000000","message":"+1","commit_id":"cac6cfb9abfbb5d483682561aceb8a1f23f8dcee"}],"openstack/load_balancer/v2/_proxy.py":[{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"f54aa4d43cceb49020ad163ca0e48e34ed775bd4","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        :returns: One"},{"line_number":107,"context_line":"             :class:`~openstack.load_balancer.v2.pools.Pool`"},{"line_number":108,"context_line":"        \"\"\""},{"line_number":109,"context_line":"        return self._get(_pool.LoadBalancer, *attrs)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def delete_pool(self, pool, ignore_missing\u003dTrue):"},{"line_number":112,"context_line":"        \"\"\"Delete a pool"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_1301f705","line":109,"updated":"2017-04-04 15:56:36.000000000","message":"_pool.Pool","commit_id":"046bf8ec271e998e3a81182df2b5c407af9bce81"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"f54aa4d43cceb49020ad163ca0e48e34ed775bd4","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        :returns: ``None``"},{"line_number":124,"context_line":"        \"\"\""},{"line_number":125,"context_line":"        return self._delete(_pool.Pool, pool,"},{"line_number":126,"context_line":"                            ignore_missing\u003dignore_missing)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_f32e9390","line":126,"updated":"2017-04-04 15:56:36.000000000","message":"Also get_list and update needs to be added","commit_id":"046bf8ec271e998e3a81182df2b5c407af9bce81"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"0d17da6ad4d2a014167b746f99740908180e70f1","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        \"\"\""},{"line_number":97,"context_line":"        return self._create(_pool.Pool, **attrs)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def get_pool(self, *attrs):"},{"line_number":100,"context_line":"        \"\"\"Get a pool"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        :param pool: Value is"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_8de1d401","line":99,"range":{"start_line":99,"start_character":23,"end_line":99,"end_character":29},"updated":"2017-04-06 00:56:17.000000000","message":"do you mean a \u0027pool\u0027 here?\n\ndo we have to use a Pool instance or a Pool ID is okay as well?","commit_id":"45e854e369e27bd67d7f427cdcf14ea95c95d4df"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"0d17da6ad4d2a014167b746f99740908180e70f1","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        :returns: A generator of Pool instances"},{"line_number":115,"context_line":"        \"\"\""},{"line_number":116,"context_line":"        return self._list(_pool.Pool, paginated\u003dTrue, **query)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def delete_pool(self, pool, ignore_missing\u003dTrue):"},{"line_number":119,"context_line":"        \"\"\"Delete a pool"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_2df088c9","line":116,"range":{"start_line":116,"start_character":37,"end_line":116,"end_character":52},"updated":"2017-04-06 00:56:17.000000000","message":"this doesn\u0027t have to be explicitly specified because it is the default.","commit_id":"45e854e369e27bd67d7f427cdcf14ea95c95d4df"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"0d17da6ad4d2a014167b746f99740908180e70f1","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        \"\"\""},{"line_number":116,"context_line":"        return self._list(_pool.Pool, paginated\u003dTrue, **query)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def delete_pool(self, pool, ignore_missing\u003dTrue):"},{"line_number":119,"context_line":"        \"\"\"Delete a pool"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        :param pool: The pool is a"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_6dcfb07f","line":118,"range":{"start_line":118,"start_character":26,"end_line":118,"end_character":30},"updated":"2017-04-06 00:56:17.000000000","message":"again, this has to be a pool instance? can we use an ID here?","commit_id":"45e854e369e27bd67d7f427cdcf14ea95c95d4df"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"75f21135b8e8062c20e1d842ce2f409362e50ab4","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        :param dict attrs: Keyword arguments which will be used to create"},{"line_number":185,"context_line":"                           a :class:`~openstack.load_balancer.v2."},{"line_number":186,"context_line":"                           pools.Pool`,"},{"line_number":187,"context_line":"                           comprised of the properties on the"},{"line_number":188,"context_line":"                           Pool class."},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"df3967d1_b4af9c7b","line":186,"range":{"start_line":186,"start_character":27,"end_line":186,"end_character":32},"updated":"2017-08-04 01:41:25.000000000","message":"this (and all the following) should be a singular?\nSeems the module name is \u0027pool\u0027, not \u0027pools\u0027.","commit_id":"caa6f0132835e2da4e7e934cd5895c44f2d76212"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"75f21135b8e8062c20e1d842ce2f409362e50ab4","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        \"\"\""},{"line_number":205,"context_line":"        return self._get(_pool.Pool, *attrs)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def pools(self, **query):"},{"line_number":208,"context_line":"        \"\"\"Retrieve a generator of pools"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        :returns: A generator of Pool instances"}],"source_content_type":"text/x-python","patch_set":9,"id":"df3967d1_34c3ac3a","line":207,"range":{"start_line":207,"start_character":22,"end_line":207,"end_character":27},"updated":"2017-08-04 01:41:25.000000000","message":"from SDK user\u0027s perspective, I\u0027d suggest we document what parameters can be used for query.","commit_id":"caa6f0132835e2da4e7e934cd5895c44f2d76212"}],"openstack/load_balancer/v2/pool.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"0d17da6ad4d2a014167b746f99740908180e70f1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    allow_list \u003d True"},{"line_number":26,"context_line":"    allow_get \u003d True"},{"line_number":27,"context_line":"    allow_delete \u003d True"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    #: Properties"},{"line_number":30,"context_line":"    #: The pool name"},{"line_number":31,"context_line":"    name \u003d resource.Body(\u0027name\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_8db674d9","line":28,"updated":"2017-04-06 00:56:17.000000000","message":"You may want to add a _query_mapping field specifying which field(s) can be used for query.","commit_id":"45e854e369e27bd67d7f427cdcf14ea95c95d4df"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"0d17da6ad4d2a014167b746f99740908180e70f1","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    #: Description for the pool."},{"line_number":33,"context_line":"    description \u003d resource.Body(\u0027description\u0027)"},{"line_number":34,"context_line":"    #: The administrative state of the pool *Type: bool*"},{"line_number":35,"context_line":"    admin_state_up \u003d resource.Body(\u0027admin_state_up\u0027, type\u003dbool)"},{"line_number":36,"context_line":"    #: Provisioning status of the pool"},{"line_number":37,"context_line":"    provisioning_status \u003d resource.Body(\u0027provisioning_status\u0027)"},{"line_number":38,"context_line":"    #: Operating status of the pool"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_8daf9493","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":18},"updated":"2017-04-06 00:56:17.000000000","message":"the convention here is to name this property as \u0027is_admin_state_up\u0027.","commit_id":"45e854e369e27bd67d7f427cdcf14ea95c95d4df"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"2e032552c84b7eb0091c948b69c7ad6b3e5de19e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    #: The protocol of the pool"},{"line_number":41,"context_line":"    protocol \u003d resource.Body(\u0027protocol\u0027)"},{"line_number":42,"context_line":"    #: The loadbalancing algorithm used in the pool"},{"line_number":43,"context_line":"    lb_algorithm \u003d resource.Body(\u0027lb_algorithm\u0027)"},{"line_number":44,"context_line":"    #: Session Persistence"},{"line_number":45,"context_line":"    session_persistence \u003d resource.Body(\u0027session_persistence\u0027)"},{"line_number":46,"context_line":"    #: The ID of the project"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_310face2","line":43,"updated":"2017-04-06 12:21:15.000000000","message":"I\u0027d rather we call this load_balancer_algorithm as we generally don\u0027t use shorthand names. Additionally the docstring should have a space between \"load\" and \"balancer\".","commit_id":"45e854e369e27bd67d7f427cdcf14ea95c95d4df"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"2e032552c84b7eb0091c948b69c7ad6b3e5de19e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    protocol \u003d resource.Body(\u0027protocol\u0027)"},{"line_number":42,"context_line":"    #: The loadbalancing algorithm used in the pool"},{"line_number":43,"context_line":"    lb_algorithm \u003d resource.Body(\u0027lb_algorithm\u0027)"},{"line_number":44,"context_line":"    #: Session Persistence"},{"line_number":45,"context_line":"    session_persistence \u003d resource.Body(\u0027session_persistence\u0027)"},{"line_number":46,"context_line":"    #: The ID of the project"},{"line_number":47,"context_line":"    project_id \u003d resource.Body(\u0027project_id\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_112dc842","line":44,"updated":"2017-04-06 12:21:15.000000000","message":"Rather than stating that is is session persistence, can you explain what it indicates, or something like that?","commit_id":"45e854e369e27bd67d7f427cdcf14ea95c95d4df"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"0d17da6ad4d2a014167b746f99740908180e70f1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    session_persistence \u003d resource.Body(\u0027session_persistence\u0027)"},{"line_number":46,"context_line":"    #: The ID of the project"},{"line_number":47,"context_line":"    project_id \u003d resource.Body(\u0027project_id\u0027)"},{"line_number":48,"context_line":"    #: The ID of the tenant"},{"line_number":49,"context_line":"    tenant_id \u003d resource.Body(\u0027tenant_id\u0027)"},{"line_number":50,"context_line":"    #: List of loadbalancers associated with this pool"},{"line_number":51,"context_line":"    loadbalancers \u003d resource.Body(\u0027loadbalancers\u0027, type\u003dlist)"},{"line_number":52,"context_line":"    #: List of listeners associated with this pool"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_ed8e2026","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":42},"updated":"2017-04-06 00:56:17.000000000","message":"I\u0027m curious if tenant id is still used by any project. Since we have \u0027project_id\u0027 already, maybe it is time to stop exposing this to users NOW.","commit_id":"45e854e369e27bd67d7f427cdcf14ea95c95d4df"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"2e032552c84b7eb0091c948b69c7ad6b3e5de19e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    session_persistence \u003d resource.Body(\u0027session_persistence\u0027)"},{"line_number":46,"context_line":"    #: The ID of the project"},{"line_number":47,"context_line":"    project_id \u003d resource.Body(\u0027project_id\u0027)"},{"line_number":48,"context_line":"    #: The ID of the tenant"},{"line_number":49,"context_line":"    tenant_id \u003d resource.Body(\u0027tenant_id\u0027)"},{"line_number":50,"context_line":"    #: List of loadbalancers associated with this pool"},{"line_number":51,"context_line":"    loadbalancers \u003d resource.Body(\u0027loadbalancers\u0027, type\u003dlist)"},{"line_number":52,"context_line":"    #: List of listeners associated with this pool"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_ae2ebda2","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":42},"in_reply_to":"bff0334d_ed8e2026","updated":"2017-04-06 12:21:15.000000000","message":"Yeah, this should just be removed.","commit_id":"45e854e369e27bd67d7f427cdcf14ea95c95d4df"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"0d17da6ad4d2a014167b746f99740908180e70f1","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    #: The ID of the tenant"},{"line_number":49,"context_line":"    tenant_id \u003d resource.Body(\u0027tenant_id\u0027)"},{"line_number":50,"context_line":"    #: List of loadbalancers associated with this pool"},{"line_number":51,"context_line":"    loadbalancers \u003d resource.Body(\u0027loadbalancers\u0027, type\u003dlist)"},{"line_number":52,"context_line":"    #: List of listeners associated with this pool"},{"line_number":53,"context_line":"    listeners \u003d resource.Body(\u0027listeners\u0027, type\u003dlist)"},{"line_number":54,"context_line":"    #: Timestamp when the pool was created"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_4d9f4c50","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":17},"updated":"2017-04-06 00:56:17.000000000","message":"change this to \u0027load_balancers\u0027? We do not encourage concatenating words in this way in SDK.","commit_id":"45e854e369e27bd67d7f427cdcf14ea95c95d4df"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"2e032552c84b7eb0091c948b69c7ad6b3e5de19e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    #: Health Monitor ID"},{"line_number":61,"context_line":"    health_monitor_id \u003d resource.Body(\u0027health_monitor_id\u0027)"},{"line_number":62,"context_line":"    #: Members associated with this pool"},{"line_number":63,"context_line":"    members \u003d resource.Body(\u0027members\u0027, type\u003dlist)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_31dd6c42","line":63,"updated":"2017-04-06 12:21:15.000000000","message":"Is members a list of IDs? I feel like it might be, but just want to be sure. If it is a list of the IDs of members in the pool, this should be member_ids.","commit_id":"45e854e369e27bd67d7f427cdcf14ea95c95d4df"}],"openstack/load_balancer/v2/pools.py":[{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"aee09eab0617e5539d00fb24d8dbb007d7e4b7b6","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    allow_delete \u003d True"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    #: Properties"},{"line_number":30,"context_line":"    #: The administrative state of the pool *Type: bool*"},{"line_number":31,"context_line":"    admin_state_up \u003d resource.Body(\u0027admin_state_up\u0027, type\u003dbool)"},{"line_number":32,"context_line":"    #: Timestamp when the pool was created"},{"line_number":33,"context_line":"    created_at \u003d resource.Body(\u0027created_at\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_3779ecfb","line":30,"updated":"2017-03-31 15:20:29.000000000","message":"All these properties should match the \noctavia/api/v2/types/pools nothing more nothing less\n\ntheres a couple missing/additional","commit_id":"cac6cfb9abfbb5d483682561aceb8a1f23f8dcee"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"aee09eab0617e5539d00fb24d8dbb007d7e4b7b6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    #: The pool description"},{"line_number":35,"context_line":"    description \u003d resource.Body(\u0027description\u0027)"},{"line_number":36,"context_line":"    #: Load balancer associated with this pool"},{"line_number":37,"context_line":"    listeners \u003d resource.Body(\u0027listeners\u0027, type\u003dlist)"},{"line_number":38,"context_line":"    #: List of listeners associated with this pool"},{"line_number":39,"context_line":"    listeners \u003d resource.Body(\u0027listeners\u0027, type\u003dlist)"},{"line_number":40,"context_line":"    #: The pool name"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_171948d6","line":37,"updated":"2017-03-31 15:20:29.000000000","message":"loadbalancers?","commit_id":"cac6cfb9abfbb5d483682561aceb8a1f23f8dcee"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"f54aa4d43cceb49020ad163ca0e48e34ed775bd4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from openstack.network import network_service"},{"line_number":14,"context_line":"from openstack import resource2 as resource"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_f020c9ae","line":13,"updated":"2017-04-04 15:56:36.000000000","message":"import load_balancer_service","commit_id":"046bf8ec271e998e3a81182df2b5c407af9bce81"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"f54aa4d43cceb49020ad163ca0e48e34ed775bd4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    resource_key \u003d \u0027pool\u0027"},{"line_number":19,"context_line":"    resources_key \u003d \u0027pools\u0027"},{"line_number":20,"context_line":"    base_path \u003d \u0027/pools\u0027"},{"line_number":21,"context_line":"    service \u003d network_service.LoadBalancerService()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    # capabilities"},{"line_number":24,"context_line":"    allow_create \u003d True"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_900f3d36","line":21,"updated":"2017-04-04 15:56:36.000000000","message":"use load_balancer_service","commit_id":"046bf8ec271e998e3a81182df2b5c407af9bce81"}]}