)]}'
{"openstack/compute/v2/_proxy.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"54c807e68c6fdb6cad2b9b9bcc1228b65a3512e5","unresolved":false,"context_lines":[{"line_number":1125,"context_line":"    def create_server_attachment(self, server, **attrs):"},{"line_number":1126,"context_line":"        \"\"\"Create a new server attachment from attributes"},{"line_number":1127,"context_line":""},{"line_number":1128,"context_line":"        :param server: The server can be either the ID of a server or a"},{"line_number":1129,"context_line":"                       :class:`~openstack.compute.v2.server.Server` instance."},{"line_number":1130,"context_line":"        :param dict attrs: Keyword arguments which will be used to create a"},{"line_number":1131,"context_line":"            :class:`~openstack.compute.v2.server_attachment.ServerAttachment`,"},{"line_number":1132,"context_line":"            comprised of the properties on the ServerAttachment class."},{"line_number":1133,"context_line":""},{"line_number":1134,"context_line":"        :returns: The results of server attachment creation"},{"line_number":1135,"context_line":"        :rtype:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_d8cdc685","line":1132,"range":{"start_line":1128,"start_character":0,"end_line":1132,"end_character":70},"updated":"2017-04-11 01:50:40.000000000","message":"When reading this docstring (and imagining the doc generated), renaming ServerAttachment to VolumeAttachment is more clear to me.","commit_id":"cc13477c5b77ca5d70f93966b8a2aba9126f8ef3"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"54c807e68c6fdb6cad2b9b9bcc1228b65a3512e5","unresolved":false,"context_lines":[{"line_number":1139,"context_line":"        return self._create(_server_attachment.ServerAttachment,"},{"line_number":1140,"context_line":"                            server_id\u003dserver_id, **attrs)"},{"line_number":1141,"context_line":""},{"line_number":1142,"context_line":"    def update_server_attachment(self, server_attachment, server\u003dNone,"},{"line_number":1143,"context_line":"                                 **attrs):"},{"line_number":1144,"context_line":"        \"\"\"update a server attachment"},{"line_number":1145,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_f8952a41","line":1142,"range":{"start_line":1142,"start_character":58,"end_line":1142,"end_character":69},"updated":"2017-04-11 01:50:40.000000000","message":"can we actually use None for server?","commit_id":"cc13477c5b77ca5d70f93966b8a2aba9126f8ef3"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"55e9c29e7dfe1490edb2c20aaa1f223f861ea96e","unresolved":false,"context_lines":[{"line_number":1164,"context_line":"                                            \"server_id\")"},{"line_number":1165,"context_line":"        volume_attachment \u003d resource2.Resource._get_id(volume_attachment)"},{"line_number":1166,"context_line":""},{"line_number":1167,"context_line":"        self._update(_volume_attachment.VolumeAttachment,"},{"line_number":1168,"context_line":"                     attachment_id\u003dvolume_attachment,"},{"line_number":1169,"context_line":"                     server_id\u003dserver_id)"},{"line_number":1170,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_354d9b3d","line":1167,"range":{"start_line":1167,"start_character":8,"end_line":1167,"end_character":20},"updated":"2017-04-12 13:48:43.000000000","message":"Should be returning this result","commit_id":"21ca6cc4ebbd9eed16c70868d579a4d7be3b4984"}],"openstack/compute/v2/server_attachment.py":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"54c807e68c6fdb6cad2b9b9bcc1228b65a3512e5","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from openstack import resource2"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class ServerAttachment(resource2.Resource):"},{"line_number":18,"context_line":"    resource_key \u003d \u0027volumeAttachment\u0027"},{"line_number":19,"context_line":"    resources_key \u003d \u0027volumeAttachments\u0027"},{"line_number":20,"context_line":"    base_path \u003d \u0027/servers/%(server_id)s/os-volume_attachments\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_580bf6d4","line":17,"range":{"start_line":17,"start_character":6,"end_line":17,"end_character":22},"updated":"2017-04-11 01:50:40.000000000","message":"My feeling is that we should call it VolumeAttachement. The server itself is not attached to anything else.","commit_id":"cc13477c5b77ca5d70f93966b8a2aba9126f8ef3"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"54c807e68c6fdb6cad2b9b9bcc1228b65a3512e5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"class ServerAttachment(resource2.Resource):"},{"line_number":18,"context_line":"    resource_key \u003d \u0027volumeAttachment\u0027"},{"line_number":19,"context_line":"    resources_key \u003d \u0027volumeAttachments\u0027"},{"line_number":20,"context_line":"    base_path \u003d \u0027/servers/%(server_id)s/os-volume_attachments\u0027"},{"line_number":21,"context_line":"    service \u003d compute_service.ComputeService()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    # capabilities"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_58d9b654","line":20,"range":{"start_line":20,"start_character":28,"end_line":20,"end_character":37},"updated":"2017-04-11 01:50:40.000000000","message":"this deserves a resource2.URI(\u0027server_id\u0027) ?","commit_id":"cc13477c5b77ca5d70f93966b8a2aba9126f8ef3"}],"openstack/compute/v2/volume_attachment.py":[{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"903456deee8d6f0728de69b1e504383e1821532b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    #: The ID for the server."},{"line_number":37,"context_line":"    server_id \u003d resource2.URI(\u0027server_id\u0027)"},{"line_number":38,"context_line":"    #: The ID of the server."},{"line_number":39,"context_line":"    volume_attachment_server_id \u003d resource2.Body(\u0027serverId\u0027)"},{"line_number":40,"context_line":"    #: The ID of the attached volume."},{"line_number":41,"context_line":"    volume_id \u003d resource2.Body(\u0027volumeId\u0027)"},{"line_number":42,"context_line":"    #: The ID of the attachment you want to delete or update."}],"source_content_type":"text/x-python","patch_set":5,"id":"bff0334d_84d8bf52","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":60},"updated":"2017-04-12 12:46:15.000000000","message":"It looks like we can just remove this. Since we already have the server_id URI name, it\u0027s going to be the same value as this one so we don\u0027t need both.","commit_id":"d7398f60caceee6a2905e5728a592bb4a745c116"}]}