)]}'
{"doc/source/user/microversions.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e346f00c13fee20851bf398b7921faeb16e85053","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  of for a given call, unless a microversion removes important data."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"* Microversion selection should under no circumstances be exposed to the user"},{"line_number":18,"context_line":"  in python API calls in the Resource layer or the openstack.cloud layer."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"* Microversion selection is exposed to the user in the REST layer via the"},{"line_number":21,"context_line":"  ``microversion`` argument to each REST call."}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_1f48f884","line":18,"updated":"2018-05-28 08:58:48.000000000","message":"Good to know, I was about to ask you today about it :)","commit_id":"f184f3e5eada55cc87152385b738dbb7490add49"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"06850d54c7c417566ee115b29c316a6c2af8abe0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  of for a given call, unless a microversion removes important data."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"* Microversion selection should under no circumstances be exposed to the user"},{"line_number":18,"context_line":"  in python API calls in the Resource layer or the openstack.cloud layer."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"* Microversion selection is exposed to the user in the REST layer via the"},{"line_number":21,"context_line":"  ``microversion`` argument to each REST call."}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_68c12254","line":18,"in_reply_to":"5f7c97a3_1f48f884","updated":"2018-05-29 14:06:43.000000000","message":"It\u0027ll be the goal at least - I\u0027m sure something will come up that will make this hard. :)","commit_id":"f184f3e5eada55cc87152385b738dbb7490add49"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e346f00c13fee20851bf398b7921faeb16e85053","unresolved":false,"context_lines":[{"line_number":20,"context_line":"* Microversion selection is exposed to the user in the REST layer via the"},{"line_number":21,"context_line":"  ``microversion`` argument to each REST call."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"* A user may set the default microversion by setting"},{"line_number":24,"context_line":"  ``{service_type}_default_microversion`` in clouds.yaml or"},{"line_number":25,"context_line":"  ``OS_{service_type|upper}_DEFAULT_MICROVERSION`` environment variable."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_bf60e402","line":23,"updated":"2018-05-28 08:58:48.000000000","message":"I think it\u0027s worth elaborating what \"default microversion\" means for higher level API. The \"note\" below makes me think it\u0027s not the default, but rather a forced version. For me the default means \"this will be used instead of the base version, unless a higher version is required\". So,\n\n requested_version \u003d max(default_version, needed_version)\n\nwhere requested_version is the version we use for REST calls, default_version is the default from the configuration, needed_version is what is needed to implement the high-level call (say, ironic allows \"abort\" action starting with 1.13, so needed_version\u003d\"1.13\" for the future machine_abort call).\n\nThe note below, however, suggests that you\u0027re doing\n\n requested_version \u003d default_version or needed_version\n\nThis may be a less useful approach. In any case, without reading the code I\u0027m not sure which one you end up using.","commit_id":"f184f3e5eada55cc87152385b738dbb7490add49"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"e6aaa4c0602d6c0332a24774f29d74beddf00fd7","unresolved":false,"context_lines":[{"line_number":20,"context_line":"* Microversion selection is exposed to the user in the REST layer via the"},{"line_number":21,"context_line":"  ``microversion`` argument to each REST call."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"* A user may set the default microversion by setting"},{"line_number":24,"context_line":"  ``{service_type}_default_microversion`` in clouds.yaml or"},{"line_number":25,"context_line":"  ``OS_{service_type|upper}_DEFAULT_MICROVERSION`` environment variable."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_d3a606c1","line":23,"in_reply_to":"5f7c97a3_0b6988f6","updated":"2018-06-11 16:32:29.000000000","message":"I think in these docs I may have used the words \"a user\" too loosely. default_microversion is really only for people using the REST API layer. If a person knows they want to talk to the REST API at a certain microversion for all of their interactions, they can set default_microversion at Connection construction time.\n\nThen, how you have that other patch looks generally speaking fine - it\u0027s the SDK\u0027s job to use the appropriate microversion for the task at hand.","commit_id":"f184f3e5eada55cc87152385b738dbb7490add49"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a0d4a1d83bfa5d91a5bbab70898f2719f101d255","unresolved":false,"context_lines":[{"line_number":20,"context_line":"* Microversion selection is exposed to the user in the REST layer via the"},{"line_number":21,"context_line":"  ``microversion`` argument to each REST call."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"* A user may set the default microversion by setting"},{"line_number":24,"context_line":"  ``{service_type}_default_microversion`` in clouds.yaml or"},{"line_number":25,"context_line":"  ``OS_{service_type|upper}_DEFAULT_MICROVERSION`` environment variable."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_0b6988f6","line":23,"in_reply_to":"5f7c97a3_28e80ab1","updated":"2018-05-29 15:08:27.000000000","message":"Yeah, this makes sense. How I understood this in https://review.openstack.org/570895 is slightly different. There I use default_microversion if the request can be done  with, otherwise I use a well-known microversion. Do you think it\u0027s reasonable?","commit_id":"f184f3e5eada55cc87152385b738dbb7490add49"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"06850d54c7c417566ee115b29c316a6c2af8abe0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"* Microversion selection is exposed to the user in the REST layer via the"},{"line_number":21,"context_line":"  ``microversion`` argument to each REST call."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"* A user may set the default microversion by setting"},{"line_number":24,"context_line":"  ``{service_type}_default_microversion`` in clouds.yaml or"},{"line_number":25,"context_line":"  ``OS_{service_type|upper}_DEFAULT_MICROVERSION`` environment variable."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_28e80ab1","line":23,"in_reply_to":"5f7c97a3_bf60e402","updated":"2018-05-29 14:06:43.000000000","message":"Yes - that\u0027s an excellent question. I tend to think of these variables (api_version, default_microversion) as overrides. There was one cloud, for instance, that had glance v1 and v2 but v2 didn\u0027t work, so as a user you\u0027d set OS_IMAGE_API_VERSION when using that cloud and shade would use v1 even though it found you had v2 available.\n\nIn the general case, users should never have to touch these (unless they\u0027re using the REST layer, in which case they might)\n\nIn the basic sense, default_microversion actually just get passed to the keystoneauth Adapter object, so it will set the microversion to be sent in the absence of any per-call microversion. This would most directly impact the REST layer.\n\nAt the resource and cloud layers, either the SDK has code to handle a microversion and that microversion is available or it doesn\u0027t - so a user specifying one has a less-clear use-case than overriding the major.\n\nPerhaps this text should indicate that this is talking about the REST layer, and although it can be set for the other layers, it doesn\u0027t make a ton of sense and the user gets to keep all the pieces when it breaks?","commit_id":"f184f3e5eada55cc87152385b738dbb7490add49"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e346f00c13fee20851bf398b7921faeb16e85053","unresolved":false,"context_lines":[{"line_number":23,"context_line":"* A user may set the default microversion by setting"},{"line_number":24,"context_line":"  ``{service_type}_default_microversion`` in clouds.yaml or"},{"line_number":25,"context_line":"  ``OS_{service_type|upper}_DEFAULT_MICROVERSION`` environment variable."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. note::"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  Setting the default microversion in any circumstance other than when using"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_df5da047","line":26,"updated":"2018-05-28 08:58:48.000000000","message":"What about raising default_microversion? Do we allow it? Do we allow it with a major version bump?","commit_id":"f184f3e5eada55cc87152385b738dbb7490add49"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"06850d54c7c417566ee115b29c316a6c2af8abe0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"* A user may set the default microversion by setting"},{"line_number":24,"context_line":"  ``{service_type}_default_microversion`` in clouds.yaml or"},{"line_number":25,"context_line":"  ``OS_{service_type|upper}_DEFAULT_MICROVERSION`` environment variable."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. note::"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  Setting the default microversion in any circumstance other than when using"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_e8f6928f","line":26,"in_reply_to":"5f7c97a3_df5da047","updated":"2018-05-29 14:06:43.000000000","message":"If a service raises default_microversion we\u0027ll have to support it. As we do in this patch, we can certainly support bumping the default microversion the sdk uses (such as using ironic mv 1.6 by default)\n\nWe would prefer it if services wouldn\u0027t bump the default min though. :)","commit_id":"f184f3e5eada55cc87152385b738dbb7490add49"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a0d4a1d83bfa5d91a5bbab70898f2719f101d255","unresolved":false,"context_lines":[{"line_number":23,"context_line":"* A user may set the default microversion by setting"},{"line_number":24,"context_line":"  ``{service_type}_default_microversion`` in clouds.yaml or"},{"line_number":25,"context_line":"  ``OS_{service_type|upper}_DEFAULT_MICROVERSION`` environment variable."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. note::"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  Setting the default microversion in any circumstance other than when using"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_0b42e868","line":26,"in_reply_to":"5f7c97a3_e8f6928f","updated":"2018-05-29 15:08:27.000000000","message":"Sorry for confusion, I meant a bit different thing. Say, you put default_baremetal_api_microversion\u003d1.6 in the openstacksdk defaults (which you do in this patch). Are we going to ever change it? If we are, are we going to raise openstacksdk\u0027s major (semantic) version?","commit_id":"f184f3e5eada55cc87152385b738dbb7490add49"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e346f00c13fee20851bf398b7921faeb16e85053","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  \"get me a network\" feature. The logic of \"get me a network\" can be done"},{"line_number":53,"context_line":"  client-side, albeit less efficiently. Adding support for the"},{"line_number":54,"context_line":"  \"get me a network\" feature via nova microversion should also add support for"},{"line_number":55,"context_line":"  doing the client-side workaround."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* If openstacksdk is aware of logic for more than one microversion, it should"},{"line_number":58,"context_line":"  always attempt to use the latest version available for the service for that"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_7f56cc2c","line":55,"updated":"2018-05-28 08:58:48.000000000","message":"I wonder if we need a \"hardcore mode\", disabling such workarounds :)","commit_id":"f184f3e5eada55cc87152385b738dbb7490add49"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"06850d54c7c417566ee115b29c316a6c2af8abe0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  \"get me a network\" feature. The logic of \"get me a network\" can be done"},{"line_number":53,"context_line":"  client-side, albeit less efficiently. Adding support for the"},{"line_number":54,"context_line":"  \"get me a network\" feature via nova microversion should also add support for"},{"line_number":55,"context_line":"  doing the client-side workaround."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* If openstacksdk is aware of logic for more than one microversion, it should"},{"line_number":58,"context_line":"  always attempt to use the latest version available for the service for that"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_88727e11","line":55,"in_reply_to":"5f7c97a3_7f56cc2c","updated":"2018-05-29 14:06:43.000000000","message":"Sure! It\u0027s called the REST layer. ;)\n\nSeriously though- its definitely an idea to consider - at least at the resource layer. (this will be a good question as we start to merge methods from the shade layer into the proxy objects of the resource layer - how much magic is the right amount of magic at that layer, and how much should be reserved for the cloud layer?)","commit_id":"f184f3e5eada55cc87152385b738dbb7490add49"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e346f00c13fee20851bf398b7921faeb16e85053","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  old microversion on the cloud in question. In the case where an old"},{"line_number":76,"context_line":"  microversion is no longer available, care must be taken to either find the"},{"line_number":77,"context_line":"  data from another source and fill it in, or to put a value of None into the"},{"line_number":78,"context_line":"  field and document for the user that on some clouds the value may not exist."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* If a microversion removes a field and the outcome is particularly intractable"},{"line_number":81,"context_line":"  and impossible to work around without fundamentally breaking users,"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_9f53a839","line":78,"updated":"2018-05-28 08:58:48.000000000","message":"(thinking aloud) this poses an interesting problem, if we ever promised that a value is not None. My favourite example is Server\u0027s flavor field. Before some point it contained a link (id) to a Flavor, after that point - only flavor information. Not sure what to recommend people in this situation.","commit_id":"f184f3e5eada55cc87152385b738dbb7490add49"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"06850d54c7c417566ee115b29c316a6c2af8abe0","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  old microversion on the cloud in question. In the case where an old"},{"line_number":76,"context_line":"  microversion is no longer available, care must be taken to either find the"},{"line_number":77,"context_line":"  data from another source and fill it in, or to put a value of None into the"},{"line_number":78,"context_line":"  field and document for the user that on some clouds the value may not exist."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* If a microversion removes a field and the outcome is particularly intractable"},{"line_number":81,"context_line":"  and impossible to work around without fundamentally breaking users,"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f7c97a3_88559e20","line":78,"in_reply_to":"5f7c97a3_9f53a839","updated":"2018-05-29 14:06:43.000000000","message":"Indeed. I this is a good example of where we have to keep our API with our users in mind - and why we need to use judgment in adding support for specific microversions. In that case I\u0027m not sure whether it would be correct to make the call using the old microversion as we do now and then a followup call to flesh out the flavor info from the id) or to switch to the new microversion which already has the data we were fetching in the second call - but might be missing an id field.\n\nThat\u0027ll be a fun patch to think about.","commit_id":"f184f3e5eada55cc87152385b738dbb7490add49"}],"openstack/config/cloud_region.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ebd428f7519b263051eb71ccdd74df1405987681","unresolved":false,"context_lines":[{"line_number":353,"context_line":"            # Neutron springs to mind with version \"2.0\". If a user has \"2.0\""},{"line_number":354,"context_line":"            # set in a variable or config file just because history, we don\u0027t"},{"line_number":355,"context_line":"            # need to send any microversion headers."},{"line_number":356,"context_line":"            if version.split(\u0027.\u0027)[1] !\u003d \"0\":"},{"line_number":357,"context_line":"                default_microversion \u003d version"},{"line_number":358,"context_line":"                # If we\u0027re inferring a microversion, don\u0027t pass the whole"},{"line_number":359,"context_line":"                # string in as api_version, since that tells keystoneauth"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f7c97a3_a8897a6f","line":356,"updated":"2018-06-11 16:03:49.000000000","message":"Why not do similar logic when default_microversion is provided? I\u0027m afraid of people doing\n\n baremetal_api_version: 1.42\n baremetal_default_microversion: 1.42","commit_id":"264c802ad86225503697a1b860192e31f11411fa"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"7400e108aa6839e3999095eb57f092e413c76834","unresolved":false,"context_lines":[{"line_number":353,"context_line":"            # Neutron springs to mind with version \"2.0\". If a user has \"2.0\""},{"line_number":354,"context_line":"            # set in a variable or config file just because history, we don\u0027t"},{"line_number":355,"context_line":"            # need to send any microversion headers."},{"line_number":356,"context_line":"            if version.split(\u0027.\u0027)[1] !\u003d \"0\":"},{"line_number":357,"context_line":"                default_microversion \u003d version"},{"line_number":358,"context_line":"                # If we\u0027re inferring a microversion, don\u0027t pass the whole"},{"line_number":359,"context_line":"                # string in as api_version, since that tells keystoneauth"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f7c97a3_cb20704c","line":356,"in_reply_to":"5f7c97a3_8be1182e","updated":"2018-06-11 16:39:45.000000000","message":"I\u0027ll do that as a followup","commit_id":"264c802ad86225503697a1b860192e31f11411fa"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"e6aaa4c0602d6c0332a24774f29d74beddf00fd7","unresolved":false,"context_lines":[{"line_number":353,"context_line":"            # Neutron springs to mind with version \"2.0\". If a user has \"2.0\""},{"line_number":354,"context_line":"            # set in a variable or config file just because history, we don\u0027t"},{"line_number":355,"context_line":"            # need to send any microversion headers."},{"line_number":356,"context_line":"            if version.split(\u0027.\u0027)[1] !\u003d \"0\":"},{"line_number":357,"context_line":"                default_microversion \u003d version"},{"line_number":358,"context_line":"                # If we\u0027re inferring a microversion, don\u0027t pass the whole"},{"line_number":359,"context_line":"                # string in as api_version, since that tells keystoneauth"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f7c97a3_eb652ce2","line":356,"in_reply_to":"5f7c97a3_a8897a6f","updated":"2018-06-11 16:32:29.000000000","message":"I think I\u0027m more afraid of people doing:\n\n  baremetal_api_version: 1.42\n  baremetal_default_microversion: 1.6\n\nNow what do we do? They\u0027ve been explicit about default_microversion - but they\u0027ve also put a microversion formatted version in api_version. Perhaps we should, in fact, throw an error if default_microversion is set and there is also a microversion in api_version (since it\u0027s not obvious what the user is wanting)","commit_id":"264c802ad86225503697a1b860192e31f11411fa"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5530955d18bf94ec8c5fbacdf0f1d7123e388f6e","unresolved":false,"context_lines":[{"line_number":353,"context_line":"            # Neutron springs to mind with version \"2.0\". If a user has \"2.0\""},{"line_number":354,"context_line":"            # set in a variable or config file just because history, we don\u0027t"},{"line_number":355,"context_line":"            # need to send any microversion headers."},{"line_number":356,"context_line":"            if version.split(\u0027.\u0027)[1] !\u003d \"0\":"},{"line_number":357,"context_line":"                default_microversion \u003d version"},{"line_number":358,"context_line":"                # If we\u0027re inferring a microversion, don\u0027t pass the whole"},{"line_number":359,"context_line":"                # string in as api_version, since that tells keystoneauth"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f7c97a3_8be1182e","line":356,"in_reply_to":"5f7c97a3_eb652ce2","updated":"2018-06-11 16:36:37.000000000","message":"\u003e Perhaps we should, in fact, throw an error if default_microversion is set and there is also a microversion in api_version\n\n++","commit_id":"264c802ad86225503697a1b860192e31f11411fa"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ebd428f7519b263051eb71ccdd74df1405987681","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            default_microversion\u003dversion_request.default_microversion,"},{"line_number":396,"context_line":"            **kwargs)"},{"line_number":397,"context_line":"        if version_request.default_microversion:"},{"line_number":398,"context_line":"            default_microversion \u003d version_request.default_microversion"},{"line_number":399,"context_line":"            info \u003d client.get_endpoint_data()"},{"line_number":400,"context_line":"            if not discover.version_between("},{"line_number":401,"context_line":"                    info.min_microversion,"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f7c97a3_48e8e614","line":398,"updated":"2018-06-11 16:03:49.000000000","message":"nit: move before \"if\"","commit_id":"264c802ad86225503697a1b860192e31f11411fa"}],"openstack/config/defaults.json":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2e72354f24447abe3e7e37bf044e7fd326507320","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  \"application_catalog_api_version\": \"1\","},{"line_number":3,"context_line":"  \"auth_type\": \"password\","},{"line_number":4,"context_line":"  \"baremetal_api_version\": \"1\","},{"line_number":5,"context_line":"  \"baremetal_default_microversion\": \"1.6\","},{"line_number":6,"context_line":"  \"block_storage_api_version\": \"2\","},{"line_number":7,"context_line":"  \"container_api_version\": \"1\","},{"line_number":8,"context_line":"  \"container_infra_api_version\": \"1\","}],"source_content_type":"application/json","patch_set":15,"id":"5f7c97a3_23711277","line":5,"updated":"2018-05-29 09:44:52.000000000","message":"Actually, how does the very existance of default versions play with your statement that the SDK should try to use the latest version?","commit_id":"f184f3e5eada55cc87152385b738dbb7490add49"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e346f00c13fee20851bf398b7921faeb16e85053","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  \"application_catalog_api_version\": \"1\","},{"line_number":3,"context_line":"  \"auth_type\": \"password\","},{"line_number":4,"context_line":"  \"baremetal_api_version\": \"1\","},{"line_number":5,"context_line":"  \"baremetal_default_microversion\": \"1.6\","},{"line_number":6,"context_line":"  \"block_storage_api_version\": \"2\","},{"line_number":7,"context_line":"  \"container_api_version\": \"1\","},{"line_number":8,"context_line":"  \"container_infra_api_version\": \"1\","}],"source_content_type":"application/json","patch_set":15,"id":"5f7c97a3_ff42dc67","line":5,"updated":"2018-05-28 08:58:48.000000000","message":"I\u0027d prefer we change baremetal_api_version, but it\u0027s not blocking.","commit_id":"f184f3e5eada55cc87152385b738dbb7490add49"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"06850d54c7c417566ee115b29c316a6c2af8abe0","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  \"application_catalog_api_version\": \"1\","},{"line_number":3,"context_line":"  \"auth_type\": \"password\","},{"line_number":4,"context_line":"  \"baremetal_api_version\": \"1\","},{"line_number":5,"context_line":"  \"baremetal_default_microversion\": \"1.6\","},{"line_number":6,"context_line":"  \"block_storage_api_version\": \"2\","},{"line_number":7,"context_line":"  \"container_api_version\": \"1\","},{"line_number":8,"context_line":"  \"container_infra_api_version\": \"1\","}],"source_content_type":"application/json","patch_set":15,"id":"5f7c97a3_a8141aea","line":5,"in_reply_to":"5f7c97a3_23711277","updated":"2018-05-29 14:06:43.000000000","message":"Yes - exactly! These are what\u0027s in use currently, but in another couple of patches we should be fully on discovery and can get rid of these.","commit_id":"f184f3e5eada55cc87152385b738dbb7490add49"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a0d4a1d83bfa5d91a5bbab70898f2719f101d255","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  \"application_catalog_api_version\": \"1\","},{"line_number":3,"context_line":"  \"auth_type\": \"password\","},{"line_number":4,"context_line":"  \"baremetal_api_version\": \"1\","},{"line_number":5,"context_line":"  \"baremetal_default_microversion\": \"1.6\","},{"line_number":6,"context_line":"  \"block_storage_api_version\": \"2\","},{"line_number":7,"context_line":"  \"container_api_version\": \"1\","},{"line_number":8,"context_line":"  \"container_infra_api_version\": \"1\","}],"source_content_type":"application/json","patch_set":15,"id":"5f7c97a3_eb5c4c4c","line":5,"in_reply_to":"5f7c97a3_a8141aea","updated":"2018-05-29 15:08:27.000000000","message":"Okay, so I think I\u0027m kind of -1 on putting this here. If it\u0027s going to go away before the next release - fine, but otherwise I\u0027d prefer we don\u0027t default to a (semi) randomly chosen version.","commit_id":"f184f3e5eada55cc87152385b738dbb7490add49"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"e6aaa4c0602d6c0332a24774f29d74beddf00fd7","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  \"application_catalog_api_version\": \"1\","},{"line_number":3,"context_line":"  \"auth_type\": \"password\","},{"line_number":4,"context_line":"  \"baremetal_api_version\": \"1\","},{"line_number":5,"context_line":"  \"baremetal_default_microversion\": \"1.6\","},{"line_number":6,"context_line":"  \"block_storage_api_version\": \"2\","},{"line_number":7,"context_line":"  \"container_api_version\": \"1\","},{"line_number":8,"context_line":"  \"container_infra_api_version\": \"1\","}],"source_content_type":"application/json","patch_set":15,"id":"5f7c97a3_33d89a51","line":5,"in_reply_to":"5f7c97a3_eb5c4c4c","updated":"2018-06-11 16:32:29.000000000","message":"After chatting in IRC - my understanding of the ironic default microversion in shade was in error. I\u0027m removing this and keeping the specific version usage in the shade code.","commit_id":"f184f3e5eada55cc87152385b738dbb7490add49"}]}