)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"889fd49f0d9ba2cee9ccdb68d6b18ee1fd1293f3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"as the name in the URL will return a 404."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The `name` parameter for a recordset needs to be the full FQDN"},{"line_number":14,"context_line":"including the zone part. Fix the tests accordingly."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Also harmonised the naming of vars in the recordset"},{"line_number":17,"context_line":"section to make this clearer."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf659307_7c46a6c2","line":14,"updated":"2018-04-13 07:43:06.000000000","message":"FWIW I\u0027m not 100% sure that this is the solution we want, but this way the behaviour is similar to what users of the CLI would be expecting. It also avoids having to change the ABI, which might break existing applications.\n\nThe alternative would be to fix the functions to match what the original tests expect, but then I guess we\u0027d need to make it consistent across all calls including delete.","commit_id":"55cf236077fdbf6239322541f2dd34b87de4f714"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"3feab0d6dae7d8e8d965f0c13c361ee40f369fd6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"as the name in the URL will return a 404."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The `name` parameter for a recordset needs to be the full FQDN"},{"line_number":14,"context_line":"including the zone part. Fix the tests accordingly."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Also harmonised the naming of vars in the recordset"},{"line_number":17,"context_line":"section to make this clearer."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf659307_e999906c","line":14,"in_reply_to":"bf659307_7c46a6c2","updated":"2018-04-13 13:54:42.000000000","message":"from IRC:\n\n\u003e  14:51:48 \u003cmugsie\u003e frickler: for the name parameter, we could do what we did in the client - and if you provide a name without a trailing \u0027.\u0027 we append the zone name\n\u003e 14:52:27 \u003cmugsie\u003e does that seem sane? that way people who actually have it working would have needed the \u0027.\u0027 and people who want to add a bare label going forward can?","commit_id":"55cf236077fdbf6239322541f2dd34b87de4f714"}],"openstack/tests/functional/cloud/test_recordset.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"792a781cb9913bf9d6d98c93a8ce775386e824f1","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        if not self.user_cloud.has_service(\u0027dns\u0027):"},{"line_number":30,"context_line":"            self.skipTest(\u0027dns service not supported by cloud\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def test_recordsets(self):"},{"line_number":33,"context_line":"        \u0027\u0027\u0027Test DNS recordsets functionality\u0027\u0027\u0027"},{"line_number":34,"context_line":"        zone \u003d \u0027example2.net.\u0027"},{"line_number":35,"context_line":"        email \u003d \u0027test@example2.net\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_57cdf12e","line":32,"updated":"2018-04-11 16:59:42.000000000","message":"Can we rename this to test_recordsets_with_zone_id for consistency or do we need to keep the original test name for some reason? In the latter case, I\u0027d still vote to change the name for this test and keep the second one because that has the original functionality.","commit_id":"207c335bfe1dbe9388fd2d1534da66772a5e1b25"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"5717bda786d46e92a2310d5d1200164aa75dcd36","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        if not self.user_cloud.has_service(\u0027dns\u0027):"},{"line_number":30,"context_line":"            self.skipTest(\u0027dns service not supported by cloud\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def test_recordsets(self):"},{"line_number":33,"context_line":"        \u0027\u0027\u0027Test DNS recordsets functionality\u0027\u0027\u0027"},{"line_number":34,"context_line":"        zone \u003d \u0027example2.net.\u0027"},{"line_number":35,"context_line":"        email \u003d \u0027test@example2.net\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_371b9d81","line":32,"in_reply_to":"bf659307_57cdf12e","updated":"2018-04-11 17:03:02.000000000","message":"Sure - I am not aware of any need to keep the name the same, will update","commit_id":"207c335bfe1dbe9388fd2d1534da66772a5e1b25"}]}