)]}'
{"openstack/network/v2/floating_ip.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8c53318dca63eed92578fa965cb359d153c575b0","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        # server-side filtering on empty values is not always supported."},{"line_number":83,"context_line":"        # Send the server-side filter, but also filter client side. Otherwise"},{"line_number":84,"context_line":"        # this can return floating ips that are not, in fact, available."},{"line_number":85,"context_line":"        for ip in cls.list(session, port_id\u003d\u0027\u0027):"},{"line_number":86,"context_line":"            if ip.port_id is None:"},{"line_number":87,"context_line":"                return ip"},{"line_number":88,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_b3697426","line":85,"updated":"2018-05-04 19:47:04.000000000","message":"maybe (just thinking) instead of filtering on both server side and client side, You could check if \"empty-string-filtering\" (according to https://review.openstack.org/#/c/545490/19/neutron/extensions/_empty_string_filtering_lib.py) API extension is available in neutron ext-list. If it\u0027s available, server side filtering fir empt string works fine, if not, do it on client\u0027s side.\nWhat You think about such solution?","commit_id":"d2e28cf5b8859f6302373ef9353b08dbf96e10db"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"f2d156a8f6115c1a625a8896e806adc46c00c07e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        # server-side filtering on empty values is not always supported."},{"line_number":83,"context_line":"        # Send the server-side filter, but also filter client side. Otherwise"},{"line_number":84,"context_line":"        # this can return floating ips that are not, in fact, available."},{"line_number":85,"context_line":"        for ip in cls.list(session, port_id\u003d\u0027\u0027):"},{"line_number":86,"context_line":"            if ip.port_id is None:"},{"line_number":87,"context_line":"                return ip"},{"line_number":88,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_ba17d745","line":85,"in_reply_to":"5f7c97a3_b3697426","updated":"2018-05-08 14:46:30.000000000","message":"Yes! I definitely want to do that. Gonna land this as is for now, then do that as followup","commit_id":"d2e28cf5b8859f6302373ef9353b08dbf96e10db"}],"tox.ini":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e4294c5aa7d87a017b802a107d3d5c9cd10724cd","unresolved":false,"context_lines":[{"line_number":95,"context_line":"# H306 Is about alphabetical imports - there\u0027s a lot to fix."},{"line_number":96,"context_line":"# H4 Are about docstrings and there\u0027s just a huge pile of pre-existing issues."},{"line_number":97,"context_line":"# D* Came from sdk, unknown why they\u0027re skipped."},{"line_number":98,"context_line":"ignore \u003d H103,H306,H4,D100,D101,D102,D103,D104,D105,D200,D202,D204,D205,D211,D301,D400,D401,F405,W503"},{"line_number":99,"context_line":"show-source \u003d True"},{"line_number":100,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,build"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"5f7c97a3_95774003","line":98,"updated":"2018-05-09 06:52:47.000000000","message":"Maybe add a comment about the new additions above for future generations?","commit_id":"a310e567c10de056350183bfa4dbcc7f4826c1b5"}]}