)]}'
{"openstack/cloud/meta.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"455ce2eb67f711bf870f32edd847882daa0af229","unresolved":false,"context_lines":[{"line_number":253,"context_line":"                            connect_socket.settimeout(1)"},{"line_number":254,"context_line":"                            connect_socket.connect(sa)"},{"line_number":255,"context_line":"                            return address"},{"line_number":256,"context_line":"                    except socket.error:"},{"line_number":257,"context_line":"                        # Sometimes a \"no route to address\" type error"},{"line_number":258,"context_line":"                        # will fail fast, but can often come alive"},{"line_number":259,"context_line":"                        # when retried."}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_56d489e9","line":256,"updated":"2018-06-17 09:23:27.000000000","message":"why not catch the exception inside the for loop? then we would still try other addresses","commit_id":"850b99bf8ccf7e3fe5baf4dd90232cc1bea0be59"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"04e7f1b154d208f38711978531e9b21e7e170214","unresolved":false,"context_lines":[{"line_number":253,"context_line":"                            connect_socket.settimeout(1)"},{"line_number":254,"context_line":"                            connect_socket.connect(sa)"},{"line_number":255,"context_line":"                            return address"},{"line_number":256,"context_line":"                    except socket.error:"},{"line_number":257,"context_line":"                        # Sometimes a \"no route to address\" type error"},{"line_number":258,"context_line":"                        # will fail fast, but can often come alive"},{"line_number":259,"context_line":"                        # when retried."}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_a77fe5dd","line":256,"in_reply_to":"5f7c97a3_56d489e9","updated":"2018-06-18 00:06:44.000000000","message":"Are we ever going to have an actual hostname, as opposed to an ip-address coming in here?  ergo i\u0027m not sure in practice we\u0027d actually see multiple addresses?","commit_id":"850b99bf8ccf7e3fe5baf4dd90232cc1bea0be59"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"53489dd743c9422a53f104f349c49993b17981fc","unresolved":false,"context_lines":[{"line_number":253,"context_line":"                            connect_socket.settimeout(1)"},{"line_number":254,"context_line":"                            connect_socket.connect(sa)"},{"line_number":255,"context_line":"                            return address"},{"line_number":256,"context_line":"                    except socket.error:"},{"line_number":257,"context_line":"                        # Sometimes a \"no route to address\" type error"},{"line_number":258,"context_line":"                        # will fail fast, but can often come alive"},{"line_number":259,"context_line":"                        # when retried."}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_3b73edb6","line":256,"in_reply_to":"5f7c97a3_a77fe5dd","updated":"2018-06-18 08:55:58.000000000","message":"I\u0027m not sure. If we do have a hostname, we can end up with both IPv6 and IPv4 appearing here, while only one of them may be practically available.. I think moving try..except to under the cycle will make the code a bit cleaner. On the other hand - getaddrinfo itself may fail. So maybe leave it as it is.","commit_id":"850b99bf8ccf7e3fe5baf4dd90232cc1bea0be59"}]}