)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"71a3ab939926758b9d2ed2b6a6b927db408124b5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Keystone has changed the default role during bootstrap from \u0027Member\u0027"},{"line_number":10,"context_line":"to \u0027member\u0027 therefore the tests which operated under the assumption"},{"line_number":11,"context_line":"of having the \u0027Member\u0027 role assigned are no longer passing."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch addresses this issue, however, long term, it\u0027s probably"},{"line_number":14,"context_line":"better to create a role and assign it during the test rather than"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_b535b347","line":11,"updated":"2018-06-19 05:05:29.000000000","message":"IIUC this is incorrect, \u0027Member\u0027 seems to be a pure devstack thing. Keystone bootstrap now creates \u0027member\u0027 in an attempt to unify assumptions. Both are the same thing to keystone, just spelled differently.\n\nThe main issue is that role names are treated case-insensitively by keystone, so I\u0027m wondering why this isn\u0027t true for sdk + shade, too. Running \"openstack role show Member\" does show the \"member\" role fine.","commit_id":"130010db36fcca4d65392d9dc3b1fe4f23e8a1b2"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"fac9a642e585345379ca8606861c041201570d55","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Keystone has changed the default role during bootstrap from \u0027Member\u0027"},{"line_number":10,"context_line":"to \u0027member\u0027 therefore the tests which operated under the assumption"},{"line_number":11,"context_line":"of having the \u0027Member\u0027 role assigned are no longer passing."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch addresses this issue, however, long term, it\u0027s probably"},{"line_number":14,"context_line":"better to create a role and assign it during the test rather than"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_f7a485a5","line":11,"in_reply_to":"5f7c97a3_575459fe","updated":"2018-06-19 13:52:46.000000000","message":"Awesome. Well - shade/openstacksdk are currently imposing case sensitivity on top of keystone by accident - so there\u0027s definitely some work we should do to rectify that.","commit_id":"130010db36fcca4d65392d9dc3b1fe4f23e8a1b2"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"92445a0047bf2c18ae9eb9000230cad03c9f8e60","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Keystone has changed the default role during bootstrap from \u0027Member\u0027"},{"line_number":10,"context_line":"to \u0027member\u0027 therefore the tests which operated under the assumption"},{"line_number":11,"context_line":"of having the \u0027Member\u0027 role assigned are no longer passing."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch addresses this issue, however, long term, it\u0027s probably"},{"line_number":14,"context_line":"better to create a role and assign it during the test rather than"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_e50a9025","line":11,"in_reply_to":"5f7c97a3_b535b347","updated":"2018-06-19 12:00:19.000000000","message":"The issue is that we have a general purpose utility for finding resources by name or id that does client-side filtering on the id or name attributes. I had no idea that keystone had decided to be case-insensitive with one of them.\n\nI guess we should add support for filtering name-or-id case insensitively and then use it in keystone.","commit_id":"130010db36fcca4d65392d9dc3b1fe4f23e8a1b2"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"169cc6e2d8e906e8728177060d329f06749c8c53","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Keystone has changed the default role during bootstrap from \u0027Member\u0027"},{"line_number":10,"context_line":"to \u0027member\u0027 therefore the tests which operated under the assumption"},{"line_number":11,"context_line":"of having the \u0027Member\u0027 role assigned are no longer passing."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch addresses this issue, however, long term, it\u0027s probably"},{"line_number":14,"context_line":"better to create a role and assign it during the test rather than"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_575459fe","line":11,"in_reply_to":"5f7c97a3_e50a9025","updated":"2018-06-19 13:39:16.000000000","message":"FWIW - case-insensitivity is because MySQL is case-insensitive by default. `POST member` and then `POST Member` returns a 409 because MySQL sees the two as being the same.\n\nI was talking with Morgan a bit yesterday about this and we could make role names case-sensitive, but it would require migrations and some other work. This is consistent with user names and project names, both are treated as case-insensitive in keystone for the same reason.","commit_id":"130010db36fcca4d65392d9dc3b1fe4f23e8a1b2"}],"openstack/tests/functional/cloud/test_users.py":[{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"93308f7c04c10cfad39ad63b31b29155b9cf0cff","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        self.assertEqual(user_email, new_user[\u0027email\u0027])"},{"line_number":128,"context_line":"        self.assertTrue(new_user[\u0027enabled\u0027])"},{"line_number":129,"context_line":"        self.assertTrue(self.operator_cloud.grant_role("},{"line_number":130,"context_line":"            \u0027member\u0027, user\u003duser[\u0027id\u0027], project\u003d\u0027demo\u0027, wait\u003dTrue))"},{"line_number":131,"context_line":"        self.addCleanup("},{"line_number":132,"context_line":"            self.operator_cloud.revoke_role,"},{"line_number":133,"context_line":"            \u0027member\u0027, user\u003duser[\u0027id\u0027], project\u003d\u0027demo\u0027, wait\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_71608a0e","line":130,"updated":"2018-06-19 09:07:38.000000000","message":"Kindly look into functional test failed here.\n\nshade.exc.OpenStackCloudException: Role Member not found.","commit_id":"130010db36fcca4d65392d9dc3b1fe4f23e8a1b2"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"92445a0047bf2c18ae9eb9000230cad03c9f8e60","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        self.assertEqual(user_email, new_user[\u0027email\u0027])"},{"line_number":128,"context_line":"        self.assertTrue(new_user[\u0027enabled\u0027])"},{"line_number":129,"context_line":"        self.assertTrue(self.operator_cloud.grant_role("},{"line_number":130,"context_line":"            \u0027member\u0027, user\u003duser[\u0027id\u0027], project\u003d\u0027demo\u0027, wait\u003dTrue))"},{"line_number":131,"context_line":"        self.addCleanup("},{"line_number":132,"context_line":"            self.operator_cloud.revoke_role,"},{"line_number":133,"context_line":"            \u0027member\u0027, user\u003duser[\u0027id\u0027], project\u003d\u0027demo\u0027, wait\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_a5049819","line":130,"in_reply_to":"5f7c97a3_71608a0e","updated":"2018-06-19 12:00:19.000000000","message":"Yes - this should be fixed by https://review.openstack.org/#/c/576308/","commit_id":"130010db36fcca4d65392d9dc3b1fe4f23e8a1b2"}]}