)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"ff4119b10ed77f6470ccaafd0710185feb8e3e4c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     wacuuu \u003cjwalecki1996@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-07-02 22:19:29 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implementing solution for 2002563 issue from story board"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Includes:"},{"line_number":10,"context_line":"patch in _get_grant_revoke_params to work with domain_id"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_46e537da","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":56},"updated":"2018-07-05 19:28:40.000000000","message":"For next time, it\u0027s better to make the commit subject a short description of the work, and then the body explain why - with maybe a small summary of what was done. This way reviewers can review the patch and understand it without needing to go read an entire bug.\n\nIt might be worth reading https://wiki.openstack.org/wiki/GitCommitMessages if you haven\u0027t already.","commit_id":"3fce613297865a6f9ab6657b4c84ce1e269f58d4"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"ff4119b10ed77f6470ccaafd0710185feb8e3e4c","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Fixed UT to work with change"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ic892f028e1a3468abaafdcd079ae0142104b6f97"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_c6d067f7","line":14,"updated":"2018-07-05 19:28:40.000000000","message":"You can also add commit message footers to link to the story in storyboard, such as:\n\nStory: 2002563","commit_id":"3fce613297865a6f9ab6657b4c84ce1e269f58d4"}],"openstack/cloud/openstackcloud.py":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"ff4119b10ed77f6470ccaafd0710185feb8e3e4c","unresolved":false,"context_lines":[{"line_number":10889,"context_line":""},{"line_number":10890,"context_line":"        if user:"},{"line_number":10891,"context_line":"            if domain:"},{"line_number":10892,"context_line":"                data[\u0027user\u0027] \u003d self.get_user(user,"},{"line_number":10893,"context_line":"                                             domain_id\u003dfilters[\u0027domain_id\u0027],"},{"line_number":10894,"context_line":"                                             filters\u003dfilters)"},{"line_number":10895,"context_line":"            else:"},{"line_number":10896,"context_line":"                data[\u0027user\u0027] \u003d self.get_user(user, filters\u003dfilters)"},{"line_number":10897,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_c6a2a797","line":10894,"range":{"start_line":10892,"start_character":31,"end_line":10894,"end_character":61},"updated":"2018-07-05 19:28:40.000000000","message":"I recommend line breaks after the ( instead of lined up on the first parameter, like:\n\n  data[\u0027user\u0027] \u003d self.get_user(\n      user,\n      domain_id\u003dfilters[\u0027domain_id\u0027],\n      filters)\n\nThe reason is that if a refactor happens at some point in the future that changes the data[\u0027user\u0027] \u003d self.get_user( line (like, for instance, if we decided to change the name of the data variable) - then we don\u0027t have to re-indent all of the parameters.\n\nI\u0027ve been trying to consistently indent in that manner in the codebase - although there are certainly visual indentation in places.","commit_id":"3fce613297865a6f9ab6657b4c84ce1e269f58d4"}],"openstack/tests/unit/cloud/test_role_assignment.py":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"ff4119b10ed77f6470ccaafd0710185feb8e3e4c","unresolved":false,"context_lines":[{"line_number":663,"context_line":"                 json\u003dself.domain_data.json_response),"},{"line_number":664,"context_line":"            dict(method\u003d\u0027GET\u0027,"},{"line_number":665,"context_line":"                 uri\u003dself.get_mock_url(resource\u003d\u0027users\u0027,"},{"line_number":666,"context_line":"                                       qs_elements\u003d[\u0027domain_id\u003d%s\u0027 %"},{"line_number":667,"context_line":"                                                    self.domain_data."},{"line_number":668,"context_line":"                                                    domain_id]),"},{"line_number":669,"context_line":"                 complete_qs\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_862d8ffe","line":666,"updated":"2018-07-05 19:28:40.000000000","message":"This is an instance where the existing code is visually indented - so you definitely did the right thing by matching it. However, you can see the trouble it causes shifting everything so far to the right so that \u0027domain_id\u003d%s\u0027 % self.domain_data is split across lines.\n\n(It\u0027s probably not worth the churn in the codebase to fix the file though - I\u0027m just being extra verbose)","commit_id":"3fce613297865a6f9ab6657b4c84ce1e269f58d4"}]}