)]}'
{"openstack/identity/v3/registered_limit.py":[{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"96630b73eb292adb1863c86c37625bf56de49ceb","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    service_id \u003d resource.Body(\u0027service_id\u0027)"},{"line_number":39,"context_line":"    #: ID of region, if any. *Type: string*"},{"line_number":40,"context_line":"    region_id \u003d resource.Body(\u0027region_id\u0027)"},{"line_number":41,"context_line":"    #: The resource name. *Type: string*"},{"line_number":42,"context_line":"    resource_name \u003d resource.Body(\u0027resource_name\u0027)"},{"line_number":43,"context_line":"    #: The default limit value. *Type: int*"},{"line_number":44,"context_line":"    default_limit \u003d resource.Body(\u0027default_limit\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_8192eb49","line":41,"updated":"2018-10-18 06:12:36.000000000","message":"we can add \u0027if any\u0027 in this comment to for consistency. As resource_name is also optional in some API calls.","commit_id":"391498a8e1323b5fa8864638e376b2cd4f74f71d"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"aeb29fd2589d6fe0bd75c00faee71eba7b7b8767","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    service_id \u003d resource.Body(\u0027service_id\u0027)"},{"line_number":39,"context_line":"    #: ID of region, if any. *Type: string*"},{"line_number":40,"context_line":"    region_id \u003d resource.Body(\u0027region_id\u0027)"},{"line_number":41,"context_line":"    #: The resource name. *Type: string*"},{"line_number":42,"context_line":"    resource_name \u003d resource.Body(\u0027resource_name\u0027)"},{"line_number":43,"context_line":"    #: The default limit value. *Type: int*"},{"line_number":44,"context_line":"    default_limit \u003d resource.Body(\u0027default_limit\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_641304b9","line":41,"in_reply_to":"3f79a3b5_5cefd8f9","updated":"2018-10-19 03:14:44.000000000","message":"ok. I gave comment considering all the CRUD options,like in update resource_name is optional. As we haven\u0027t mentioned here that it is for create or update.I think it\u0027s general that we are mentioning. But I got your point that it is not in terms of request body.","commit_id":"391498a8e1323b5fa8864638e376b2cd4f74f71d"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"6868a0d0e7b376a54a8f8ed24ee97a663b97081b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    service_id \u003d resource.Body(\u0027service_id\u0027)"},{"line_number":39,"context_line":"    #: ID of region, if any. *Type: string*"},{"line_number":40,"context_line":"    region_id \u003d resource.Body(\u0027region_id\u0027)"},{"line_number":41,"context_line":"    #: The resource name. *Type: string*"},{"line_number":42,"context_line":"    resource_name \u003d resource.Body(\u0027resource_name\u0027)"},{"line_number":43,"context_line":"    #: The default limit value. *Type: int*"},{"line_number":44,"context_line":"    default_limit \u003d resource.Body(\u0027default_limit\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_5cefd8f9","line":41,"in_reply_to":"3f79a3b5_8192eb49","updated":"2018-10-18 06:47:16.000000000","message":"No, resource_name is not a optional property for registered limit. It\u0027s just optional in request body when do updating action.","commit_id":"391498a8e1323b5fa8864638e376b2cd4f74f71d"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"96630b73eb292adb1863c86c37625bf56de49ceb","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    #: The resource name. *Type: string*"},{"line_number":42,"context_line":"    resource_name \u003d resource.Body(\u0027resource_name\u0027)"},{"line_number":43,"context_line":"    #: The default limit value. *Type: int*"},{"line_number":44,"context_line":"    default_limit \u003d resource.Body(\u0027default_limit\u0027)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _prepare_request_body(self, patch, prepend_key):"},{"line_number":47,"context_line":"        # the request body for creating registered_limit is a list instead of"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_6199cf69","line":44,"updated":"2018-10-18 06:12:36.000000000","message":"ditto","commit_id":"391498a8e1323b5fa8864638e376b2cd4f74f71d"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"96630b73eb292adb1863c86c37625bf56de49ceb","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _prepare_request_body(self, patch, prepend_key):"},{"line_number":47,"context_line":"        # the request body for creating registered_limit is a list instead of"},{"line_number":48,"context_line":"        # dict."},{"line_number":49,"context_line":"        body \u003d self._body.dirty"},{"line_number":50,"context_line":"        if prepend_key and self.resource_key is not None:"},{"line_number":51,"context_line":"            body \u003d {self.resources_key: [body]}"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_e1295ff1","line":48,"updated":"2018-10-18 06:12:36.000000000","message":"A doubt here, why we have explicitly stating that body is list not dict.? Can we also state the reason?","commit_id":"391498a8e1323b5fa8864638e376b2cd4f74f71d"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"6868a0d0e7b376a54a8f8ed24ee97a663b97081b","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _prepare_request_body(self, patch, prepend_key):"},{"line_number":47,"context_line":"        # the request body for creating registered_limit is a list instead of"},{"line_number":48,"context_line":"        # dict."},{"line_number":49,"context_line":"        body \u003d self._body.dirty"},{"line_number":50,"context_line":"        if prepend_key and self.resource_key is not None:"},{"line_number":51,"context_line":"            body \u003d {self.resources_key: [body]}"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_dc2c484b","line":48,"in_reply_to":"3f79a3b5_e1295ff1","updated":"2018-10-18 06:47:16.000000000","message":"We support bunch create for unified limit. So the request body should be list. See api-ref for detail. I\u0027ll write more in the comment.","commit_id":"391498a8e1323b5fa8864638e376b2cd4f74f71d"}],"openstack/resource.py":[{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"96630b73eb292adb1863c86c37625bf56de49ceb","unresolved":false,"context_lines":[{"line_number":873,"context_line":"        if requires_id is None:"},{"line_number":874,"context_line":"            requires_id \u003d self.requires_id"},{"line_number":875,"context_line":""},{"line_number":876,"context_line":"        body \u003d self._prepare_request_body(patch, prepend_key)"},{"line_number":877,"context_line":""},{"line_number":878,"context_line":"        # TODO(mordred) Ensure headers have string values better than this"},{"line_number":879,"context_line":"        headers \u003d {}"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_01981b74","line":876,"updated":"2018-10-18 06:12:36.000000000","message":"Just wanted to know the reason of this change? Does it enhance something?","commit_id":"391498a8e1323b5fa8864638e376b2cd4f74f71d"}]}