)]}'
{"openstack/cloud/openstackcloud.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"38885cc979b648ba1515ad73fa31b90ad274dd3c","unresolved":false,"context_lines":[{"line_number":9434,"context_line":""},{"line_number":9435,"context_line":"    def list_nics(self):"},{"line_number":9436,"context_line":"        \"\"\"Return a list of all bare metal ports.\"\"\""},{"line_number":9437,"context_line":"        return [nic for nic in self.baremetal.ports(details\u003dTrue)]"},{"line_number":9438,"context_line":""},{"line_number":9439,"context_line":"    def list_nics_for_machine(self, uuid):"},{"line_number":9440,"context_line":"        \"\"\"Returns a list of ports present on the machine node."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c2b81013","line":9437,"range":{"start_line":9437,"start_character":15,"end_line":9437,"end_character":66},"updated":"2018-10-16 15:22:33.000000000","message":"nit:\n\n list(self.baremetal.ports(details\u003dTrue))","commit_id":"a3ba7b0680c4c3152ce5a65883355c9f6368a4ac"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"38885cc979b648ba1515ad73fa31b90ad274dd3c","unresolved":false,"context_lines":[{"line_number":9444,"context_line":"        :returns: A list of ports."},{"line_number":9445,"context_line":"        \"\"\""},{"line_number":9446,"context_line":"        # TODO(dtantsur): support node names here."},{"line_number":9447,"context_line":"        return ["},{"line_number":9448,"context_line":"            nic for nic in self.baremetal.ports(details\u003dTrue, node_id\u003duuid)]"},{"line_number":9449,"context_line":""},{"line_number":9450,"context_line":"    def get_nic_by_mac(self, mac):"},{"line_number":9451,"context_line":"        \"\"\"Get bare metal NIC by its hardware address (usually MAC).\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_823458ad","line":9448,"range":{"start_line":9447,"start_character":15,"end_line":9448,"end_character":23},"updated":"2018-10-16 15:22:33.000000000","message":"ditto","commit_id":"a3ba7b0680c4c3152ce5a65883355c9f6368a4ac"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"38885cc979b648ba1515ad73fa31b90ad274dd3c","unresolved":false,"context_lines":[{"line_number":9449,"context_line":""},{"line_number":9450,"context_line":"    def get_nic_by_mac(self, mac):"},{"line_number":9451,"context_line":"        \"\"\"Get bare metal NIC by its hardware address (usually MAC).\"\"\""},{"line_number":9452,"context_line":"        results \u003d ["},{"line_number":9453,"context_line":"            nic for nic in self.baremetal.ports(address\u003dmac, details\u003dTrue)]"},{"line_number":9454,"context_line":"        try:"},{"line_number":9455,"context_line":"            return results[0]"},{"line_number":9456,"context_line":"        except IndexError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c24d703c","line":9453,"range":{"start_line":9452,"start_character":18,"end_line":9453,"end_character":27},"updated":"2018-10-16 15:22:33.000000000","message":"ditto. or even avoid building a list \n\n results \u003d self.baremetal.ports(address\u003dmac, details\u003dTrue)\n\n try:\n   return next(results)\n except StopIteration:\n   return None","commit_id":"a3ba7b0680c4c3152ce5a65883355c9f6368a4ac"}]}