)]}'
{"openstack/tests/functional/orchestration/v1/test_stack.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b5eaf98d6223b84dd13723efd54cfd418d1243ab","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.assertEqual(self.NAME, sot.name)"},{"line_number":60,"context_line":"        self.conn.orchestration.wait_for_status("},{"line_number":61,"context_line":"            sot, status\u003d\u0027CREATE_COMPLETE\u0027, failures\u003d[\u0027CREATE_FAILED\u0027],"},{"line_number":62,"context_line":"            wait\u003d300)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def tearDown(self):"},{"line_number":65,"context_line":"        self.conn.orchestration.delete_stack(self.stack, ignore_missing\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_5b4d493a","line":62,"updated":"2018-11-20 17:06:29.000000000","message":"maybe specify this via an environment variable?","commit_id":"e4b3eacd9bbeca20ef2e18352dafd1b6d316d8a5"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"19ea6164ad2041d3a2311bad6341b47e68fcd5bf","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.assertEqual(self.NAME, sot.name)"},{"line_number":60,"context_line":"        self.conn.orchestration.wait_for_status("},{"line_number":61,"context_line":"            sot, status\u003d\u0027CREATE_COMPLETE\u0027, failures\u003d[\u0027CREATE_FAILED\u0027],"},{"line_number":62,"context_line":"            wait\u003d300)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def tearDown(self):"},{"line_number":65,"context_line":"        self.conn.orchestration.delete_stack(self.stack, ignore_missing\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_bb881d25","line":62,"in_reply_to":"3f79a3b5_5b4d493a","updated":"2018-11-21 10:28:37.000000000","message":"was thinking about env, but not sure. Actually lots of func tests need to have increased timeout. It might be, that each case would/might need different value not to uselessly block tests. Do you think make sense to have single env var set everywhere in func tests?","commit_id":"e4b3eacd9bbeca20ef2e18352dafd1b6d316d8a5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3f287059f406f3a3c5a53b08004b664333d89732","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.assertEqual(self.NAME, sot.name)"},{"line_number":60,"context_line":"        self.conn.orchestration.wait_for_status("},{"line_number":61,"context_line":"            sot, status\u003d\u0027CREATE_COMPLETE\u0027, failures\u003d[\u0027CREATE_FAILED\u0027],"},{"line_number":62,"context_line":"            wait\u003d300)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def tearDown(self):"},{"line_number":65,"context_line":"        self.conn.orchestration.delete_stack(self.stack, ignore_missing\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ca5bb786","line":62,"in_reply_to":"3f79a3b5_bb881d25","updated":"2018-11-21 11:51:57.000000000","message":"Hmmm.. Maybe a hierarchy of variables? Something like, OPENSTACKSDK_HEAT_STACK_TIMEOUT defaulting to OPENSTACKSDK_TIMEOUT defaulting to 300? I\u0027m not sure the same value makes sense for all cases though..","commit_id":"e4b3eacd9bbeca20ef2e18352dafd1b6d316d8a5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b5eaf98d6223b84dd13723efd54cfd418d1243ab","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        # Need to wait for the stack to go away before network delete"},{"line_number":68,"context_line":"        try:"},{"line_number":69,"context_line":"            self.conn.orchestration.wait_for_status("},{"line_number":70,"context_line":"                self.stack, \u0027DELETE_COMPLETE\u0027, wait\u003d300)"},{"line_number":71,"context_line":"        except exceptions.ResourceNotFound:"},{"line_number":72,"context_line":"            pass"},{"line_number":73,"context_line":"        test_network.delete_network(self.conn, self.network, self.subnet)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_7b48452a","line":70,"updated":"2018-11-20 17:06:29.000000000","message":"ditto","commit_id":"e4b3eacd9bbeca20ef2e18352dafd1b6d316d8a5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"39c4b56480cbf7ecf983f1dbe28bc88fcf525e47","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def setUpClass(cls):"},{"line_number":32,"context_line":"        super(TestStack, cls).setUpClass()"},{"line_number":33,"context_line":"        cls._wait_for_timeout \u003d int(os.getenv("},{"line_number":34,"context_line":"            \u0027OPENSTACKSDK_FUNC_TEST_TIMEOUT_ORCHESTRATE\u0027,"},{"line_number":35,"context_line":"            cls._wait_for_timeout))"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_f1068622","line":34,"updated":"2018-11-23 09:18:38.000000000","message":"nit: ORCHESTRATION?","commit_id":"1ee9f6558b54e2706a8ea4ba60a5d896468f04bd"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"d708d2d858f0668537fa70f16c5a9476a4abc0b0","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def setUpClass(cls):"},{"line_number":32,"context_line":"        super(TestStack, cls).setUpClass()"},{"line_number":33,"context_line":"        cls._wait_for_timeout \u003d int(os.getenv("},{"line_number":34,"context_line":"            \u0027OPENSTACKSDK_FUNC_TEST_TIMEOUT_ORCHESTRATE\u0027,"},{"line_number":35,"context_line":"            cls._wait_for_timeout))"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_3c4cd572","line":34,"in_reply_to":"3f79a3b5_f1068622","updated":"2018-11-23 09:23:27.000000000","message":"Done","commit_id":"1ee9f6558b54e2706a8ea4ba60a5d896468f04bd"}]}