)]}'
{"openstack/compute/v2/server.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"5158042da1e83e4edcdd118b0ebf936bc8176d86","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":142,"context_line":"        super(Server, self).__init__(*args, **kwargs)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        if self._connection:"},{"line_number":145,"context_line":"            self.location \u003d self._connection._get_current_location("},{"line_number":146,"context_line":"                project_id\u003dself.project_id,"},{"line_number":147,"context_line":"                zone\u003dself.availability_zone)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_55334a63","side":"PARENT","line":144,"updated":"2019-02-05 09:50:08.000000000","message":"would you please be so kind to add a small comment to explain why is this necessary here?","commit_id":"85e1408e36397dfef11921967a7e4646feb45dd4"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"89dbd74e6481dc64b3742a4bf1989cee027783d2","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":142,"context_line":"        super(Server, self).__init__(*args, **kwargs)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        if self._connection:"},{"line_number":145,"context_line":"            self.location \u003d self._connection._get_current_location("},{"line_number":146,"context_line":"                project_id\u003dself.project_id,"},{"line_number":147,"context_line":"                zone\u003dself.availability_zone)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_cbb551cf","side":"PARENT","line":144,"in_reply_to":"9fdfeff1_55334a63","updated":"2019-02-05 19:52:40.000000000","message":"This is the one-off version that we were doing in server before this patch, and that this patch replaces.\n\nThe general gist is that location should describe the location of the resource. For some, where the resource doesn\u0027t have any baked-in notion, we assume it exists in the same project as the logged-in user\u0027s token.\n\nHowever, if a resource reports a project_id, then that project is where the resource lives, and the location should reflect that.","commit_id":"85e1408e36397dfef11921967a7e4646feb45dd4"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"17130e5eec9f3163548a793289bea3f85213cc40","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":142,"context_line":"        super(Server, self).__init__(*args, **kwargs)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        if self._connection:"},{"line_number":145,"context_line":"            self.location \u003d self._connection._get_current_location("},{"line_number":146,"context_line":"                project_id\u003dself.project_id,"},{"line_number":147,"context_line":"                zone\u003dself.availability_zone)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_0b1ef96f","side":"PARENT","line":144,"in_reply_to":"9fdfeff1_cbb551cf","updated":"2019-02-12 20:54:35.000000000","message":"\u003e This is the one-off version that we were doing in server before\n \u003e this patch, and that this patch replaces.\n \u003e \n \u003e The general gist is that location should describe the location of\n \u003e the resource. For some, where the resource doesn\u0027t have any\n \u003e baked-in notion, we assume it exists in the same project as the\n \u003e logged-in user\u0027s token.\n \u003e \n \u003e However, if a resource reports a project_id, then that project is\n \u003e where the resource lives, and the location should reflect that.","commit_id":"85e1408e36397dfef11921967a7e4646feb45dd4"}],"openstack/resource.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"04c25fcb0138e3889e80e930e3f4d7c16631f8c0","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        However, if a resource contains a project_id, then that project is"},{"line_number":620,"context_line":"        where the resource lives, and the location should reflect that."},{"line_number":621,"context_line":"        \"\"\""},{"line_number":622,"context_line":"        if not self._connection:"},{"line_number":623,"context_line":"            return"},{"line_number":624,"context_line":"        kwargs \u003d {}"},{"line_number":625,"context_line":"        if hasattr(self, \u0027project_id\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_4be1f89a","line":622,"updated":"2019-02-12 10:10:27.000000000","message":"Is it a real case? Oo","commit_id":"5a4ce4567b81081b37179e79edfa374b0862c6d5"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"17130e5eec9f3163548a793289bea3f85213cc40","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        However, if a resource contains a project_id, then that project is"},{"line_number":620,"context_line":"        where the resource lives, and the location should reflect that."},{"line_number":621,"context_line":"        \"\"\""},{"line_number":622,"context_line":"        if not self._connection:"},{"line_number":623,"context_line":"            return"},{"line_number":624,"context_line":"        kwargs \u003d {}"},{"line_number":625,"context_line":"        if hasattr(self, \u0027project_id\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_ba98de74","line":622,"in_reply_to":"9fdfeff1_4be1f89a","updated":"2019-02-12 20:54:35.000000000","message":"It can be - when blank resources get made like:\n\n  foo \u003d server.Server()\n  foo.name \u003d \"my-server\"\n  foo.commit(connection\u003dself.connection)\n\nIt\u0027s not a convenient way to program, but it\u0027s possible in places when using the resources like data structures.","commit_id":"5a4ce4567b81081b37179e79edfa374b0862c6d5"}]}