)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d611530b1863f151380f5a54aa213f3bcb3a6a2f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sergii Golovatiuk \u003csgolovat@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-02-15 12:01:05 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Log OpenStackCloudResourceNotFound exceptions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are cases where router between 2 networks is not created. It means"},{"line_number":10,"context_line":"that it\u0027s not possible to create floating ip as there are no"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_a6008935","line":7,"updated":"2019-02-15 14:47:15.000000000","message":"nit: \".. when attaching IPs\".","commit_id":"c0e3ef4d3de309a0140fa9030fd2731f39bda0b4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"14e8dec76c979a859a0da6f151151df749058338","unresolved":false,"context_lines":[{"line_number":11,"context_line":"may be no connectivity between networks at all. It\u0027s a legit error. This"},{"line_number":12,"context_line":"patch logs both neutron and nova messages. Also, it raises"},{"line_number":13,"context_line":"attach_ip_failed flag that helps not to wait for floating ip when both"},{"line_number":14,"context_line":"methods already failed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ie1fc5b28ea2febd5016bc653e5879b3b705515d6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fdfeff1_a3e3a0d7","line":14,"updated":"2019-02-28 10:49:02.000000000","message":"Why not raise an exception in this case?","commit_id":"d2ef322222919fdff915b9d9793402e6d1ee3578"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"9be969486c3f5add71a38857806cc68fea235bb9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"may be no connectivity between networks at all. It\u0027s a legit error. This"},{"line_number":12,"context_line":"patch logs both neutron and nova messages. Also, it raises"},{"line_number":13,"context_line":"attach_ip_failed flag that helps not to wait for floating ip when both"},{"line_number":14,"context_line":"methods already failed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ie1fc5b28ea2febd5016bc653e5879b3b705515d6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fdfeff1_fef37b71","line":14,"in_reply_to":"9fdfeff1_a3e3a0d7","updated":"2019-02-28 11:33:30.000000000","message":"I didn\u0027t want to change the logic. It\u0027s a question for Core Folks. I can update review and add raise in nova instead of attach_ip_failed.","commit_id":"d2ef322222919fdff915b9d9793402e6d1ee3578"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a0b4be0c5e7621a5087d6d2ea153d868e9b64474","unresolved":false,"context_lines":[{"line_number":11,"context_line":"may be no connectivity between networks at all. It\u0027s a legit error. This"},{"line_number":12,"context_line":"patch logs both neutron and nova messages. Also, it raises"},{"line_number":13,"context_line":"attach_ip_failed flag that helps not to wait for floating ip when both"},{"line_number":14,"context_line":"methods already failed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ie1fc5b28ea2febd5016bc653e5879b3b705515d6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fdfeff1_52563b2c","line":14,"in_reply_to":"9fdfeff1_fef37b71","updated":"2019-02-28 12:18:40.000000000","message":"I think the current logic is to fail if all methods fail, no?","commit_id":"d2ef322222919fdff915b9d9793402e6d1ee3578"}],"openstack/cloud/openstackcloud.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d611530b1863f151380f5a54aa213f3bcb3a6a2f","unresolved":false,"context_lines":[{"line_number":6227,"context_line":"                except exc.OpenStackCloudResourceNotFound as e:"},{"line_number":6228,"context_line":"                    self.log.error("},{"line_number":6229,"context_line":"                        \"Error attaching IP: \""},{"line_number":6230,"context_line":"                        \"\u0027%(msg)s\u0027.\", {\u0027msg\u0027: str(e)})"},{"line_number":6231,"context_line":"                    raise"},{"line_number":6232,"context_line":"                except exc.OpenStackCloudURINotFound as e:"},{"line_number":6233,"context_line":"                    self.log.debug("}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_46fbdd45","line":6230,"updated":"2019-02-15 14:47:15.000000000","message":"nit: str is not needed, it\u0027s done automatically by %s","commit_id":"c0e3ef4d3de309a0140fa9030fd2731f39bda0b4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d611530b1863f151380f5a54aa213f3bcb3a6a2f","unresolved":false,"context_lines":[{"line_number":6229,"context_line":"                        \"Error attaching IP: \""},{"line_number":6230,"context_line":"                        \"\u0027%(msg)s\u0027.\", {\u0027msg\u0027: str(e)})"},{"line_number":6231,"context_line":"                    raise"},{"line_number":6232,"context_line":"                except exc.OpenStackCloudURINotFound as e:"},{"line_number":6233,"context_line":"                    self.log.debug("},{"line_number":6234,"context_line":"                        \"Something went wrong talking to neutron API: \""},{"line_number":6235,"context_line":"                        \"\u0027%(msg)s\u0027. Trying with Nova.\", {\u0027msg\u0027: str(e)})"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_66f62160","line":6232,"updated":"2019-02-15 14:47:15.000000000","message":"This is the same exception: https://github.com/openstack/openstacksdk/blob/master/openstack/cloud/exc.py#L43","commit_id":"c0e3ef4d3de309a0140fa9030fd2731f39bda0b4"}]}