)]}'
{"openstack/service_description.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"54645d2a509d7d9b899c962ecc591d7a5627895b","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                    region_name\u003dinstance.config.region_name,"},{"line_number":212,"context_line":"                    version\u003dstr(found_version[0])))"},{"line_number":213,"context_line":"        elif not proxy_class:"},{"line_number":214,"context_line":"            proxy_class \u003d proxy.Proxy"},{"line_number":215,"context_line":"        return config.get_session_client("},{"line_number":216,"context_line":"            self.service_type,"},{"line_number":217,"context_line":"            constructor\u003dproxy_class,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_f93270f2","line":214,"range":{"start_line":214,"start_character":0,"end_line":214,"end_character":37},"updated":"2019-02-19 16:46:59.000000000","message":"I wonder if this is any better from user\u0027s perspective..","commit_id":"1ffb60d2b21c08b304c8a7ae60860e93c09090b3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4da1b32ec7cca155d4af25df8144e6e7194afc76","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                    service_type\u003dself.service_type,"},{"line_number":196,"context_line":"                    cloud\u003dinstance.name,"},{"line_number":197,"context_line":"                    region_name\u003dinstance.config.region_name))"},{"line_number":198,"context_line":"        proxy_class \u003d self.supported_versions.get(str(found_version[0]))"},{"line_number":199,"context_line":"        if not proxy_class:"},{"line_number":200,"context_line":"            # Maybe openstacksdk is being used for the passthrough"},{"line_number":201,"context_line":"            # REST API proxy layer for an unknown service in the"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_ee055f7b","line":198,"updated":"2019-02-25 14:19:34.000000000","message":"what happens here if both found_version and version_kwargs are empty? Or is it impossible?","commit_id":"0f592e474b49b7a2efc8c7887d79367c112d69f6"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"eaaefe0650feab5c442fbf17abe5f67bbd635197","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                    service_type\u003dself.service_type,"},{"line_number":196,"context_line":"                    cloud\u003dinstance.name,"},{"line_number":197,"context_line":"                    region_name\u003dinstance.config.region_name))"},{"line_number":198,"context_line":"        proxy_class \u003d self.supported_versions.get(str(found_version[0]))"},{"line_number":199,"context_line":"        if not proxy_class:"},{"line_number":200,"context_line":"            # Maybe openstacksdk is being used for the passthrough"},{"line_number":201,"context_line":"            # REST API proxy layer for an unknown service in the"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_b40b8ad3","line":198,"in_reply_to":"9fdfeff1_ee055f7b","updated":"2019-03-04 18:45:35.000000000","message":"It shouldn\u0027t be possible - BUT - it\u0027s maybe good to handle it. Right now if found_version and version_kwargs are both None, it\u0027ll fall through and the blow up on str(found_version[0])). I\u0027ll do a quick followup to add a different error message.\n\n(found_version being none at this point would mean there is a service with no version discovery document AND no version in the catalog url which would be super broken ... but things are super broken all the time)","commit_id":"0f592e474b49b7a2efc8c7887d79367c112d69f6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"45a23cd3d551b58ed603b40511ac957dff4f6769","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        if found_version is None and version_kwargs:"},{"line_number":181,"context_line":"            raise exceptions.NotSupported("},{"line_number":182,"context_line":"                \"The {service_type} service for {cloud}:{region_name}\""},{"line_number":183,"context_line":"                \" exists but does not have any supported versions.\".format("},{"line_number":184,"context_line":"                    service_type\u003dself.service_type,"},{"line_number":185,"context_line":"                    cloud\u003dinstance.name,"},{"line_number":186,"context_line":"                    region_name\u003dinstance.config.region_name))"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_6a894073","line":183,"updated":"2019-04-08 09:01:28.000000000","message":"maybe better \"any versions satisfying {version_kwargs}\"?","commit_id":"be753eacbbcdd0bcb2d80c71c77ca6b99341b4d4"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"bcd048ec62b120269e0a35c2550e1f56767da14e","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        if found_version is None and version_kwargs:"},{"line_number":181,"context_line":"            raise exceptions.NotSupported("},{"line_number":182,"context_line":"                \"The {service_type} service for {cloud}:{region_name}\""},{"line_number":183,"context_line":"                \" exists but does not have any supported versions.\".format("},{"line_number":184,"context_line":"                    service_type\u003dself.service_type,"},{"line_number":185,"context_line":"                    cloud\u003dinstance.name,"},{"line_number":186,"context_line":"                    region_name\u003dinstance.config.region_name))"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_432b0fea","line":183,"in_reply_to":"5fc1f717_6a894073","updated":"2019-04-08 10:49:36.000000000","message":"Fixed in followup.","commit_id":"be753eacbbcdd0bcb2d80c71c77ca6b99341b4d4"}]}