)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"157a91a7d543893238dfdd27fb1c4366d9d0ebca","unresolved":false,"context_lines":[{"line_number":11,"context_line":"possibility to find image by name is to do a list with `os_hidden\u003dTrue` "},{"line_number":12,"context_line":"to list hidden images. So what we do here is search as usual, and if "},{"line_number":13,"context_line":"nothing found try also to search in hidden images (list of hidden images "},{"line_number":14,"context_line":"and grep by name)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I237da3e7e6b5d23010d8b26a3fcbfabaddeb5f31"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_23a9f07a","line":14,"updated":"2019-02-28 10:47:28.000000000","message":"SIGH","commit_id":"d85e3b746f11ab11b67608c9200ad05423ad08f8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"383bf917f4f83c2c7977e187a2cc964649acce94","unresolved":false,"context_lines":[{"line_number":11,"context_line":"possibility to find image by name is to do a list with `os_hidden\u003dTrue` "},{"line_number":12,"context_line":"to list hidden images. So what we do here is search as usual, and if "},{"line_number":13,"context_line":"nothing found try also to search in hidden images (list of hidden images "},{"line_number":14,"context_line":"and grep by name)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I237da3e7e6b5d23010d8b26a3fcbfabaddeb5f31"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_c35904fd","line":14,"updated":"2019-02-28 10:40:27.000000000","message":"What prevents us from searching with hidden images right away, if os_hidden is not specified explicitly in conditions?","commit_id":"d85e3b746f11ab11b67608c9200ad05423ad08f8"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"6592c8180f65cbb22a5b95d5b57d41108930e5ed","unresolved":false,"context_lines":[{"line_number":11,"context_line":"possibility to find image by name is to do a list with `os_hidden\u003dTrue` "},{"line_number":12,"context_line":"to list hidden images. So what we do here is search as usual, and if "},{"line_number":13,"context_line":"nothing found try also to search in hidden images (list of hidden images "},{"line_number":14,"context_line":"and grep by name)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I237da3e7e6b5d23010d8b26a3fcbfabaddeb5f31"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_63f938c6","line":14,"in_reply_to":"9fdfeff1_c35904fd","updated":"2019-02-28 10:42:32.000000000","message":"list with os_hidden\u003dTrue returns ONLY hidden images, so there is no way to get it in one shot","commit_id":"d85e3b746f11ab11b67608c9200ad05423ad08f8"}],"openstack/image/v2/image.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"157a91a7d543893238dfdd27fb1c4366d9d0ebca","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        result \u003d super(Image, cls).find(session, name_or_id, True,"},{"line_number":309,"context_line":"                                        **params)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        if not result:"},{"line_number":312,"context_line":"            # Search also in hidden images"},{"line_number":313,"context_line":"            params[\u0027is_hidden\u0027] \u003d True"},{"line_number":314,"context_line":"            data \u003d cls.list(session, **params)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_43a434a3","line":311,"updated":"2019-02-28 10:47:28.000000000","message":"nit: a bit streamline\n\n if result:\n     return result","commit_id":"d85e3b746f11ab11b67608c9200ad05423ad08f8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"34fbad0e4081174cd687c82b92b5f2c367a35da3","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        if not result:"},{"line_number":312,"context_line":"            # Search also in hidden images"},{"line_number":313,"context_line":"            params[\u0027is_hidden\u0027] \u003d True"},{"line_number":314,"context_line":"            data \u003d cls.list(session, **params)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"            result \u003d cls._get_one_match(name_or_id, data)"},{"line_number":317,"context_line":"            if result is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_dee9d719","line":314,"updated":"2019-02-28 11:11:50.000000000","message":"Apparently, Glance ignores unknown parameters? Okay then.","commit_id":"d85e3b746f11ab11b67608c9200ad05423ad08f8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"157a91a7d543893238dfdd27fb1c4366d9d0ebca","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        if not result:"},{"line_number":312,"context_line":"            # Search also in hidden images"},{"line_number":313,"context_line":"            params[\u0027is_hidden\u0027] \u003d True"},{"line_number":314,"context_line":"            data \u003d cls.list(session, **params)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"            result \u003d cls._get_one_match(name_or_id, data)"},{"line_number":317,"context_line":"            if result is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_e3b8c8c8","line":314,"updated":"2019-02-28 10:47:28.000000000","message":"shouldn\u0027t we catch BadRequest or whatever glance returns on unknown parameters (if API 2.7 is not present)?","commit_id":"d85e3b746f11ab11b67608c9200ad05423ad08f8"}]}