)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"cad3d722b9c4e4e0184c7ff5f3f45712dd5ae8a2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add floating IP port forwarding related methods"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1811352"},{"line_number":10,"context_line":"Change-Id: Id78c91b0a66c8c04ab783fe4ba666a18844aed59"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_741feb6b","line":9,"updated":"2019-04-08 07:49:51.000000000","message":"nit: Needed-by: https://review.openstack.org/650062\n\nI am not sure if zuul misses the needed-by, or not","commit_id":"8a0bd21ad9a9533d4a478c8a6816d7ea14452e29"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"98323071f80201a1fd4d30dd24cbd9e69b02ad50","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add floating IP port forwarding related methods"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1811352"},{"line_number":10,"context_line":"Change-Id: Id78c91b0a66c8c04ab783fe4ba666a18844aed59"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_d73b41ce","line":9,"in_reply_to":"5fc1f717_741feb6b","updated":"2019-04-08 08:06:53.000000000","message":"Thanks, it is mocked there.","commit_id":"8a0bd21ad9a9533d4a478c8a6816d7ea14452e29"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c909387bb86487ef9957ebac0947d2ab8e6bac4b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add floating IP port forwarding related methods"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1811352"},{"line_number":10,"context_line":"Change-Id: Id78c91b0a66c8c04ab783fe4ba666a18844aed59"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_f90aecce","line":9,"in_reply_to":"5fc1f717_d73b41ce","updated":"2019-04-08 12:22:09.000000000","message":"I think the Needed-by is not that important as the Depends-on label, as that helps zuul to keep the dependency tree if the patches are in different repos","commit_id":"8a0bd21ad9a9533d4a478c8a6816d7ea14452e29"}],"openstack/network/v2/_proxy.py":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"015c85d8c722b69d5f0dcdbfe7f9a67872224b98","unresolved":false,"context_lines":[{"line_number":3862,"context_line":"        return self._get(_port_forwarding.PortForwarding, port_forwarding,"},{"line_number":3863,"context_line":"                         floatingip_id\u003dfloatingip.id)"},{"line_number":3864,"context_line":""},{"line_number":3865,"context_line":"    def get_floating_ip_port_forwardings(self, floating_ip, **query):"},{"line_number":3866,"context_line":"        \"\"\"Return a generator of floating ip port forwarding"},{"line_number":3867,"context_line":""},{"line_number":3868,"context_line":"        :param floating_ip: The value can be the ID of the Floating IP that the"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_8f129a61","line":3865,"range":{"start_line":3865,"start_character":8,"end_line":3865,"end_character":12},"updated":"2019-04-05 11:58:06.000000000","message":"We should remove this get_ ... the pattern for the list generators is to just name it for the resource in question.","commit_id":"84ec67ae98b65786e73e106682e22c2fb0eaa2af"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e6b4407c7e4c7fae50b4daadc2ef3a10bb67d218","unresolved":false,"context_lines":[{"line_number":3862,"context_line":"        return self._get(_port_forwarding.PortForwarding, port_forwarding,"},{"line_number":3863,"context_line":"                         floatingip_id\u003dfloatingip.id)"},{"line_number":3864,"context_line":""},{"line_number":3865,"context_line":"    def get_floating_ip_port_forwardings(self, floating_ip, **query):"},{"line_number":3866,"context_line":"        \"\"\"Return a generator of floating ip port forwarding"},{"line_number":3867,"context_line":""},{"line_number":3868,"context_line":"        :param floating_ip: The value can be the ID of the Floating IP that the"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_e0132cb7","line":3865,"range":{"start_line":3865,"start_character":8,"end_line":3865,"end_character":12},"in_reply_to":"5fc1f717_8f129a61","updated":"2019-04-05 15:12:33.000000000","message":"Nice catch, Done","commit_id":"84ec67ae98b65786e73e106682e22c2fb0eaa2af"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"1a5df0e010bd44eca8ebd1d1cc5743020c2eee07","unresolved":false,"context_lines":[{"line_number":3800,"context_line":""},{"line_number":3801,"context_line":"    def delete_floating_ip_port_forwarding(self, floating_ip, port_forwarding,"},{"line_number":3802,"context_line":"                                           ignore_missing\u003dTrue):"},{"line_number":3803,"context_line":"        \"\"\"Deletes a floating IP port forwarding."},{"line_number":3804,"context_line":""},{"line_number":3805,"context_line":"        :param port_forwarding: The value can be either the ID of a port"},{"line_number":3806,"context_line":"                    forwarding or a :class:`~openstack.network.v2."}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_548f4f22","line":3803,"updated":"2019-04-08 07:27:12.000000000","message":"nit: delete instead of deletes","commit_id":"8a0bd21ad9a9533d4a478c8a6816d7ea14452e29"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"9d578743faa0fa7a823971c985279292271669f6","unresolved":false,"context_lines":[{"line_number":3800,"context_line":""},{"line_number":3801,"context_line":"    def delete_floating_ip_port_forwarding(self, floating_ip, port_forwarding,"},{"line_number":3802,"context_line":"                                           ignore_missing\u003dTrue):"},{"line_number":3803,"context_line":"        \"\"\"Deletes a floating IP port forwarding."},{"line_number":3804,"context_line":""},{"line_number":3805,"context_line":"        :param port_forwarding: The value can be either the ID of a port"},{"line_number":3806,"context_line":"                    forwarding or a :class:`~openstack.network.v2."}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_81300e09","line":3803,"in_reply_to":"5fc1f717_548f4f22","updated":"2019-04-08 13:38:41.000000000","message":"Done","commit_id":"8a0bd21ad9a9533d4a478c8a6816d7ea14452e29"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"1a5df0e010bd44eca8ebd1d1cc5743020c2eee07","unresolved":false,"context_lines":[{"line_number":3802,"context_line":"                                           ignore_missing\u003dTrue):"},{"line_number":3803,"context_line":"        \"\"\"Deletes a floating IP port forwarding."},{"line_number":3804,"context_line":""},{"line_number":3805,"context_line":"        :param port_forwarding: The value can be either the ID of a port"},{"line_number":3806,"context_line":"                    forwarding or a :class:`~openstack.network.v2."},{"line_number":3807,"context_line":"                    port_forwarding.PortForwarding`instance."},{"line_number":3808,"context_line":"        :param floating_ip: The value can be either the ID of a floating ip"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_14e307da","line":3805,"updated":"2019-04-08 07:27:12.000000000","message":"order of params in doc does not correspond order of param in function definition","commit_id":"8a0bd21ad9a9533d4a478c8a6816d7ea14452e29"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"9d578743faa0fa7a823971c985279292271669f6","unresolved":false,"context_lines":[{"line_number":3802,"context_line":"                                           ignore_missing\u003dTrue):"},{"line_number":3803,"context_line":"        \"\"\"Deletes a floating IP port forwarding."},{"line_number":3804,"context_line":""},{"line_number":3805,"context_line":"        :param port_forwarding: The value can be either the ID of a port"},{"line_number":3806,"context_line":"                    forwarding or a :class:`~openstack.network.v2."},{"line_number":3807,"context_line":"                    port_forwarding.PortForwarding`instance."},{"line_number":3808,"context_line":"        :param floating_ip: The value can be either the ID of a floating ip"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_a1350af9","line":3805,"in_reply_to":"5fc1f717_14e307da","updated":"2019-04-08 13:38:41.000000000","message":"Done","commit_id":"8a0bd21ad9a9533d4a478c8a6816d7ea14452e29"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"52a631e5040649e07ca9bdb61f315eb1c5216ceb","unresolved":false,"context_lines":[{"line_number":3787,"context_line":"        :param floating_ip: The value can be either the ID of a floating ip"},{"line_number":3788,"context_line":"                or a :class:`~openstack.network.v2.floating_ip.FloatingIP`"},{"line_number":3789,"context_line":"                instance."},{"line_number":3790,"context_line":"        :param dict attrs:Keyword arguments which will be used to create"},{"line_number":3791,"context_line":"            a:class:`~openstack.network.v2.port_forwarding.PortForwarding`,"},{"line_number":3792,"context_line":"            comprised of the properties on the PortForwarding class."},{"line_number":3793,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_56c14f4d","line":3790,"updated":"2019-04-10 16:47:06.000000000","message":"nit: a space is needed after \"attrs:\"","commit_id":"8bbd44c9b5ad413de6384ae8fb096f20737ebf92"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"52a631e5040649e07ca9bdb61f315eb1c5216ceb","unresolved":false,"context_lines":[{"line_number":3807,"context_line":"                    instance."},{"line_number":3808,"context_line":"        :param port_forwarding: The value can be either the ID of a port"},{"line_number":3809,"context_line":"                    forwarding or a :class:`~openstack.network.v2."},{"line_number":3810,"context_line":"                    port_forwarding.PortForwarding`instance."},{"line_number":3811,"context_line":"        :param bool ignore_missing: When set to ``False``"},{"line_number":3812,"context_line":"                    :class:`~openstack.exceptions.ResourceNotFound` will be"},{"line_number":3813,"context_line":"                    raised when the floating ip does not exist."}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_96901750","line":3810,"range":{"start_line":3810,"start_character":51,"end_line":3810,"end_character":59},"updated":"2019-04-10 16:47:06.000000000","message":"a space is needed before \"instance\".","commit_id":"8bbd44c9b5ad413de6384ae8fb096f20737ebf92"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"52a631e5040649e07ca9bdb61f315eb1c5216ceb","unresolved":false,"context_lines":[{"line_number":3887,"context_line":"                            network.v2.floating_ip.FloatingIP` instance."},{"line_number":3888,"context_line":"        :param port_forwarding: Either the id of a floating ip port forwarding"},{"line_number":3889,"context_line":"                            or a :class:`~openstack.network.v2."},{"line_number":3890,"context_line":"                            port_forwarding.PortForwarding`instance."},{"line_number":3891,"context_line":"        :attrs kwargs: The attributes to update on the floating ip port"},{"line_number":3892,"context_line":"                       forwarding represented by ``value``."},{"line_number":3893,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_b6e3d3d7","line":3890,"range":{"start_line":3890,"start_character":59,"end_line":3890,"end_character":67},"updated":"2019-04-10 16:47:06.000000000","message":"a space is needed before \"instance\".","commit_id":"8bbd44c9b5ad413de6384ae8fb096f20737ebf92"}],"openstack/tests/unit/network/v2/test_proxy.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"cad3d722b9c4e4e0184c7ff5f3f45712dd5ae8a2","unresolved":false,"context_lines":[{"line_number":1173,"context_line":"            False, input_path_args\u003d[FIP_ID, \"resource_or_id\"],"},{"line_number":1174,"context_line":"            expected_path_args\u003d{\u0027floatingip_id\u0027: FIP_ID},)"},{"line_number":1175,"context_line":""},{"line_number":1176,"context_line":"    def test_delete_floating_ip_port_forwarding_ignore(self):"},{"line_number":1177,"context_line":"        self.verify_delete("},{"line_number":1178,"context_line":"            self.proxy.delete_floating_ip_port_forwarding,"},{"line_number":1179,"context_line":"            port_forwarding.PortForwarding,"},{"line_number":1180,"context_line":"            True, input_path_args\u003d[FIP_ID, \"resource_or_id\"],"},{"line_number":1181,"context_line":"            expected_path_args\u003d{\u0027floatingip_id\u0027: FIP_ID}, )"},{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"    def test_find_floating_ip_port_forwarding(self):"},{"line_number":1184,"context_line":"        fip \u003d floating_ip.FloatingIP.new(id\u003dFIP_ID)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_d476dfd8","line":1181,"range":{"start_line":1176,"start_character":4,"end_line":1181,"end_character":59},"updated":"2019-04-08 07:49:51.000000000","message":"I expected that the test would check if the exception is rised/ not rised if ignore_missing\u003dFalse/True.\nlike:\ntest_delete_floating_ip_port_forwarding\ntest_delete_floating_ip_port_forwarding_not_found\ntest_delete_floating_ip_port_forwarding_not_found_ignore_missing","commit_id":"8a0bd21ad9a9533d4a478c8a6816d7ea14452e29"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"98323071f80201a1fd4d30dd24cbd9e69b02ad50","unresolved":false,"context_lines":[{"line_number":1173,"context_line":"            False, input_path_args\u003d[FIP_ID, \"resource_or_id\"],"},{"line_number":1174,"context_line":"            expected_path_args\u003d{\u0027floatingip_id\u0027: FIP_ID},)"},{"line_number":1175,"context_line":""},{"line_number":1176,"context_line":"    def test_delete_floating_ip_port_forwarding_ignore(self):"},{"line_number":1177,"context_line":"        self.verify_delete("},{"line_number":1178,"context_line":"            self.proxy.delete_floating_ip_port_forwarding,"},{"line_number":1179,"context_line":"            port_forwarding.PortForwarding,"},{"line_number":1180,"context_line":"            True, input_path_args\u003d[FIP_ID, \"resource_or_id\"],"},{"line_number":1181,"context_line":"            expected_path_args\u003d{\u0027floatingip_id\u0027: FIP_ID}, )"},{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"    def test_find_floating_ip_port_forwarding(self):"},{"line_number":1184,"context_line":"        fip \u003d floating_ip.FloatingIP.new(id\u003dFIP_ID)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_f7d99d82","line":1181,"range":{"start_line":1176,"start_character":4,"end_line":1181,"end_character":59},"in_reply_to":"5fc1f717_d476dfd8","updated":"2019-04-08 08:06:53.000000000","message":"Seems in this file all similar tests do not add such cases. But, thanks, I will give a try for this.","commit_id":"8a0bd21ad9a9533d4a478c8a6816d7ea14452e29"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1bd1872d4581ca5ffdfdabb1abb5502b61df2267","unresolved":false,"context_lines":[{"line_number":1173,"context_line":"            False, input_path_args\u003d[FIP_ID, \"resource_or_id\"],"},{"line_number":1174,"context_line":"            expected_path_args\u003d{\u0027floatingip_id\u0027: FIP_ID},)"},{"line_number":1175,"context_line":""},{"line_number":1176,"context_line":"    def test_delete_floating_ip_port_forwarding_ignore(self):"},{"line_number":1177,"context_line":"        self.verify_delete("},{"line_number":1178,"context_line":"            self.proxy.delete_floating_ip_port_forwarding,"},{"line_number":1179,"context_line":"            port_forwarding.PortForwarding,"},{"line_number":1180,"context_line":"            True, input_path_args\u003d[FIP_ID, \"resource_or_id\"],"},{"line_number":1181,"context_line":"            expected_path_args\u003d{\u0027floatingip_id\u0027: FIP_ID}, )"},{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"    def test_find_floating_ip_port_forwarding(self):"},{"line_number":1184,"context_line":"        fip \u003d floating_ip.FloatingIP.new(id\u003dFIP_ID)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_b9730480","line":1181,"range":{"start_line":1176,"start_character":4,"end_line":1181,"end_character":59},"in_reply_to":"5fc1f717_f7d99d82","updated":"2019-04-08 12:20:59.000000000","message":"Ah, ok. I haven\u0027t checked the surroundings, I can live without it.","commit_id":"8a0bd21ad9a9533d4a478c8a6816d7ea14452e29"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"cad3d722b9c4e4e0184c7ff5f3f45712dd5ae8a2","unresolved":false,"context_lines":[{"line_number":1180,"context_line":"            True, input_path_args\u003d[FIP_ID, \"resource_or_id\"],"},{"line_number":1181,"context_line":"            expected_path_args\u003d{\u0027floatingip_id\u0027: FIP_ID}, )"},{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"    def test_find_floating_ip_port_forwarding(self):"},{"line_number":1184,"context_line":"        fip \u003d floating_ip.FloatingIP.new(id\u003dFIP_ID)"},{"line_number":1185,"context_line":"        self._verify2(\u0027openstack.proxy.Proxy._find\u0027,"},{"line_number":1186,"context_line":"                      self.proxy.find_floating_ip_port_forwarding,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_14378700","line":1183,"range":{"start_line":1183,"start_character":8,"end_line":1183,"end_character":45},"updated":"2019-04-08 07:49:51.000000000","message":"The same: perhaps a test to check whether the NotFound exception raised, and not if ignore_raising\u003dTrue","commit_id":"8a0bd21ad9a9533d4a478c8a6816d7ea14452e29"}]}