)]}'
{"openstack/cloud/_normalize.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"936dae079416389cb0628663d84ca94bc6c19463","unresolved":false,"context_lines":[{"line_number":473,"context_line":"        image \u003d server.pop(\u0027image\u0027, None)"},{"line_number":474,"context_line":"        if str(image) !\u003d image:"},{"line_number":475,"context_line":"            image \u003d munch.Munch(id\u003dimage[\u0027id\u0027])"},{"line_number":476,"context_line":"            # image.pop(\u0027links\u0027, None)"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        ret[\u0027image\u0027] \u003d image"},{"line_number":479,"context_line":"        # From original_names from sdk"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fce034c_ae574958","line":476,"updated":"2019-04-18 13:19:11.000000000","message":"Is it not needed any more? maybe delete it?","commit_id":"eb5b47d0a925f5c5784093fee0aa7c90af3d8a6f"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"1ceabb7197b1d64ad5964f127b7faf126234d42c","unresolved":false,"context_lines":[{"line_number":473,"context_line":"        image \u003d server.pop(\u0027image\u0027, None)"},{"line_number":474,"context_line":"        if str(image) !\u003d image:"},{"line_number":475,"context_line":"            image \u003d munch.Munch(id\u003dimage[\u0027id\u0027])"},{"line_number":476,"context_line":"            # image.pop(\u0027links\u0027, None)"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        ret[\u0027image\u0027] \u003d image"},{"line_number":479,"context_line":"        # From original_names from sdk"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffb9cba7_5488d86f","line":476,"in_reply_to":"3fce034c_2ed4aebc","updated":"2019-04-25 13:25:01.000000000","message":"Done","commit_id":"eb5b47d0a925f5c5784093fee0aa7c90af3d8a6f"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"6cd719e5af7132634b0e49f71f37f6de1d57343f","unresolved":false,"context_lines":[{"line_number":473,"context_line":"        image \u003d server.pop(\u0027image\u0027, None)"},{"line_number":474,"context_line":"        if str(image) !\u003d image:"},{"line_number":475,"context_line":"            image \u003d munch.Munch(id\u003dimage[\u0027id\u0027])"},{"line_number":476,"context_line":"            # image.pop(\u0027links\u0027, None)"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        ret[\u0027image\u0027] \u003d image"},{"line_number":479,"context_line":"        # From original_names from sdk"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fce034c_2ed4aebc","line":476,"in_reply_to":"3fce034c_ae574958","updated":"2019-04-18 23:39:16.000000000","message":"++","commit_id":"eb5b47d0a925f5c5784093fee0aa7c90af3d8a6f"}],"openstack/compute/v2/_proxy.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"936dae079416389cb0628663d84ca94bc6c19463","unresolved":false,"context_lines":[{"line_number":487,"context_line":"            instances with only basic data will be returned. The default,"},{"line_number":488,"context_line":"            ``True``, will cause instances with full data to be returned."},{"line_number":489,"context_line":"        :param kwargs query: Optional query parameters to be sent to limit"},{"line_number":490,"context_line":"            the servers being returned.  Available parameters include:"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"            * access_ipv4: Filter server list result by IPv4 address that"},{"line_number":493,"context_line":"                should be used to access the server."}],"source_content_type":"text/x-python","patch_set":4,"id":"3fce034c_ce541556","line":490,"updated":"2019-04-18 13:19:11.000000000","message":"I understand the desire here, but available parameters depend on the server, not on the client. So this list is only valid when openstacksdk is used against a certain version of Nova. I\u0027d prefer to link people to api-ref instead.","commit_id":"eb5b47d0a925f5c5784093fee0aa7c90af3d8a6f"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"1ceabb7197b1d64ad5964f127b7faf126234d42c","unresolved":false,"context_lines":[{"line_number":487,"context_line":"            instances with only basic data will be returned. The default,"},{"line_number":488,"context_line":"            ``True``, will cause instances with full data to be returned."},{"line_number":489,"context_line":"        :param kwargs query: Optional query parameters to be sent to limit"},{"line_number":490,"context_line":"            the servers being returned.  Available parameters include:"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"            * access_ipv4: Filter server list result by IPv4 address that"},{"line_number":493,"context_line":"                should be used to access the server."}],"source_content_type":"text/x-python","patch_set":4,"id":"ffb9cba7_7492bca0","line":490,"in_reply_to":"3fce034c_0ecf7229","updated":"2019-04-25 13:25:01.000000000","message":"ok, but we would need to do this consistently everywhere then and not just in one place","commit_id":"eb5b47d0a925f5c5784093fee0aa7c90af3d8a6f"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"6cd719e5af7132634b0e49f71f37f6de1d57343f","unresolved":false,"context_lines":[{"line_number":487,"context_line":"            instances with only basic data will be returned. The default,"},{"line_number":488,"context_line":"            ``True``, will cause instances with full data to be returned."},{"line_number":489,"context_line":"        :param kwargs query: Optional query parameters to be sent to limit"},{"line_number":490,"context_line":"            the servers being returned.  Available parameters include:"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"            * access_ipv4: Filter server list result by IPv4 address that"},{"line_number":493,"context_line":"                should be used to access the server."}],"source_content_type":"text/x-python","patch_set":4,"id":"3fce034c_0ecf7229","line":490,"in_reply_to":"3fce034c_ce541556","updated":"2019-04-18 23:39:16.000000000","message":"Yeah - I think that\u0027s a good point.","commit_id":"eb5b47d0a925f5c5784093fee0aa7c90af3d8a6f"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"6e6fc75d00eaf07e7aed279a830a2d154a1912d6","unresolved":false,"context_lines":[{"line_number":487,"context_line":"            instances with only basic data will be returned. The default,"},{"line_number":488,"context_line":"            ``True``, will cause instances with full data to be returned."},{"line_number":489,"context_line":"        :param kwargs query: Optional query parameters to be sent to limit"},{"line_number":490,"context_line":"            the servers being returned.  Available parameters include:"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"            * access_ipv4: Filter server list result by IPv4 address that"},{"line_number":493,"context_line":"                should be used to access the server."}],"source_content_type":"text/x-python","patch_set":4,"id":"ffb9cba7_d4c12882","line":490,"in_reply_to":"ffb9cba7_7492bca0","updated":"2019-04-25 13:27:29.000000000","message":"Also a good point.","commit_id":"eb5b47d0a925f5c5784093fee0aa7c90af3d8a6f"}],"openstack/compute/v2/server.py":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"fbf177a41943a0af7da3cf8e168a3c1b2c737dea","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    allow_commit \u003d True"},{"line_number":27,"context_line":"    allow_delete \u003d True"},{"line_number":28,"context_line":"    allow_list \u003d True"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    _query_mapping \u003d resource.QueryParameters("},{"line_number":31,"context_line":"        \"auto_disk_config\", \"availability_zone\","},{"line_number":32,"context_line":"        \"created_at\", \"description\", \"flavor\","}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_19e818b1","line":29,"updated":"2019-04-08 12:41:10.000000000","message":"I think you want to add something like:\n\n_max_microversion \u003d \u00272.61\u0027\n\nbut obviously set to the newest microversion we\u0027re actually handling.","commit_id":"23fbb472bc519e421e90e8b0bb5b909701280263"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"fbf177a41943a0af7da3cf8e168a3c1b2c737dea","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    #: this server."},{"line_number":92,"context_line":"    flavor_id \u003d resource.Body(\u0027flavorRef\u0027)"},{"line_number":93,"context_line":"    #: The flavor property as returned from server."},{"line_number":94,"context_line":"    flavor \u003d resource.Body(\u0027flavor\u0027, type\u003ddict)"},{"line_number":95,"context_line":"    #: Indicates whether a configuration drive enables metadata injection."},{"line_number":96,"context_line":"    #: Not all cloud providers enable this feature."},{"line_number":97,"context_line":"    has_config_drive \u003d resource.Body(\u0027config_drive\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_39c71415","line":94,"updated":"2019-04-08 12:41:10.000000000","message":"I think we could do type\u003dopenstack.compute.v2.flavor.Flavor here.\n\nWell, almost. The flavor dict embedded in the server uses \"original_name\" and we\u0027d want to make flavor be able to handle that. So maybe let\u0027s do that as a followup. (Since I\u0027m touching Flavor right now)\n\nI think what we can do in Flavor is do:\n\n  _original_name \u003d resource.Body(\u0027original_name\u0027)\n\nThen:\n\n  name \u003d resource.Body(\u0027name\u0027, alias\u003d\u0027_original_name\u0027)","commit_id":"23fbb472bc519e421e90e8b0bb5b909701280263"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"fbf177a41943a0af7da3cf8e168a3c1b2c737dea","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    #: this server."},{"line_number":110,"context_line":"    image_id \u003d resource.Body(\u0027imageRef\u0027)"},{"line_number":111,"context_line":"    #: The image property as returned from server."},{"line_number":112,"context_line":"    image \u003d resource.Body(\u0027image\u0027, type\u003ddict)"},{"line_number":113,"context_line":"    #: The instance name. The Compute API generates the instance name from the"},{"line_number":114,"context_line":"    #: instance name template. Appears in the response for administrative users"},{"line_number":115,"context_line":"    #: only."}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_b9da24e6","line":112,"updated":"2019-04-08 12:41:10.000000000","message":"Similarly, I wonder if type\u003dImage would be nicer here.","commit_id":"23fbb472bc519e421e90e8b0bb5b909701280263"}]}