)]}'
{"openstack/cloud/_compute.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3de97b710bb98d6936df24b2506f0924e3e88159","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def search_keypairs(self, name_or_id\u003dNone, filters\u003dNone):"},{"line_number":83,"context_line":"        keypairs \u003d self.list_keypairs("},{"line_number":84,"context_line":"            filters\u003dfilters if isinstance(filters, dict) else None"},{"line_number":85,"context_line":"        )"},{"line_number":86,"context_line":"        return _utils._filter_list(keypairs, name_or_id, filters)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_44c3c389","line":84,"updated":"2019-06-14 08:49:54.000000000","message":"you cannot pass None here, and it breaks ansible: http://logs.openstack.org/29/662729/4/check/openstacksdk-ansible-devel-functional-devstack/684a437/job-output.txt.gz#_2019-06-04_08_25_11_956493","commit_id":"bbbe27106270fb6a5c10d123097457ef226ea3a1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3de97b710bb98d6936df24b2506f0924e3e88159","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        server_groups \u003d self.list_server_groups()"},{"line_number":118,"context_line":"        return _utils._filter_list(server_groups, name_or_id, filters)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def list_keypairs(self, filters\u003d{}):"},{"line_number":121,"context_line":"        \"\"\"List all available keypairs."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        :returns: A list of ``munch.Munch`` containing keypair info."}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_e4bd1702","line":120,"updated":"2019-06-14 08:49:54.000000000","message":"This is an antipattern, let us maybe support None value properly?","commit_id":"bbbe27106270fb6a5c10d123097457ef226ea3a1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1df504264567892b995566795216e3966d80e4ad","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def search_keypairs(self, name_or_id\u003dNone, filters\u003dNone):"},{"line_number":83,"context_line":"        keypairs \u003d self.list_keypairs("},{"line_number":84,"context_line":"            filters\u003dfilters if isinstance(filters, dict) else None"},{"line_number":85,"context_line":"        )"},{"line_number":86,"context_line":"        return _utils._filter_list(keypairs, name_or_id, filters)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_be203f4b","line":84,"updated":"2019-07-24 12:28:49.000000000","message":"nit: why this logic?","commit_id":"15baef656ac56421a71e691982a70b218110f18d"}],"openstack/compute/v2/keypair.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1df504264567892b995566795216e3966d80e4ad","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    #: The SSH public key that is paired with the server."},{"line_number":51,"context_line":"    public_key \u003d resource.Body(\u0027public_key\u0027)"},{"line_number":52,"context_line":"    #: The type of the keypair."},{"line_number":53,"context_line":"    type \u003d resource.Body(\u0027type\u0027, default\u003d\u0027ssh\u0027)"},{"line_number":54,"context_line":"    #: The user_id for a keypair."},{"line_number":55,"context_line":"    user_id \u003d resource.Body(\u0027user_id\u0027)"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_de1dfb0f","line":53,"updated":"2019-07-24 12:28:49.000000000","message":"I wonder if we need to hardcode the default information on the client side, given that it is applied on the server side","commit_id":"15baef656ac56421a71e691982a70b218110f18d"}]}