)]}'
{"openstack/cloud/_compute.py":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"2583766988cbefbc422559d3072a5c7d80f20c79","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    @property"},{"line_number":43,"context_line":"    def _compute_region(self):"},{"line_number":44,"context_line":"        # This is only used in exception messages. Can we get rid of it?"},{"line_number":45,"context_line":"        return self.config.get_region_name(\u0027compute\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def get_flavor_name(self, flavor_id):"},{"line_number":48,"context_line":"        flavor \u003d self.get_flavor(flavor_id, get_extra\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_f1882f72","line":45,"updated":"2019-06-04 13:45:56.000000000","message":"We could put this on the proxy/adapter instead and make it:\n\n  return self.config.get_region_name(self.service_type)\n\nThe adapter should already have self.region_name though...","commit_id":"5f0401a20609569de77d8d355cd43b36bed8d111"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"730a137e5994aa47d130101ad0e1b6353a6b87ec","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    @property"},{"line_number":43,"context_line":"    def _compute_region(self):"},{"line_number":44,"context_line":"        # This is only used in exception messages. Can we get rid of it?"},{"line_number":45,"context_line":"        return self.config.get_region_name(\u0027compute\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def get_flavor_name(self, flavor_id):"},{"line_number":48,"context_line":"        flavor \u003d self.get_flavor(flavor_id, get_extra\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_114f03be","line":45,"in_reply_to":"9fb8cfa7_f1882f72","updated":"2019-06-04 14:06:21.000000000","message":"\u003e We could put this on the proxy/adapter instead and make it:\n \u003e \n \u003e return self.config.get_region_name(self.service_type)\n\n\"this\" the _compute_region property? Yes, that would be great. With all the mixin\u0027ing going on here, I didn\u0027t know where I could reliably put it and have it still work.\n\n \u003e The adapter should already have self.region_name though...\n\nYes, it does - kind of the whole point of this patch. If the methods in this class are always called from the context of a Proxy/Adapter, we could\n- make sure the region_name from CloudRegion always ends up on the Adapter (I *think* this patch does that, but I\u0027m not positive); and then\n- get rid of this @property and just use self.region_name throughout.","commit_id":"5f0401a20609569de77d8d355cd43b36bed8d111"}],"openstack/cloud/_normalize.py":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"2583766988cbefbc422559d3072a5c7d80f20c79","unresolved":false,"context_lines":[{"line_number":565,"context_line":"            ret[\u0027tenant_id\u0027] \u003d project_id"},{"line_number":566,"context_line":"            # TODO(efried): This is hardcoded to \u0027compute\u0027 because this method"},{"line_number":567,"context_line":"            # should only ever be used by the compute proxy. (That said, it"},{"line_number":568,"context_line":"            # doesn\u0027t appear to be used at all, so can we get rid of it?)"},{"line_number":569,"context_line":"            ret[\u0027region\u0027] \u003d self.config.get_region_name(\u0027compute\u0027)"},{"line_number":570,"context_line":"            ret[\u0027cloud\u0027] \u003d self.config.name"},{"line_number":571,"context_line":"            ret[\u0027az\u0027] \u003d az"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_b145d719","line":568,"updated":"2019-06-04 13:45:56.000000000","message":"Can\u0027t get rid of it yet - it\u0027s used in the cloud layer... but it\u0027s hopefully going away reasonably soon.","commit_id":"5f0401a20609569de77d8d355cd43b36bed8d111"}],"openstack/cloud/openstackcloud.py":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"2583766988cbefbc422559d3072a5c7d80f20c79","unresolved":false,"context_lines":[{"line_number":651,"context_line":"        return self.name"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    def get_region(self):"},{"line_number":654,"context_line":"        # TODO(efried): This seems to be unused. Can we get rid of it?"},{"line_number":655,"context_line":"        return self.config.get_region_name()"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"    def get_session_endpoint(self, service_key):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_51f81bc3","line":654,"updated":"2019-06-04 13:45:56.000000000","message":"I think I\u0027m fine with getting rid of it.","commit_id":"5f0401a20609569de77d8d355cd43b36bed8d111"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"730a137e5994aa47d130101ad0e1b6353a6b87ec","unresolved":false,"context_lines":[{"line_number":651,"context_line":"        return self.name"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    def get_region(self):"},{"line_number":654,"context_line":"        # TODO(efried): This seems to be unused. Can we get rid of it?"},{"line_number":655,"context_line":"        return self.config.get_region_name()"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"    def get_session_endpoint(self, service_key):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_71851fad","line":654,"in_reply_to":"9fb8cfa7_51f81bc3","updated":"2019-06-04 14:06:21.000000000","message":"https://review.opendev.org/663038","commit_id":"5f0401a20609569de77d8d355cd43b36bed8d111"}],"openstack/config/cloud_region.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3a9d72675501bd19f5f0fa1d3f8d25ba9ea28daf","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    A CloudRegion encapsulates the config information needed for connections"},{"line_number":154,"context_line":"    to all of the services in a Region of a Cloud."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    TODO(efried): Doc the rest of the kwargs"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    :param str region_name:"},{"line_number":159,"context_line":"        The default region name for all services in this CloudRegion. If"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_28308c56","line":156,"updated":"2019-06-05 06:28:21.000000000","message":"TODO\u0027s should not be part of docstrings, they\u0027re user-visible","commit_id":"5f0401a20609569de77d8d355cd43b36bed8d111"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"82dd77ce4d7400330e74547bc90afb9930b115e5","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    A CloudRegion encapsulates the config information needed for connections"},{"line_number":154,"context_line":"    to all of the services in a Region of a Cloud."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    TODO(efried): Doc the rest of the kwargs"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    :param str region_name:"},{"line_number":159,"context_line":"        The default region name for all services in this CloudRegion. If"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_ef54b923","line":156,"in_reply_to":"9fb8cfa7_28308c56","updated":"2019-06-06 14:34:23.000000000","message":"Trying to make my name famous?\n\nFair enough, I\u0027ll move the TODO. (Or just resolve it, though the reason I didn\u0027t do it on the spot is I wouldn\u0027t know how to describe most of these. Should really have been TODO(mordred) (or TODO(dtantsur)) but that\u0027s kinda rude :P )\n\n[Later] Done via https://review.opendev.org/663685","commit_id":"5f0401a20609569de77d8d355cd43b36bed8d111"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3a9d72675501bd19f5f0fa1d3f8d25ba9ea28daf","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        return ("},{"line_number":235,"context_line":"            self.name \u003d\u003d other.name"},{"line_number":236,"context_line":"            # Ew"},{"line_number":237,"context_line":"            and self.get_region_name() \u003d\u003d other.get_region_name()"},{"line_number":238,"context_line":"            and self.config \u003d\u003d other.config)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def __ne__(self, other):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_c834504d","line":237,"updated":"2019-06-05 06:28:21.000000000","message":"Isn\u0027t it redundant with the next line? We no longer keep region_name as a separate field.","commit_id":"5f0401a20609569de77d8d355cd43b36bed8d111"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"82dd77ce4d7400330e74547bc90afb9930b115e5","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        return ("},{"line_number":235,"context_line":"            self.name \u003d\u003d other.name"},{"line_number":236,"context_line":"            # Ew"},{"line_number":237,"context_line":"            and self.get_region_name() \u003d\u003d other.get_region_name()"},{"line_number":238,"context_line":"            and self.config \u003d\u003d other.config)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def __ne__(self, other):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_2fadf130","line":237,"in_reply_to":"9fb8cfa7_c834504d","updated":"2019-06-06 14:34:23.000000000","message":"Ah, yes, good spot. Will nix. I think I put this in at a stage in the development where I was still keeping self.region_name.\n\n[Later] Done via https://review.opendev.org/663685","commit_id":"5f0401a20609569de77d8d355cd43b36bed8d111"}],"openstack/tests/unit/config/test_cloud_config.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3a9d72675501bd19f5f0fa1d3f8d25ba9ea28daf","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        self.assertEqual(3, cc.get_connect_retries(\u0027baremetal\u0027))"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def test_get_region_name(self):"},{"line_number":185,"context_line":"        # TODO(efried): ddt this"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        # No region_name kwarg, no regions specified in services dict"},{"line_number":188,"context_line":"        # (including the default)."}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_e8391441","line":185,"updated":"2019-06-05 06:28:21.000000000","message":"yes please","commit_id":"5f0401a20609569de77d8d355cd43b36bed8d111"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"82dd77ce4d7400330e74547bc90afb9930b115e5","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        self.assertEqual(3, cc.get_connect_retries(\u0027baremetal\u0027))"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def test_get_region_name(self):"},{"line_number":185,"context_line":"        # TODO(efried): ddt this"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        # No region_name kwarg, no regions specified in services dict"},{"line_number":188,"context_line":"        # (including the default)."}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_4f1126ac","line":185,"in_reply_to":"9fb8cfa7_e8391441","updated":"2019-06-06 14:34:23.000000000","message":"Done (more or less) via https://review.opendev.org/663685","commit_id":"5f0401a20609569de77d8d355cd43b36bed8d111"}]}