)]}'
{"id":"openstack%2Fopenstacksdk~663369","triplet_id":"openstack%2Fopenstacksdk~master~I9f31ad33eb500f59eb7634ea9e7e6502362a375b","project":"openstack/openstacksdk","branch":"master","topic":"update-router-routes","hashtags":[],"change_id":"I9f31ad33eb500f59eb7634ea9e7e6502362a375b","subject":"Support deleting all routes in update_router","status":"MERGED","created":"2019-06-05 15:49:34.000000000","updated":"2019-06-13 08:55:49.000000000","submitted":"2019-06-13 08:55:49.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"663369-1560416149518-8e310be5","meta_rev_id":"9ab2f473625d4ce083dedf88eac5de0e4ca994c8","_number":663369,"virtual_id_number":663369,"owner":{"_account_id":30288,"name":"charlie","email":"candles@amihere.net","username":"candles"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-06-13 08:55:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-06-13 07:39:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":2,"date":"2019-06-10 13:44:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-06-13 07:39:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-10 13:44:52.000000000","updated_by":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"reviewer":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"state":"REVIEWER"},{"updated":"2019-06-13 07:39:32.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2019-06-13 08:55:49.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"edabaa72e7f19ecf856d1819eaa86070f2c01411","author":{"_account_id":30288,"name":"charlie","email":"candles@amihere.net","username":"candles"},"date":"2019-06-05 15:49:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"08b3defaac0807ef73f6957627d42cf63e73474d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-05 17:34:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/69/663369/1/check/openstack-tox-lower-constraints/cff0e28/ : SUCCESS in 5m 06s\n- openstack-tox-pep8 http://logs.openstack.org/69/663369/1/check/openstack-tox-pep8/5649826/ : SUCCESS in 3m 52s\n- openstack-tox-py27 http://logs.openstack.org/69/663369/1/check/openstack-tox-py27/653cd69/ : SUCCESS in 4m 01s\n- openstack-tox-py36 http://logs.openstack.org/69/663369/1/check/openstack-tox-py36/88fb46a/ : SUCCESS in 3m 22s\n- openstack-tox-py37 http://logs.openstack.org/69/663369/1/check/openstack-tox-py37/47619f2/ : SUCCESS in 4m 19s\n- openstacksdk-functional-devstack-tips http://logs.openstack.org/69/663369/1/check/openstacksdk-functional-devstack-tips/c5656a0/ : SUCCESS in 56m 24s\n- openstacksdk-functional-devstack-tips-python2 http://logs.openstack.org/69/663369/1/check/openstacksdk-functional-devstack-tips-python2/b802cd5/ : SUCCESS in 1h 25m 19s\n- openstacksdk-tox-py36-tips http://logs.openstack.org/69/663369/1/check/openstacksdk-tox-py36-tips/714ca4f/ : SUCCESS in 4m 05s\n- os-client-config-tox-py27-tips http://logs.openstack.org/69/663369/1/check/os-client-config-tox-py27-tips/ae9a584/ : SUCCESS in 4m 08s\n- os-client-config-tox-py37-tips http://logs.openstack.org/69/663369/1/check/os-client-config-tox-py37-tips/c564623/ : SUCCESS in 4m 50s\n- osc-tox-py27-tips http://logs.openstack.org/69/663369/1/check/osc-tox-py27-tips/fa5ddf6/ : SUCCESS in 5m 42s\n- osc-tox-py36-tips http://logs.openstack.org/69/663369/1/check/osc-tox-py36-tips/439eb53/ : SUCCESS in 8m 19s\n- openstack-tox-docs http://logs.openstack.org/69/663369/1/check/openstack-tox-docs/1052309/html/ : SUCCESS in 3m 36s\n- openstacksdk-ansible-devel-functional-devstack http://logs.openstack.org/69/663369/1/check/openstacksdk-ansible-devel-functional-devstack/901b454/ : SUCCESS in 37m 23s (non-voting)\n- openstacksdk-ansible-stable-2.6-functional-devstack http://logs.openstack.org/69/663369/1/check/openstacksdk-ansible-stable-2.6-functional-devstack/1d22790/ : SUCCESS in 51m 59s (non-voting)\n- openstacksdk-functional-devstack http://logs.openstack.org/69/663369/1/check/openstacksdk-functional-devstack/7d49c46/ : SUCCESS in 1h 01m 05s\n- openstacksdk-functional-devstack-networking http://logs.openstack.org/69/663369/1/check/openstacksdk-functional-devstack-networking/17aa1eb/ : SUCCESS in 1h 22m 48s\n- openstacksdk-functional-devstack-senlin http://logs.openstack.org/69/663369/1/check/openstacksdk-functional-devstack-senlin/8bbd380/ : SUCCESS in 52m 28s\n- openstacksdk-functional-devstack-magnum http://logs.openstack.org/69/663369/1/check/openstacksdk-functional-devstack-magnum/352dfae/ : SUCCESS in 54m 01s (non-voting)\n- openstacksdk-functional-devstack-masakari http://logs.openstack.org/69/663369/1/check/openstacksdk-functional-devstack-masakari/9929b5f/ : SUCCESS in 27m 08s (non-voting)\n- openstacksdk-functional-devstack-ironic http://logs.openstack.org/69/663369/1/check/openstacksdk-functional-devstack-ironic/084ba91/ : SUCCESS in 34m 57s (non-voting)\n- openstacksdk-functional-devstack-python2 http://logs.openstack.org/69/663369/1/check/openstacksdk-functional-devstack-python2/1470b08/ : SUCCESS in 1h 08m 22s\n- osc-functional-devstack-tips http://logs.openstack.org/69/663369/1/check/osc-functional-devstack-tips/d386070/ : SUCCESS in 58m 13s (non-voting)\n- nodepool-functional-py35-src http://logs.openstack.org/69/663369/1/check/nodepool-functional-py35-src/79265c2/ : SUCCESS in 33m 26s\n- bifrost-integration-tinyipa-ubuntu-xenial http://logs.openstack.org/69/663369/1/check/bifrost-integration-tinyipa-ubuntu-xenial/1de2c94/ : SUCCESS in 18m 51s\n- metalsmith-integration-openstacksdk-src http://logs.openstack.org/69/663369/1/check/metalsmith-integration-openstacksdk-src/7c9b0e2/ : SUCCESS in 1h 00m 26s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"66d24e954e616f70027f951ac89bf681ec075e09","author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"date":"2019-06-10 13:44:52.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"33483c7bb29191916357a78ab13e20874e278d8d","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-06-13 07:39:32.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"269de767b4d2a64d2b437b4d89db859ccfaaae56","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-13 07:39:45.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"b53cfeab6a05a89b4c847522d2ebf261beb179d1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-13 08:55:49.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"a11a11a38ff8a7a7e972493e217790bc6b3ba1b5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-13 08:55:49.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/69/663369/1/gate/openstack-tox-lower-constraints/d1d7058/ : SUCCESS in 3m 43s\n- openstack-tox-pep8 http://logs.openstack.org/69/663369/1/gate/openstack-tox-pep8/70bbeca/ : SUCCESS in 3m 24s\n- openstack-tox-py27 http://logs.openstack.org/69/663369/1/gate/openstack-tox-py27/93fbb67/ : SUCCESS in 3m 45s\n- openstack-tox-py36 http://logs.openstack.org/69/663369/1/gate/openstack-tox-py36/47677a1/ : SUCCESS in 3m 24s\n- openstack-tox-py37 http://logs.openstack.org/69/663369/1/gate/openstack-tox-py37/ab0ea9d/ : SUCCESS in 3m 35s\n- openstacksdk-functional-devstack-tips http://logs.openstack.org/69/663369/1/gate/openstacksdk-functional-devstack-tips/2ec7d69/ : SUCCESS in 1h 00m 03s\n- openstacksdk-functional-devstack-tips-python2 http://logs.openstack.org/69/663369/1/gate/openstacksdk-functional-devstack-tips-python2/b983ee2/ : SUCCESS in 1h 01m 58s\n- openstacksdk-tox-py36-tips http://logs.openstack.org/69/663369/1/gate/openstacksdk-tox-py36-tips/0bf80cf/ : SUCCESS in 4m 14s\n- os-client-config-tox-py27-tips http://logs.openstack.org/69/663369/1/gate/os-client-config-tox-py27-tips/d655f7e/ : SUCCESS in 4m 35s\n- os-client-config-tox-py37-tips http://logs.openstack.org/69/663369/1/gate/os-client-config-tox-py37-tips/e90f9d1/ : SUCCESS in 5m 41s\n- osc-tox-py27-tips http://logs.openstack.org/69/663369/1/gate/osc-tox-py27-tips/950fa06/ : SUCCESS in 5m 48s\n- osc-tox-py36-tips http://logs.openstack.org/69/663369/1/gate/osc-tox-py36-tips/6e9159f/ : SUCCESS in 5m 50s\n- openstack-tox-docs http://logs.openstack.org/69/663369/1/gate/openstack-tox-docs/4ba90f4/html/ : SUCCESS in 4m 19s\n- openstacksdk-functional-devstack http://logs.openstack.org/69/663369/1/gate/openstacksdk-functional-devstack/137d241/ : SUCCESS in 1h 00m 53s\n- openstacksdk-functional-devstack-python2 http://logs.openstack.org/69/663369/1/gate/openstacksdk-functional-devstack-python2/8221453/ : SUCCESS in 1h 05m 57s\n- openstacksdk-functional-devstack-networking http://logs.openstack.org/69/663369/1/gate/openstacksdk-functional-devstack-networking/a67b715/ : SUCCESS in 1h 13m 56s\n- openstacksdk-functional-devstack-senlin http://logs.openstack.org/69/663369/1/gate/openstacksdk-functional-devstack-senlin/589f2e2/ : SUCCESS in 58m 50s\n- nodepool-functional-py35-src http://logs.openstack.org/69/663369/1/gate/nodepool-functional-py35-src/0b4161a/ : SUCCESS in 38m 41s\n- bifrost-integration-tinyipa-ubuntu-xenial http://logs.openstack.org/69/663369/1/gate/bifrost-integration-tinyipa-ubuntu-xenial/0fbb650/ : SUCCESS in 19m 28s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"40cc2cc564ca2a86da6f029e7e21abacf98ba1c2","revisions":{"40cc2cc564ca2a86da6f029e7e21abacf98ba1c2":{"kind":"REWORK","_number":1,"created":"2019-06-05 15:49:34.000000000","uploader":{"_account_id":30288,"name":"charlie","email":"candles@amihere.net","username":"candles"},"ref":"refs/changes/69/663369/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/69/663369/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/69/663369/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/69/663369/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/69/663369/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/69/663369/1"}}},"commit":{"parents":[{"commit":"a5dfa85d4e7ff5bd5a40d37519670392f05ab6fe","subject":"Get rid of unused _OpenStackCloudMixin.get_region","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/a5dfa85d4e7ff5bd5a40d37519670392f05ab6fe"}]}],"author":{"name":"Charlie","email":"candles@amihere.net","date":"2019-06-05 15:40:35.000000000","tz":600},"committer":{"name":"Charlie","email":"candles@amihere.net","date":"2019-06-05 15:40:35.000000000","tz":600},"subject":"Support deleting all routes in update_router","message":"Support deleting all routes in update_router\n\nThere was previously no way to remove all routes from a router with the\nupdate_router function because it only processed the routes if the\nstatement \u0027if routes\u0027 evaluated to True, which an empty list did not.\n\nModified the unit test for cloud/test_router so that it initialises the\ntest router with routes, and confirms that they are removed.\n\nChange-Id: I9f31ad33eb500f59eb7634ea9e7e6502362a375b\nStory: 2005089\nTask: 29685\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/40cc2cc564ca2a86da6f029e7e21abacf98ba1c2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/40cc2cc564ca2a86da6f029e7e21abacf98ba1c2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}