)]}'
{"id":"openstack%2Fopenstacksdk~663449","triplet_id":"openstack%2Fopenstacksdk~master~Ice984fe26bc2a27a91e833300d34cdc83b2d5c4a","project":"openstack/openstacksdk","branch":"master","topic":"from_conf-exception-cases","hashtags":[],"change_id":"Ice984fe26bc2a27a91e833300d34cdc83b2d5c4a","subject":"Disable service on exception in from_conf","status":"ABANDONED","created":"2019-06-05 22:03:44.000000000","updated":"2019-06-05 22:47:33.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b8585a8a6bc4e1e2493ffbd1e883617d2f1f1460","_number":663449,"virtual_id_number":663449,"owner":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"actions":{},"labels":{"Verified":{"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"a58b24d4f8b5724a238f9c721981a42c5c0a7c0c","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-06-05 22:03:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"60995a321611c3c4aba9abfe8b7288956108c1ab","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-06-05 22:26:01.000000000","message":"Topic set to from_conf-exception-cases","accounts_in_message":[],"_revision_number":1},{"id":"b8585a8a6bc4e1e2493ffbd1e883617d2f1f1460","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-06-05 22:47:33.000000000","message":"Abandoned\n\nSquashed into https://review.opendev.org/#/c/663439/","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"91080491b556598ae5602e462a3f2b4ea803fd60","revisions":{"91080491b556598ae5602e462a3f2b4ea803fd60":{"kind":"REWORK","_number":1,"created":"2019-06-05 22:03:44.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/49/663449/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/49/663449/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/49/663449/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/49/663449/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/49/663449/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/49/663449/1"}}},"commit":{"parents":[{"commit":"a2797727ee87d2195f360caaa4bce67f6cf9fd72","subject":"WIP Plumb service disabling into Connection adapters","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/a2797727ee87d2195f360caaa4bce67f6cf9fd72"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-06-05 21:58:56.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-06-05 21:58:56.000000000","tz":-300},"subject":"Disable service on exception in from_conf","message":"Disable service on exception in from_conf\n\nIn the following cases, we used to happily allow the Connection to the\nservice, using default Adapter settings:\n\n- If the conf section for a given service is missing, or present but\n  without ksa adapter opts registered.\n- If the conf section for a given service has bogus values.\n\nNow for these scenarios, we disable that service, so that attempting to\naccess its Proxy gives you:\n\nAttributeError: \u0027NoneType\u0027 object has no attribute \u0027_connection\u0027\n\nWhen we disable the service, we register a helpful reason, which will\neventually be plumbed into the thing you get back instead of your Proxy\nso you get something better than the above.\n\nChange-Id: Ice984fe26bc2a27a91e833300d34cdc83b2d5c4a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/91080491b556598ae5602e462a3f2b4ea803fd60"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/91080491b556598ae5602e462a3f2b4ea803fd60"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}