)]}'
{"id":"openstack%2Fopenstacksdk~671104","triplet_id":"openstack%2Fopenstacksdk~master~Id8d68a8b544cb557cfbd3e38bee93bcf88f673ed","project":"openstack/openstacksdk","branch":"master","topic":"dashes-discovery","hashtags":[],"change_id":"Id8d68a8b544cb557cfbd3e38bee93bcf88f673ed","subject":"Correct endpoint_override discovery for service with dashes in their type","status":"MERGED","created":"2019-07-16 16:20:43.000000000","updated":"2019-07-17 10:07:36.000000000","submitted":"2019-07-17 10:07:36.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"671104-1563358056858-ef2d6f53","meta_rev_id":"7bf5edb0111c58139123463e3486f77c10ef1f5e","_number":671104,"virtual_id_number":671104,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":29745,"name":"Dustin Cowles","email":"cowlesd@gmail.com","username":"dustinc","status":"inactive"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":2,"date":"2019-07-17 10:07:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"recommended":{"_account_id":29745,"name":"Dustin Cowles","email":"cowlesd@gmail.com","username":"dustinc","status":"inactive"},"all":[{"value":1,"date":"2019-07-16 17:43:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":29745,"name":"Dustin Cowles","email":"cowlesd@gmail.com","username":"dustinc","status":"inactive"},{"value":2,"date":"2019-07-16 16:23:05.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":2,"date":"2019-07-17 08:46:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"all":[{"value":0,"_account_id":29745,"name":"Dustin Cowles","email":"cowlesd@gmail.com","username":"dustinc","status":"inactive"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":1,"date":"2019-07-17 08:46:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":29745,"name":"Dustin Cowles","email":"cowlesd@gmail.com","username":"dustinc","status":"inactive"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"_account_id":29745,"name":"Dustin Cowles","email":"cowlesd@gmail.com","username":"dustinc","status":"inactive"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-16 16:23:05.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2019-07-16 17:43:29.000000000","updated_by":{"_account_id":29745,"name":"Dustin Cowles","email":"cowlesd@gmail.com","username":"dustinc","status":"inactive"},"reviewer":{"_account_id":29745,"name":"Dustin Cowles","email":"cowlesd@gmail.com","username":"dustinc","status":"inactive"},"state":"REVIEWER"},{"updated":"2019-07-17 08:46:26.000000000","updated_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"},{"updated":"2019-07-17 10:07:36.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d3c9b88cfdf473431e5f5ccad6f1b51b82e2ca0e","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-07-16 16:20:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cca0df12776f76951e6b97729c66ebd5ca777354","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2019-07-16 16:23:05.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"455e144b5033424a480752b62dd20148390713e5","author":{"_account_id":29745,"name":"Dustin Cowles","email":"cowlesd@gmail.com","username":"dustinc","status":"inactive"},"date":"2019-07-16 17:43:29.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"3eb5eb40cfaa7710fcdfe003c7e649e30f6f97ba","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-16 17:53:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/04/671104/1/check/openstack-tox-lower-constraints/17bedd7/ : SUCCESS in 4m 30s\n- openstack-tox-pep8 http://logs.openstack.org/04/671104/1/check/openstack-tox-pep8/6f6a538/ : SUCCESS in 4m 38s\n- openstack-tox-py27 http://logs.openstack.org/04/671104/1/check/openstack-tox-py27/62ef782/ : SUCCESS in 4m 02s\n- openstack-tox-py36 http://logs.openstack.org/04/671104/1/check/openstack-tox-py36/bf3cbab/ : SUCCESS in 3m 50s\n- openstack-tox-py37 http://logs.openstack.org/04/671104/1/check/openstack-tox-py37/f5bd547/ : SUCCESS in 4m 10s\n- openstacksdk-functional-devstack-tips http://logs.openstack.org/04/671104/1/check/openstacksdk-functional-devstack-tips/1e27723/ : SUCCESS in 1h 10m 21s\n- openstacksdk-functional-devstack-tips-python2 http://logs.openstack.org/04/671104/1/check/openstacksdk-functional-devstack-tips-python2/e28ada6/ : SUCCESS in 56m 07s\n- openstacksdk-tox-py36-tips http://logs.openstack.org/04/671104/1/check/openstacksdk-tox-py36-tips/a06a9bb/ : SUCCESS in 4m 02s\n- os-client-config-tox-py27-tips http://logs.openstack.org/04/671104/1/check/os-client-config-tox-py27-tips/0ff075c/ : SUCCESS in 3m 34s\n- os-client-config-tox-py37-tips http://logs.openstack.org/04/671104/1/check/os-client-config-tox-py37-tips/013ce02/ : SUCCESS in 4m 08s\n- osc-tox-py27-tips http://logs.openstack.org/04/671104/1/check/osc-tox-py27-tips/5ea1fb9/ : SUCCESS in 5m 11s\n- osc-tox-py36-tips http://logs.openstack.org/04/671104/1/check/osc-tox-py36-tips/634ad8f/ : SUCCESS in 5m 30s\n- openstack-tox-docs http://logs.openstack.org/04/671104/1/check/openstack-tox-docs/8763bcd/html/ : SUCCESS in 4m 13s\n- openstacksdk-ansible-devel-functional-devstack http://logs.openstack.org/04/671104/1/check/openstacksdk-ansible-devel-functional-devstack/d240eab/ : SUCCESS in 40m 12s (non-voting)\n- openstacksdk-ansible-stable-2.6-functional-devstack http://logs.openstack.org/04/671104/1/check/openstacksdk-ansible-stable-2.6-functional-devstack/1848720/ : SUCCESS in 41m 22s (non-voting)\n- openstacksdk-functional-devstack http://logs.openstack.org/04/671104/1/check/openstacksdk-functional-devstack/aa215a3/ : SUCCESS in 1h 30m 41s\n- openstacksdk-functional-devstack-networking http://logs.openstack.org/04/671104/1/check/openstacksdk-functional-devstack-networking/c4f39eb/ : SUCCESS in 1h 22m 32s\n- openstacksdk-functional-devstack-senlin http://logs.openstack.org/04/671104/1/check/openstacksdk-functional-devstack-senlin/af47f64/ : SUCCESS in 1h 06m 44s\n- openstacksdk-functional-devstack-magnum http://logs.openstack.org/04/671104/1/check/openstacksdk-functional-devstack-magnum/dc08d3e/ : FAILURE in 59m 49s (non-voting)\n- openstacksdk-functional-devstack-masakari http://logs.openstack.org/04/671104/1/check/openstacksdk-functional-devstack-masakari/53f4330/ : SUCCESS in 49m 29s (non-voting)\n- openstacksdk-functional-devstack-ironic http://logs.openstack.org/04/671104/1/check/openstacksdk-functional-devstack-ironic/8e99af1/ : SUCCESS in 32m 54s (non-voting)\n- openstacksdk-functional-devstack-python2 http://logs.openstack.org/04/671104/1/check/openstacksdk-functional-devstack-python2/5388fd1/ : SUCCESS in 1h 09m 28s\n- osc-functional-devstack-tips http://logs.openstack.org/04/671104/1/check/osc-functional-devstack-tips/f5c7e38/ : SUCCESS in 1h 00m 03s (non-voting)\n- nodepool-functional-openstack-src http://logs.openstack.org/04/671104/1/check/nodepool-functional-openstack-src/a030ad9/ : SUCCESS in 37m 57s\n- bifrost-integration-tinyipa-ubuntu-xenial http://logs.openstack.org/04/671104/1/check/bifrost-integration-tinyipa-ubuntu-xenial/be9c970/ : SUCCESS in 24m 41s\n- metalsmith-integration-openstacksdk-src http://logs.openstack.org/04/671104/1/check/metalsmith-integration-openstacksdk-src/7cc520a/ : SUCCESS in 44m 26s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ad9fe418bfe3af35ff456c71325f6bf6ba07fcf2","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2019-07-17 08:46:26.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"bfc182af352fe5a75eaa8001f715d157e0c483ed","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-17 08:46:37.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"6d0b1b829d1a9100e6f4ce3c97b5582983e51559","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-17 10:07:36.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/04/671104/1/gate/openstack-tox-lower-constraints/77ca1ae/ : SUCCESS in 4m 00s\n- openstack-tox-pep8 http://logs.openstack.org/04/671104/1/gate/openstack-tox-pep8/2ba0881/ : SUCCESS in 3m 55s\n- openstack-tox-py27 http://logs.openstack.org/04/671104/1/gate/openstack-tox-py27/261aac4/ : SUCCESS in 3m 14s\n- openstack-tox-py36 http://logs.openstack.org/04/671104/1/gate/openstack-tox-py36/90a005b/ : SUCCESS in 6m 10s\n- openstack-tox-py37 http://logs.openstack.org/04/671104/1/gate/openstack-tox-py37/82c50ca/ : SUCCESS in 3m 25s\n- openstacksdk-functional-devstack-tips http://logs.openstack.org/04/671104/1/gate/openstacksdk-functional-devstack-tips/bc40a40/ : SUCCESS in 1h 02m 54s\n- openstacksdk-functional-devstack-tips-python2 http://logs.openstack.org/04/671104/1/gate/openstacksdk-functional-devstack-tips-python2/dc34df2/ : SUCCESS in 58m 55s\n- openstacksdk-tox-py36-tips http://logs.openstack.org/04/671104/1/gate/openstacksdk-tox-py36-tips/7e11e47/ : SUCCESS in 5m 27s\n- os-client-config-tox-py27-tips http://logs.openstack.org/04/671104/1/gate/os-client-config-tox-py27-tips/953c73e/ : SUCCESS in 5m 40s\n- os-client-config-tox-py37-tips http://logs.openstack.org/04/671104/1/gate/os-client-config-tox-py37-tips/b25e637/ : SUCCESS in 4m 11s\n- osc-tox-py27-tips http://logs.openstack.org/04/671104/1/gate/osc-tox-py27-tips/1c27be0/ : SUCCESS in 4m 19s\n- osc-tox-py36-tips http://logs.openstack.org/04/671104/1/gate/osc-tox-py36-tips/2ba8ce1/ : SUCCESS in 5m 04s\n- openstack-tox-docs http://logs.openstack.org/04/671104/1/gate/openstack-tox-docs/a165911/html/ : SUCCESS in 3m 43s\n- openstacksdk-functional-devstack http://logs.openstack.org/04/671104/1/gate/openstacksdk-functional-devstack/737b1b9/ : SUCCESS in 1h 17m 09s\n- openstacksdk-functional-devstack-python2 http://logs.openstack.org/04/671104/1/gate/openstacksdk-functional-devstack-python2/2e12555/ : SUCCESS in 1h 01m 40s\n- openstacksdk-functional-devstack-networking http://logs.openstack.org/04/671104/1/gate/openstacksdk-functional-devstack-networking/c98aa73/ : SUCCESS in 1h 14m 09s\n- openstacksdk-functional-devstack-senlin http://logs.openstack.org/04/671104/1/gate/openstacksdk-functional-devstack-senlin/ac9b978/ : SUCCESS in 1h 03m 18s\n- nodepool-functional-openstack-src http://logs.openstack.org/04/671104/1/gate/nodepool-functional-openstack-src/897a0bb/ : SUCCESS in 33m 42s\n- bifrost-integration-tinyipa-ubuntu-xenial http://logs.openstack.org/04/671104/1/gate/bifrost-integration-tinyipa-ubuntu-xenial/118beb3/ : SUCCESS in 16m 46s","accounts_in_message":[],"_revision_number":1},{"id":"c567ae04a09f631fd3df0ba654bfa838b942bf58","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-17 10:07:36.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6a2668724551cd60589d018bd8962840e9f9a9a4","revisions":{"6a2668724551cd60589d018bd8962840e9f9a9a4":{"kind":"REWORK","_number":1,"created":"2019-07-16 16:20:43.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/04/671104/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/04/671104/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/04/671104/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/04/671104/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/04/671104/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/04/671104/1"}}},"commit":{"parents":[{"commit":"0105ceb2f570622daf5bc412904ddb0715b6234e","subject":"Merge \"Add Python 3 Train unit tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/0105ceb2f570622daf5bc412904ddb0715b6234e"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2019-07-16 16:19:10.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2019-07-16 16:19:10.000000000","tz":120},"subject":"Correct endpoint_override discovery for service with dashes in their type","message":"Correct endpoint_override discovery for service with dashes in their type\n\nCurrently when handling endpoint_override, we correctly discover the\nactual URL, but then we populate the wrong configuration option (with\na dash instead of an underscore). This results in the unversioned URL\nbeing used for requests, breaking ironic-inspector with endpoint_override.\n\nChange-Id: Id8d68a8b544cb557cfbd3e38bee93bcf88f673ed\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/6a2668724551cd60589d018bd8962840e9f9a9a4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/6a2668724551cd60589d018bd8962840e9f9a9a4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}