)]}'
{"openstack/object_store/object_store_service.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"2970dcb50d8e4fe1528e6d4ebcbf95dadfa58eb0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"            config.get_endpoint(self.service_type)"},{"line_number":29,"context_line":"            or config.get_session().auth.get_endpoint("},{"line_number":30,"context_line":"                config.get_session(), service_type\u003dself.service_type))"},{"line_number":31,"context_line":"        config.config[\u0027object_store_endpoint_override\u0027] \u003d endpoint_override"},{"line_number":32,"context_line":"        return config.get_session_client("},{"line_number":33,"context_line":"            self.service_type,"},{"line_number":34,"context_line":"            constructor\u003d_proxy.Proxy,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_376dd031","line":31,"updated":"2019-08-01 19:47:42.000000000","message":"Not to nit-pick tooooooo much here, but maybe we should add this type of information into the service-types definition. I don\u0027t think the hard-code here is the best idea. With that said, this is def. worth landing now and enhancing service-types in the future.","commit_id":"9db1db6dd67ad92466a2b3e33380f5325b1e35ae"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"3b73b8051ef346f64b87e4d9515261d0e99b2a61","unresolved":false,"context_lines":[{"line_number":28,"context_line":"            config.get_endpoint(self.service_type)"},{"line_number":29,"context_line":"            or config.get_session().auth.get_endpoint("},{"line_number":30,"context_line":"                config.get_session(), service_type\u003dself.service_type))"},{"line_number":31,"context_line":"        config.config[\u0027object_store_endpoint_override\u0027] \u003d endpoint_override"},{"line_number":32,"context_line":"        return config.get_session_client("},{"line_number":33,"context_line":"            self.service_type,"},{"line_number":34,"context_line":"            constructor\u003d_proxy.Proxy,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_9715a44b","line":31,"in_reply_to":"7faddb67_376dd031","updated":"2019-08-01 19:59:59.000000000","message":"yeah. totally agree.","commit_id":"9db1db6dd67ad92466a2b3e33380f5325b1e35ae"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ed572f7017a17c913e49ef36b8091c5f2ff1e45a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        \u00271\u0027: _proxy.Proxy,"},{"line_number":22,"context_line":"    }"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def get_proxy_override(self, config):"},{"line_number":25,"context_line":"        # Swift doesn\u0027t do version discovery. It doesn\u0027t need any of the"},{"line_number":26,"context_line":"        # version code, so skip it."},{"line_number":27,"context_line":"        endpoint_override \u003d ("}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_667f7566","line":24,"updated":"2019-08-12 19:03:47.000000000","message":"When I remove this override, the test still passes.\n\nI.e. the code path the test is hitting was not triggering discovery before.","commit_id":"dfbc6bafc112efedabb4d07db73ee8e921634072"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"388e369e1e3bcc131b588252cd71655a10bc005c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        \u00271\u0027: _proxy.Proxy,"},{"line_number":22,"context_line":"    }"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def get_proxy_override(self, config):"},{"line_number":25,"context_line":"        # Swift doesn\u0027t do version discovery. It doesn\u0027t need any of the"},{"line_number":26,"context_line":"        # version code, so skip it."},{"line_number":27,"context_line":"        endpoint_override \u003d ("}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_a170ec09","line":24,"in_reply_to":"7faddb67_667f7566","updated":"2019-08-13 12:09:20.000000000","message":"Yeah - I agree. I can\u0027t make a test that exhibits the problem I thought we were solving. I\u0027m going to push this to the end of the stack and WIP it - I\u0027m not sure it\u0027s actually needed.","commit_id":"dfbc6bafc112efedabb4d07db73ee8e921634072"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5e2b65866083e8e538747978f77e065868dc4e71","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    def get_proxy_override(self, config):"},{"line_number":25,"context_line":"        # Swift doesn\u0027t do version discovery. It doesn\u0027t need any of the"},{"line_number":26,"context_line":"        # version code, so skip it."},{"line_number":27,"context_line":"        endpoint_override \u003d ("},{"line_number":28,"context_line":"            config.get_endpoint(self.service_type)"},{"line_number":29,"context_line":"            or config.get_endpoint_from_catalog(self.service_type))"},{"line_number":30,"context_line":"        config.config[\u0027object_store_endpoint_override\u0027] \u003d endpoint_override"},{"line_number":31,"context_line":"        return config.get_session_client("},{"line_number":32,"context_line":"            self.service_type,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_59157e48","line":29,"range":{"start_line":27,"start_character":0,"end_line":29,"end_character":67},"updated":"2019-08-12 21:17:05.000000000","message":"This is exactly endpoint_for as twiddled later in this series [1]. Is there a way to use that instead?\n\n[1] https://review.opendev.org/#/c/675130/3/openstack/cloud/openstackcloud.py","commit_id":"dfbc6bafc112efedabb4d07db73ee8e921634072"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"388e369e1e3bcc131b588252cd71655a10bc005c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    def get_proxy_override(self, config):"},{"line_number":25,"context_line":"        # Swift doesn\u0027t do version discovery. It doesn\u0027t need any of the"},{"line_number":26,"context_line":"        # version code, so skip it."},{"line_number":27,"context_line":"        endpoint_override \u003d ("},{"line_number":28,"context_line":"            config.get_endpoint(self.service_type)"},{"line_number":29,"context_line":"            or config.get_endpoint_from_catalog(self.service_type))"},{"line_number":30,"context_line":"        config.config[\u0027object_store_endpoint_override\u0027] \u003d endpoint_override"},{"line_number":31,"context_line":"        return config.get_session_client("},{"line_number":32,"context_line":"            self.service_type,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_4161f838","line":29,"range":{"start_line":27,"start_character":0,"end_line":29,"end_character":67},"in_reply_to":"7faddb67_59157e48","updated":"2019-08-13 12:09:20.000000000","message":"Yes - assuming we do wind up wanting this patch, that\u0027s a great idea.","commit_id":"dfbc6bafc112efedabb4d07db73ee8e921634072"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7964e80aecdfd598c41bce9f4737e69b78a04621","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        \u00271\u0027: _proxy.Proxy,"},{"line_number":22,"context_line":"    }"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def x_get_proxy_override(self, instance):"},{"line_number":25,"context_line":"        # Swift doesn\u0027t do version discovery. It doesn\u0027t need any of the"},{"line_number":26,"context_line":"        # version code, so skip it."},{"line_number":27,"context_line":"        instance.config.set_endpoint_override("}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_27596c34","line":24,"range":{"start_line":24,"start_character":8,"end_line":24,"end_character":28},"updated":"2019-08-13 13:30:05.000000000","message":"Still playing with this, it appears.","commit_id":"0be926d0782fa463598c61dfa737fb17121d0e0a"}],"openstack/object_store/v1/_proxy.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ee9e3429cbc1a3e4584dc3037d857c68fd66cb62","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class Proxy(proxy.Proxy):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    skip_discovery \u003d True"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    Account \u003d _account.Account"},{"line_number":40,"context_line":"    Container \u003d _container.Container"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_86887122","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":25},"updated":"2019-08-12 19:27:11.000000000","message":"because of this","commit_id":"dfbc6bafc112efedabb4d07db73ee8e921634072"}],"openstack/service_description.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ee9e3429cbc1a3e4584dc3037d857c68fd66cb62","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        if proxy_obj:"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"            if getattr(proxy_obj, \u0027skip_discovery\u0027, False):"},{"line_number":178,"context_line":"                # Some services, like swift, don\u0027t have discovery. While"},{"line_number":179,"context_line":"                # keystoneauth will behave correctly and handle such"},{"line_number":180,"context_line":"                # scenarios, it\u0027s not super efficient as it involves trying"},{"line_number":181,"context_line":"                # and falling back a few times."},{"line_number":182,"context_line":"                return proxy_obj"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"            data \u003d proxy_obj.get_endpoint_data()"},{"line_number":185,"context_line":"            # If we\u0027ve gotten here with a proxy object it means we have"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_e697e544","line":182,"range":{"start_line":177,"start_character":0,"end_line":182,"end_character":32},"updated":"2019-08-12 19:27:11.000000000","message":"because of this","commit_id":"dfbc6bafc112efedabb4d07db73ee8e921634072"}]}