)]}'
{"openstack/tests/functional/baremetal/test_baremetal_node.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7fcafe44a964b110816aa72cb0032abe4608c393","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        traits1 \u003d [\u0027CUSTOM_FAKE\u0027, \u0027CUSTOM_REAL\u0027]"},{"line_number":342,"context_line":"        traits2 \u003d [\u0027CUSTOM_FOOBAR\u0027]"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        self.conn.baremetal.set_node_traits(self.node, traits1)"},{"line_number":345,"context_line":"        self.assertEqual([\u0027CUSTOM_FAKE\u0027, \u0027CUSTOM_REAL\u0027], self.node.traits)"},{"line_number":346,"context_line":"        node \u003d self.conn.baremetal.get_node(self.node)"},{"line_number":347,"context_line":"        self.assertEqual([\u0027CUSTOM_FAKE\u0027, \u0027CUSTOM_REAL\u0027], node.traits)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        self.conn.baremetal.set_node_traits(self.node, traits2)"},{"line_number":350,"context_line":"        self.assertEqual([\u0027CUSTOM_FOOBAR\u0027], self.node.traits)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_92704442","line":347,"range":{"start_line":344,"start_character":0,"end_line":347,"end_character":69},"updated":"2019-08-02 15:08:51.000000000","message":"I think we should apply the same change here","commit_id":"1a9a98f431f6fd32034ed5cd7a9b1b871df2789a"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"7114e11b53f0c5c358d58b555f5fc0d60b047e87","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        traits1 \u003d [\u0027CUSTOM_FAKE\u0027, \u0027CUSTOM_REAL\u0027]"},{"line_number":342,"context_line":"        traits2 \u003d [\u0027CUSTOM_FOOBAR\u0027]"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        self.conn.baremetal.set_node_traits(self.node, traits1)"},{"line_number":345,"context_line":"        self.assertEqual([\u0027CUSTOM_FAKE\u0027, \u0027CUSTOM_REAL\u0027], self.node.traits)"},{"line_number":346,"context_line":"        node \u003d self.conn.baremetal.get_node(self.node)"},{"line_number":347,"context_line":"        self.assertEqual([\u0027CUSTOM_FAKE\u0027, \u0027CUSTOM_REAL\u0027], node.traits)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        self.conn.baremetal.set_node_traits(self.node, traits2)"},{"line_number":350,"context_line":"        self.assertEqual([\u0027CUSTOM_FOOBAR\u0027], self.node.traits)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_eda2f9fb","line":347,"range":{"start_line":344,"start_character":0,"end_line":347,"end_character":69},"in_reply_to":"7faddb67_52516c35","updated":"2019-08-02 15:29:37.000000000","message":"as you made me notice, we don\u0027t\nadded sorted here too","commit_id":"1a9a98f431f6fd32034ed5cd7a9b1b871df2789a"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1094611aed326fcd404ec5d3ddc9bc2a72fa6e74","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        traits1 \u003d [\u0027CUSTOM_FAKE\u0027, \u0027CUSTOM_REAL\u0027]"},{"line_number":342,"context_line":"        traits2 \u003d [\u0027CUSTOM_FOOBAR\u0027]"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        self.conn.baremetal.set_node_traits(self.node, traits1)"},{"line_number":345,"context_line":"        self.assertEqual([\u0027CUSTOM_FAKE\u0027, \u0027CUSTOM_REAL\u0027], self.node.traits)"},{"line_number":346,"context_line":"        node \u003d self.conn.baremetal.get_node(self.node)"},{"line_number":347,"context_line":"        self.assertEqual([\u0027CUSTOM_FAKE\u0027, \u0027CUSTOM_REAL\u0027], node.traits)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        self.conn.baremetal.set_node_traits(self.node, traits2)"},{"line_number":350,"context_line":"        self.assertEqual([\u0027CUSTOM_FOOBAR\u0027], self.node.traits)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_92a5a4a1","line":347,"range":{"start_line":344,"start_character":0,"end_line":347,"end_character":69},"in_reply_to":"7faddb67_92704442","updated":"2019-08-02 15:10:30.000000000","message":"shouldn\u0027t this actually follow the correct order since we\u0027re imposing traits1 as traits?","commit_id":"1a9a98f431f6fd32034ed5cd7a9b1b871df2789a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7b628d99d4f261a0d536ee6e348590d8f37b7df8","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        traits1 \u003d [\u0027CUSTOM_FAKE\u0027, \u0027CUSTOM_REAL\u0027]"},{"line_number":342,"context_line":"        traits2 \u003d [\u0027CUSTOM_FOOBAR\u0027]"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        self.conn.baremetal.set_node_traits(self.node, traits1)"},{"line_number":345,"context_line":"        self.assertEqual([\u0027CUSTOM_FAKE\u0027, \u0027CUSTOM_REAL\u0027], self.node.traits)"},{"line_number":346,"context_line":"        node \u003d self.conn.baremetal.get_node(self.node)"},{"line_number":347,"context_line":"        self.assertEqual([\u0027CUSTOM_FAKE\u0027, \u0027CUSTOM_REAL\u0027], node.traits)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        self.conn.baremetal.set_node_traits(self.node, traits2)"},{"line_number":350,"context_line":"        self.assertEqual([\u0027CUSTOM_FOOBAR\u0027], self.node.traits)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_52516c35","line":347,"range":{"start_line":344,"start_character":0,"end_line":347,"end_character":69},"in_reply_to":"7faddb67_92a5a4a1","updated":"2019-08-02 15:22:33.000000000","message":"I\u0027m not sure we guarantee traits ordering in the API.. At least that\u0027s not something I\u0027d rely on.","commit_id":"1a9a98f431f6fd32034ed5cd7a9b1b871df2789a"}]}